Re: [PATCH v2] dwarf_getaranges: Build aranges list from CUs instead of .debug_aranges

2024-02-22 Thread Aaron Merey
Hi Frank, On Thu, Feb 22, 2024 at 10:35 AM Frank Ch. Eigler wrote: > > > > We could then also introduce a new public function, dwarf_getdieranges > > > (?) that does the new thing. But it doesn't have to be public on the > > > first try as long as dwarf_addrdie and dwfl_module_addrdie work. (We >

Re: [PATCH v2] dwarf_getaranges: Build aranges list from CUs instead of .debug_aranges

2024-02-22 Thread Frank Ch. Eigler
Hi - > > We could then also introduce a new public function, dwarf_getdieranges > > (?) that does the new thing. But it doesn't have to be public on the > > first try as long as dwarf_addrdie and dwfl_module_addrdie work. (We > > might want to change the interface of dwarf_getdieranges so it can b

Re: [PATCH v2] dwarf_getaranges: Build aranges list from CUs instead of .debug_aranges

2024-02-21 Thread Aaron Merey
Hi Mark, On Tue, Feb 20, 2024 at 5:23 PM Mark Wielaard wrote: > > > As for the number of aranges found, there is a difference for libxul.so: > > 250435 with the patch compared to 254832 without. So 4397 fewer aranges > > are found when using the new CU iteration method. I'll dig into this and >

Re: [PATCH v2] dwarf_getaranges: Build aranges list from CUs instead of .debug_aranges

2024-02-20 Thread Mark Wielaard
Hi Aaron, We already discussed on irc, but just for the record. On Mon, Feb 19, 2024 at 11:20:13PM -0500, Aaron Merey wrote: > On Tue, Feb 13, 2024 at 8:28 AM Mark Wielaard wrote: > > > > > This patch's method of building the aranges list is slower than simply > > > reading .debug_aranges. On m

Re: [PATCH v2] dwarf_getaranges: Build aranges list from CUs instead of .debug_aranges

2024-02-19 Thread Aaron Merey
Hi Mark, On Tue, Feb 13, 2024 at 8:28 AM Mark Wielaard wrote: > > > This patch's method of building the aranges list is slower than simply > > reading .debug_aranges. On my machine, running eu-stack on a 2.9G > > firefox core file takes about 8.7 seconds with this patch applied, > > compared to

Re: [PATCH v2] dwarf_getaranges: Build aranges list from CUs instead of .debug_aranges

2024-02-13 Thread Mark Wielaard
Hi Aaron, On Mon, 2023-12-11 at 18:18 -0500, Aaron Merey wrote: > No longer use .debug_aranges to build the aranges list since it could be > absent or incomplete. > > Instead build the aranges list by iterating over each CU and recording > each address range. > > https://sourceware.org/bugzilla/

[PATCH v2] dwarf_getaranges: Build aranges list from CUs instead of .debug_aranges

2023-12-11 Thread Aaron Merey
No longer use .debug_aranges to build the aranges list since it could be absent or incomplete. Instead build the aranges list by iterating over each CU and recording each address range. https://sourceware.org/bugzilla/show_bug.cgi?id=22288 https://sourceware.org/bugzilla/show_bug.cgi?id=30948 Si