Re: [PATCH v2] backends,bpf: add proper relocation support

2018-06-21 Thread Mark Wielaard
On Thu, Jun 21, 2018 at 01:24:41PM -0700, Yonghong Song wrote: > Don't know you release schedule, but could you cut a release > soon so this can be picked up by dist/pahole? I'll push a new 0.173 release next week. We recently added DWARF5 support, but running all the new data parsers under the a

Re: [PATCH v2] backends,bpf: add proper relocation support

2018-06-21 Thread Mark Wielaard
On Wed, Jun 20, 2018 at 07:18:22AM -0700, Yonghong Song wrote: > On 6/20/18 4:41 AM, Mark Wielaard wrote: > > The patch looks perfect. And the new testcase is good. I used the > > testfile to quickly test eu-readelf --debug-dump also got the > > relocations right, and it did of course. > > > > Jus

Re: [PATCH v2] backends,bpf: add proper relocation support

2018-06-20 Thread Mark Wielaard
On Sat, 2018-06-16 at 13:02 -0700, Yonghong Song wrote: > Due to libdw does not have proper BPF relocation support, > the pahole cannot display filenames correctly for objects > with default llvm options. So we have to invent > a special option "llc -march=bpf -mattr=dwarfris" to > prevent llvm fro

[PATCH v2] backends,bpf: add proper relocation support

2018-06-16 Thread Yonghong Song
Due to libdw does not have proper BPF relocation support, the pahole cannot display filenames correctly for objects with default llvm options. So we have to invent a special option "llc -march=bpf -mattr=dwarfris" to prevent llvm from generating cross-section dwarf relocation records (https://revie