Re: [PATCH 2/4] eu-stacktrace: configury for initial version (x86/sysprof only)

2024-10-17 Thread Aaron Merey
On Thu, Oct 17, 2024 at 11:28 AM Serhei Makarov wrote: > > On Wed, Oct 16, 2024, at 11:38 PM, Aaron Merey wrote: > > Using less wide indentation throughout would help make the configure.ac > > changes more readable. Otherwise this patch LGTM. > Ok, my code imitated the offset for the debuginfod c

Re: [PATCH 2/4] eu-stacktrace: configury for initial version (x86/sysprof only)

2024-10-17 Thread Serhei Makarov
On Wed, Oct 16, 2024, at 11:38 PM, Aaron Merey wrote: > Using less wide indentation throughout would help make the configure.ac > changes more readable. Otherwise this patch LGTM. Ok, my code imitated the offset for the debuginfod configury immediately above, but I'll update the patch to use 3

[PATCH 2/4] eu-stacktrace: configury for initial version (x86/sysprof only)

2024-10-16 Thread Aaron Merey
Hi Serhei, On Tue, Oct 15, 2024 at 11:28 AM Serhei Makarov wrote: > > Due to the x86-specific code in the initial version the configury has > significant restrictions. If --enable-stacktrace is not explicitly > provided, then eu-stacktrace will be disabled by default when > x86 architecture or sy

[PATCH 2/4] eu-stacktrace: configury for initial version (x86/sysprof only)

2024-10-15 Thread Serhei Makarov
Due to the x86-specific code in the initial version the configury has significant restrictions. If --enable-stacktrace is not explicitly provided, then eu-stacktrace will be disabled by default when x86 architecture or sysprof headers are absent. The way we test for x86 is a bit unusual. What we a