Re: [PATCH] srcfiles.cxx: Prevent fd and entry leak

2024-11-25 Thread Aaron Merey
On Thu, Nov 21, 2024 at 7:09 PM Mark Wielaard wrote: > > Hi Aaron, > > On Mon, Nov 18, 2024 at 06:43:56PM -0500, Aaron Merey wrote: > > Make sure to free fd and the archive entry if an error is encountered > > while adding source files to the archive. > > Looks good to me. But one (paranoid?) nitp

Re: [PATCH] srcfiles.cxx: Prevent fd and entry leak

2024-11-21 Thread Mark Wielaard
Hi Aaron, On Mon, Nov 18, 2024 at 06:43:56PM -0500, Aaron Merey wrote: > Make sure to free fd and the archive entry if an error is encountered > while adding source files to the archive. Looks good to me. But one (paranoid?) nitpick below. > Signed-off-by: Aaron Merey > --- > src/srcfiles.cxx

[PATCH] srcfiles.cxx: Prevent fd and entry leak

2024-11-18 Thread Aaron Merey
Make sure to free fd and the archive entry if an error is encountered while adding source files to the archive. Signed-off-by: Aaron Merey --- src/srcfiles.cxx | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/srcfiles.cxx b/src/srcfiles.cxx index c46