Re: [PATCH] libdwfl: Do not dlopen libdebuginfod if DEBUGINFOD_URLS is unset or empty

2020-12-09 Thread Mark Wielaard
On Wed, 2020-12-09 at 18:35 +0300, Dmitry V. Levin wrote: > On Mon, Nov 09, 2020 at 09:57:57AM -0500, Frank Ch. Eigler via Elfutils-devel > wrote: > > > [...] The problem with doing the dlopen late is that we also need > > > libcurl and initializing libcurl (as done by libdebuginfod) is not > > >

Re: [PATCH] libdwfl: Do not dlopen libdebuginfod if DEBUGINFOD_URLS is unset or empty

2020-12-09 Thread Dmitry V. Levin
Hi, On Mon, Nov 09, 2020 at 09:57:57AM -0500, Frank Ch. Eigler via Elfutils-devel wrote: > Hi - > > > [...] The problem with doing the dlopen late is that we also need > > libcurl and initializing libcurl (as done by libdebuginfod) is not > > thread-safe. > > From reading libcurl code, and that

Re: [PATCH] libdwfl: Do not dlopen libdebuginfod if DEBUGINFOD_URLS is unset or empty

2020-11-09 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > [...] The problem with doing the dlopen late is that we also need > libcurl and initializing libcurl (as done by libdebuginfod) is not > thread-safe. >From reading libcurl code, and that of other clients, I still believe this concern was & is overrated. We could back down to simple debugi

Re: [PATCH] libdwfl: Do not dlopen libdebuginfod if DEBUGINFOD_URLS is unset or empty

2020-11-09 Thread Mark Wielaard
Hi Vitaly, On Thu, 2020-11-05 at 17:44 +0300, Vitaly Chikunov wrote: > Avoid calling expensive dlopen at the cost of an extra getenv check when > we already know it would not be needed. > > This mirrors the getenv check from debuginfod_query_server. I am sympathetic to this. It would have been a

[PATCH] libdwfl: Do not dlopen libdebuginfod if DEBUGINFOD_URLS is unset or empty

2020-11-05 Thread Vitaly Chikunov
Avoid calling expensive dlopen at the cost of an extra getenv check when we already know it would not be needed. This mirrors the getenv check from debuginfod_query_server. Signed-off-by: Vitaly Chikunov Reviewed-by: Dmitry V. Levin --- libdwfl/debuginfod-client.c | 8 1 file changed,