Re: [PATCH] lib: remove usage of `sys/cdefs.h`

2021-08-27 Thread Mark Wielaard
Hi Saleem, On Mon, 2021-08-23 at 08:23 -0700, Saleem Abdulrasool via Elfutils- devel wrote: > Yes, it seems that `STROF` can be removed as well. However, I'd > prefer to do that in a separate change. This way the change is a > separate clean up rather than just happens to come along with the > s

Re: [PATCH] lib: remove usage of `sys/cdefs.h`

2021-08-23 Thread Saleem Abdulrasool via Elfutils-devel
Hi Érico, Yes, it seems that `STROF` can be removed as well. However, I'd prefer to do that in a separate change. This way the change is a separate clean up rather than just happens to come along with the sys/cdefs.h removal. On Mon, Aug 23, 2021 at 5:48 AM Érico Nogueira wrote: > > On Fri Aug

Re: [PATCH] lib: remove usage of `sys/cdefs.h`

2021-08-23 Thread Érico Nogueira via Elfutils-devel
On Fri Aug 20, 2021 at 3:20 PM -03, Saleem Abdulrasool via Elfutils-devel wrote: > This header is a BSD header that is also available in glibc. However, > this is a not a standard C header and was used for `__CONCAT`. Because > this is not a standard header, not all libc implementations provide the

[PATCH] lib: remove usage of `sys/cdefs.h`

2021-08-20 Thread Saleem Abdulrasool via Elfutils-devel
This header is a BSD header that is also available in glibc. However, this is a not a standard C header and was used for `__CONCAT`. Because this is not a standard header, not all libc implementations provide the header. Remove the usage of the header and always use the previously fallback path.