Re: [PATCH] Make elf section sorting more deterministic

2017-05-03 Thread Ulf Hermann
[...] How about the attached? Looks good to me. Ulf

Re: [PATCH] Make elf section sorting more deterministic

2017-05-02 Thread Mark Wielaard
ions->count && *addr == sections->refs[idx + 1].start) ++idx; So we do indeed want the zero sized section to be the first. How about the attached? Cheers, Mark >From d7e1e08f68afd6c3363231e3100fa0124a2d5cb6 Mon Sep 17 00:00:00 2001 From: Ulf Hermann

Re: [PATCH] Make elf section sorting more deterministic

2017-04-28 Thread Ulf Hermann
On 04/27/2017 09:41 PM, Mark Wielaard wrote: > On Thu, Apr 20, 2017 at 04:54:26PM +0200, Ulf Hermann wrote: >> At least one test (dwfl-addr-sect) depends on the order of elf sections >> with equal addresses. This is not guaranteed by the code. Compare also >> by end address and name to tell entries

Re: [PATCH] Make elf section sorting more deterministic

2017-04-27 Thread Mark Wielaard
On Thu, Apr 20, 2017 at 04:54:26PM +0200, Ulf Hermann wrote: > At least one test (dwfl-addr-sect) depends on the order of elf sections > with equal addresses. This is not guaranteed by the code. Compare also > by end address and name to tell entries apart. O, interesting find. If the start address

[PATCH] Make elf section sorting more deterministic

2017-04-20 Thread Ulf Hermann
At least one test (dwfl-addr-sect) depends on the order of elf sections with equal addresses. This is not guaranteed by the code. Compare also by end address and name to tell entries apart. Signed-off-by: Ulf Hermann --- libdwfl/ChangeLog | 5 + libdwfl/derelocate.c| 17 ++