Re: [PATCH RFC] backends: Add RISC-V object attribute printing

2023-02-24 Thread Martin Liška
@Andreas: Can you take a look? Martin On 2/22/23 23:56, Mark Wielaard wrote: > Hi, > > On Fri, Nov 25, 2022 at 05:29:19PM +0100, Martin Liška wrote: >> On 10/13/22 16:53, Mark Wielaard wrote: >>> On Wed, 2022-08-10 at 11:27 +0200, Andreas Schwab via Elfutils-devel >&

Re: elfutils code names

2023-02-23 Thread Martin Liška
On 2/21/23 16:12, Mark Wielaard wrote: > On Thu, 2023-02-16 at 13:37 +0100, Mark Wielaard wrote: >> Hi, >> >> On irc (#elfutils on libera.chat) we had a discussion about the >> elfutils code names. For some reason those are only in the irc channel >> topic. Which seems to mean not many people know

Re: [PATCH] addr2line: -C should not try to handle optional (ignored) argument

2023-02-03 Thread Martin Liška
On 1/30/23 22:04, Mark Wielaard wrote: > Hi, > > On Mon, Jan 23, 2023 at 10:11:28AM +0100, Mark Wielaard wrote: >> The --demangle option takes an option (ignored) argument. Since -C >> is the short option of --demangle it also takes that optional >> argument. But that means that something like -Cf

Re: [PATCHv2] support ZSTD compression algorithm

2022-12-23 Thread Martin Liška
On 12/22/22 19:36, Mark Wielaard wrote: > |See also my other email. I think that addresses everything. Just merge those > and push please.| Hi. Thank you Mark for help! I've just finished the patch and pushed that to master. Cheers, Martin

[PATCHv2] support ZSTD compression algorithm

2022-12-22 Thread Martin Liška
Hi. > Is the abort () at the second call site because that cannot happen? Or > should that also goto cleanup? Yes, it can't happen. There's V2 (including ChangeLog) where all issues apart from the libzstd configure.ac detection should be addressed. Cheers, Martin config/ChangeLog: *

Re: ☠ Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2)

2022-12-22 Thread Martin Liška
On 12/22/22 00:38, Mark Wielaard wrote: > Hi Martin, > > On Wed, Dec 21, 2022 at 07:29:19PM +0100, Martin Liška wrote: >>> What goes wrong is that this debian old stable arm setup has libzstd >>> containing a ZSTD_compressStream2 symbol... >>> >>>

Re: ☠ Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2)

2022-12-21 Thread Martin Liška
On 12/21/22 16:21, Mark Wielaard wrote: > Hi, > > On Wed, 2022-12-21 at 15:42 +0100, Mark Wielaard wrote: >> >> Unfortunately buildbot itself doesn't show the config.log. >> Trying to get that... >> >> configure:6961: checking for library containing ZSTD_compressStream2 >> configure:6992: gcc -o c

Re: ☠ Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2)

2022-12-21 Thread Martin Liška
On 12/21/22 12:15, buil...@sourceware.org wrote: > A failed build has been detected on builder elfutils-try-debian-armhf while > building elfutils. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/201/builds/47 > > Build state: failed compile (failure) >

Re: [PATCHv2] support ZSTD compression algorithm

2022-12-21 Thread Martin Liška
On 12/19/22 16:09, Mark Wielaard wrote: > Hi Martin, > > On Mon, 2022-12-19 at 15:19 +0100, Martin Liška wrote: >> On 12/15/22 14:17, Mark Wielaard wrote: >>> Is there a particular way you are running eu-readelf? Is it with >>> generic -w or -a, or decoding a s

Re: [PATCHv2] support ZSTD compression algorithm

2022-12-21 Thread Martin Liška
On 12/19/22 16:16, Mark Wielaard wrote: > Hi Martin, > > On Mon, 2022-12-19 at 15:21 +0100, Martin Liška wrote: >>>> + else >>>> +error (0, 0, "Couldn't get chdr for section %zd", ndx); >>> >>> Shouldn't this error

Re: [PATCHv2] support ZSTD compression algorithm

2022-12-19 Thread Martin Liška
Hi. + if (use_zstd) +#ifdef USE_ZSTD +return __libelf_compress_zstd (scn, hsize, ei_data, orig_size, + orig_addralign, new_size, force, + data, next_data, out_buf, out_size, + block); +#else +

Re: [PATCHv2] support ZSTD compression algorithm

2022-12-19 Thread Martin Liška
On 12/15/22 14:17, Mark Wielaard wrote: Hi Martin, On Tue, 2022-11-29 at 13:05 +0100, Martin Liška wrote: There's second version of the patch that fully support both compression and decompression. Changes from the v1: - compression support added - zstd detection is fixed - new tests are

Re: [PATCHv2] support ZSTD compression algorithm

2022-12-09 Thread Martin Liška
PING^1 On 11/29/22 13:05, Martin Liška wrote: > Hi. > > There's second version of the patch that fully support both compression and > decompression. > > Changes from the v1: > - compression support added > - zstd detection is fixed > - new tests are added >

[PATCHv2] support ZSTD compression algorithm

2022-11-29 Thread Martin Liška
Hi. There's second version of the patch that fully support both compression and decompression. Changes from the v1: - compression support added - zstd detection is fixed - new tests are added - builds fine w/ and w/o the ZSTD library What's currently missing and where I need a help: 1) When I

Re: [PATCH][RFC] readelf: partial support of ZSTD compression

2022-11-29 Thread Martin Liška
On 11/28/22 23:29, Mark Wielaard wrote: Hi Martin, On Mon, Nov 28, 2022 at 02:16:35PM +0100, Martin Liška wrote: On 10/29/22 00:21, Mark Wielaard wrote: Although I like to also have compression working. Then we can also add support to src/elfcompress, which makes for a good testcase. See

Re: [PATCH][RFC] readelf: partial support of ZSTD compression

2022-11-28 Thread Martin Liška
On 10/29/22 00:21, Mark Wielaard wrote: Although I like to also have compression working. Then we can also add support to src/elfcompress, which makes for a good testcase. See tests/run-compress.sh (which has found some subtle memory issues when run under valgrind). Hi. All right, so I'm prep

[PATCH] Missing newline for: elfcompress -t zlib-gnu a.out -force

2022-11-28 Thread Martin Liška
Hey. Fixes: ./src/elfcompress -t zlib-gnu a.out -force [28] .zdebug_aranges unchanged, already GNU compressed[29] .zdebug_info unchanged, already GNU compressed[30] .zdebug_abbrev unchanged, already GNU compressed[31] .zdebug_line unchanged, already GNU compressed[32] .zdebug_str unchanged, al

Re: [PATCH RFC] backends: Add RISC-V object attribute printing

2022-11-25 Thread Martin Liška
On 10/13/22 16:53, Mark Wielaard wrote: > Hi Andreas, > > On Wed, 2022-08-10 at 11:27 +0200, Andreas Schwab via Elfutils-devel > wrote: >> This does not work yet. The RISC-V attribute tags use the same >> convention as the GNU attributes: odd numbered tags take a string >> value, >> even numbered

[PATCH] readelf: print warning for -sW

2022-11-25 Thread Martin Liška
The option -s accepts in elfutils (compared to binutils) a positional argument that is name of a symbol table section which should be printed. Thus, print a reasonable warning if -sW is used: ./src/readelf -sW a.out WARNING: cannot find section: 'W' Ready for master? Thanks, Martin src/ChangeLog

Re: [PATCH] libebl: Do not require EI_OSABI for IFUNC.

2022-11-25 Thread Martin Liška
On 11/24/22 13:33, Mark Wielaard wrote: > Hi Martin, > > On Thu, 2022-11-24 at 13:23 +0100, Martin Liška wrote: >> Similar fix to: >> https://sourceware.org/bugzilla/show_bug.cgi?id=29718 >> >> Ready for master? > > Assuming runtime, glibc/ld.s

[PATCH] libebl: Do not require EI_OSABI for IFUNC.

2022-11-24 Thread Martin Liška
Similar fix to: https://sourceware.org/bugzilla/show_bug.cgi?id=29718 Ready for master? Thanks, Martin PR 29826 libebl/ChangeLog: * eblsymboltypename.c (ebl_symbol_type_name): Do not require EI_OSABI for IFUNC --- libebl/eblsymboltypename.c | 6 +++--- 1 file changed, 3

Re: [PATCH][RFC] readelf: partial support of ZSTD compression

2022-10-24 Thread Martin Liška
On 10/24/22 18:48, Dmitry V. Levin wrote: > On Mon, Oct 24, 2022 at 02:17:17PM +0200, Martin Liška wrote: >> On 10/24/22 13:41, Dmitry V. Levin wrote: >>> On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote: >>> [...] >>>> One TODO I see is that: &g

Re: [PATCH][RFC] readelf: partial support of ZSTD compression

2022-10-24 Thread Martin Liška
On 10/24/22 13:41, Dmitry V. Levin wrote: > On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote: > [...] >> One TODO I see is that: >> +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd >> >> should be conditional based on HAVE_ZSTD. But I don't know ho

[PATCH][RFC] readelf: partial support of ZSTD compression

2022-10-24 Thread Martin Liška
Support decompression of ZSTD sections and add support for it when -SWz is used: ... [30] .debug_abbrevPROGBITS 1f9d 0168 0 C 0 0 1 [ELF ZSTD (2) 02fc 1] ... One TODO I see is that: +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd should b

GNU Tools Cauldron 2022 - video recordings

2022-10-18 Thread Martin Liška
Hello, Video recordings of the GNU Tools Cauldron 2022 are available now at YouTube: https://www.youtube.com/playlist?list=PL_GiHdX17WtzDK0OVhD_u_a3ti4shpXLl Cheers, Martin

Re: [PATCH] debuginfod: Add Ubuntu's debuginfod service to the list.

2022-09-15 Thread Martin Liška
Pushed, thanks for the server! Martin On 9/15/22 03:26, Sergio Durigan Junior via Elfutils-devel wrote: > Signed-off-by: Sergio Durigan Junior > --- > Debuginfod.html | 8 > 1 file changed, 8 insertions(+) > > diff --git a/Debuginfod.html b/Debuginfod.html > index 64fef86c..71bc7c9b 1

[PATCH] add debuginfod_get_headers if DUMMY_LIBDEBUGINFOD is used

2022-09-08 Thread Martin Liška
Pushed as obvious as I can't build elfutils: [ 70s] gcc -std=gnu99 -Wall -Wshadow -Wformat=2 -Wold-style-definition -Wstrict-prototypes -Wtrampolines -Wlogical-op -Wduplicated-cond -Wnull-dereference -Wimplicit-fallthrough=5 -Werror -Wunused -Wextra -Wstack-usage=262144 -O2 -Wall -U_FORTIFY

[PATCH] Add new debuginfod.sysconfig value DEBUGINFOD_EXTRA_ARGS

2022-08-17 Thread Martin Liška
Split DEBUGINFOD_PATHS and put non-path arguments to the newly created variable called DEBUGINFOD_EXTRA_ARGS. Signed-off-by: Martin Liska --- config/debuginfod.service | 2 +- config/debuginfod.sysconfig | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/config/debuginfod.

[PATCH v2] debuginfod: fix http_requests_total{type="debuginfo"} when dwz is used

2022-08-17 Thread Martin Liška
When dwarf_extract_source_paths is called, it can call handle_buildid when a rpm file used dwz. Ignore such internal request in http_requests_total statistics. Signed-off-by: Martin Liska --- debuginfod/debuginfod.cxx | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/debu

[PATCH v2] debuginfod: print filename for "cannot open archive" error

2022-08-17 Thread Martin Liška
Report the file that has such a problem so that one can inspect it. Signed-off-by: Martin Liska --- debuginfod/debuginfod.cxx | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx index 9245be53..366a4a09 100644 --- a

[PATCH] debuginfod: fix http_requests_total{type="debuginfo"} when dwz is used

2022-08-17 Thread Martin Liška
When dwarf_extract_source_paths is called, it can call handle_buildid when a rpm file used dwz. Ignore such internal request in http_requests_total statistics. Signed-off-by: Martin Liska --- debuginfod/debuginfod.cxx | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a

[PATCH] debuginfod: print filename for "cannot open archive" error

2022-08-17 Thread Martin Liška
Report the file that has such a problem so that one can inspect it. Signed-off-by: Martin Liska --- debuginfod/debuginfod.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx index 9245be53..67683354 100644 --- a/debugi

[PATCH] Support nullglob in profile.*.in files

2022-08-16 Thread Martin Liška
In openSUSE we have the following RPM checker that uses shopt -s nullglob: https://github.com/openSUSE/post-build-checks/blob/master/checks/50-check-libtool-deps#L31 The script loads all /etc/profile.d/*.sh files via source $FILE which can end up by stuck cat (with no arguments): shopt -s nullglo

Re: buildbot users try branch builders for elfutils

2022-08-15 Thread Martin Liška
On 8/15/22 12:01, Mark Wielaard wrote: > Hi Martin, > > On Mon, Aug 15, 2022 at 09:55:13AM +0200, Martin Liška wrote: >> On 7/28/22 17:26, Mark Wielaard wrote: >>> I setup git users try branches for elfutils. If you have commit >>> access to elfutils.git you ca

[PATCH] debuginfod: Fix concurrent request leading to a same .rpm file [PR29474]

2022-08-15 Thread Martin Liška
As explained in detail in the PR, the problem happens when multiple requests lead to a single RPM and one of the threads does prefetching. In that case, the requested file is added to fdcache and thus skip as interned. --- debuginfod/debuginfod.cxx | 69 --- 1 f

Re: buildbot users try branch builders for elfutils

2022-08-15 Thread Martin Liška
On 7/28/22 17:26, Mark Wielaard wrote: > Hi, > > I setup git users try branches for elfutils. If you have commit > access to elfutils.git you can now push to a users//try-xxx > branch and the buildbot will do builds and sent you (the commit > author) email about the results. The builds are also vi

Re: [PATCH] tests: do not fail on zero sized DIEs (binutils-2.39 compatible)

2022-08-07 Thread Martin Liška
On 8/6/22 10:53, Sergei Trofimovich via Elfutils-devel wrote: Hi. Thanks for catching this. Btw. I've also noticed the elfutils failure in openSUSE staging project. > binutils started producing 0-sized DIEs on functions interspersed > by nested sections (".section ...; .previous). This led to >

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Martin Liška
On 11/9/21 14:31, Martin Liška wrote: Correct, I'm not using: s/not/now

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Martin Liška
On 11/9/21 12:45, Mark Wielaard wrote: Hi Martin, On Tue, 2021-11-09 at 10:04 +0100, Martin Liška wrote: On 11/9/21 09:58, Dmitry V. Levin wrote: Yes, but those who build elfutils with -flto are likely using -ffat-lto-objects if they build static libraries. Yes, I can confirm that we do

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Martin Liška
On 11/9/21 10:09, Dmitry V. Levin wrote: On Tue, Nov 09, 2021 at 10:04:57AM +0100, Martin Liška wrote: On 11/9/21 09:58, Dmitry V. Levin wrote: Yes, but those who build elfutils with -flto are likely using -ffat-lto-objects if they build static libraries. Yes, I can confirm that we do that

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Martin Liška
On 11/9/21 09:58, Dmitry V. Levin wrote: Yes, but those who build elfutils with -flto are likely using -ffat-lto-objects if they build static libraries. Yes, I can confirm that we do that as openSUSE, we actually build with: -flto -flto-partition=none -Wno-error=stack-usage= -ffat-lto-objects

Re: [PATCH] RFC: come up with startswith function.

2021-05-12 Thread Martin Liška
On 5/12/21 12:01 PM, Mark Wielaard wrote: Sorry it missed the 0.184 release. Thanks. Don't worry, it's a NOP, nothing urgent. Martin

Re: [PATCH] RFC: come up with startswith function.

2021-05-10 Thread Martin Liška
On 5/1/21 12:13 AM, Mark Wielaard wrote: Yes, it is. It looks good and makes the code simpler to read. Thanks. Is it OK to add your Signed-off-by before I push it? Yes, please do it and push it. Martin

Re: [PATCH] RFC: come up with startswith function.

2021-04-21 Thread Martin Liška
On 4/20/21 1:43 PM, Mark Wielaard wrote: > Hi Martin, > > On Mon, 2021-04-19 at 15:18 +0200, Martin Liška wrote: >> I made similar changes to binutils some time ago and I would like to >> come up with the same function for elfutils. Note that current >> construct >&

[PATCH] RFC: come up with startswith function.

2021-04-19 Thread Martin Liška
Hello. I made similar changes to binutils some time ago and I would like to come up with the same function for elfutils. Note that current construct is quite error prone, I found for instance these 2 bad usages: diff --git a/libdwfl/relocate.c b/libdwfl/relocate.c index 88b5211d..b6de3510 100644

Re: elfutils 0.180 released

2020-06-11 Thread Martin Liška
On 6/11/20 9:07 PM, Mark Wielaard wrote: commit 3eaa4421b2422452b40547aab3e8da0749990ef9 The patch works for me! Thanks, Martin

Re: elfutils 0.180 released

2020-06-11 Thread Martin Liška
On 6/11/20 8:31 PM, Martin Liška wrote: On 6/11/20 7:48 PM, Mark Wielaard wrote: ELFUTILS 0.180 -http://elfutils.org/ Hello. Thank you for the release. I'm seeing a linking error during test build: [   84s] gcc -D_GNU_SOURCE -DHAVE_CONFIG_H -DLOCALEDIR='"/usr/share/l

Re: elfutils 0.180 released

2020-06-11 Thread Martin Liška
On 6/11/20 7:48 PM, Mark Wielaard wrote: ELFUTILS 0.180 -http://elfutils.org/ Hello. Thank you for the release. I'm seeing a linking error during test build: [ 84s] gcc -D_GNU_SOURCE -DHAVE_CONFIG_H -DLOCALEDIR='"/usr/share/locale"' -I. -I.. \ [ 84s] -I. -I. -I../lib -I.. -I../libasm

Re: [COMMITTED] tests: Add GCOV flags when necessary.

2020-06-11 Thread Martin Liška
On 6/11/20 7:09 PM, Mark Wielaard wrote: +if·GCOV +GCOV_FLAGS=-fprofile-arcs·-ftest-coverage +else Hello. The pair of options can be replaced with --coverage. Martin

Re: [COMMITTED] Prepare for 0.176

2019-02-15 Thread Martin Liška
On 2/14/19 9:37 PM, Mark Wielaard wrote: > On Thu, 2019-02-14 at 20:51 +0100, Martin Liška wrote: >> I see 2 tests failing for s390x: >> > https://build.opensuse.org/package/live_build_log/home:marxin:branches:Base:System/elfutils/openSUSE_Factory_zSystems/s390x >> > &

Re: [COMMITTED] Prepare for 0.176

2019-02-14 Thread Martin Liška
Hi. I see 2 tests failing for s390x: https://build.opensuse.org/package/live_build_log/home:marxin:branches:Base:System/elfutils/openSUSE_Factory_zSystems/s390x [ 269s] == [ 269s]elfutils 0.176: tests/test-suite.log [ 269s] =

Re: Prepare for 0.175

2018-11-14 Thread Martin Liška
On 11/14/18 1:16 PM, Mark Wielaard wrote: > Set version to 0.175 > Update NEWS and elfutils.spec.in. > Regenerate po/*.po files. > > Signed-off-by: Mark Wielaard > --- > NEWS| 18 + > config/elfutils.spec.in | 14 + > configure.ac|2 +- > po/de.po

Re: tests/backtrace-dwarf.c failure due to -freorder-blocks-and-partition

2018-08-03 Thread Martin Liška
On 08/03/2018 11:46 AM, Mark Wielaard wrote: > Hi Martin, > > On Fri, 2018-08-03 at 09:41 +0200, Martin Liška wrote: >> As slightly discussed with Mark, there are tests that expect 'main' >> will be present in backtrace. That's not always true on x86_6

tests/backtrace-dwarf.c failure due to -freorder-blocks-and-partition

2018-08-03 Thread Martin Liška
Hello. As slightly discussed with Mark, there are tests that expect 'main' will be present in backtrace. That's not always true on x86_64 because -freorder-blocks-and-partition option is on by default. Then one can see: [ 88s] FAIL: run-backtrace-dwarf.sh [ 88s] [

Re: [PATCH] Prepare for 0.171.

2018-05-30 Thread Martin Liška
On 05/30/2018 02:07 AM, Mark Wielaard wrote: > Please give feedback if you find some time to try it out. And I see a new warning with GCC 8 on arm target: https://sourceware.org/bugzilla/show_bug.cgi?id=23248 Martin

Re: [PATCH] Prepare for 0.171.

2018-05-30 Thread Martin Liška
On 05/30/2018 02:07 AM, Mark Wielaard wrote: > Please give feedback if you find some time to try it out. Thanks Mark for the RC. I see: https://sourceware.org/bugzilla/show_bug.cgi?id=23247 Martin