Re: [PATCH] libdwfl: Read no more than required to parse dynamic sections

2022-12-01 Thread Gavin Li
te patch. Best, Gavin On Wed, Nov 30, 2022 at 3:14 PM Mark Wielaard wrote: > > Hi Gavin, > > On Tue, Nov 29, 2022 at 01:48:42PM -0800, Gavin Li wrote: > > I think for the purposes of reading small segments (like PT_DYNAMIC > > and PT_NOTE), we should ignore *buffer_availabl

Re: [PATCH] libdwfl: Read no more than required to parse dynamic sections

2022-11-29 Thread Gavin Li
Hi Mark, Thanks for looking over this patch. Responses are inline. > The code as written doesn't seem to guarantee that > dwfl_segment_report_module will always be called with > dwfl_elf_phdr_memory_callback as memory_callback. Although it probably > will be in practice. All file/line references