[Bug libelf/32311] elf_compress_gnu.c: gcc warns null-dereference with lto

2024-11-07 Thread the.ra2.ifv at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32311 --- Comment #12 from User441669 --- > Thanks for the testing. > I see you have some other openwrt specific patches. > Do you think any of them are useful upstream or for other distros? Uh, no, I'm not sure about this because I'm just a simple

[Bug tools/32253] FAIL: run-strip-reloc-self.sh with binutils master

2024-11-07 Thread amerey at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32253 Aaron Merey changed: What|Removed |Added CC||amerey at redhat dot com St

[Bug libelf/32311] elf_compress_gnu.c: gcc warns null-dereference with lto

2024-11-07 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=32311 Mark Wielaard changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug libelf/32311] elf_compress_gnu.c: gcc warns null-dereference with lto

2024-11-07 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=32311 --- Comment #10 from Mark Wielaard --- (In reply to User441669 from comment #9) > Compilation successfully! I plan to close this issue as fixed, and send this > patch to the OpenWrt project (named > `007-fix-null-dereference-with-lto.patch` in

Re: [PATCH] strip: Ignore --reloc-debug-sections-only for non-ET_REL files.

2024-11-07 Thread Aaron Merey
On Wed, Nov 6, 2024 at 6:32 PM Mark Wielaard wrote: > > Hi Aaron, > > On Wed, Nov 06, 2024 at 04:15:30PM -0500, Aaron Merey wrote: > > On Wed, Nov 6, 2024 at 2:35 PM Mark Wielaard wrote: > > > >if (reloc_debug_only) > > > > { > > > > + if (ehdr->e_type != ET_REL) > > > > + { > >

Re: [PATCH] libelf: Only fetch shdr once in elf_compress[_gnu]

2024-11-07 Thread Aaron Merey
Hi Mark, On Wed, Nov 6, 2024 at 2:13 PM Mark Wielaard wrote: > > Some compilers assume the second call to elf[32|64]_getshdr can fail > and produce error: potential null pointer dereference. Just store the > result of the first call and reuse (when not NULL). > >* libelf/elf_compress.c (e