Re: [PATCH 5/5] libdwfl, aarch64: Read PAC mask from core

2024-08-16 Thread Mark Wielaard
Hi Steve, On Fri, Jun 14, 2024 at 03:47:19PM +0100, Steve Capper wrote: > We need to read the PAC mask from a core file when debugging offline > as the information is still needed to demangle return addresses. > > This commit pulls out the NT_ARM_PAC_MASK info from the core and feeds > it through

Re: [PATCH 3/3] aarch64: add some new core note types name

2024-08-16 Thread Mark Wielaard
Hi, On Wed, Aug 14, 2024 at 04:51:20PM +0800, Kuan-Ying Lee wrote: > Recognize names of some new core note types in ebl_core_note_type_name. Thanks. Pushed the eblcorenotetypename.c part. I pushed a glibc elf.h sync separately (commit 0abdd2e79). Cheers, Mark

Re: [PATCH 2/3] aarch64: Add NT_ARM_PAC_* regset

2024-08-16 Thread Mark Wielaard
Hi, On Wed, Aug 14, 2024 at 04:51:19PM +0800, Kuan-Ying Lee wrote: > Add the NT_ARM_PAC_MASK and NT_ARM_PAC_ENABLED_KEYS for aarch64. > Recognize and print the new core item. For NT_ARM_PAC_MASK it looks like the user_pac_mask struct, so two 8 byte words. But for NT_ARM_PAC_ENABLED_KEYS I cannot

[Bug debuginfod/32063] let debuginfod-find locate pre-installed (/usr/lib/.debug or similar) exec / .debug files

2024-08-16 Thread osandov at osandov dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32063 Omar Sandoval changed: What|Removed |Added CC||osandov at osandov dot com --- Commen

Re: [PATCH 1/3] aarch64: Add NT_ARM_TAGGED_ADDR_CTRL regset

2024-08-16 Thread Mark Wielaard
On Wed, Aug 14, 2024 at 04:51:18PM +0800, Kuan-Ying Lee wrote: > Add the NT_ARM_TAGGED_ADDR_CTRL regset for aarch64. > Recognize and print this new core itme. Thanks, found the description (The corresponding regset is 1 element of 8 bytes) here https://docs.kernel.org/arch/arm64/memory-tagging-ext

[COMMITTED] libelf: Sync elf.h from glibc

2024-08-16 Thread Mark Wielaard
* libelf/elf.h: Adds NT_ARM_{SSVE,ZA,ZT,FPRM} Signed-off-by: Mark Wielaard --- libelf/elf.h | 4 1 file changed, 4 insertions(+) diff --git a/libelf/elf.h b/libelf/elf.h index 081742a9c38c..33aea7f743b8 100644 --- a/libelf/elf.h +++ b/libelf/elf.h @@ -831,6 +831,10 @@ typedef struc

Re: [PATCH 0/3] aarch64: add some core note types name

2024-08-16 Thread Mark Wielaard
Hi, On Wed, Aug 14, 2024 at 04:51:17PM +0800, Kuan-Ying Lee wrote: > Patch 1: > - Add MTE related regset in core note > Patch 2: > - Add PAC related regset in core note > Patch 3: > - Add some core note types name This look good. Thanks. For elf.h we try to keep it in sync with the glibc elf/

Re: [PATCH 06/10 v3] libdwP.h: Add locking to dwarf_formref_die and __libdw_dieabbrev

2024-08-16 Thread Mark Wielaard
On Fri, Aug 02, 2024 at 07:38:05PM -0400, Aaron Merey wrote: > From: Heather McIntyre > > * libdw/dwarf_formref_die.c (dwarf_formref_die): Add locking > around call to __libdw_intern_next_unit. > * libdw/libdwP.h (__libdw_dieabbrev): Add locking. > > Signed-off-by: Heather

Re: [PATCH 08/10 v3] libdw: Make libdw_findcu thread-safe

2024-08-16 Thread Mark Wielaard
Hi, On Fri, Aug 02, 2024 at 07:38:07PM -0400, Aaron Merey wrote: > From: Heather McIntyre > > * libdw/libdw_findcu.c (__libdw_findcu): Add locking. > > Signed-off-by: Heather S. McIntyre > Signed-off-by: Aaron Merey > Signed-off-by: Mark Wielaard > > --- > v3 changes: > Fix indentatio

Re: [PATCH 07/10 v3] libdw: Make libdw_find_split_unit thread-safe

2024-08-16 Thread Mark Wielaard
Hi, On Fri, Aug 02, 2024 at 07:38:06PM -0400, Aaron Merey wrote: > From: Heather McIntyre > > * libdw/libdwP.h (struct Dwarf_CU): Add split_lock. > * libdw/libdw_find_split_unit.c (__libdw_find_split_unit): > Add locking. > > Signed-off-by: Heather S. McIntyre > Signed-off-

Re: [PATCH 09/10 v3] tests: Add eu-search tests

2024-08-16 Thread Mark Wielaard
Hi, On Fri, 2024-08-02 at 19:38 -0400, Aaron Merey wrote: > From: Heather McIntyre > > * tests/eu_search_cfi.c: New file. > * tests/eu_search_die.c: New file. > * tests/eu_search_lines.c: New file. > * tests/eu_search_macros.c: New file. > * tests/run-eu-s

Re: [PATCH 05/10 v3] libdw: make dwarf_getalt and dwarf_setalt thread-safe

2024-08-16 Thread Mark Wielaard
On Fri, 2024-08-02 at 19:38 -0400, Aaron Merey wrote: > From: Heather McIntyre > > * libdw/dwarf_getalt.c (dwarf_getalt): Add locking. > * libdw/dwarf_setalt.c (dwarf_setalt): Ditto. > > Signed-off-by: Heather S. McIntyre > Signed-off-by: Aaron Merey > Signed-off-by: Mark Wielaard

Re: [PATCH 04/10 v3] libdw: Add rwlocks for Dwarf and Dwarf_CU

2024-08-16 Thread Mark Wielaard
Hi Aaron, On Fri, 2024-08-02 at 19:38 -0400, Aaron Merey wrote: > From: Heather McIntyre > > Add dwarf_lock for Dwarf as well as abbrev_lock for Dwarf_CU. > > * libdw/dwarf_begin_elf.c (dwarf_begin_elf): Init dwarf_lock. > * libdw/dwarf_end.c (cu_free): Free abbrev_lock. > (dw