Re: [PATCH] strip: Add check for elf_begin() result

2024-04-05 Thread Mark Wielaard
Hi Maks, On Fri, Apr 05, 2024 at 09:53:03PM +0300, Maks Mishin wrote: > Return value of a function 'elf_begin' is dereferenced at strip.c:1166 > without checking for NULL, but it is usually checked for this function. Please stop sending these "patches" till you actually understand the code. In t

[PATCH] strip: Add check for elf_begin() result

2024-04-05 Thread Maks Mishin
Return value of a function 'elf_begin' is dereferenced at strip.c:1166 without checking for NULL, but it is usually checked for this function. Found by RASU JSC. Signed-off-by: Maks Mishin --- src/strip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/strip.c b/src/s

Re: [PATCH v3] Hexagon: implement machine flag check

2024-04-05 Thread Matheus Tavares Bernardino
On Fri, 05 Apr 2024 16:45:40 +0200 Mark Wielaard wrote: > > Hi Matheus, > > On Thu, 2024-04-04 at 16:56 -0300, Matheus Tavares Bernardino wrote: > > BTW, just out of curiosity, since the last incident with xz's backdoor > > (which apparently involved malicious code disguised as a test binary), >

Re: [PATCH v3] Hexagon: implement machine flag check

2024-04-05 Thread Mark Wielaard
Hi Matheus, On Thu, 2024-04-04 at 16:56 -0300, Matheus Tavares Bernardino wrote: > BTW, just out of curiosity, since the last incident with xz's backdoor > (which apparently involved malicious code disguised as a test binary), > has the elfutils community already considered using something like >

Re: [PATCH v3 6/6] backends: Add register_info, return_value_location, core_note function on mips

2024-04-05 Thread Mark Wielaard
Hi, On Tue, Mar 05, 2024 at 05:51:22PM +0800, Ying Huang wrote: > From: Ying Huang > > Signed-off-by: Ying Huang > --- > backends/Makefile.am | 3 +- > backends/mips_corenote.c | 85 + > backends/mips_init.c | 3 + > backends/mips_regs.c | 135 +

Re: [PATCH v3 5/6] stack: Fix stack unwind failure on mips

2024-04-05 Thread Mark Wielaard
Hi Ying, On Tue, Mar 05, 2024 at 05:51:21PM +0800, Ying Huang wrote: > From: Ying Huang > > Add abi_cfi, set_initial_registers_tid, unwind on mips. Sorry for reviewing out of order. But this one looked easy enough. The new abi_cfi, unwind and set_initial_registers_tid implementations looks corr