[Bug libdw/27405] libdw_get_srcfiles should not imply srclines

2024-03-28 Thread amerey at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=27405 Aaron Merey changed: What|Removed |Added CC||amerey at redhat dot com --- Comment #2

[PATCH] libdw: dwarf_getsrcfiles should not imply dwarf_getsrclines

2024-03-28 Thread Aaron Merey
dwarf_getsrcfiles causes line data to be read in addition to file data. This is wasteful for programs which only need file or directory names. Debuginfod server is one such example. Fix this by moving the srcfile handling in read_srclines into a separate function read_srcfiles. read_srclines also

Re: [PATCH v3 1/6] Support Mips architecture

2024-03-28 Thread Mark Wielaard
Hi Ying, On Tue, Mar 05, 2024 at 05:51:17PM +0800, Ying Huang wrote: > From: Ying Huang > > Signed-off-by: Ying Huang > --- > backends/Makefile.am| 6 +- > backends/mips_init.c| 52 > backends/mips_reloc.def | 93 +++ > backends/mips_symbol.c | 63 + > libebl/eblopen

[PATCH] tests, config: Add more .gitignore files

2024-03-28 Thread Mark Wielaard
Some new tests and one configure file weren't in .gitignore. Also we made a copy of libelf.h in tests/ which should be an symlink. * config/.gitignore: Add profile.fish. * tests/.gitignore: Add funcretval_test_struct, libelf.h and system-elf-gelf-test. * tests/Makef

Re: [PATCH 0/2] Add initial support for Hexagon

2024-03-28 Thread Matheus Bernardino
Hi, Mark Thanks for the comments. On 3/28/24 8:45 AM, Mark Wielaard wrote: Hi Matheus, The only issue is that we like to keep libelf/elf.h synced with glibc elf/elf.h. Would it be possible/make sense to submit the elf.h changes to libc-alpha? Otherwise we should keep the new constants in some

Re: [PATCH] nm: Fix descriptor leak

2024-03-28 Thread Mark Wielaard
Hi, On Thu, Mar 28, 2024 at 11:49:58PM +0300, Maks Mishin wrote: > The descriptor 'dwfl_fd' is created at nm.c:1278 by calling > function 'dup' and lost at nm.c:1593. Sorry, I don't follow, the code at nm.c:1278 says: /* Duplicate an fd for dwfl_report_offline to swallow. */

Re: [PATCH] segment: Fix dangling pointer

2024-03-28 Thread Mark Wielaard
Hi Maks, On Thu, Mar 28, 2024 at 11:29:22PM +0300, Maks Mishin wrote: > Pointer 'lookup_module' which is a field of the structure 'Dwfl' > freed at segment.c:88 is not overwritten, but it is usually overwritten > after free. But the very next statement is a return true; so old isn't in scope anym

[PATCH] nm: Fix descriptor leak

2024-03-28 Thread Maks Mishin
The descriptor 'dwfl_fd' is created at nm.c:1278 by calling function 'dup' and lost at nm.c:1593. Found by RASU JSC. Signed-off-by: Maks Mishin --- src/nm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/nm.c b/src/nm.c index 3675f59b..fee397dd 100644 --- a/src/nm.c +++ b/src/nm.c @@

[PATCH] segment: Fix dangling pointer

2024-03-28 Thread Maks Mishin
Pointer 'lookup_module' which is a field of the structure 'Dwfl' freed at segment.c:88 is not overwritten, but it is usually overwritten after free. Found by RASU JSC. Signed-off-by: Maks Mishin --- libdwfl/segment.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libdwfl/segment.c b/libdwf

Elfutils Code of Conduct

2024-03-28 Thread Aaron Merey
Hi all, I'd like to propose a formal code of conduct for elfutils. Elfutils already has a brief, informal code of conduct. The CONTRIBUTING document in the elfutils source directory states that: committers/maintainers who repeatedly ignore the above guidelines, are hostile or offensive to

Re: [PATCH 0/2] Add initial support for Hexagon

2024-03-28 Thread Mark Wielaard
Hi Matheus, On Thu, Mar 21, 2024 at 06:09:08PM -0300, Matheus Tavares Bernardino wrote: > The patches were inspired by > https://sourceware.org/cgit/elfutils/commit?id=13a4d1279c5b7847049ca3045d04f2705c45ce31 > > Related to: > https://lore.kernel.org/all/6498586d7d0ed112e6c44be98d439abc549653c7.c