Re: PATCH PR30962, debuginfod

2023-10-11 Thread Frank Ch. Eigler
Hi - > OK. But I think you should add an explanation or example to "Front-end > proxies can also elide sensitive path name components" paragraph. So > the user is fully aware what those "sensitive path names" are. Maybe > even add that debuginfod-find -v example so people can double check. OK, re

Re: [PATCH 12/16] libdw: Make libdw_find_split_unit thread-safe

2023-10-11 Thread Mark Wielaard
Hi Heather, On Tue, Oct 10, 2023 at 03:42:56PM +0200, Mark Wielaard wrote: > From: Heather McIntyre > > * (try_split_file): Use eu_tsearch. > Add lock for cu->split. > > Signed-off-by: Heather S. McIntyre > Signed-off-by: Mark Wielaard > --- > libdw/libdw_find_split_unit.c | 43 +

Re: [PATCH 11/16] libdw: Add locking around __libdw_dieabbrev for dwarf_hasattr

2023-10-11 Thread Mark Wielaard
Hi Heather, On Tue, 2023-10-10 at 15:42 +0200, Mark Wielaard wrote: > From: Heather McIntyre > > * libdw/dwarf_hasattr.c (dwarf_hasattr): Use die_abbrev_lock > around __libdw_dieabbrev call. > > Signed-off-by: Heather S. McIntyre > Signed-off-by: Mark Wielaard > --- > libdw/dwarf

Re: PATCH PR30962, debuginfod

2023-10-11 Thread Mark Wielaard
Hi Frank, On Wed, 2023-10-11 at 10:22 -0400, Frank Ch. Eigler wrote: > > I think this makes sense, but it would be good to see an example of the > > paths this now exposes. > > e.g: > % debuginfod-find -v debuginfo /bin/ls > [...] > x-debuginfod-size: 502024 > x-debuginfod-archive: > /mnt/fedora

Re: PATCH PR30962, debuginfod

2023-10-11 Thread Frank Ch. Eigler
Hi - > I think this makes sense, but it would be good to see an example of the > paths this now exposes. e.g: % debuginfod-find -v debuginfo /bin/ls [...] x-debuginfod-size: 502024 x-debuginfod-archive: /mnt/fedora_koji_prod/koji/packages/coreutils/9.3/4.fc39/x86_64/coreutils-debuginfo-9.3-4.fc3

Re: PATCH PR30962, debuginfod

2023-10-11 Thread Mark Wielaard
Hi Frank, On Tue, 2023-10-10 at 16:37 -0400, Frank Ch. Eigler wrote: > commit e967988e419121cad1d7f40013a316059b1173f0 > Author: Frank Ch. Eigler > Date: Tue Oct 10 16:21:00 2023 -0400 > > PR30962: debuginfod: full paths for X-DEBUGINFOD-FILE/ARCHIVE response > headers > > Previo