[Bug general/29767] run-backtrace-native-core{,-biarch}.sh Tests Fail

2022-12-16 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=29767 Mark Wielaard changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFI

Re: [PATCH 15/25] lib: Implement error properly even when not HAVE_ERR_H

2022-12-16 Thread Yonggang Luo
On Mon, Dec 12, 2022 at 11:37 PM Mark Wielaard wrote: > > Hi, > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > wrote: > > on win32, there is no err.h > > [...] > > +#else > > + (void)status; > > + vfprintf(stderr, format, argp); > > +#endif > >va_end(argp); > > That d

Re: [PATCH 14/25] libdw: check __OPTIMIZE__ in dwarf_whatattr.c and dwarf_whatform.c to match the header

2022-12-16 Thread Yonggang Luo
>From bdf8a3b45f063d010e7c93b3d3bfc42b801ee9b2 Mon Sep 17 00:00:00 2001 From: Yonggang Luo Date: Thu, 20 Oct 2022 02:50:03 +0800 Subject: [PATCH] libdw: Fixes compile of dwarf_whatattr.c and dwarf_whatform.c If __OPTIMIZE__ is defined, then compile dwarf_whatattr.c and dwarf_whatform.c will caus

Re: [PATCH 11/25] libcpu: Use __asm instead asm that can be recognized by both clang-cl and gcc

2022-12-16 Thread Yonggang Luo
On Mon, Dec 12, 2022 at 8:42 PM Mark Wielaard wrote: > > Hi, > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > wrote: > > Signed-off-by: Yonggang Luo > > --- > > libcpu/i386_disasm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libcpu/i386

Re: [PATCH 09/25] include libgen.h in system.h

2022-12-16 Thread Yonggang Luo
But still I think the force cast to (char *) is needed On Sat, Dec 17, 2022 at 5:22 AM 罗勇刚(Yonggang Luo) wrote: > > > > On Fri, Oct 28, 2022 at 7:45 PM Mark Wielaard wrote: > > > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > > wrote: > > > basename function are accessed

Re: [PATCH 09/25] include libgen.h in system.h

2022-12-16 Thread Yonggang Luo
On Fri, Oct 28, 2022 at 7:45 PM Mark Wielaard wrote: > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > wrote: > > basename function are accessed multiple place, but used without > > include libgen.h > > This is wrong. We use the GNU basename (from string.h with > _GNU_SOURCE

Re: [PATCH 08/25] Use configure to detect HAVE_DECL_MMAP and use it for system doesn't provide sys/mman.h

2022-12-16 Thread Yonggang Luo
On Fri, Oct 28, 2022 at 7:41 PM Mark Wielaard wrote: > > Hi, > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > wrote: > > Signed-off-by: Yonggang Luo > > --- > > configure.ac | 1 + > > lib/crc32_file.c | 4 ++-- > > lib/system.h | 2 ++ >

Re: [PATCH 06/25] move platform depended include into system.h of libebl

2022-12-16 Thread Yonggang Luo
On Fri, Oct 28, 2022 at 7:35 PM Mark Wielaard wrote: > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > wrote: > > Because all source in libebl #include , so #include > > in > > libeblP.h is enough, there is multiple memory-access.h file, so use > > relative path to > > incl

Re: [PATCH 02/25] ignore build directory

2022-12-16 Thread Yonggang Luo
It's a common step to configure and make under build directory, so that the IDE won't affect by it On Thu, Oct 27, 2022 at 9:03 PM Mark Wielaard wrote: > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > wrote: > > Signed-off-by: Yonggang Luo > > --- > > .gitignore | 1 + > >

Re: [PATCH 7/7] Add CMake build files

2022-12-16 Thread Yonggang Luo
Using cmake building with msvc-clang will be easier, anyway I'll drop it first On Mon, Oct 17, 2022 at 5:23 AM Mark Wielaard wrote: > > Hi, > > I rather not have multiple build systems in the tree. Are the > autotools not available on your system? > > Cheers, > > Mark -- 此致 礼 罗勇刚 Your

Re: [PATCH 6/7] Fixes building with msvc/clang mingw/gcc

2022-12-16 Thread Yonggang Luo
I am not able running test-suite on windows yet, just getting it compiled at the very first step On Mon, Oct 17, 2022 at 5:21 AM Mark Wielaard wrote: > > Hi, > > I find this hard to review. I have no experienc with msvc and don't > know when/what _MSC_VER implies or how to verify system_win32.c.

[Bug general/29767] run-backtrace-native-core{,-biarch}.sh Tests Fail

2022-12-16 Thread shahab.vahedi at gmail dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=29767 --- Comment #7 from Shahab --- $$ TL;DR; $$___ Please close the issue. $$ $$ Rumbling $$_ $$ I just tried it o