Re: [PATCH 4/5] readelf: Pull regname() into file scope

Hi Timm, On Fri, Jan 08, 2021 at 09:16:32AM +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Right. Adding two arguments allows it as file scope function. Added a ChangeLog entry and pushed. Cheers, Mark

Re: [PATCH 3/5] readelf: Pull left() info file scope

Hi Timm, On Fri, Jan 08, 2021 at 09:16:31AM +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. I would probably simply inlined that line of code into the two callers instead of introducing a new function with two arguments. But this also works. Added a ChangeLog

Re: [PATCH 2/5] readelf: Pull same_set() info file scope

Hi Timm, On Fri, Jan 08, 2021 at 09:16:30AM +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way OK, with the 2 extra arguments this works identically. I did put one same_set call on its own line because it became too long. Added a ChangeLog entry and pushed. Thank

Re: [PATCH 1/5] readelf: Pull add_dump_section() into file scope

Hi Timm, On Fri, Jan 08, 2021 at 09:16:29AM +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. OK. Adding the key as argument allows to select either the data or string sections to add. Added a ChangeLog entry and pushed. Thanks, Mark