Re: Indent and formatting of elfutils

Hi Navin, On Mon, 2020-11-09 at 22:03 +0530, Navin P via Elfutils-devel wrote: >I'm trying to compile elfutils with clang. >I haven't written new code but moved code around. In this process source > code formatting is lost when I moved couple of functions. > > Do you have any indent setti

Re: [PATCH] libelf: Update SH_ENTSIZE_HASH comment.

On Fri, 2020-11-06 at 18:33 +0100, Mark Wielaard wrote: > The elf-knowledge.h contains various macros to deal with specific ELF > knowledge needed to interpret some ELF constructs that can be ambigious > depending on architecture ABI. Update the comment of SH_ENTSIZE_HASH > to add a more technical

Re: multi debug files and artificial module

Hi Sasha, On Thu, 2020-11-05 at 22:15 +, Sasha Da Rocha Pinheiro via Elfutils-devel wrote: > In libdw.h it says: /* The offset can be computed from the address. > */ > How do I get the CU DIE offset from the address? Only saving the > first CU and subtracting it on the others to get the offse

Indent and formatting of elfutils

Hi, I'm trying to compile elfutils with clang. I haven't written new code but moved code around. In this process source code formatting is lost when I moved couple of functions. Do you have any indent settings or clang-format or any auto settings ? Regards, Navin

Re: [PATCH] libdwfl: Do not dlopen libdebuginfod if DEBUGINFOD_URLS is unset or empty

Hi - > [...] The problem with doing the dlopen late is that we also need > libcurl and initializing libcurl (as done by libdebuginfod) is not > thread-safe. >From reading libcurl code, and that of other clients, I still believe this concern was & is overrated. We could back down to simple debugi

Re: [PATCH] libdwfl: Do not dlopen libdebuginfod if DEBUGINFOD_URLS is unset or empty

Hi Vitaly, On Thu, 2020-11-05 at 17:44 +0300, Vitaly Chikunov wrote: > Avoid calling expensive dlopen at the cost of an extra getenv check when > we already know it would not be needed. > > This mirrors the getenv check from debuginfod_query_server. I am sympathetic to this. It would have been a

Re: [PATCH 2/1] config: do not define DEBUGINFOD_URLS environment variable unnecessarily

Hi Dmitry, On Wed, 2020-11-04 at 08:00 +, Dmitry V. Levin wrote: > Before this change, when elfutils was configured without > --enable-debuginfod-urls, the installed profile.d/debuginfod.sh and > profile.d/debuginfod.csh scripts used to define the DEBUGINFOD_URLS > environment variable as an n

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

Hi Dmitry, On Mon, 2020-11-02 at 08:00 +, Dmitry V. Levin wrote: > When elfutils is configured using --enable-libdebuginfod > --disable-debuginfod, that is, when the library is built and > installed > but the server is not, it makes sense to install libdebuginfod.pc > because the latter comple