Hi -
> I was just thinking put them together in one file.
.. or a header?
> Otherwise, just add a comment in both that there is similar code in the
> other file and if you update one, then you probably want to update the
> other too.
Did this for now.
- FChE
Hi Frank,
On Thu, 2019-11-14 at 06:54 -0500, Frank Ch. Eigler wrote:
> > > +++ b/config/debuginfod.sysconfig
> > > +#DEBUGINFOD_VERBOSE="-v"
> > > +DEBUGINFOD_PATHS="/usr/lib/debug /usr/bin /usr/sbin /usr/lib /usr/lib64
> > > /usr/local"
> >
> > Should this also include /usr/libexec ?
> > Isn't
On Thu, 2019-11-14 at 06:24 -0500, Frank Ch. Eigler wrote:
> > [...libdw* debuginfod_find_* calls]
> > But given that they are almost similar, I would suggest to move both
> > into their own file sharing most of the code to do the dlopen dance.
>
> Where? It can't be in the solib. We're talking
Hi,
On Wed, 2019-11-13 at 18:24 -0500, Frank Ch. Eigler wrote:
> Hurrah! Documentation! Thanks.
> >
> > But given that all other documentation is under doc/ could you move it
> > there (guarded by DEBUGINFOD). It is just more consistent. If you leave
> > it in this subdir I think you should also
On Tue, 2019-11-12 at 10:14 -0500, Frank Ch. Eigler wrote:
> > My only concern is that these might slow down configure when debuginfod
> > isn't enabled? Can/Should they be moved later after the enable test?
>
> It'd be fractions of a second per configure run ... worth worrying about?
Probably no
Hi -
> > +// Roll this identifier for every sqlite schema incompatiblity.
> > +#define BUILDIDS "buildids9"
> > +
> > +#if SQLITE_VERSION_NUMBER >= 3008000
> > +#define WITHOUT_ROWID "without rowid"
> > +#else
> > +#define WITHOUT_ROWID ""
> > +#endif
> > +
> > +static const char DEBUGINFOD_SQLITE
https://sourceware.org/bugzilla/show_bug.cgi?id=25173
Mark Wielaard changed:
What|Removed |Added
CC||mark at klomp dot org
--- Comment #1
Hi -
> And I don't like the pretty big testfiles, which aren't self-contained.
> You have to fetch them from a remote koji server. It would be much
> better to have a (small) self-contained .spec file that can be used to
> generate the rpms. Frank is already working on that.
Well, one did not h
Hi -
> > In order to support file/rpm archives that are organized via symlink
> > trees, add an "-L" option to debuginfod, meaning about the same as for
> > find(1) or ls(1): to traverse rather than ignore symlinks.
>
> Could you give an example of when exactly this is necessary?
Because some fi
On 11/15/19 5:35 PM, Mark Wielaard wrote:
> IMHO it would be best to avoid any global state from the start. Since
> we haven't released this api yet we can make it so that it is easy to
> have state per request object.
+1
> In the gdb thread
> https://sourceware.org/ml/gdb-patches/2019-11/msg0
Hi -
> Could you also add a reference to the Prometheus Exposition format. I
> see it is already in a comment in the code. Best to also add it as See
> also in the docs.
OK.
> > +control. The \fI/metrics\fP webapi endpoint is probably not
> > +appropriate for disclosure to the public.
>
> So,
Hi Aaron,
On Fri, 2019-11-15 at 12:03 -0500, Aaron Merey wrote:
> On Fri, Nov 15, 2019 at 11:16 AM Mark Wielaard wrote:
> > On Mon, 2019-11-04 at 16:48 -0500, Frank Ch. Eigler wrote:
> > > At the wise counsel of gdb folks such as and :
> > >
> > > debuginfod 3/3: client interruptability
> >
Hi,
On Thu, 2019-11-07 at 04:08 -0500, Frank Ch. Eigler wrote:
> This webapi extensions allows admins to hook up debuginfod to a
> prometheus-compatible monitoring system for general situational
> statistics. The metrics are simple enough that local curl requests
> can give a user a sense of what
On Fri, Nov 15, 2019 at 11:16 AM Mark Wielaard wrote:
> On Mon, 2019-11-04 at 16:48 -0500, Frank Ch. Eigler wrote:
> > At the wise counsel of gdb folks such as and :
> >
> > debuginfod 3/3: client interruptability
> >
> > For interactive clients such as gdb, interruptibility is important
Hi Frank,
On Thu, 2019-11-07 at 04:07 -0500, Frank Ch. Eigler wrote:
> From: "Frank Ch. Eigler"
> Date: Wed, 6 Nov 2019 18:53:31 -0500
> Subject: [PATCH 1/2] debuginfod 4: symbolic link traversal mode
>
> In order to support file/rpm archives that are organized via symlink
> trees, add an "-L" o
Hi,
On Mon, 2019-11-04 at 16:48 -0500, Frank Ch. Eigler wrote:
> At the wise counsel of gdb folks such as and :
>
> debuginfod 3/3: client interruptability
>
> For interactive clients such as gdb, interruptibility is important for
> usability during longer downloads. This patch
Hi,
On Mon, 2019-10-28 at 15:07 -0400, Frank Ch. Eigler wrote:
> Subject: [PATCH 2/2] debuginfod 2/2: server side
>
> Add the server to the debuginfod/ subdirectory. This is a highly
> multithreaded c++11 program (still buildable on rhel7's gcc 4.8,
> which is only partly c++11 compliant). Incl
On Thu, 2019-11-14 at 21:44 +0100, Mark Wielaard wrote:
> > + // validate buildid
> > + if ((buildid.size() < 2) || // not empty
> > + (buildid.size() % 2) || // even number
> > + (buildid.find_first_not_of("0123456789abcdef") !=
> > string::npos)) // pure tasty lowercase hex
> > +t
18 matches
Mail list logo
