Re: [PATCH] libelf: Fix some 32bit offset/size issues that break updating 4G+ files.

2019-06-19 Thread Dmitry V. Levin
On Thu, Jun 20, 2019 at 01:10:53AM +0200, Mark Wielaard wrote: > On Wed, 2019-06-19 at 02:04 +0200, Mark Wielaard wrote: > > The patch also contains a testcase. But since it is necessary to create > > and process a 4GB+ file it is guarded by some checks to make sure the > > machine has enough disk

Re: [PATCH] libelf: Fix some 32bit offset/size issues that break updating 4G+ files.

2019-06-19 Thread Mark Wielaard
On Wed, 2019-06-19 at 02:04 +0200, Mark Wielaard wrote: > The patch also contains a testcase. But since it is necessary to create > and process a 4GB+ file it is guarded by some checks to make sure the > machine has enough disk and memory. Do these checks look reasonable? > They probably prevent (m