Re: [elephant-devel] Bug in GET-CON

2009-10-18 Thread Alain Picard
"Leslie P. Polzer" writes: > But STORE-CONTROLLER is not a persistent class, so that's neither > needed nor possible. Doh!! :-) -- Please read about why Top Posting is evil at: http://en.wikipedia.org/wiki/Top-posting and http://www.dickalba.demon.co.uk/usenet/guide/faq_topp.html Please read

Re: [elephant-devel] Bug in GET-CON

2009-10-18 Thread Leslie P. Polzer
Hi Alain, I just pushed your patch. You wrote: > I understand that perfectly, which is why I was happy to provide > a new patch. No harm done. It's just that I've forced everone > on my team for 10 years to use the same .emacs file, so there's > never any "empty" or "meaningless" white space

Re: [elephant-devel] Bug in GET-CON

2009-10-17 Thread Alain Picard
"Leslie P. Polzer" writes: > FWIW I guess most projects wouldn't accept such a patch. It's I understand that perfectly, which is why I was happy to provide a new patch. No harm done. It's just that I've forced everone on my team for 10 years to use the same .emacs file, so there's never any "e

Re: [elephant-devel] Bug in GET-CON

2009-10-17 Thread Leslie P. Polzer
Alain Picard wrote: > That's because my emacs automatically cleans up the whitespace > as a file saving hook --- something I would heartily recommend > to any developer using emacs. But since this isn't my project, > I will again try to make a simpler patch. FWIW I guess most projects wouldn't

Re: [elephant-devel] Bug in GET-CON

2009-10-17 Thread Alain Picard
Alain Picard writes: OK - here is a MINIMAL patch. It applies with patch -p1 < /tmp/patch. Hope this one works! --ap diff -rN -wu old-elephant-1.0-work/src/elephant/controller.lisp new-elephant-1.0-work/src/elephant/controller.lisp --- old-elephant-1.0-work/src/elephant/controller.lisp 20

Re: [elephant-devel] Bug in GET-CON

2009-10-17 Thread Alain Picard
"Leslie P. Polzer" writes: > Alain Picard wrote: > >>> You could also make a Darcs patch using "darcs record" followed by >>> "darcs send -o mypatch", although in the general case I prefer plain >>> diffs. >> >> OK - here's a patch produced as above. > > Thank you, this one applies. > > But the p

Re: [elephant-devel] Bug in GET-CON

2009-10-17 Thread Leslie P. Polzer
Alain Picard wrote: >> You could also make a Darcs patch using "darcs record" followed by >> "darcs send -o mypatch", although in the general case I prefer plain >> diffs. > > OK - here's a patch produced as above. Thank you, this one applies. But the patch is very cluttered since it's full of

Re: [elephant-devel] Bug in GET-CON

2009-10-16 Thread Alain Picard
"Leslie P. Polzer" writes: > But this one doesn't apply cleanly here: > You could also make a Darcs patch using "darcs record" followed by > "darcs send -o mypatch", although in the general case I prefer plain > diffs. OK - here's a patch produced as above. Sat Oct 17 10:28:34 EST 2009 dr.ala

Re: [elephant-devel] Bug in GET-CON

2009-10-16 Thread Leslie P. Polzer
Alain Picard wrote: > This patch works against what was tip in darcs 3 days ago. > If this helps >darcs show repo > Type: darcs >Format: darcs-1.0 > Root: /home/ap/Subway/subway-elephant/src/systems/elephant-1.0 > Pristine: PlainPristine "_darcs/

Re: [elephant-devel] Bug in GET-CON

2009-10-15 Thread Alain Picard
"Leslie P. Polzer" writes: > I'd be happy to review and apply your patch. It should contain a test > case if that's possible. OK, here it is. Sorry, I don't have a test case, but I did verify that it now works properly from two separate processes when I now pass :register t to OPEN-STORE. Thi

Re: [elephant-devel] Bug in GET-CON

2009-10-15 Thread Leslie P. Polzer
Alain Picard wrote: > The correct fix involved capturing the ARGS which are required to > properly reopen a store controller. I'm not sure where those should > be captured (Perhaps as a slot on the store-controller?) I'm happy to > attempt a fix if someone would confirm that the approach I prop

[elephant-devel] Bug in GET-CON

2009-10-14 Thread Alain Picard
The current version of GET-CON is broken. The code reads: (defmethod get-con ((instance persistent)) (let ((con (fast-lookup-con-spec (db-spec instance (cond ((not con) (aif (slow-lookup-con-spec (db-spec instance)) (progn