[Dx-packages] [Bug 1506744] Re: Newly installed applications do not show in the dash

2016-06-23 Thread Allison Ryan Lortie
To elaborate on the previous remark: why didn't we just replace: menu_monitor_queue_event (event_info); with: g_timeout_add_seconds (2, menu_monitor_queue_event, event_info); (and make sure menu_monitor_queue_event() returns FALSE)? -- You received this bug notification because you are a

[Dx-packages] [Bug 1506744] Re: Newly installed applications do not show in the dash

2016-06-23 Thread Allison Ryan Lortie
The latest patch looks good to me, but with a couple of notes (no need to fix these): - using the _full() version of the timeout call is not necessary here - now that this patch is simplified it becomes easy to see how all of this is just putting values into one structure and then later moving

[Dx-packages] [Bug 1506744] Re: Newly installed applications do not show in the dash

2016-05-24 Thread Allison Ryan Lortie
The patch in comment 42 is not acceptable, for two big reasons. First: you need to hold a ref on the GFile object when you put it into the info struct. This means that you cannot simply use g_free for the struct: you need to write a custom free func that handles the unref as well. Also: you can'

[Dx-packages] [Bug 1512002] Re: Annoying dialog "Authentication is required to change your own user data"

2016-04-15 Thread Allison Ryan Lortie
Although I agree that it makes sense to allow the user to modify their own data even if not "actively logged in", I think it would also be interesting to track down the program that is the real source of this problem. ie: let's figure out which part of the session is writing to accountsservice at

[Dx-packages] [Bug 1485659] Re: Date/time indicator doesn't update after changing time zone

2015-09-02 Thread Ryan Lortie
A couple of notes: - this is fixed upstream in GLib already - watching dbus for the signal is fine, but you should not use dbus to read the property in the first place. This will result in activation of the datetime service, which is expensive. -- You received this bug notification because y

[Dx-packages] [Bug 1315434] Re: Mouse with no time remaining estimate showing in preference to battery being charged

2015-03-12 Thread Ryan Lortie
Just to play devil's advocate a bit here: The logic taken in this bug (that we should show the device that will run out of power first) seems perfectly sound, but it makes a very large assumption, which I suspect will often be untrue: that reporting of time remaining on mice will always be complet

[Dx-packages] [Bug 1430542] [NEW] Indicator doesn't use weighted average with different-sized batteries

2015-03-10 Thread Ryan Lortie
Public bug reported: The indicator implements the spec: https://wiki.ubuntu.com/Power#Handling_multiple_batteries which states: "Their percentages should be averaged." Apparently this was taken to mean the simple arithmetic mean, and not the weighted average (by the capacity of each batter

[Dx-packages] [Bug 1284017] Re: gnome-shell crashed with SIGABRT in g_thread_abort()

2015-02-15 Thread Ryan Lortie
In fact, I think this was fixed a year ago already: https://bugzilla.gnome.org/show_bug.cgi?id=724929 Did anyone see this in newer Ubuntu releases (ie: the released version of trusty or later)? -- You received this bug notification because you are a member of DX Packages, which is subscribed

[Dx-packages] [Bug 1284017] Re: gnome-shell crashed with SIGABRT in g_thread_abort()

2015-02-15 Thread Ryan Lortie
It's worth noting that this bug can no longer occur as it is described here -- g_mutex_lock() has been rewritten and the new version doesn't abort. That said, the underlying issue that was causing the misuse of a mutex could very well still exist... Unfortunately, it's very difficult to guess wha

[Dx-packages] [Bug 1364070] Re: vivid, utopic and trusty unity (7.3.1+14.10.20140811-0ubuntu1) launcher addition through gsettings isn't picked up

2015-02-05 Thread Ryan Lortie
Yup. This is a GIO issue. We register a file monitor and don't bother checking if desktop files changed until we see the file monitor has fired. Due to inotify implementation issues, this usually happens about ~1s later. We will need to add a mechanism to force a reload and/or do it automatical

[Dx-packages] [Bug 967879] Re: "hud-service" has a memory leak (I think)

2013-12-03 Thread Ryan Lortie
** Changed in: indicator-appmenu (Ubuntu) Assignee: Ryan Lortie (desrt) => (unassigned) -- You received this bug notification because you are a member of DX Packages, which is subscribed to indicator-appmenu in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/b