g compatibility, we can use the default transport in a
> given
> VM depending on the underlying hypervisor.
I think AF_VSOCK should hide the transport from users/applications.
Think of same-on-same nested virtualization: VMware-on-VMware or
KVM-on-KVM. In that case specifying VMCI or virtio doesn't help.
We'd still need to distinguish between "to guest" and "to host"
(currently VMCI has code to do this but virtio does not).
The natural place to distinguish the destination is when dealing with
the sockaddr in connect(), bind(), etc.
Stefan
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
listener sock is locked, preventing concurrent modification. I have
checked both the virtio and vmci transports. Can you post an example
where the listener sock isn't locked?
Stefan
signature.asc
Description: PGP signature
___
devel m
On Tue, Aug 15, 2017 at 10:18:41PM +, Dexuan Cui wrote:
> +static u32 hvs_get_local_cid(void)
> +{
> + return VMADDR_CID_ANY;
> +}
Interesting concept: the guest never knows its CID. This is nice from a
live migration perspective. Currently VMCI and virtio adjust listen
socket local CIDs
On Fri, Aug 18, 2017 at 11:07:37PM +, Dexuan Cui wrote:
> > From: Stefan Hajnoczi [mailto:stefa...@redhat.com]
> > > CID is not really used by us, because we only support guest<->host
> > communication,
> > > and don't support guest<->guest
On Fri, Aug 18, 2017 at 10:23:54PM +, Dexuan Cui wrote:
> > From: Stefan Hajnoczi [mailto:stefa...@redhat.com]
> > Sent: Thursday, August 17, 2017 07:56
> > To: Dexuan Cui
> > On Tue, Aug 15, 2017 at 10:18:41PM +, Dexuan Cui wrote:
> > > +
On Tue, Aug 22, 2017 at 09:40:01PM +, Dexuan Cui wrote:
> > From: Stefan Hajnoczi [mailto:stefa...@redhat.com]
> > On Fri, Aug 18, 2017 at 10:23:54PM +, Dexuan Cui wrote:
> > > > > +static bool hvs_stream_allow(u32 cid, u32 port)
> > > > > +{
&
u are in Prague, Czech Republic on October 25-27 for
Linux Kernel Summit, Open Source Summit Europe, Embedded Linux
Conference Europe, KVM Forum, or MesosCon Europe?
Stefan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverprojec
This fixes a NULL pointer dereference on RPi 2 with multi_v7_defconfig.
The function page_address() could return NULL with enabled CONFIG_HIGHMEM.
So fix this by using kmap() instead.
Signed-off-by: Stefan Wahren
Fixes: 71bad7f08641 ("staging: add bcm2708 vchiq driver")
---
drive
idProduct);
>
> @@ -444,13 +448,11 @@ void line6_toneport_disconnect(struct usb_interface
> *interface)
> device_remove_file(&interface->dev, &dev_attr_led_green);
> }
>
> - if (toneport != NULL) {
> - struct snd_line6_pcm *line6pcm = toneport->
further
cleanups and a move out of staging/. There's not that much left to do
but the rate of progress at the moment is zero.
Stefan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Jun 24, 2014 at 9:52 PM, Greg KH wrote:
> On Tue, Jun 24, 2014 at 11:54:10AM +0800, Stefan Hajnoczi wrote:
>> On Tue, Jun 24, 2014 at 4:23 AM, Kristina Martšenko
>> wrote:
>> > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
>
On Fri, Jun 27, 2014 at 1:39 AM, Greg KH wrote:
> On Tue, Jun 24, 2014 at 10:12:03PM +0800, Stefan Hajnoczi wrote:
>> On Tue, Jun 24, 2014 at 9:52 PM, Greg KH wrote:
>> > On Tue, Jun 24, 2014 at 11:54:10AM +0800, Stefan Hajnoczi wrote:
>> >> On Tue, Jun 24, 2014
This allows drivers for devices connected via SPI to check if the
controller supports a given bits_per_word value during setup.
Currently any BPW value is accepted durings setup, and transfers
are rejected later.
Signed-off-by: Stefan Brüns
---
drivers/spi/spi.c | 27
on RPi B with an Ilitek9341 based TFT display in 9 bit mode.
Crossposting to linux-spi and staging ML, as the FBTFT 9 bit fix
depends on the change in SPI core.
Stefan Brüns (2):
spi: check bits_per_word in spi_setup
staging/fbtft: use spi_setup instead of direct call to master->setup
d
Avoid a crash, as master->setup may be NULL (e.g. xilinx controller).
Even if master->setup is set, spi_setup does several compatibility/
sanity checks which should not be skipped (fixes problems with
displays/controllers needing emulation for bits_per_word = 9).
Signed-off-by: Stefan
Calling the setup of the SPI master directly causes a NULL pointer
dereference with master drivers without a separate setup function.
This problem is reproduceable on ARM MXS platform.
So fix this issue by using spi_setup() instead.
Signed-off-by: Stefan Wahren
---
drivers/staging/fbtft
This patch series fixes the 9-bit SPI support of fbtft.
Stefan Wahren (2):
staging: fbtft: replace master->setup() with spi_setup()
staging: fbtft: fix 9-bit SPI support detection
drivers/staging/fbtft/fb_uc1611.c|2 +-
drivers/staging/fbtft/fb_watterott.c |4 ++--
driv
Since bits_per_word isn't usually checked during SPI setup the 9-bit
support must be checked manually.
Signed-off-by: Stefan Wahren
---
drivers/staging/fbtft/fbtft-core.c |7 +++
drivers/staging/fbtft/flexfb.c |7 +++
2 files changed, 14 insertions(+)
diff --git a/dr
> Noralf Trønnes hat am 25. August 2015 um 00:00
> geschrieben:
>
>
>
> Den 24.08.2015 20:33, skrev Stefan Wahren:
> > Since bits_per_word isn't usually checked during SPI setup the 9-bit
> > support must be checked manually.
> >
> > Signed-off
This patch series fixes issues caused by calling SPI master setup function
directly.
Changes since RFC:
* use only bits_per_word_mask for 9-bit support detection
(suggested by Noralf Trønnes)
* change patch order
Stefan Wahren (2):
staging: fbtft: fix 9-bit SPI support detection
Calling the setup of the SPI master directly causes a NULL pointer
dereference with master drivers without a separate setup function.
This problem is reproduceable on ARM MXS platform.
So fix this issue by using spi_setup() instead.
Signed-off-by: Stefan Wahren
---
drivers/staging/fbtft
Since the result of the setup function isn't adequate to check
9-bit SPI support, we better check bits_per_word_mask. Btw this
change avoids a NULL pointer dereference with master drivers
without a separate setup function.
Signed-off-by: Stefan Wahren
---
drivers/staging/fbtft/fbtft-c
On Monday 24 August 2015 01:24:59 Noralf Trønnes wrote:
> Den 24.08.2015 00:24, skrev Stefan Brüns:
> > Avoid a crash, as master->setup may be NULL (e.g. xilinx controller).
> > Even if master->setup is set, spi_setup does several compatibility/
> > sanity checks which s
or may not reject 9 bpw.
> >
> > Why should one penalize any controllers having an unset bpw mask, which
> > is a completely valid configuration?
> >
> > BTW, the SPI core patch needed for this to work is in the 4.3 pull
> > request.
>
> I
Am 02.09.2015 um 19:29 schrieb Noralf Trønnes:
>
> Den 01.09.2015 19:52, skrev Brüns, Stefan:
>> On Tuesday, September 01, 2015 16:57:14 Noralf Trønnes wrote:
>>>> IMHO, this is a bad idea. A controller supporting more than 32 bpw can
>>>> not set the bpw mas
BUG();
> + BUG_ON(!platform_state->inited);
>
vchiq isn't critical so i prefer WARN_ON_ONCE() here.
Thanks
Stefan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ning nearly once a week. Suggestion:
staging: vchiq_version: Use tabs for identation
In case there are more files in vc04_services affected by this particular
issue, you are invited to fix them, too.
Thanks
Stefan
___
devel mailing list
de...@linu
[add Phil]
> Arnd Bergmann hat am 2. Februar 2018 um 16:01 geschrieben:
>
>
> There are two incompatible definitions of 'vchiq_instance_struct', so
> passing them through vchiq_initialise(), vchiq_connect() or another
> such interface is broken, as shown by building the driver with link-time
>
vchiq_build_info.h
> delete mode 100644
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_memdrv.h
> delete mode 100644
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c
>
The memdrv interface is possibly used by a driver in the RPi Foundation tree,
at only one of the two sides actually access the members,
> but it's clear that they need to agree on the layout. The easiest way
> to achieve this appears to be to merge the two files into one. I tried
> moving the structure definition into a shared header first, but ended
> up runni
tack. This saves stack space and removes the VLA build warning.
> >
> > kmalloc a buffer for dumping state instead of using the stack.
> >
> > [1]: https://lkml.org/lkml/2018/3/7/621
> >
> > Signed-off-by: Tobin C. Harding
> > ---
>
> Drop this plea
The TODO list missed some issues before we can move the driver out of staging.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchi/TODO | 27 +++
1 file changed, 27 insertions(+)
diff --git a/drivers/staging/vc04_services/interface/vchi/TODO
b
The bcm2835-camera driver has already been imported. So remove it from the TODO.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchi/TODO | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/TODO
b/drivers/staging
The TODO list missed some issues before we can move the driver out of staging.
Signed-off-by: Stefan Wahren
Reviewed-by: Eric Anholt
---
drivers/staging/vc04_services/interface/vchi/TODO | 31 +++
1 file changed, 31 insertions(+)
Changes in V2:
- make corruption test case
The bcm2835-camera driver has already been imported. So remove it from the TODO.
Signed-off-by: Stefan Wahren
Reviewed-by: Eric Anholt
---
drivers/staging/vc04_services/interface/vchi/TODO | 5 -
1 file changed, 5 deletions(-)
Changes in V2:
- add Eric's reviewed-by
diff --git a/dr
Hi Dan,
> Dan Carpenter hat am 22. März 2018 um 13:28
> geschrieben:
>
>
> Hello Stefan Wahren,
>
> The patch d1eab9dec610: "staging: vchiq_core: Bail out in case of
> invalid tx_pos" from May 26, 2017, leads to the following static
> checker warnin
It's better to use the __func__ macro instead of open-code the function
name. This fixes the following checkpatch warning:
WARNING: Prefer using '"%s...", __func__' to using 'x',
this function's name, in a string
Signed-off-by: Stefan Wahren
---
Hiding memset behind a macro isn't the best, because it relies on that
the parameter is not a pointer. Luckily all user has been removed, so
we can remove BITSET_ZERO too.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 1 -
1 file chang
This removes the stackhog in process_free_queue by allocating the
necessary memory within the recycle thread main function instead
of the stack.
Signed-off-by: Stefan Wahren
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 16
1 file changed, 12 insertions(+), 4
Multiline dereferences aren't nice to review. So fix this checkpatch
warning.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vc04_services/inte
Move all calls of wake_up_process to one point, whichs makes the
following implementation of clean-up code easier.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers
]: https://lkml.org/lkml/2018/3/7/621
CC: Tobin C. Harding
Signed-off-by: Stefan Wahren
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c| 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
The bail out branch in case of a invalid tx_pos missed a semaphore
release. Dan Carpenter found this with a static checker.
Fixes: d1eab9dec610 ("staging: vchiq_core: Bail out in case of invalid tx_pos")
Reported-by: Dan Carpenter
Signed-off-by: Stefan Wahren
---
drivers/staging/vc0
vchiq_initialise() is used in non-interrupt context, so we can
replace udelay with usleep_range as suggested by timers-howto.txt.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
The chance to mixup i and j is very high. So rename variable j to a more
explaining one.
Signed-off-by: Stefan Wahren
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vc04_services
In order to make the code easier to review, move the second
abort criterion into the loop and the incrementation into
a separate line.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions
We need to free the kthreads in error case before leaving
vchiq_init_state() otherwise we leak resources.
Signed-off-by: Stefan Wahren
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers
On Fri, Sep 13, 2013 at 10:07 AM, Dan Carpenter
wrote:
> "source" comes from the user in snd_ctl_elem_write() so it needs to be
> checked.
>
> Signed-off-by: Dan Carpenter
Reviewed-by: Stefan Hajnoczi
___
On Mi, 2018-11-21 at 16:04 -0200, Giuliano Belinassi wrote:
> Previously, the AD7780 driver only supported gpio for the 'powerdown'
> pin. This commit adds suppport for the 'gain' and 'filter' pin.
Hey,
Comments inline.
>
> Signed-off-by: Giuliano Belinassi
> ---
> drivers/staging/iio/adc/ad778
On Lu, 2018-11-26 at 17:24 -0200, Giuliano Belinassi wrote:
Hi, please see bellow
> Hi, thank you for the review
>
> >
> > On Thu, 22 Nov 2018 11:01:00 +
> > "Popa, Stefan Serban" wrote:
> > >
> > > I think that instead o
On Mi, 2018-11-28 at 16:15 -0200, Giuliano Belinassi wrote:
> Previously, the AD7780 driver only supported gpio for the 'powerdown'
> pin. This commit adds suppport for the 'gain' and 'filter' pin.
>
> Signed-off-by: Giuliano Belinassi
> ---
> Changes in v2:
> - Now this patch is part of the
On Du, 2018-12-16 at 13:49 +, Jonathan Cameron wrote:
> On Thu, 13 Dec 2018 14:46:17 +0200
> Stefan Popa wrote:
>
> >
> > This patch replaces the use of a polling ring buffer with a threaded
> > interrupt.
> >
> > Enabling the buffer sets the CONVST s
uliano Belinassi
> Co-developed-by: Giuliano Belinassi
> ---
> Changes in v2:
> - Filter reading changed to mHz
> - Storing filter, gain and voltage to chip_info
Hi,
Comments inline.
Regards,
Stefan
>
> drivers/staging/iio/adc/ad7780.c | 103 +++
On Vi, 2019-02-01 at 12:55 -0200, Renato Lui Geh wrote:
> On 01/30, Popa, Stefan Serban wrote:
> >
> > On Du, 2019-01-27 at 18:30 -0200, Renato Lui Geh wrote:
> > >
> > > Previously, the AD7780 driver only supported gpio for the 'powerdown'
> > &g
patch for another driver. Is there any driver that I
> can
> > > > > fix a style warning?
> > > >
> > > > Maybe, one checkstyle patch is enough, right? Which drivers can I
> truly
> > > > contribute to?
> > >
> > > How about the
pyright notes and
updates MODULE_DESCRIPTION.
Signed-off-by: Andrea Merello
Signed-off-by: John W. Linville
Regards
Stefan Lippers-Hollmann
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
no driver[2] made it to staging or the proper kernel.
> RTL81xxEU (2013)
Regards
Stefan Lippers-Hollmann
[1] apparently even concurrent operations for the double MAC +
double PHY variants
[2] https://github.com/lwfinger/rtl8192du
pgpl
Hi
On 2016-07-22, Arnd Bergmann wrote:
> On Friday, July 22, 2016 7:55:36 AM CEST Jes Sorensen wrote:
> > Stefan Lippers-Hollmann writes:
> > > On 2016-07-20, Arnd Bergmann wrote:
> > >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote:
drivers to small corrections and
bugfixes. In the hope that the devices will get enough traction that
someone takes up the effort of doing a parallel re-implementation of a
proper mac80211 based driver, using the staging source only as
reference.
Regards
St
of comment as possible (e.g. translating from chinese), but in
this case none of the removed comments states anything non-obvious.
Regards
Stefan Lippers-Hollmann
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.or
401 - 460 of 460 matches
Mail list logo
