From: Dave Stevenson
mmal-common.h and mmal-msg.h didn't have the normal
ifndef FOO / define FOO / endif protection to stop it being
included multiple times. Add it.
Signed-off-by: Dave Stevenson
Signed-off-by: Stefan Wahren
Acked-by: Hans Verkuil
Acked-by: Mauro Carvalho C
From: Dave Stevenson
Most of the headers use ifndef FOO_H, whilst mmal-parameters.h
used ifndef __FOO_H.
Revise mmal-parameters.h to drop the underscores and make the
headers all consistent.
Signed-off-by: Dave Stevenson
Signed-off-by: Stefan Wahren
Acked-by: Hans Verkuil
Acked-by: Mauro
From: Dave Stevenson
Clear checkpatch complaints of "multiple assignments should be avoided"
Signed-off-by: Dave Stevenson
Signed-off-by: Stefan Wahren
Acked-by: Hans Verkuil
Acked-by: Mauro Carvalho Chehab
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 5 +++
d-off-by: Dave Stevenson
Signed-off-by: Stefan Wahren
Acked-by: Hans Verkuil
Acked-by: Mauro Carvalho Chehab
---
drivers/staging/vc04_services/bcm2835-camera/controls.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-c
From: Dave Stevenson
RGB3/BGR3 end up being 3 bytes per pixel, which meant that
the alignment code ended up trying to align using bitmasking
with a mask of 96.
That doesn't work, so switch to an arithmetic alignment for
those formats.
Signed-off-by: Dave Stevenson
Signed-off-by: Stefan W
From: Dave Stevenson
Fixes a v4l2-compliance failure
v4l2-test-buffers.cpp(415): g_field() == V4L2_FIELD_ANY
The driver only ever produces progresive frames, so field should
always be set to V4L2_FIELD_NONE.
Signed-off-by: Dave Stevenson
Signed-off-by: Stefan Wahren
Acked-by: Hans Verkuil
From: Dave Stevenson
Fixes up a checkpatch error "Avoid using bool structure members
because of possible alignment issues".
Signed-off-by: Dave Stevenson
Signed-off-by: Stefan Wahren
Acked-by: Hans Verkuil
Acked-by: Mauro Carvalho Chehab
---
drivers/staging/vc04_services/bcm2
used in the REQBUFS case where it provides
the buffer properties.
Signed-off-by: Dave Stevenson
Signed-off-by: Stefan Wahren
Acked-by: Hans Verkuil
Acked-by: Mauro Carvalho Chehab
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c| 16
1 file changed, 16 inser
Hi Yue,
Am 26.07.19 um 11:26 schrieb YueHaibing:
> Fix gcc used-but-set-variable warning:
just a nit. It is call "unused-but-set-variable"
Acked-by: Stefan Wahren
>
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function
> vchiq_release_inter
SPI host drivers can use DMA to transfer data, so the buffer should be properly
allocated.
Keeping it on the stack could cause an undefined behavior.
The dedicated reset function solves this issue.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7192.c | 4 +---
1 file changed, 1
Hi Greg,
> Phil Elwell hat am 11. August 2017 um 12:20
> geschrieben:
>
>
> The previous commit (0adbfd46) fixed a memory leak but also freed a
> block in the success case, causing a stale pointer to be used with
> potentially fatal results. Only free the vchi_instance block in the
> case that
Hi Phil,
> Greg Kroah-Hartman hat am 23. September 2017 um
> 18:15 geschrieben:
>
>
> On Sat, Sep 23, 2017 at 12:57:33PM +0200, Stefan Wahren wrote:
> > Hi Greg,
> >
> > > Phil Elwell hat am 11. August 2017 um 12:20
> > > geschrieben:
>
("staging: bcm2835-audio: fix memory leak in
> bcm2835_audio_open_connection()")
Tested-by: Stefan Wahren
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Am 03.10.2017 um 13:43 schrieb Arvind Yadav:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav
Acked-by: Stefan Wahren
> ---
> drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +-
&g
taging/vc04_services/interface/vchiq_arm/vchiq_core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Stefan Wahren
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
e currently ignore NAND_CMD_SEQIN in ->cmdfunc anyway, so I think this
change would not even be necessary here.
This is a NAND controller which will benefit from the new interface. I
plan to convert the driver to the new interface, maybe I manage to do
that soon so we have a second driver making use of the new interface.
> + nand_prog_page_begin_op(chip, page, 0, buf, mtd->writesize);
> if (oob_required)
> vf610_nfc_write_buf(mtd, chip->oob_poi, mtd->oobsize);
>
> @@ -588,7 +588,7 @@ static int vf610_nfc_write_page(struct mtd_info
> *mtd, struct nand_chip *chip,
> nfc->use_hw_ecc = true;
> nfc->write_sz = mtd->writesize + mtd->oobsize;
>
> - return 0;
> + return nand_prog_page_end_op(chip);
> }
>
> static const struct of_device_id vf610_nfc_dt_ids[] = {
--
Stefan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
c: Greg Kroah-Hartman
> Cc: Eric Anholt
> Cc: Stefan Wahren
> Cc: Michael Zoran
> Cc: Keerthi Reddy
> Cc: linux-rpi-ker...@lists.infradead.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: de...@driverdev.osuosl.org
>
Hi,
in a recent discussion [1] with Phil Elwell pointed out that the VPU firmware
of the Raspberry Pi isn't aware of an unload of the vchiq kernel module after a
successful registration.
So my question is there a proper way to prevent a platform driver from
unloading?
[1] - https://github.com
Hello Mikhail,
Am 07.12.2017 um 08:47 schrieb Mikhail Shvetsov:
> From: Mike
please provide your full name and a changelog. Also the subject should
start with something like "staging: vchiq_arm:".
>
> Signed-off-by: Mike
> ---
> .../interface/vchiq_arm/vchiq_kern_lib.c | 64
> +
Am 13.12.2017 um 21:51 schrieb Tomas Marek:
This patch fix brace on next line coding style errors reported by
checkpatch.
Signed-off-by: Tomas Marek
Acked-by: Stefan Wahren
Thanks
___
devel mailing list
de...@linuxdriverproject.org
http
m
the maintainer, and I resend the fixed description with the reviewed-by?
did you test your patch via vchiq_test or something else?
Please add Eric Anholt and fix my mail address in the second version, i
only received this via mailing list.
Stefan
+ const struct vchiq_element __user *ele
Hi Carlos,
Am 30.07.2018 um 11:25 schrieb Carlos Maiolino:
On Mon, Jul 30, 2018 at 11:13 AM, Stefan Wahren wrote:
Hi Carlos,
Am 30.07.2018 um 11:08 schrieb Carlos Maiolino:
On Mon, Jul 30, 2018 at 10:58 AM, Greg KH wrote:
On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote
Am 30.07.2018 um 11:43 schrieb Carlos Maiolino:
> On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren
> wrote:
>> i think easiest the way would be to get a recent Raspbian Lite (
>> https://www.raspberrypi.org/downloads/raspbian/ ),
>> build the kernel with bcm2835_defconf
Hi Carlos,
> Carlos Maiolino hat am 30. Juli 2018 um 11:57
> geschrieben:
>
>
> On Mon, Jul 30, 2018 at 11:49 AM, Stefan Wahren
> wrote:
> > Am 30.07.2018 um 11:43 schrieb Carlos Maiolino:
> >> On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren
> >>
uot;staging:
bcm2835-audio: Fix alignment of functions arguments" would be better.
Stefan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> Greg Gallagher hat am 8. August 2018 um 03:40
> geschrieben:
>
>
> Fix warnings generated by checkpatch.pl for alignment should match open
> parenthesis. This is a coding style change only.
>
> Signed-off-by: Greg Gallagher
gt; +static int tegra_nand_read_page_raw(struct nand_chip *chip, u8 *buf,
> int oob_required, int page)
> {
> + struct mtd_info *mtd = nand_to_mtd(chip);
> void *oob_buf = oob_required ? chip->oob_poi : NULL;
>
> return te
On 19.08.2018 13:26, Boris Brezillon wrote:
> Hi Stefan,
>
> On Sat, 18 Aug 2018 10:30:13 +0200
> Stefan Agner wrote:
>
>> > diff --git a/drivers/mtd/nand/raw/tegra_nand.c
>> > b/drivers/mtd/nand/raw/tegra_nand.c
>> > index 5dcee20e2a8c..bcc3a2888
On 20.08.2018 10:09, Boris Brezillon wrote:
> Hi Stefan,
>
> On Mon, 20 Aug 2018 09:57:47 +0200
> Stefan Agner wrote:
>
>> On 19.08.2018 13:26, Boris Brezillon wrote:
>> > Hi Stefan,
>> >
>> > On Sat, 18 Aug 2018 10:30:13 +0200
>> > S
Hi Michael,
> Michael Zoran hat am 18. Februar 2017 um 01:03
> geschrieben:
>
>
> This appears to be an ancient issue with the old github.com sources.
no, in the old sources DT binding was optional [1]. But now it should be
mandatory and i think cache-line-size should be a required property,
of_property_read_u32.
Signed-off-by: Michael Zoran
Acked-by: Stefan Wahren
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
;gdev[0]' freed? Should it be?
sorry, didn't checked your patch yet. Currently there are 3 bcm2835
drivers in staging (vchiq, camera, audio). So please resend with a more
distinct subject.
Thanks
Stefan
---
drivers/staging/media/platform/bcm2835/bcm2835-camera.c | 6 --
1 f
> Dan Carpenter hat am 24. Februar 2017 um 20:57
> geschrieben:
>
>
> On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote:
> > Hi Christophe,
> >
> > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET:
> > >If 'kzalloc()' fails, w
Including those headers is unnecessary, so we better remove them.
Signed-off-by: Stefan Wahren
---
.../interface/vchiq_arm/vchiq_2835_arm.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
b/drivers/staging
There is no need to define PAGE_SIZE in the vchiq driver
so remove the define from vchiq_pagelist.h .
Signed-off-by: Stefan Wahren
---
.../interface/vchiq_arm/vchiq_pagelist.h |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm
vchiq_2835_arm.c uses functions and macros like put_page() or
PAGE_ALIGN(). So we better include the necessary header.
Signed-off-by: Stefan Wahren
---
.../interface/vchiq_arm/vchiq_2835_arm.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services
[add Eric]
> Michael Zoran hat am 18. Februar 2017 um 12:59
> geschrieben:
>
>
> On Sat, 2017-02-18 at 03:22 -0800, Michael Zoran wrote:
> > The original github source allowed for the cache-line-size property
> > to be missing. Since recent firmwares also require this property,
> > it makes s
>
> What's the rule as to who exactly I should be including on patches?
> get_maintainer.pl displays a very long list for stagging, so it isn't
> clear to me who should be getting this.
At least the active maintainers (bcm2835 + staging) and the relevant mailing
lists. Usually i try to avoid se
> Eric Anholt hat am 26. Februar 2017 um 18:16 geschrieben:
>
> ...
>
> For staging, Greg has been taking patches without platform maintainer
> ack. I think this is great -- the staging code needs *lots* of work,
> and it generally doesn't need any platform knowledge.
>
> As far as this patch
> Michael Zoran hat am 28. Februar 2017 um 19:49
> geschrieben:
>
>
> Change the audio's dependency on BCM2835_VCHIQ to a select.
>
> Signed-off-by: Michael Zoran
> ---
> drivers/staging/vc04_services/bcm2835-audio/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff
> Michael Zoran hat am 1. März 2017 um 17:39 geschrieben:
>
>
> On Wed, 2017-03-01 at 16:51 +0300, Dan Carpenter wrote:
> > On Tue, Feb 28, 2017 at 09:18:56PM +0100, Stefan Wahren wrote:
> > >
> > > > Michael Zoran hat am 28. Fe
> Michael Zoran hat am 2. März 2017 um 04:41 geschrieben:
>
>
> This patch adds compatibility wrappers for the ioctls
> exposed by vchiq/vc04_services. The compat ioctls are
> completely implemented on top of the native ioctls. No
> existing lines are modified.
>
> While the ideal approach w
ort *peer_ve
> {
> int32_t ret = -1;
> SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle;
> - if (service)
> - {
> + if (service) {
Since you want to fix coding stlye i think it's better to leave an empty
line between the declaration and
> Sergiy Redko hat am 4. März 2017 um 06:15 geschrieben:
>
>
> On 03/03, Stefan Wahren wrote:
> > Hi Sergiy,
> >
> > Am 03.03.2017 um 09:05 schrieb Sergiy Redko:
> > > fix coding style: move brace to the line above
> >
> > please make the s
t that Eric's fixes for await
> completion will not work at all.
>
> Only handling the case of 1 passed in would completely break vchiq_test
> which is the main test application and would break all of 32 bit user
> mode which would defeat the point of the wrapp
There is no need to include types.h and vmalloc.h twice.
This issue has been found by make includecheck.
Signed-off-by: Stefan Wahren
---
.../vc04_services/interface/vchiq_arm/vchiq_util.h |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm
Am 14.03.2017 um 07:45 schrieb Michael Zoran:
> The extra virtual cards created for HDMI and Headphone output
> may not be compatible with operating systems that expose
> very simple audio controls.
>
> By default only enable the traditional mode that exposes a single
> card for maximum compatibili
> Jean-Baptiste Abbadie hat am 14. März 2017 um 20:14
> geschrieben:
>
>
> These four functions are not used and report errors with sparse.
>
> Signed-off-by: Jean-Baptiste Abbadie
Acked-by: Stefan Wahren
___
quest
> for the full fix there) and stop bothering you.
>
> Dave
i wasn't involved in this issue. But i wouldn't be happy if the
Foundation take care only of the downstream tree in the future.
So i would be happy if you or Michael could fix this issue properly.
Th
64] vchiq_get_state: g_state.remote == NULL
> [ 991.847969] vchiq: vchiq_initialise: videocore not initialized
>
> [ 991.847973] mmal_vchiq: Failed to initialise VCHI instance (status=-1)
>
only a guess, but did you add the vchiq node to the device tree?
vchiq: v
Hi Michael,
Am 17.03.2017 um 16:22 schrieb Michael Zoran:
The firmware now has a mailbox API for performing generalized gpio through
the firmware. This driver builds upon a driver written by Dave Stevenson
that was written specifically for the expander on the RPI 3, but I have
generalized for
Hi Michael,
> Michael Zoran hat am 17. März 2017 um 17:48 geschrieben:
>
>
> On Fri, 2017-03-17 at 17:31 +0100, Stefan Wahren wrote:
> > Hi Michael,
> >
> >
> > Am 17.03.2017 um 16:22 schrieb Michael Zoran:
> > > The firmware now has
Regarding to the header the driver is licensed under BSD and GPL.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b
> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben:
>
>
> From: Dave Stevenson
>
> Pi3 and Compute Module 3 have a GPIO expander that the
> VPU communicates with.
> There is a mailbox service that now allows control of this
> expander, so add a kernel driver that can make use of it.
>
> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben:
>
>
> The original change this driver is based on adds the needed mailbox
> defines to include/soc/bcm2835/raspberrypi-firmware.h. That is not
> appropriate at this time, so add the defines directly into the
> driver source.
>
> This c
> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben:
>
>
> This change adds the following optional DT properties:
>
> number-gpios: Number of GPIOs the device should expose
> gpio-base: GPIO base that is registered with the kernel
Please don't reinvent existing properties. Take a look a
> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben:
>
>
> This change adds the driver to the standard kernel build system.
>
> Signed-off-by: Michael Zoran
> ---
> drivers/staging/vc04_services/Kconfig| 2 ++
> drivers/staging/vc04_services/Makefile
Hi Michael,
> Michael Zoran hat am 19. März 2017 um 05:42 geschrieben:
>
>
> On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote:
> > > Michael Zoran hat am 17. März 2017 um 16:22
> > > geschrieben:
> > >
> > >
> > > From: Dave Ste
keep compability
with the Foundation tree. Currently i'm afraid that we build up many drivers in
staging, which need a complete rewrite later if they should come out of
staging. It would be nice if we could avoid the situation we have with the
thermal driver.
Stefan
Hi Mauro,
Am 20.03.2017 um 11:58 schrieb Mauro Carvalho Chehab:
Em Sun, 19 Mar 2017 22:11:07 -0300
Mauro Carvalho Chehab escreveu:
Em Sun, 19 Mar 2017 10:04:28 -0700
Michael Zoran escreveu:
A working DT that I tried this morning with the current firmware is
posted here:
http://lists.infra
.
Detected by CoverityScan, CID#1419681 ("Explicit null dereferenced")
Signed-off-by: Colin Ian King
Acked-by: Stefan Wahren
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> kbuild test robot hat am 1. April 2018 um 01:36 geschrieben:
>
>
> Hi Stefan,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on staging/staging-testing]
> [also build test WARNING on v4.16-rc7 next-20180329]
> [if your pat
load newer ones here (even for i686):
https://releases.linaro.org/components/toolchain/binaries/7.2-2017.11/arm-linux-gnueabihf/
Best regards
Stefan
Best Regards,
Kirill
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriv
, let's just allocate the memory instead of using the
stack. This saves stack space and removes the VLA build warning.
kmalloc a buffer for dumping state instead of using the stack.
[1]: https://lkml.org/lkml/2018/3/7/621
CC: Kees Cook
Signed-off-by: Tobin C. Harding
Signed-off-by: Stefan W
This fixes a whitespace issue reported by checkpatch:
ERROR: code indent should use tabs where possible
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
Since there is no vchiq function listed by "make checkstack" anymore,
we can remove the stack hog issue from the TODO.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchi/TODO | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drive
In order to make the code easier to review, move the second
abort criterion into the loop and the incrementation into
a separate line.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions
-devel@linuxdriverproject.org/msg73716.html
Changes in V2:
- rebased
- fixed format issue reported by kbuild test robot
- switch back to kmalloc in VLA patch because the function could be called
from concurrent threads
Stefan Wahren (9):
staging: vchiq_arm: print real dump limit
staging
The definition of USE_VCHIQ_ARM and VCOS_VERIFY_BKPTS isn't really necessary
so remove them.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/Makefile | 2 +-
drivers/staging/vc04_services/interface/vchi/vchi_common.h | 2 --
2 files changed, 1 insertion(
This removing an unnecessary return which has been reported by checkpatch.pl.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b
The chance to mixup i and j is very high. So rename variable j to a more
explaining one.
Signed-off-by: Stefan Wahren
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c| 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vc04_services
We better use the real loop limit in the warning about
"too many active services". Another benefit is than we don't have to care
about the format string in the following change.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
This removes an unnecessary break which has been reported by checkpatch.pl.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
b
The overlay code is non-functional since it relies on firmware control
of the HVS.
Signed-off-by: Stefan Schake
---
Dave, does this match your understanding?
drivers/staging/vc04_services/bcm2835-camera/TODO | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/staging
that will be passed along with our message so
> + * that when we service the VCHI reply, we can look up what
> + * message is being replied to.
> + */
> + spin_lock(&instance->context_map_lock);
> + handle = idr_alloc(&instance->context_map, msg_context,
> +0, 0, GFP_KERNEL);
> + spin_unlock(&instance->context_map_lock);
>
> - if (!msg_context->handle) {
> + if (msg_context->handle < 0) {
handle < 0 ?
> kfree(msg_context);
> - return ERR_PTR(-ENOMEM);
> + return ERR_PTR(handle);
> }
>
> + msg_context->instance = instance;
> + msg_context->handle = handle;
> +
> return msg_context;
> }
>
Regards
Stefan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
memory management, an overlay can be implemented
in userland through DRM overlay planes of which we provide plenty.
Signed-off-by: Stefan Schake
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 255 +
.../vc04_services/bcm2835-camera/bcm2835-camera.h | 18
This checks the preview component for overlay functionality, but that has
little to do with streaming (you don't need to enable the overlay to do
streaming). We shouldn't withhold frames from userspace because of an
estimate for AGC stabilization time in any case.
Signed-off-by: Ste
In order to provide a channel name to in kernel consumers add the
datasheet names for every usable AD channel.
Signed-off-by: Stefan Wahren
---
drivers/staging/iio/adc/mxs-lradc.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/drivers
Am 05.06.2015 um 15:43 schrieb Marek Vasut:
> On Thursday, June 04, 2015 at 08:44:31 PM, Stefan Wahren wrote:
>> In order to provide a channel name to in kernel consumers add the
>> datasheet names for every usable AD channel.
> Hi!
>
> Did you check those channel name
Am 20.11.19 um 14:38 schrieb Krzysztof Kozlowski:
> Adjust indentation from spaces to tab (+optional two spaces) as in
> coding style with command like:
> $ sed -e 's/^/\t/' -i */Kconfig
>
> Signed-off-by: Krzysztof Kozlowski
far I've basically just
> diffed the output of 'cat /dev/vchiq', run the program above with
> a few different values, and run vchiq_test a few times.
i consider this as sufficient, but i'm not the VCHIQ expert.
Thanks
Stefan
>
> These were applied to the staging-ne
The initializer lists for the V4L2 controls are hard to read.
So improve this by using designators.
Signed-off-by: Stefan Wahren
---
.../vc04_services/bcm2835-camera/controls.c| 424 ++---
1 file changed, 277 insertions(+), 147 deletions(-)
diff --git a/drivers/staging
These 2 patches improves the V4L2 controls in the bcm2835 camera driver.
Stefan Wahren (2):
staging: bcm2835-camera: Drop unused ignore_errors flag
staging: bcm2835-camera: Use designators to init V4L2 controls
.../vc04_services/bcm2835-camera/controls.c| 458
The struct bm2835_mmal_v4l2_ctrl contains an ignore_errors flag which
was always set to false. So drop the unused flag.
Signed-off-by: Stefan Wahren
---
.../vc04_services/bcm2835-camera/controls.c| 34 +-
1 file changed, 1 insertion(+), 33 deletions(-)
diff --git a
I don't see any reason to keep this TODO, so activate the
V4L2_EXPOSURE_METERING_MATRIX handling.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/bcm2835-camera/controls.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/st
We can reduce the indentation in mmal_setup_components further by
returning early in error case.
Signed-off-by: Stefan Wahren
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 60 +++---
1 file changed, 31 insertions(+), 29 deletions(-)
diff --git a/drivers/staging
We can reduce the indentation in the loop by using continue in case the
effect doesn't match.
Signed-off-by: Stefan Wahren
---
.../vc04_services/bcm2835-camera/controls.c| 63 +++---
1 file changed, 31 insertions(+), 32 deletions(-)
diff --git a/drivers/st
This define is used only once. So drop the define and init the layer
directly.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 2 +-
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h | 2 --
2 files changed, 1 insertion(+), 3
Except of patch 2 all these patches tries to clean up the bcm2835-camera
driver.
Stefan Wahren (9):
staging: bcm2835-camera: Drop PREVIEW_LAYER
staging: bcm2835-camera: Activate V4L2_EXPOSURE_METERING_MATRIX
handling
staging: bcm2835-camera: Make struct indentation consistent
staging
This simplifies set_framerate_params and avoids the multiple assignment
in one line by moving the fps_high handling out of the if statement.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/bcm2835-camera/controls.c | 15 ++-
1 file changed, 6 insertions(+), 9
There are a lot of multiline statements which can be reduced.
Signed-off-by: Stefan Wahren
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 57 +-
.../vc04_services/bcm2835-camera/controls.c| 3 +-
2 files changed, 23 insertions(+), 37 deletions(-)
diff
The indentation of struct members wasn't consistent over the whole driver.
Signed-off-by: Stefan Wahren
---
.../vc04_services/bcm2835-camera/bcm2835-camera.h | 60 +++---
.../vc04_services/bcm2835-camera/controls.c| 4 +-
.../vc04_services/bcm2835-camera/mmal-com
The function mmal_setup_components has to many indention levels. So move
the setup code for video component in its own function.
Signed-off-by: Stefan Wahren
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 88 --
1 file changed, 48 insertions(+), 40 deletions
The function mmal_setup_components has to many indention levels. So move
the setup code for encode component in its own function.
Signed-off-by: Stefan Wahren
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 185 ++---
1 file changed, 91 insertions(+), 94 deletions
s://github.com/0day-ci/linux/commits/Stefan-Wahren/staging-bcm2835-camera-Clean-up-driver/20200329-225704
>
>
> in testcase: boot
>
> on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 8G
>
> caused below changes (please refer t
rs/staging/line6/playback.c | 5 +
> drivers/staging/line6/toneport.c | 1 +
> 3 files changed, 7 insertions(+)
Reviewed-by: Stefan Hajnoczi
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi,
recently i found that vchiq_test -f doesn't work anymore with current mainline
(4.11-rc6) and linux-next (20170404) on my Raspberry Pi Zero. The issue is
always reproducible, but the error behavior isn't deterministic. Sometimes
vchiq_test hangs and sometimes i get an error message from vch
> Stefan Wahren hat am 11. April 2017 um 20:10
> geschrieben:
>
>
> Hi,
>
> recently i found that vchiq_test -f doesn't work anymore with current
> mainline (4.11-rc6) and linux-next (20170404) on my Raspberry Pi Zero. The
> issue is always reproducib
ages().
Thanks for your explanation and the example, but i can't see the relevant
difference. So i think i'm not the right person to fix this issue, but i will
test any patches regarding to this issue.
>
> The rest of the driver should also be converted to the DMA mapping API
>
Am 20.04.2017 um 21:58 schrieb Rabin Vincent:
> On Thu, Apr 20, 2017 at 11:27:38AM -0700, Eric Anholt wrote:
>> I'm confused by what you're saying here. The driver has already been
>> converted to not use dmac_map_area (commit
>> cf9caf1929882b66922aee698e99e6c8f357bee5), and uses dma_map_sg inste
201 - 300 of 460 matches
Mail list logo
