Hi,
attached patch applies value of pixelclk-active
to support displays which need a falling edge on pixelclk like
seiko-wvga on wandboard.
diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c
index 720868b..71c741b 100644
--- a/drivers/staging/imx-drm/ipuv3-crt
Signed-off-by: stefan
---
drivers/staging/imx-drm/parallel-display.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/imx-drm/parallel-display.c
b/drivers/staging/imx-drm/parallel-display.c
index 4ca61af..a67c1ad 100644
--- a/drivers/staging/imx-drm/parallel-display.c
Signed-off-by: stefan
---
drivers/staging/imx-drm/ipuv3-crtc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c
b/drivers/staging/imx-drm/ipuv3-crtc.c
index 720868b..71c741b 100644
--- a/drivers/staging/imx-drm/ipuv3-crtc.c
+++ b
-MODULE_DEVICE_TABLE(of, vchiq_of_match);
> > -
> > static struct platform_driver vchiq_driver = {
> > .driver = {
> > .name = "bcm2835_vchiq",
> > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h
> > b/drivers/stag
Hi Phil,
Am 17.09.2018 um 10:22 schrieb Phil Elwell:
> Both sides of the VCHIQ communications mechanism need to agree on the cache
> line size. Using an incorrect value can lead to data corruption, but having
> the
> two sides using different values is usually worse.
>
> In the absence of an obvi
> Tuomas Tynkkynen hat am 21. September 2018 um 21:56
> geschrieben:
>
>
> As far as I can tell, this has never been used.
>
> Signed-off-by: Tuomas Tynkkynen
Acked-by: Stefan Wahren
___
devel mailing list
de...@linuxd
> Phil Elwell hat am 17. September 2018 um 10:22
> geschrieben:
>
>
> Use the compatible string in the DTB to select the correct cache line
> size for the SoC - 32 for BCM2835, and 64 for BCM2836 and BCM2837.
>
> Signed-off-by: Phil Elwell
ot;)
>
> Also remove the unnecessary asm/cacheflush.h header.
This doesn't match to the subject. Maybe a separate patch would be
better here.
Thanks
Stefan
>
> Signed-off-by: Aymen Qader
> ---
> v2: Make commit message clearer
>
> drivers/staging/vc04_services/bcm
t; flush operations")
>
> Aymen Qader (2):
> staging: bcm2835-camera: Update TODO
> staging: bcm2835-camera: Remove unused header
The whole series is
Acked-by: Stefan Wahren
___
devel mailing list
de...@linuxdriverproject.org
http://
>
> I've tested on a Raspberry Pi Model B (bcm2835_defconfig) that
> snd-bcm2835 can still play analog audio just fine.
>
thanks and i'm fine with your patch series:
Acked-by: Stefan Wahren
Unfortunately this would break compilation of the downstream vchi drivers like
vcsm [1].
le = ctrl->val & 0xff;
>
> ret = vchiq_mmal_port_parameter_set(dev->instance, control,
as long as the current behavior is correct, i'm okay with this patch.
But the byte masking looks suspicious, so i hope Dave can clarify that.
Thanks Stefan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Dave,
> Dave Stevenson hat am 8. Oktober 2018 um
> 18:51 geschrieben:
>
>
> Hi Stefan.
>
> Thanks for forwarding as the linux-rpi-kernel list hasn't sent it to me as
> yet.
AFAIK every mail with more than 5 recipients will be delayed.
>
> On Mon,
Hi,
Am 17.10.2018 um 11:55 schrieb Dave Stevenson:
> On Mon, 15 Oct 2018 at 17:27, Eric Anholt wrote:
>> Stefan Wahren writes:
>>
>>> Hi Tuomas,
>>>
>>>> Tuomas Tynkkynen hat am 4. Oktober 2018 um 11:37
>>>> geschrieben:
>>>&
>>>> entire header files worth of unused code.
>>>>>>
>>>>>> I've tested on a Raspberry Pi Model B (bcm2835_defconfig) that
>>>>>> snd-bcm2835 can still play analog audio just fine.
>>>>>>
>>>&g
Move ad7606 ADC driver out of staging and into the mainline.
Signed-off-by: Stefan Popa
---
MAINTAINERS | 7 +
drivers/iio/adc/Kconfig | 34 +++
drivers/iio/adc/Makefile | 3 +
drivers/iio/adc/ad7606.c | 565
ingly
> and adds suggestions from Takashi.
>
Acked-by: Stefan Wahren
for the rest of the series
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Following Eric's commit 37b7b3087a2f ("staging/vc04_services: Register a
platform device for the camera driver.") this register the audio driver as
a platform device, too.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4
1
Enable the compilation test for bcm2835-audio to gain more build coverage.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/bcm2835-audio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/Kconfig
b/drivers
27; series ("staging: vc04_services:
Some dead code removal") has been applied, i will rebase my series.
Stefan Wahren (11):
staging: bcm2835-camera: Abort probe if there is no camera
staging: bcm2835-camera: fix module autoloading
staging: bcm2835-camera: Move module info to the end
st
There is not much value behind this boilerplate, so use
module_platform_driver() instead.
Signed-off-by: Stefan Wahren
---
.../staging/vc04_services/bcm2835-audio/bcm2835.c| 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/staging/vc04_services
In order to have this more consistent between the vc04 services move
the module information to the end of the file.
Signed-off-by: Stefan Wahren
---
.../staging/vc04_services/bcm2835-camera/bcm2835-camera.c| 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a
Since the camera driver isn't probed via DT, we need to properly setup DMA.
Fixes: 37b7b3087a2f ("staging/vc04_services: Register a platform device for the
camera driver.")
Signed-off-by: Stefan Wahren
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c| 20 +
Just like the bcm2835-video make this a platform driver which is probed
by vchiq. In order to change the number of channels use a module
parameter instead, but use the maximum as default.
Signed-off-by: Stefan Wahren
---
.../staging/vc04_services/bcm2835-audio/bcm2835.c | 41
In error case platform_device_register_data would return an ERR_PTR
instead of NULL. So we better check this before unregistration.
Fixes: 37b7b3087a2f ("staging/vc04_services: Register a platform device for the
camera driver.")
Signed-off-by: Stefan Wahren
---
drivers/staging/vc0
As per default the GPU memory config of the Raspberry Pi isn't sufficient
for the camera usage. Even worse the bcm2835 camera driver doesn't provide a
helpful error message in this case. So let's add a hint to point the user
to the likely cause.
Signed-off-by: Stefan Wahren
---
In order to make the module bcm2835-camera load automatically, we need to
add a module alias.
Fixes: 4bebb0312ea9 ("staging/bcm2835-camera: Set ourselves up as a platform
driver.")
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 1
Abort the probing of the camera driver in case there isn't a camera
actually connected to the Raspberry Pi. This solution also avoids a
NULL ptr dereference of mmal instance on driver unload.
Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera
driver.")
Signed
Currently there is only a catch-all info message which print the
relevant error code without any context. So add more specific error
messages in order to narrow down possible issues.
Signed-off-by: Stefan Wahren
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 58
Hi Dave,
> Dave Stevenson hat am 26. Oktober 2018 um
> 19:15 geschrieben:
>
>
> Thanks Stefan.
> I've picked up your latest patches which mean I can get the driver
> loaded via the (almost) approved method.
> I do seem to still have issues with not getting the
Hi Nicolas,
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um
> 13:06 geschrieben:
>
>
> Hi Stefan,
>
> On Thu, 2018-10-25 at 17:29 +0200, Stefan Wahren wrote:
> > This patch series improves the load/unload of bcm2835 camera and
> > audio
> > drivers.
Hi Nicolas,
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um
> 15:48 geschrieben:
>
>
> vchiq_init_state() initialises a series of semaphores to then call
> remote_event_create() on the same semaphores, which initializes them
> again.
i would prefer to have all init stuff at one place in v
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um
> 15:48 geschrieben:
>
>
> We update sync to reflect that the firmware version is compatible with
> that option. We don't need to check both of them again further down the
> code.
please fix the typo in the subject s/stagning/staging/ for thi
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um
> 15:48 geschrieben:
>
>
> It is preferred in the kernel to avoid using semaphores to wait for
> events, as they are optimised for the opposite situation; where the
> common case is that they are available and may block only occasionally.
> FY
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um
> 15:48 geschrieben:
>
>
> Some operations performed in the probe function should have been
> implemented in the init function. Namely class and dev region creations.
>
Please explain the why in the commit log
___
> Nicolas Saenz Julienne hat am 26. Oktober 2018 um
> 15:48 geschrieben:
>
>
> The more the better.
Please try to find a better commit log ;-)
>
> Signed-off-by: Nicolas Saenz Julienne
> ---
> .../staging/vc04_services/interface/vchi/TODO | 46 ++-
> 1 file changed, 44 in
Am 06.11.18 um 16:41 schrieb Nicolas Saenz Julienne:
> Hi Stefan,
> thanks for spending the time reviewing the code. I took note of the
> rest of comments.
>
> On Sun, 2018-10-28 at 21:45 +0100, Stefan Wahren wrote:
>> Hi Nicolas,
>>
>>> Nicolas Saenz Julienne
> Phil Elwell hat am 17. September 2018 um 20:01
> geschrieben:
>
>
> On 17/09/2018 18:51, Florian Fainelli wrote:
> > On 09/17/2018 04:47 AM, Phil Elwell wrote:
> >> Hi Stefan,
> >>
> >> On 17/09/2018 12:39, Stefan Wahren wrote:
> >>&
binary forms, with or without
> * modification, are permitted provided that the following conditions
After adding the SPDX id we can drop the whole license text.
> @@ -36,7 +36,7 @@
>
> #include
>
> -typedef int32_t VCHI_MEM_HANDLE_T;
> +typedef s32 VCHI_MEM_HANDLE_T;
In
t; messages.
>
> See https://github.com/raspberrypi/linux/pull/2703 for more discussion of
> this patch.
>
> Fixes: 5569a12 ("staging: vchiq_arm: Add compatibility wrappers for ioctls")
>
> Signed-off-by: Ben Wolsieffer
Acked-by: Stefan Wahren
___
Hi Andre,
> Stefan Wahren hat am 7. November 2018 um 09:30
> geschrieben:
>
>
> >
> > Signed-off-by: André Almeida
> >
> > ---
> >
> > Hello! This is my first patch to Linux Kernel. Let me know any feedback
> > ---
> > drivers/stag
cy of 10s to 100s of parts per million.
>
> Signed-off-by: Mike Brady
the former version of your patch has already been applied to staging-next.
Didn't you received Greg's email?
So please rebase your changes.
Stefan
___
devel mailing l
Hi Andre,
Am 13.11.2018 um 01:37 schrieb andrealm...@riseup.net:
> From: André Almeida
>
> As pointed by Stefan Wahren in v1, this file is dual licensed
> as GPL-2 and BSD-3.
please avoid references to old versions in the commit log, because after
applying this patch the cont
gt;
> Signed-off-by: André Almeida
Acked-by: Stefan Wahren
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
7; to 's32'
> stagin: vchi: Add SPDX-License-Identifier
>
> drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
sorry i didn't noticed this before my Ack, but Nicolas wants to remove
the wh
> RPIv3B+ with audio, video and running vchiq_test.
>
> Regards,
> Nicolas
>
without a changelog i won't start a review.
Regards
Stefan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Am 20.11.18 um 11:04 schrieb Nicolas Saenz Julienne:
> On Tue, 2018-11-20 at 10:57 +0100, Greg KH wrote:
>> On Sun, Nov 18, 2018 at 04:55:49PM +0100, Stefan Wahren wrote:
>>> Hi Nicolas,
>>>
>>>
>>> without a changelog i won't start a review.
&g
Move ad7606 ADC driver out of staging and into the mainline.
Signed-off-by: Stefan Popa
---
Changes in v2:
- Simplified the Kconfig menu.
- Added SPDX-License-Identifier.
- Ordered the includes alphabetically.
- Used a threaded interrupt.
- Replaced
- Update probe/init commit message (commit 14)
> - Update TODO commit message and clean up (commit 16)
> - Fix spelling on some of the patches
>
The whole series is
Acked-by: Stefan Wahren
Unfortunately patch 05 might not apply.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Move ad7606 ADC driver out of staging and into the mainline.
Signed-off-by: Stefan Popa
---
Changes in v2:
- Simplified the Kconfig menu.
- Added SPDX-License-Identifier.
- Ordered the includes alphabetically.
- Used a threaded interrupt.
- Replaced
Enable the compilation test for bcm2835-audio to gain more build coverage.
Signed-off-by: Stefan Wahren
Reviewed-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/bcm2835-audio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services
Currently there is only a catch-all info message which print the
relevant error code without any context. So add more specific error
messages in order to narrow down possible issues.
Signed-off-by: Stefan Wahren
Reviewed-by: Nicolas Saenz Julienne
---
.../vc04_services/bcm2835-camera/bcm2835
There is not much value behind this boilerplate, so use
module_platform_driver() instead.
Signed-off-by: Stefan Wahren
Reviewed-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/bcm2835-audio/bcm2835.c| 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff
Abort the probing of the camera driver in case there isn't a camera
actually connected to the Raspberry Pi. This solution also avoids a
NULL ptr dereference of mmal instance on driver unload.
Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera
driver.")
Signed
Just like the bcm2835-video make this a platform driver which is probed
by vchiq. In order to change the number of channels use a module
parameter instead, but use the maximum as default.
Signed-off-by: Stefan Wahren
Reviewed-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/bcm2835
Since the camera driver isn't probed via DT, we need to properly setup DMA.
Fixes: 37b7b3087a2f ("staging/vc04_services: Register a platform device for the
camera driver.")
Signed-off-by: Stefan Wahren
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 27 +++
In order to have this more consistent between the vc04 services move
the module information to the end of the file.
Signed-off-by: Stefan Wahren
Reviewed-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/bcm2835-camera/bcm2835-camera.c| 12 ++--
1 file changed, 6 insertions
As per default the GPU memory config of the Raspberry Pi isn't sufficient
for the camera usage. Even worse the bcm2835 camera driver doesn't provide a
helpful error message in this case. So let's add a hint to point the user
to the likely cause.
Signed-off-by: Stefan Wahren
Revie
In order to make the module bcm2835-camera load automatically, we need to
add a module alias.
Fixes: 4bebb0312ea9 ("staging/bcm2835-camera: Set ourselves up as a platform
driver.")
Signed-off-by: Stefan Wahren
Reviewed-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_servic
Following Eric's commit 37b7b3087a2f ("staging/vc04_services: Register a
platform device for the camera driver.") this register the audio driver as
a platform device, too.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 ++
1
This patch series improves the load/unload of bcm2835 camera and audio
drivers.
Changes since RFC:
- rebase on current staging-next
- add Nicolas' reviewed-by
- address Dan Carpenter's comments about error handling of device registration
Stefan Wahren (10):
staging: bcm2835-camera: A
Move ad7606 ADC driver out of staging and into the mainline.
Signed-off-by: Stefan Popa
---
Changes in v2:
- Simplified the Kconfig menu.
- Added SPDX-License-Identifier.
- Ordered the includes alphabetically.
- Used a threaded interrupt.
- Replaced
10205&id=96ae327678eceabf455b11a88ba14ad540d4b046
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/staging/vc04_services?h=next-20210205&id=88753cc19f087abe0d39644b844e67a59cfb5a3d
Could you please try?
Best regards
Stefan
>
> I can consistently repr
Hi,
Am 28.03.21 um 07:58 schrieb Ryutaroh Matsumoto:
>> I think the root cause of this issue is that both vc4.ko and snd_bcm2835.ko
>> try to provide ALSA sinks to HDMI audio outputs from RPi.
>> Why do the two drivers provide the same functionality for the same device?
>> It seems nonsense.
>> Th
ixes: 4184da4f316a ("staging: vchiq: fix __user annotations")
>
> Signed-off-by: Phil Elwell
Tested-by: Stefan Wahren
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This patch replaces the license text at the top of ad7606 driver files
and instead adds SPDX GPL-2.0+ license identifier.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7606.c | 5 ++---
drivers/staging/iio/adc/ad7606.h | 3 +--
drivers/staging/iio/adc/ad7606_par.c | 5
The driver does not have a struct of_device_id table, but supported
devices are registered via Device Trees. This patch adds and OF device
ID table.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7606_par.c | 10 ++
drivers/staging/iio/adc/ad7606_spi.c | 10 ++
2 files
This patch replaces the use of wait_event_interruptible() with
wait_for_completion_timeout() when reading the result of a single
conversion. In this way, if the interrupt never occurs, the program will
not remain blocked.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7606.c | 14
Switch to devm version of request_irq, iio_triggered_buffer_setup,
iio_device_register. To avoid potential ordering issues in probe,
devm_add_action_or_reset() is used for the regulator_disable(). This
simplifies the code and decreases the chance of bugs.
Signed-off-by: Stefan Popa
---
drivers
The 'adi' vendor prefix needs to be added to conversion-start, range,
first-data and oversampling-ratio properties.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7606.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/adc/
There is no point in having three menu entries that can be selected
individually. Instead, the SPI and parallel interfaces should select
AD7606.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/Kconfig | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff
When looking for the available scale or oversampling ratio, it is better
to use the find_closest() macro. This simplifies the code and also does
not require an exact value to be entered from the user space.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7606.c | 58
BUSY
signal triggers the interrupt.
ad7606_trigger_handler() is used as bottom half of the poll function.
It reads data from the device and stores it in the internal buffer.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7606.c | 116 +--
drivers
This series attempts to clean up the driver according to the feedback
received during review and finally moves it out of staging.
Stefan Popa (11):
staging: iio: adc: ad7606: Simplify the Kconfing menu
staging: iio: adc: ad7606: Use SPDX identifier
staging: iio: adc: ad7606: Use wait-for
* Placed includes in alphabetical order
* Added brackets around num and mask through out for AD760X_CHANNEL
* Used single line comments where needed
* Removed extra lines and spaces
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7606.c | 27 ---
drivers
Move ad7606 ADC driver out of staging and into the mainline.
Signed-off-by: Stefan Popa
---
MAINTAINERS | 7 +
drivers/iio/adc/Kconfig | 28 ++
drivers/iio/adc/Makefile | 3 +
drivers/iio/adc/ad7606.c | 588
Document support for AD7606 Analog to Digital Converter.
Signed-off-by: Stefan Popa
Reviewed-by: Rob Herring
---
.../devicetree/bindings/iio/adc/adi,ad7606.txt | 65 ++
MAINTAINERS| 1 +
2 files changed, 66 insertions(+)
create
:
- Nothing changed.
Stefan Popa (6):
staging: iio: adc: ad7606: Simplify the Kconfing menu
staging: iio: adc: ad7606: Use SPDX identifier
staging: iio: adc: ad7606: Add support for threaded irq
staging: iio: adc: ad7606: Misc style fixes (no functional change)
staging: iio: adc: ad7606: Move
There is no point in having three menu entries that can be selected
individually. Instead, the SPI and parallel interfaces should select
AD7606.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/Kconfig | 27 ++-
1 file changed, 10 insertions(+), 17 deletions
* Placed includes in alphabetical order
* Added brackets around num and mask through out for AD760X_CHANNEL
* Used single line comments where needed
* Removed extra lines and spaces
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7606.c | 27 ---
drivers
BUSY
signal triggers the interrupt.
ad7606_trigger_handler() is used as bottom half of the poll function.
It reads data from the device and stores it in the internal buffer.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7606.c | 111 +--
drivers
Document support for AD7606 Analog to Digital Converter.
Signed-off-by: Stefan Popa
Reviewed-by: Rob Herring
---
.../devicetree/bindings/iio/adc/adi,ad7606.txt | 65 ++
MAINTAINERS| 1 +
2 files changed, 66 insertions(+)
create
This patch replaces the license text at the top of ad7606 driver files
and instead adds SPDX GPL-2.0 license identifier.
Signed-off-by: Stefan Popa
---
drivers/staging/iio/adc/ad7606.c | 5 ++---
drivers/staging/iio/adc/ad7606.h | 3 +--
drivers/staging/iio/adc/ad7606_par.c | 5
Move ad7606 ADC driver out of staging and into the mainline.
Signed-off-by: Stefan Popa
---
MAINTAINERS | 7 +
drivers/iio/adc/Kconfig | 27 ++
drivers/iio/adc/Makefile | 3 +
drivers/iio/adc/ad7606.c | 583
Hi Peter,
> Peter Robinson hat am 8. Januar 2019 um 08:21
> geschrieben:
>
>
> Hi Stefan,
>
> > This patch series improves the load/unload of bcm2835 camera and audio
> > drivers. It has been tested with Raspberry Pi 3 B and a camera module V1.
> >
> &g
Hi Peter,
> Peter Robinson hat am 8. Januar 2019 um 09:56
> geschrieben:
>
>
> Hi Stefan,
>
> > > > This patch series improves the load/unload of bcm2835 camera and audio
> > > > drivers. It has been tested with Raspberry Pi 3 B and a camera modul
Hi,
[add Arnd]
> Dave Stevenson hat am 8. Januar 2019 um 18:10
> geschrieben:
>
>
> Hi Peter
>
> On Tue, 8 Jan 2019 at 07:21, Peter Robinson wrote:
> >
> > Hi Stefan,
> >
> > > This patch series improves the load/unload of bcm2835 camera
> Peter Robinson hat am 10. Januar 2019 um 06:09
> geschrieben:
>
>
> Hi Stefan,
>
...
>
> I get difference results with 5.0-rc1 but neither of the above apps
> work either, will follow up based on the rest of the thread there.
>
My first step with Ra
Hi Peter,
> Peter Robinson hat am 10. Januar 2019 um 07:34
> geschrieben:
>
>
> > > Hi Stefan,
> > >
> > ...
> > >
> > > I get difference results with 5.0-rc1 but neither of the above apps
> > > work either, will follow up bas
code where the worker thread is being woken -
> remote_event_signal_local via request_poll - did not do so as it
> wasn't previously necessary, and since the armed flag was being
> cleared this lead to a deadlock.
>
> Fixes: 852b2876a8a8 ("staging: vchiq: rework remove_event handli
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Stefan Roese
Cc: Mark Brown
Cc: Greg Kroah-Hartman
Cc: NeilBrown
Cc: Sankalp Negi
Cc: Chuanhong Guo
Cc: John Crispin
---
v2:
- Changes are done to the driver in staging before moving it out of
hardcoded values for SPI_MASTER register access
as suggested by Neil Brown (in mt7621_spi_reset and mt7621_spi_prepare)
Signed-off-by: Stefan Roese
Cc: Mark Brown
Cc: Greg Kroah-Hartman
Cc: NeilBrown
Cc: Sankalp Negi
Cc: Chuanhong Guo
Cc: John Crispin
---
v2:
- Changes are done to the
On 01.02.19 10:03, Greg Kroah-Hartman wrote:
On Fri, Feb 01, 2019 at 09:57:12AM +0100, Stefan Roese wrote:
This patch cleans up some minor issues with this driver:
- Remove unnecessary header includes
- Sort header alphabetically
- Use correct comment style
- Add return code check on
This patch adds a return code check on device_reset() and removes the
compile warning.
Signed-off-by: Stefan Roese
Cc: Mark Brown
Cc: Greg Kroah-Hartman
Cc: NeilBrown
Cc: Sankalp Negi
Cc: Chuanhong Guo
Cc: John Crispin
---
v3:
- New patch, changes spilt into separate patches
drivers
Align macro definitions and add some empty lines to make the code better
readable.
Signed-off-by: Stefan Roese
Cc: Mark Brown
Cc: Greg Kroah-Hartman
Cc: NeilBrown
Cc: Sankalp Negi
Cc: Chuanhong Guo
Cc: John Crispin
---
v3:
- New patch, changes spilt into separate patches
drivers/staging
This patch removes the SPI_BPW_MASK definition as this is already
available in include/linux/spi/spi.h.
Signed-off-by: Stefan Roese
Cc: Mark Brown
Cc: Greg Kroah-Hartman
Cc: NeilBrown
Cc: Sankalp Negi
Cc: Chuanhong Guo
Cc: John Crispin
---
v3:
- New patch, changes spilt into separate
This patch sorts the SPI register definitions by increasing addresses.
Signed-off-by: Stefan Roese
Cc: Mark Brown
Cc: Greg Kroah-Hartman
Cc: NeilBrown
Cc: Sankalp Negi
Cc: Chuanhong Guo
Cc: John Crispin
---
v3:
- New patch, changes spilt into separate patches
drivers/staging/mt7621-spi
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Stefan Roese
Cc: Mark Brown
Cc: Greg Kroah-Hartman
Cc: NeilBrown
Cc: Sankalp Negi
Cc: Chuanhong Guo
Cc: John Crispin
---
v3:
- No change
v2:
- Changes are done to the driver in staging before
This patch removes unnecessary header includes and sorts the remaining
ones alphabetically.
Signed-off-by: Stefan Roese
Cc: Mark Brown
Cc: Greg Kroah-Hartman
Cc: NeilBrown
Cc: Sankalp Negi
Cc: Chuanhong Guo
Cc: John Crispin
---
v3:
- New patch, changes spilt into separate patches
drivers
This patch changes some comments to use the recommended multi-line
comment style.
Signed-off-by: Stefan Roese
Cc: Mark Brown
Cc: Greg Kroah-Hartman
Cc: NeilBrown
Cc: Sankalp Negi
Cc: Chuanhong Guo
Cc: John Crispin
---
v3:
- New patch, changes spilt into separate patches
drivers/staging
This patch removes the superfluous pre-declaration of struct mt7621_spi.
Signed-off-by: Stefan Roese
Cc: Mark Brown
Cc: Greg Kroah-Hartman
Cc: NeilBrown
Cc: Sankalp Negi
Cc: Chuanhong Guo
Cc: John Crispin
---
v3:
- New patch, changes spilt into separate patches
drivers/staging/mt7621-spi
1 - 100 of 460 matches
Mail list logo
