Fixed alignment so that it matched open paranthesis.
Signed-off-by: srishti sharma
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
b/drivers/staging
Fixed alignment so that it matched open parenthesis.
Signed-off-by: srishti sharma
---
.../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
b
On Thu, Jun 15, 2017 at 12:29 AM, Joe Perches wrote:
> On Wed, 2017-06-14 at 19:36 +0530, srishti sharma wrote:
>> Fixed alignment so that it matched open paranthesis.
>
> Please try to avoid typos in your commit message and as
> well try to do all of alignment warnings
On Fri, Jun 23, 2017 at 9:50 PM, Greg KH wrote:
> On Thu, Jun 15, 2017 at 01:04:55AM +0530, srishti sharma wrote:
>> Fixed alignment so that it matched open parenthesis.
>>
>> Signed-off-by: srishti sharma
>> ---
>> .../staging/vc04_services/
Fixed alignment so that it matched open parenthesis.
Signed-off-by: srishti sharma
---
Changes in v2:
-Fix all checks of the type "alignment should match open parenthesis" for a
file in the same patch.
.../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 18 +---
On Sat, Jun 24, 2017 at 8:11 AM, srishti sharma wrote:
> On Fri, Jun 23, 2017 at 9:50 PM, Greg KH wrote:
>> On Thu, Jun 15, 2017 at 01:04:55AM +0530, srishti sharma wrote:
>>> Fixed alignment so that it matched open parenthesis.
>>>
>>> Signed-off-by: sris
Fixed alignment so that it matched open parenthesis.
Signed-off-by: Srishti Sharma
---
Changes in v2:
-Fix all checks of the type "alignment should match open parenthesis" for a
file in the same patch.
.../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 18 +---
On Sun, Jun 25, 2017 at 8:01 PM, Greg KH wrote:
> On Sat, Jun 24, 2017 at 08:58:10AM +0530, srishti sharma wrote:
>> Fixed alignment so that it matched open parenthesis.
>>
>> Signed-off-by: srishti sharma
>
> Does your legal name not have capital letters? Please fi
Fixed alignment so that it matched open parenthesis
Signed-off-by: Srishti Sharma
---
drivers/staging/greybus/vibrator.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/vibrator.c
b/drivers/staging/greybus/vibrator.c
index 77a2365..5cd8a50
Fixed a check reported by checkpatch.pl to avoid multiple assignments in a
single statement.
Signed-off-by: Srishti Sharma
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
b
On Sun, Aug 20, 2017 at 5:37 AM, Greg KH wrote:
> On Sun, Aug 20, 2017 at 04:01:25AM +0530, Srishti Sharma wrote:
>> Fixed a check reported by checkpatch.pl to avoid multiple assignments in a
>> single statement.
>
> Always wrap your changelog text at 72 columns please.
Fixed alignment so that it matched open parenthesis
Signed-off-by: Srishti Sharma
---
drivers/staging/fsl-dpaa2/ethernet/dpni.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpni.c
b/drivers/staging/fsl-dpaa2/ethernet/dpni.c
index
Fixed warning produced by checkpatch.pl to remove unecessary parentheses
Signed-off-by: Srishti Sharma
---
drivers/staging/xgifb/vb_setmode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index
Correct spelling of counter in comment .
Signed-off-by: Srishti Sharma
---
drivers/staging/ccree/ssi_cipher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c
b/drivers/staging/ccree/ssi_cipher.c
index 8d31a93..99232b2 100644
--- a/drivers
Edited comment to make it more comprehensible.
Signed-off-by: Srishti Sharma
---
Changes in v2:
- Make comment more comprehensible , instead of just correcting typos.
drivers/staging/ccree/ssi_cipher.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree
On Thu, Sep 7, 2017 at 2:28 AM, Julia Lawall wrote:
>
>
> On Thu, 7 Sep 2017, Srishti Sharma wrote:
>
>> Edited comment to make it more comprehensible.
>>
>> Signed-off-by: Srishti Sharma
>> ---
>> Changes in v2:
>> - Make comment more c
On Thu, Sep 7, 2017 at 2:29 AM, Dan Carpenter wrote:
> On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote:
>> Correct spelling of counter in comment .
>>
>> Signed-off-by: Srishti Sharma
>> ---
>> drivers/staging/ccree/ssi_cipher.c | 2 +-
>
Remove local variable inflight_counter ,as it is never used.
Signed-off-by: Srishti Sharma
---
Changes in v3:
- There was no longer a need to make the comment more comprehensible as
I have deleted the variable associated with it because it is unused .
drivers/staging/ccree/ssi_cipher.c | 5
On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall wrote:
>
>
> On Thu, 7 Sep 2017, Srishti Sharma wrote:
>
>> Remove local variable inflight_counter ,as it is never used.
>
> "counter ,as" -> "counter, as"
>
>> Signed-off-by: Srishti Sharma
>
On Thu, Sep 7, 2017 at 2:56 AM, Julia Lawall wrote:
>
>
> On Thu, 7 Sep 2017, Srishti Sharma wrote:
>
>> On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall wrote:
>> >
>> >
>> > On Thu, 7 Sep 2017, Srishti Sharma wrote:
>> >
>> &g
On Thu, Sep 7, 2017 at 3:02 AM, Dan Carpenter wrote:
> Always compile your patches.
>
> CC [M] drivers/staging/ccree/ssi_cipher.o
> drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
> drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable
> ‘inflight_counter
Remove local variable inflight_counter, as it is never used.
Signed-off-by: Srishti Sharma
---
Change in v4:
-There is no longer a need to make the comment more comprehensible, as I
have deleted the variable associated with it. The v3 of this patch was
not based on the original patch, hence
possible to guess correctly. However, one does not generally include the
> extension on a filename.
>
Yes, they have not used the filename in the subject line . So I'll change it to
the required format .
Thanks ,
Srishti
> julia
>
> On Thu, 7 Sep 2017, Srishti Sharma w
Remove the local variable inflight_counter as it is never used.
Signed-off-by: Srishti Sharma
---
Changes in v5:
- Correct the format of the subject.
drivers/staging/ccree/ssi_cipher.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c
b/drivers/staging
On Thu, Sep 7, 2017 at 2:20 PM, Gilad Ben-Yossef wrote:
> Hi,
>
> On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma wrote:
>> Remove the local variable inflight_counter as it is never used.
>>
>> Signed-off-by: Srishti Sharma
>> ---
>
> I've been meani
Use BIT(x) instead of (1<
---
drivers/staging/ccree/ssi_cipher.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h
b/drivers/staging/ccree/ssi_cipher.h
index 296b375..6fbcf9d 100644
--- a/drivers/staging/ccree/ssi_cipher.h
+++ b/driv
Use BIT(x) instead of using (1<
---
Changes in v2:
- Add tab spaces before BIT macro.
drivers/staging/ccree/ssi_cipher.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h
b/drivers/staging/ccree/ssi_cipher.h
index 296b375..c9a83df
Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
Signed-off-by: Srishti Sharma
---
drivers/staging/media/omap4iss/iss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss.c
b/drivers/staging/media/omap4iss/iss.c
index c26c99fd
On Fri, Sep 8, 2017 at 7:40 PM, Julia Lawall wrote:
>
>
> On Fri, 8 Sep 2017, Srishti Sharma wrote:
>
>> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
>>
>> Signed-off-by: Srishti Sharma
>> ---
>> drivers/staging/media/omap4iss/is
On Fri, Sep 8, 2017 at 8:08 PM, Dan Carpenter wrote:
> On Fri, Sep 08, 2017 at 07:38:18PM +0530, Srishti Sharma wrote:
>> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
>>
>> Signed-off-by: Srishti Sharma
>> ---
>> drivers/staging/media/omap4is
Use BIT(x) instead of (1<
---
drivers/staging/media/imx/imx-media.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media.h
b/drivers/staging/media/imx/imx-media.h
index d409170..e5b8d29 100644
--- a/drivers/staging/media/imx/imx-
On Fri, Sep 8, 2017 at 8:59 PM, Sean Paul wrote:
> On Fri, Sep 8, 2017 at 11:11 AM, Srishti Sharma wrote:
>> Use BIT(x) instead of (1<>
>> Signed-off-by: Srishti Sharma
>> ---
>> drivers/staging/media/imx/imx-media.h | 16
>> 1 fil
Return the return value of a function directly, instead of first saving it in a
variable and then returning it. This change was made using the following
semantic patch by coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
On Sat, Sep 9, 2017 at 1:42 AM, Julia Lawall wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Return the return value of a function directly, instead of first saving it
>> in a variable and then returning it. This change was made using the following
>
&
Merge the assignment and return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
Changes in v2:
- Edit commit message so that it respects the 80 character limit
On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Merge the assignment and return statements to return the value
>> directly. Done using coccinelle.
>>
>> @@
>> local idexpression ret;
>> expre
Merge the assignment and return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
Changes in v3:
-Edit commit message so that it respects 80 character limit
On Sat, Sep 9, 2017 at 12:27 PM, Julia Lawall wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall wrote:
>> >
>> >
>> > On Sat, 9 Sep 2017, Srishti Sharma wrote:
>> >
>> >&
Merge the assignment and the return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
Changes in v4:
-Edit commit message so that it respects 80 character limit
On Sat, Sep 9, 2017 at 12:26 PM, Julia Lawall wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Merge the assignment and return statements to return the value
>> directly. Done using coccinelle.
>>
>> @@
>> local idexpression ret;
>> expre
Merge the assignment and return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
drivers/staging/ccree/ssi_sysfs.c | 4 +---
1 file changed, 1 insertion(+), 3
Merge the assignment and return statements to return the value
directly. Done using the following semantic patch by
coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
Changes in v2:
-Correct coding style problems
On Sat, Sep 9, 2017 at 10:29 PM, Julia Lawall wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Merge the assignment and return statements to return the value
>> directly. Done using coccinelle.
>
> Coccinelle is not always perfect about pretty printing,
Fix alignment so that it matches open parentheses.
Signed-off-by: Srishti Sharma
---
drivers/staging/xgifb/XGI_main_26.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index b450c74..b813f1d
101 - 144 of 144 matches
Mail list logo
