[PATCH] staging: rtl8192u: Adding space around '='

This patch fixes the checkpatch issue by adding space around '='. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

[PATCH] staging: rtl8192u: Adding space around '='

This patch fixes the checkpatch issue by adding space around '='. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_so

[PATCH] staging: rtl8192u: Adding space after ','

This patch fixes the checkpatch issue by adding space after ','. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

[PATCH] staging: rtl8192u: Adding a blank line after declarations

This patch fixes the checkpatch warning by adding a blank line after declarations. WARNING: Missing a blank line after declarations Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers

[PATCH] staging: rtl8192u: Adding a blank line after declarations

This patch fixes the checkpatch warning by adding a blank line after declarations. WARNING: Missing a blank line after declarations Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers

[PATCH] staging: rtl8192u: Adding a blank line after declarations

This patch fixes the checkpatch warning by adding a blank line after declarations. WARNING: Missing a blank line after declarations Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers

[PATCH] staging: rtl8192u: Removing multiple blank lines

This patch fixes the checkpatch warning by removing multiple blank lines. CHECK: Please don't use multiple blank lines Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/st

[PATCH] staging: rtl8192u: Removing unnecessary space after a cast

This patch fixes the checkpatch warning by removing unnecessary space after a cast. CHECK: No space is necessary after a cast Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH] staging: rtl8192u: Fixing multiple assignments

This patch modifies the assignments into single assignments. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c b/drivers

[PATCH] staging: rtl8192u: Clean up comparison to NULL

Checkpatch recommended changes. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c b/drivers/staging/rtl8192u/ieee80211

[PATCH] staging: rtl8192u: Fix braces {} style

This fixes all checkpatch form of this from the Lustre tree: CHECK: braces {} should be used on all arms of this statement Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] staging: rtl8192u: Remove useless function

This patch remove useless function ieee80211_ccmp_null. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211.h| 1 - drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 6 -- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 - 3

[PATCH] staging: rtl8192u: Replace explicit NULL comparisons with !

This patch replace explicit NULL comparison with ! or unmark operator to simplify code. Reported by checkpatch.pl for comparison to NULL could be written "!XXX" or "XXX". Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 12 ++-

[PATCH] staging: rtl8192u: Removing unnecessary space after a cast

This patch fixes the checkpatch issue: CHECK: No space is necessary after a cast Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c

[PATCH] staging: rtl8192u: Removing true and false comparison

Remove comparison to true and false in if statement. Problem found usingcheckpatch.pl. CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 4 ++-- 1 file changed, 2

Re: [PATCH] staging: rtl8192u: Removing multiple blank lines

Multiple patches ...? Can you please clarify what all patches you are including in "Multiple Patches". And the Order you should go for is the order in which I submitted them. On Sat, Feb 11, 2017 at 7:48 AM, SIMRAN SINGHAL wrote: > Multiple patches ...? > Can you please clarify

[PATCH] staging: rtl8192u: Fix brace placement

Fix brace placement errors caught by checkpatch.pl ERROR: that open brace { should be on the previous line Signed-off-by: simran singhal --- .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 90 -- 1 file changed, 30 insertions(+), 60 deletions(-) diff --git a/drivers

[PATCH] staging: rtl8192u: Fix RETURN_VOID warnings

Fix 'void function return statements are not generally useful' checkpatch.pl warnings. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c

[PATCH 01/15] staging: rtl8192u: Removing multiple blank lines

This patch fixes the checkpatch warning by removing multiple blank lines. CHECK: Please don't use multiple blank lines Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/st

[PATCH 02/15] staging: rtl8192u: Removing unnecessary space after a cast

This patch fixes the checkpatch warning by removing unnecessary space after a cast. CHECK: No space is necessary after a cast Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 03/15] staging: rtl8192u: Fixing multiple assignments

This patch modifies the assignments into single assignments. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c b/drivers

[PATCH 04/15] staging: rtl8192u: Clean up comparison to NULL

Checkpatch recommended changes. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c b/drivers/staging/rtl8192u/ieee80211

[PATCH 05/15] staging: rtl8192u: Fix braces {} style

This fixes all checkpatch form of this from the Lustre tree: CHECK: braces {} should be used on all arms of this statement Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 06/15] staging: rtl8192u: Remove useless function

This patch remove useless function ieee80211_ccmp_null. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211.h| 1 - drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 6 -- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 - 3

[PATCH 07/15] staging: rtl8192u: Replace explicit NULL comparisons with !

This patch replace explicit NULL comparison with ! or unmark operator to simplify code. Reported by checkpatch.pl for comparison to NULL could be written "!XXX" or "XXX". Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 12 ++-

[PATCH 08/15] staging: rtl8192u: Remove unnecessary space after a cast

This patch fixes the checkpatch issue: CHECK: No space is necessary after a cast Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c

[PATCH 09/15] staging: rtl8192u: Removing true and false comparison

Remove comparison to true and false in if statement. Problem found usingcheckpatch.pl. CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 4 ++-- 1 file changed, 2

[PATCH 10/15] staging: rtl8192u: Fix brace placement

Fix brace placement errors caught by checkpatch.pl ERROR: that open brace { should be on the previous line Signed-off-by: simran singhal --- .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 90 -- 1 file changed, 30 insertions(+), 60 deletions(-) diff --git a/drivers

[PATCH 11/15] staging: rtl8192u: Fix RETURN_VOID warnings

Fix 'void function return statements are not generally useful' checkpatch.pl warnings. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c

[PATCH 12/15] staging: rtl8192u: Fix warnings relating to printk()

This fixes the following checkpatch.pl warnings: WARNING: printk() should include KERN_ facility level Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 13/15] staging: rtl8192u: Prefer using the BIT macro

This patch replaces bit shifting on 1 with the BIT(x) macro as it's extensively used by other function in this driver. This was done with coccinelle: @@ int g; @@ -(1 << g) +BIT(g) Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80

[PATCH 14/15] staging: rtl8192u: Fixing no new typedef warning

This patch fixes following checkpatch.pl warnings: WARNING:do not add new typedefs. All the related files have been modified. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 ++-- .../staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 4

[PATCH 15/15] staging: rtl8192u: Removing unnecessary parentheses

Removing unnecessary parentheses from an expression of the form &(x). Issue found by checkpatch. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee8

[PATCH 1/20] staging: rtl8192u: Replace symbolic permissions with octal permissions

WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. This warning is detected by checkpatch.pl Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 inse

[PATCH 2/20] staging: rtl8192u: Fixed 'tabstop' coding style warnings

Fixed checkpatch warning "Statements should start on a tabstop" in rtl8192u module. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee802

[PATCH 3/20] staging: rtl8192u: Prefer using the BIT macro

Fix the checkpatch.pl issue: CHECK: Prefer using the BIT macro replacing bit shifting on 1 with the BIT(x) macro. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140 - 1 file changed, 70 insertions(+), 70 deletions(-) diff --git a

Re: [Outreachy kernel] Re: [PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

On Tue, Mar 6, 2018 at 2:33 AM, Julia Lawall wrote: > > > On Mon, 5 Mar 2018, Arushi Singhal wrote: > >> >> >> On Mon, Mar 5, 2018 at 3:33 PM, Dan Carpenter >> wrote: >> On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote: >> > Replace printk having a log level with the ap

<    1   2   3   4