[PATCH] staging: wilc1000: Fixes Alignment should match open parenthesis

2017-04-22 Thread richard
From: Richard Miller This patch fixes the following checkpatch.pl check: CHECK: Alignment should match open parenthesis Signed-off-by: Richard Miller --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 8 drivers/staging

[PATCH] staging: lustre: include/lustre_net.h: Remove unnecessary space before function pointer arguments.

2016-09-14 Thread Richard
Greetings Linux Kernel Developers, This is Task 10 of the Eudyptula Challenge. I fix few minor warnings spotted by checkpatch.pl in lustre Signed-off-by: Richard --- drivers/staging/lustre/lustre/include/lustre_net.h | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions

Re: [PATCH 1/2] net: dpaa2: move DPAA2 PTP driver out of staging/

2018-09-28 Thread Richard Cochran
On Fri, Sep 28, 2018 at 10:20:55AM +, Ioana Ciocoi Radulescu wrote: > Generally speaking, I think it's better to remove unused code from the current > driver and re-add it along with the feature actually using it. +1 Thanks, Richard __

[no subject]

2021-10-27 Thread Mophie Richard
-- Greetings to you, my name is Albert Jonathan, I have a very urgent beneficial proposal deal that will be of great benefit to you. If interested, kindly reply to me back. I await your response. Best Regards Albert Jonathan ___ devel mailing list de..

Re: [PATCH] arch: um: convert tasklets to use new tasklet_setup() API

2020-10-18 Thread Richard Weinberger
xplicitly. > > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais > --- > arch/um/drivers/vector_kern.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Anton, can you please review this patch? -- Thanks, //richard __

Re: [PATCH] erofs: move erofs out of staging

2019-08-17 Thread Richard Weinberger
ot; , "Stephen Rothwell" > , "tytso" , > "Pavel Machek" , "David Sterba" , "Amir > Goldstein" , "Christoph > Hellwig" , "Darrick J . Wong" , > "Dave Chinner" , > "Jaegeuk Kim" , "Jan Kara&

Re: [PATCH] erofs: move erofs out of staging

2019-08-17 Thread Richard Weinberger
to loop forever around erofs_read_raw_page(). Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Richard Weinberger
k it can be fixed easily later. This is no excuse to redo all these bugs. :-) I know that many in-kernel filesystems trust the disk ultimately, this is a problem and huge attack vector. Thanks, //richard ___ devel mailing list de...@linuxdriverprojec

Re: [PATCH v3 RESEND] staging: erofs: fix an error handling in erofs_readdir()

2019-08-18 Thread Richard Weinberger
- Ursprüngliche Mail - > changelog from v2: > - transform EIO to EFSCORRUPTED as suggested by Matthew; erofs does not define EFSCORRUPTED, so the build fails. At least on Linus' tree as of today. Thanks, //richard ___ devel mail

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Richard Weinberger
n superblock_read(): memcpy(sbi->volume_name, layout->volume_name, sizeof(layout->volume_name)); Where do you check whether ->volume_name has a NUL terminator? Currently this field has no user, maybe will add a check upon usage. But this kind of things makes

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Richard Weinberger
//github.com/openSUSE/suse-module-tools/blob/master/suse-module-tools.spec#L24 Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Richard Weinberger
- Ursprüngliche Mail - > So holding a file system like EROFS to a higher standard than say, > ext4, xfs, or btrfs hardly seems fair. Nobody claimed that. Thanks, //richard ___ devel mailing list de...@linuxdriverproject.or

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "tytso" > An: "richard" > CC: "Greg Kroah-Hartman" , "Gao Xiang" > , "Jan Kara" , "Chao > Yu" , "Dave Chinner" , "David > Sterba" , "Miao Xie" &g

Re: [PATCH] erofs: move erofs out of staging

2019-08-19 Thread Richard Weinberger
en dirs and the following script. > Does it look reasonable? I think that's a very good start. :-) Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] erofs: move erofs out of staging

2019-08-19 Thread Richard Weinberger
the ondisk data structure > and there is absolutely no priority to do so. Which is very different > from there is a bug or two here and there. On the plus side, everything I reported got fixed within hours. Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Drivers:staging:speakup: Fixed checkpatch warning

2014-11-26 Thread Richard Weinberger
(u_char)val; NACK. Please test your patch or at least read the function signature kstrtoul(). -- Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-15 Thread Richard Weinberger
this version I don't understand this kind of logic. a) Binder is considered a piece of shite. b) Google is working on a (hopefully sane) replacement. Why moving it out of staging then? What is the benefit? Keep it there for more 2-3 years and then remove it. If you move it now out of stagi

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-15 Thread Richard Weinberger
Am 15.12.2014 um 19:30 schrieb Greg KH: > On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote: >> On Mon, Dec 15, 2014 at 6:55 PM, Greg KH wrote: >>> The following changes since commit 009d0431c3914de64666bec0d350e54fdd59df6a: >>> >>> Linux

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-15 Thread Richard Weinberger
Am 15.12.2014 um 19:44 schrieb Greg KH: > On Mon, Dec 15, 2014 at 07:36:00PM +0100, Richard Weinberger wrote: >> >> Am 15.12.2014 um 19:30 schrieb Greg KH: >>> On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote: >>>> On Mon, Dec 15, 2014 at 6:55

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-16 Thread Richard Weinberger
Am 15.12.2014 um 19:56 schrieb Greg KH: > On Mon, Dec 15, 2014 at 10:41:03AM -0800, Greg KH wrote: >> On Mon, Dec 15, 2014 at 10:39:15AM -0800, Christoph Hellwig wrote: >>> On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote: >>>> I don't un

Re: [PATCH 1/2] staging: fsl-dpaa2/rtc: add rtc driver

2018-04-20 Thread Richard Cochran
On Thu, Apr 19, 2018 at 01:40:08PM +0300, Dan Carpenter wrote: > This driver seems nice and so far as I can see it doesn't need to be in > staging once we get the other parts merged. Please explain how this unit ties in with the MAC units. Than

Re: [PATCH 1/2] staging: fsl-dpaa2/rtc: add rtc driver

2018-04-20 Thread Richard Cochran
On Sat, Apr 21, 2018 at 07:41:35AM +0300, Dan Carpenter wrote: > On Fri, Apr 20, 2018 at 02:01:25PM -0700, Richard Cochran wrote: > > On Thu, Apr 19, 2018 at 01:40:08PM +0300, Dan Carpenter wrote: > > > This driver seems nice and so far as I can see it doesn't need to be i

Re: [PATCH 1/2] staging: fsl-dpaa2/rtc: add rtc driver

2018-04-22 Thread Richard Cochran
rivers/staging/fsl-dpaa2/rtc seems logical to me. Thanks, Richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: fsl-dpaa2/eth: Add support for hardware timestamping

2018-04-25 Thread Richard Cochran
aven't implemented the ethtool_get_ts_info() method, but you need to do so. Show us how the user can related these MAC time stamps to the PHC device in your other patch series. Thanks, Richard ___ devel mailing list de...@linuxdriverproje

INVESTMENT

2018-06-18 Thread RICHARD LAWRENCE
Hello We are international business advisors operating with the European Community. At this moment, we have a mandate from one of our international client seeking offshore investment in any suitable country with flexible tax laws. If you are interested, kindly contact us for more information on

[PATCH] staging: unisys: Disable driver for UML

2015-05-04 Thread Richard Weinberger
ap’ [-Werror=implicit-function-declaration] iounmap(addr); Signed-off-by: Richard Weinberger --- drivers/staging/unisys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/Kconfig b/drivers/staging/unisys/Kconfig index 19fcb34..a6d6c2a 100644

Re: [PATCH] staging: unisys: Disable driver for UML

2015-05-10 Thread Richard Weinberger
Am 10.05.2015 um 15:02 schrieb Greg KH: > On Mon, May 04, 2015 at 09:02:10PM +0200, Richard Weinberger wrote: >> UML has no io memory nor cpuid. >> Let's disable this driver for UML. > > Doesn't apply to my tree :( I'm sorry Greg, looks like my -next t

Re: [PATCH 6/6] MAINTAINERS: maintain parport

2015-05-20 Thread Richard Weinberger
I miss something? -- Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 6/6] MAINTAINERS: maintain parport

2015-05-20 Thread Richard Weinberger
Am 20.05.2015 um 18:33 schrieb One Thousand Gnomes: > On Wed, 20 May 2015 17:46:44 +0200 > Richard Weinberger wrote: > >> On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee >> wrote: >>> Lets give the parport subsystem a proper name and start >>> main

[PATCH 20/28] Remove OMAP_PM_SRF

2014-02-09 Thread Richard Weinberger
The symbol is an orphan, get rid of it. Signed-off-by: Richard Weinberger --- drivers/staging/tidspbridge/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/tidspbridge/Kconfig b/drivers/staging/tidspbridge/Kconfig index 1b6d581..b5e74e9 100644 --- a

Re: [PATCH 20/28] Remove OMAP_PM_SRF

2014-02-09 Thread Richard Weinberger
Am 09.02.2014 20:55, schrieb Paul Bolle: > On Sun, 2014-02-09 at 19:47 +0100, Richard Weinberger wrote: >> The symbol is an orphan, get rid of it. >> >> Signed-off-by: Richard Weinberger >> --- >> drivers/staging/tidspbridge/Kconfig | 2 +- >> 1 f

[PATCH] staging/xillybus: Handle OOM in xillybus_init()

2014-03-18 Thread Richard Weinberger
alloc_workqueue() can fail and returns NULL in case of OOM. Handle this case and undo class_create(). Signed-off-by: Richard Weinberger --- drivers/staging/xillybus/xillybus_core.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/xillybus/xillybus_core.c

[PATCH] staging/rtl8821ae: Fix OOM handling in _rtl_init_deferred_work()

2014-03-20 Thread Richard Weinberger
alloc_workqueue() can fail, handle this case. Signed-off-by: Richard Weinberger --- drivers/staging/rtl8821ae/base.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8821ae/base.c b/drivers/staging/rtl8821ae/base.c index fce9c3f..8dbe13c 100644

[PATCH] staging: comedi: adl_pci9118: fix whitespace issues

2014-04-09 Thread Richard Leitner
Removed not needed spaces and fixed too long lines PS: this is an exercise to get into the "patch submitting workflow" Signed-off-by: Richard Leitner --- drivers/staging/comedi/drivers/adl_pci9118.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH] staging: comedi: adl_pci9118: fix whitespace issues

2014-04-09 Thread Richard Leitner
Removed not needed spaces and fixed too long lines Signed-off-by: Richard Leitner --- drivers/staging/comedi/drivers/adl_pci9118.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118

[PATCH] staging: android: ion: Align with open parenthesis

2017-05-03 Thread Richard Porter
Fix checkpatch.pl warning: CHECK: Alignment should match open parenthesis + fd = ion_alloc(data.allocation.len, + data.allocation.heap_id_mask, Signed-off-by: Richard Porter --- drivers/staging/android/ion/ion-ioctl.c | 4 ++-- 1 file

[PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs

2016-01-25 Thread Richard Weinberger
Not every arch has io memory. So, unbreak the build by fixing the dependencies. Signed-off-by: Richard Weinberger --- drivers/staging/iio/adc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig index 58d4517..b9519be

Re: [PATCH RFC] hv_utils: implement Hyper-V PTP source

2017-01-13 Thread Richard Cochran
ers/ptp/ptp_clock.c calls .adjfreq (or adjfine) .adjtime .settime64 unconditionally, so you need to implement these returning EOPNOTSUPP. (See also Documentation/ptp/ptp.txt) > + .owner = THIS_MODULE, > +}; Thanks, Richard ___

Re: checkpatch induced patches...

2015-02-11 Thread Richard Weinberger
ok. > >> o Make --strict the default for drivers/staging > > Ack. FYI: We had already a heated debate on that topic. https://lkml.org/lkml/2014/7/17/415 -- Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: checkpatch induced patches...

2015-02-11 Thread Richard Weinberger
with patches > that aren't really a cleanup but are just done to make checkpatch happy. > > I guess documenting --force is better than not documenting. Documentation is like sex: when it is good, it is very, very good; and when it is bad, it is better than nothing. -- Dick Brandon

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-03-28 Thread Richard Weinberger
(void); > - const char *(*synth_immediate)(struct spk_synth *synth, const char > *buff); > + const char *(*synth_immediate)(struct spk_synth *synth, > + const char *buff); > void (*catch_up)(struct spk_synth *synth); > void (*flush)(struct spk_synth *synth); > int (*is_alive)(struct spk_synth *synth); > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-03-28 Thread Richard Weinberger
Am 28.03.2015 um 22:18 schrieb Joe Perches: > On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote: >> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera >> wrote: >>> This patch fixes the checkpatch.pl warning: > > [] > >>> diff --git a/driver

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-03-28 Thread Richard Weinberger
Am 29.03.2015 um 00:44 schrieb Shirish Gajera: > On Sat, Mar 28, 2015 at 02:35:19PM -0700, Joe Perches wrote: >> On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote: >>> Am 28.03.2015 um 22:18 schrieb Joe Perches: >>>> On Sat, 2015-03-28 at 21:40 +0100, Rich

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-03-29 Thread Richard Weinberger
Am 29.03.2015 um 01:26 schrieb Shirish Gajera: > Are you sure you want me to do this changes. Because it will conflict > the things written on http://kernelnewbies.org/ Conflict with what? Thanks, //richard ___ devel mailing l

Re: [PATCH] staging: dgnc: Let line have less 80 char

2016-09-01 Thread Richard Weinberger
* if the terminal unit is NOT open > +*/ Adding random new lines make the comment not better. I'm not saying checkpatch.pl is completely useless, stuff in drivers/staging/ often needs to be adopted to the kernel coding style. But please don't follow it blin

Re: [PATCH V2] staging: lustre: include/lustre_net.h: Remove unnecessary space before function pointer arguments.

2016-09-15 Thread Richard Groux
Minor warnings spotted by checkpatch.pl in lustre Remove unnecessary space before function pointer arguments. Signed-off-by: Richard Groux --- drivers/staging/lustre/lustre/include/lustre_net.h | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers

[PATCH] staging: lustre: include/lustre_net.h: Remove unnecessary space before function pointer arguments.

2016-09-16 Thread Richard Groux
Minor warnings spotted by checkpatch.pl in lustre Remove unnecessary space before function pointer arguments. Signed-off-by: Richard Groux --- drivers/staging/lustre/lustre/include/lustre_net.h | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers

[PATCH 0/2] staging: greybus: audio_codec.c: minor error spotted by checkpatch.pl

2016-09-21 Thread Richard Groux
This patchset removes few error spotted by checkpatch.pl Richard Groux (2): staging: greybus: audio_codec.c: space required before the open brace staging: greybus: audio_codec.c: code indent should use tabs where possible drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file

[PATCH 1/2] staging: greybus: audio_codec.c: space required before the open brace

2016-09-21 Thread Richard Groux
Minor error spotted by checkpatch.pl in greybus space required before the open brace '{' Signed-off-by: Richard Groux --- drivers/staging/greybus/audio_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/stagi

[PATCH 2/2] staging: greybus: audio_codec.c: code indent should use tabs where possible

2016-09-21 Thread Richard Groux
Minor error spotted by checkpatch.pl in greybus code indent should use tabs where possible Signed-off-by: Richard Groux --- drivers/staging/greybus/audio_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus

[PATCH 2/2] staging: greybus: audio_codec.c: code indent should use tabs where possible

2016-09-21 Thread Richard Groux
Minor error spotted by checkpatch.pl in greybus code indent should use tabs where possible Signed-off-by: Richard Groux --- drivers/staging/greybus/audio_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus

[PATCH 1/2] staging: greybus: audio_codec.c: space required before the open brace

2016-09-21 Thread Richard Groux
Minor error spotted by checkpatch.pl in greybus space required before the open brace '{' Signed-off-by: Richard Groux --- drivers/staging/greybus/audio_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/stagi

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-27 Thread Richard Weinberger
we'll have a > real mess on our hands. Sorry for digging up this old thread. While talking with some guys about usermodehelper abuses I came across this gem. Mainline still contains that "/etc/init.d/network restart" code. Haiyang, care to cleanup? -- Tha

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-30 Thread Richard Weinberger
Am 30.10.2015 um 23:03 schrieb Haiyang Zhang: > > >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Friday, October 30, 2015 6:56 AM >> To: Haiyang Zhang >> Cc: Richard Weinberger ; David Miller >> ; o...

Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special

2013-09-28 Thread Richard Weinberger
_aligned_in_smp; > > +static int cvm_irq_cpu = -1; Why are you introducing a new global variable here? Can't you pass cvm_irq_cpu as argument to cvm_oct_enable_napi()? Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special

2013-09-28 Thread Richard Weinberger
terrupts end up being handled by other than CPU > 0. The patch fixes that. You are right, sorry. I somehow mixed up the function names. Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/m

[PATCH 3/7] staging,spear_adc: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
-function-declaration Signed-off-by: Richard Weinberger --- drivers/staging/iio/adc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig index e3d6430..7d5d675 100644 --- a/drivers/staging/iio/adc/Kconfig +++ b/drivers/staging

[PATCH 4/7] phy,exynos: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `exynos_mipi_video_phy_probe': drivers/phy/phy-exynos-mipi-video.c:130: undefined reference to `devm_ioremap_resource' Signed-off-b

[PATCH 1/7] ptp_pch: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
/ptp_pch.c: In function ‘pch_probe’: drivers/ptp/ptp_pch.c:621:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] Signed-off-by: Richard Weinberger --- drivers/ptp/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ptp/Kconfig b/drivers/ptp

[PATCH 2/7] staging,dgap: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
-function-declaration] drivers/staging/dgap/dgap_driver.c: In function ‘dgap_do_remap’: drivers/staging/dgap/dgap_driver.c:694:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] Signed-off-by: Richard Weinberger --- drivers/staging/dgap/Kconfig | 2 +- 1

[PATCH 5/7] net,marvell: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `orion_mdio_probe': drivers/net/ethernet/marvell/mvmdio.c:228: undefined reference to `devm_ioremap' Signed-off-by: Richard Weinberger --

[PATCH 6/7] power,goldfish: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `goldfish_battery_probe': drivers/power/goldfish_battery.c:181: undefined reference to `devm_ioremap' Signed-off-by: Richard Weinberger --

[PATCH 7/7] staging,lpc32xx_adc: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `lpc32xx_adc_probe': drivers/staging/iio/adc/lpc32xx_adc.c:149: undefined reference to `devm_ioremap' Signed-off-by: Richard Weinberger --

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-07 Thread Richard Weinberger
Am 07.10.2014 07:28, schrieb Guenter Roeck: > arch/um/kernel/reboot.c| 2 -- Acked-by: Richard Weinberger Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listi

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
nel module, the sychronization is never expected to be better than one millisecond. That is not too good. I expect NTP can do better. So what was the point of this change again? Thanks, Richard ___ devel mailing list de...@linuxdriverproject.org ht

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
no apparent reason. >From the guest's point of view, this is really not acceptable. Thanks, Richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
rmore, without networking you really don't have a compelling need for correct absolute time in the first place. Thanks, Richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
time for RTP and other time > sensitive stuff . you will have to have to re-implement parts of NTP > such as adjusting the clock frequency decreasing the check period when > error becomes too great etc. etc.. No, lets not re-implement NTP. That would be

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
Maybe John Stultz should also go onto CC. Thanks, Richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
the guest steer its own clock. That gives the end user the most flexibility. Just provide the offset information, and let a dedicated service (like ntpd or linuxptp's phc2sys) do the rest. Thanks, Richard ___ devel mailing list de...@linuxdriver

Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-14 Thread Richard Cochran
On Tue, Oct 14, 2014 at 04:33:46PM +0200, Richard Cochran wrote: > > IMHO, you should let the guest steer its own clock. That gives the end > user the most flexibility. Just provide the offset information, and > let a dedicated service (like ntpd or linuxptp's phc2sys) do th

Re: [PATCH v2 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-15 Thread Richard Cochran
You really need to put John Stultz onto CC. Thanks, Richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-15 Thread Richard Cochran
gt; --- Um, what changed in V2? Thanks, Richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 2/2] hyperv: Implement Time Synchronization using host time sample

2014-10-15 Thread Richard Cochran
On Wed, Oct 15, 2014 at 09:21:33AM +, Thomas Shao wrote: > > In V2, I address all the Dan's comments. It is customary to detail the changes in each patch series revision, in order to make things easier for the reviewers. Thanks, Richard __

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Richard Cochran
ise syncing the guest's clock is pointless.) > I've got some feedbacks from Richard and Mike, including reference NTP > implementation > and do the adjustment in the host side. I've already referenced some NTP > design in > my patch. I would consider my patch as

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Richard Cochran
ient, then the host can provide a synthetic PPS, to be used by the kernel's hardpps logic. Thanks, Richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
(). Signed-off-by: Richard Weinberger --- drivers/net/hyperv/netvsc_drv.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 4fd71b7..367b71e 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 08.07.2014 20:01, schrieb KY Srinivasan: > > >> -Original Message----- >> From: Richard Weinberger [mailto:rich...@nod.at] >> Sent: Tuesday, July 8, 2014 2:32 AM >> To: KY Srinivasan; Haiyang Zhang >> Cc: de...@linuxdriverproject.org; n

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 08.07.2014 19:55, schrieb Haiyang Zhang: > > >> -Original Message----- >> From: Richard Weinberger [mailto:rich...@nod.at] >> Sent: Tuesday, July 8, 2014 5:32 AM >> To: KY Srinivasan; Haiyang Zhang >> Cc: de...@linuxdriverproject.org; n

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
allback by hand would be enough to receive SKBs. Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 09.07.2014 00:47, schrieb Francois Romieu: > Richard Weinberger : > [...] >> This won't work as netpoll runs with IRQs disabled. >> ->ndo_poll_controller() has to make sure that SKBs can be received and >> transmitted >> while IRQs are off. I thought call

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 09.07.2014 00:47, schrieb Francois Romieu: > Richard Weinberger : > [...] >> This won't work as netpoll runs with IRQs disabled. >> ->ndo_poll_controller() has to make sure that SKBs can be received and >> transmitted >> while IRQs are off. I thought call

[PATCH v2] hyperv: Add netpoll support

2014-07-09 Thread Richard Weinberger
In order to have at least a netconsole to debug kernel issues on Windows Azure this patch implements netpoll support. Sending packets is easy, netvsc_start_xmit() does already everything needed. Signed-off-by: Richard Weinberger --- drivers/net/hyperv/netvsc_drv.c | 11 +++ 1 file

Re: [PATCH] hyperv: Add netpoll support

2014-07-09 Thread Richard Weinberger
Am 09.07.2014 01:43, schrieb Francois Romieu: > Richard Weinberger : >> Am 09.07.2014 00:47, schrieb Francois Romieu: > [...] >>> What are you taking about ? netconsole does not need to receive. >> >> Isn't netconsole is only one user of netpoll ? >

Re: [PATCH v2] hyperv: Add netpoll support

2014-07-09 Thread Richard Weinberger
Am 09.07.2014 16:13, schrieb Sergei Shtylyov: > Hello. > > On 07/09/2014 11:58 AM, Richard Weinberger wrote: > >> In order to have at least a netconsole to debug kernel issues on >> Windows Azure this patch implements netpoll support. >> Sending packets is easy, ne

[PATCH v3] hyperv: Add netpoll support

2014-07-09 Thread Richard Weinberger
In order to have at least a netconsole to debug kernel issues on Windows Azure this patch implements netpoll support. Sending packets is easy, netvsc_start_xmit() does already everything needed. Signed-off-by: Richard Weinberger --- drivers/net/hyperv/netvsc_drv.c | 11 +++ 1 file

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-10 Thread Richard Weinberger
crash in a way that no disk IO is possible (thus, no SSH for me) but they still respond to ping. It happens rather seldom (every few weeks). Do you see similar symptoms? -- Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-12 Thread Richard Weinberger
On Thu, Jul 10, 2014 at 12:33 PM, Richard Weinberger wrote: > On Wed, Jul 9, 2014 at 8:51 PM, KY Srinivasan wrote: >> >> >>> -Original Message- >>> From: Christoph Hellwig [mailto:h...@infradead.org] >>> Sent: Wednesday, July 9, 2014 1:44

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Richard Weinberger
Am 13.07.2014 11:27, schrieb Lennox Wu: > As I said before, some configurations don't make sense. If such a configuration can be achieved using allmod/yesconfig it has to be fixed. Chen's fixes seem reasonable as not all architectures support iomem. Than

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Richard Weinberger
Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: > On 07/13/2014 11:45 AM, Richard Weinberger wrote: >> Am 13.07.2014 11:27, schrieb Lennox Wu: >>> As I said before, some configurations don't make sense. >> >> If such a configuration can be achieved using allm

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Richard Weinberger
Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: > On 07/13/2014 03:40 PM, Richard Weinberger wrote: >> Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: >>> On 07/13/2014 11:45 AM, Richard Weinberger wrote: >>>> Am 13.07.2014 11:27, schrieb Lennox Wu: >>>&

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Richard Weinberger
Am 13.07.2014 21:22, schrieb Greg Kroah-Hartman: > On Sun, Jul 13, 2014 at 04:25:06PM +0200, Lars-Peter Clausen wrote: >> On 07/13/2014 04:03 PM, Richard Weinberger wrote: >>> Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: >>>> On 07/13/2014 03:40 PM, Rich

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Richard Weinberger
Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: > On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote: >> Maybe we could add COMPILE_TEST to the version string too? >> Just to detect such kernels fast in user bug reports... > > What kind of bug report are yo

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Richard Weinberger
Am 14.07.2014 10:48, schrieb Lars-Peter Clausen: > On 07/14/2014 10:31 AM, Richard Weinberger wrote: >> Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: >>> On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote: >>>> Maybe we could add COMPILE_TEST to the

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Richard Weinberger
'. > > Note that s390 no has gained support for IOMEM, tile has it most > of the time (when PCI is enabled, so you get it in half the > test builds already), score should set HAS_IOMEM and doesn't > even have public compilers,

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Richard Weinberger
Am 17.07.2014 12:28, schrieb Arnd Bergmann: > On Thursday 17 July 2014 11:26:57 Richard Weinberger wrote: >> Am 17.07.2014 11:20, schrieb Arnd Bergmann: >>> On Thursday 17 July 2014 09:27:58 Chen Gang wrote: >>>> gfp_t gfp_

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Richard Weinberger
already. If UML is the only arch without io memory the dependency on !UML seems reasonable to me. :-) Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Richard Weinberger
Am 18.07.2014 02:36, schrieb Chen Gang: > > On 07/18/2014 02:09 AM, Richard Weinberger wrote: >> Am 17.07.2014 12:48, schrieb Arnd Bergmann: >>> AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take >>> a shortcut here and make COMPILE_TEST depend

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Richard Weinberger
Am 18.07.2014 12:44, schrieb Chen Gang: > On 07/18/2014 03:35 PM, Richard Weinberger wrote: >> Am 18.07.2014 02:36, schrieb Chen Gang: >>> >>> On 07/18/2014 02:09 AM, Richard Weinberger wrote: >>>> Am 17.07.2014 12:48, schrieb Arnd Bergmann: >>>&g

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-18 Thread Richard Weinberger
.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  1   2   >