Hi,
We have made progress on the items in TODO file of speakup driver in
staging directory and wanted to get some clarity on the remaining
items. Below is a summary of status of each item along with the quotes
from TODO file.
1. "The first issue has to do with the way speakup communicates
with se
Hi,
On Fri, 15 Mar 2019 18:19:39 -0700
Chris Brannon wrote:
> Okash Khawaja writes:
>
> > Finally there is an issue where text in output buffer sometimes gets
> > garbled on SMP systems, but we can continue working on it after the
> > driver is moved out of staging, i
On Fri, 15 Mar 2019 20:18:31 -0700
Greg Kroah-Hartman wrote:
> On Fri, Mar 15, 2019 at 01:01:27PM +0000, Okash Khawaja wrote:
> > Hi,
> >
> > We have made progress on the items in TODO file of speakup driver in
> > staging directory and wanted to get some clarity
On Tue, 19 Mar 2019 16:31:21 +
Alan Cox wrote:
> On Sat, 16 Mar 2019 10:35:43 +0100
> Samuel Thibault wrote:
>
> > Chris Brannon, le ven. 15 mars 2019 18:19:39 -0700, a ecrit:
> > > Okash Khawaja writes:
> > > > Finally there is an issue w
t EBUSY forever.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Tested-by: Gregory Nowak
---
drivers/staging/speakup/main.c | 1 +
drivers/staging/speakup/selection.c | 212 +++-
drivers/staging/speakup/speakup.h | 1 +
3 files changed, 88 insertions(+)
Hi,
Speakup's selection functionality parallels that of
drivers/tty/vt/selection.c. This patch set replaces speakup's
implementation with calls to vt's selection code. This is one of the
remaining items in our TODO file and it's needed for moving speakup out
of staging.
Please note that in speaku
ereby doing away with
parallel implementation.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Tested-by: Gregory Nowak
---
drivers/tty/vt/selection.c | 37 -
include/linux/selection.h | 3 +--
2 files changed, 25 insertions(+), 15 deletions(-)
On Thu, Jul 25, 2019 at 3:49 AM John Covici wrote:
>
> I think the program is genmap, I have it in my init sequence, but I
> am not sure it does anything at this point.
>
> On Thu, 25 Jul 2019 00:04:07 -0400,
> Chris Brannon wrote:
> >
> > Gregory Nowak writes:
> >
> > > keymap
> > > I believe t
step will be to convert the format to match Documentation/ABI/
requirements.
Thanks,
Okash
On Wed, Aug 21, 2019 at 11:23 PM Gregory Nowak wrote:
>
> On Wed, Aug 21, 2019 at 09:39:25AM -0700, Okash Khawaja wrote:
> > Hi Greg N,
> >
> > Would like to send this as a patch a
On Mon, Sep 9, 2019 at 3:55 AM Gregory Nowak wrote:
>
> On Sun, Sep 08, 2019 at 10:43:02AM +0100, Okash Khawaja wrote:
> > Sorry, I have only now got round to working on this. It's not complete
> > yet but I have assimilated the feedback and converted subjective
>
On Sun, Sep 15, 2019 at 2:43 PM Greg Kroah-Hartman
wrote:
>
> On Sat, Sep 14, 2019 at 10:08:35PM +0100, Okash Khawaja wrote:
> > On Mon, Sep 9, 2019 at 3:55 AM Gregory Nowak wrote:
> > >
> > > On Sun, Sep 08, 2019 at 10:43:02AM +0100, Okash Khawaja wrote:
> >
Ah it looks like the spaces after Description: need to be converted into tabs.
Thanks,
Okash
On Tue, Sep 17, 2019 at 10:35 PM Okash Khawaja wrote:
>
> Hi Greg,
>
> You're right, I got none of those emails. Thanks. Is it all taken care of?
>
> Best regards,
> Okash
>
On Fri, Sep 20, 2019 at 8:46 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Sep 18, 2019 at 01:30:33PM -0700, Gregory Nowak wrote:
> > > Extra line between each attribute (before the "What:" line) would be
> > > nice.
> >
> > In a previous post above, you wrote:
> > On Mon, Sep 16, 2019 at 04:11:00PM +0
TODO.
Authored-by: Gregory Nowak
Submitted-by: Okash Khawaja
---
drivers/staging/speakup/sysfs-driver-speakup | 369 +++
1 file changed, 369 insertions(+)
create mode 100644 drivers/staging/speakup/sysfs-driver-speakup
diff --git a/drivers/staging/speakup/sysfs-driver-speakup
b/dr
TODO.
Authored-by: Gregory Nowak
Submitted-by: Okash Khawaja
Signed-off-by: Okash Khawaja
---
drivers/staging/speakup/sysfs-driver-speakup | 369 +++
1 file changed, 369 insertions(+)
create mode 100644 drivers/staging/speakup/sysfs-driver-speakup
diff --git a/drivers/staging/speakup/
Hi,
The v2 renames set_selection() and do_set_selection() to following
more explicit names:
set_selection_user() /* includes copying data from user space */
set_selection_kernel() /* no copying from user space */
The patches also update references to set_selection() to be
set_selection_user().
x27;t get EBUSY forever.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Tested-by: Gregory Nowak
---
drivers/staging/speakup/main.c | 1 +
drivers/staging/speakup/selection.c | 212 +++-
drivers/staging/speakup/speakup.h | 1 +
3 files changed
() and fixing for name change. It also
exports set_selection_kernel() and paste_selection().
These changes are used the following patch where speakup's selection
functionality calls into the above functions, thereby doing away with
parallel implementation.
Signed-off-by: Okash Khawaja
Review
On Fri, 15 Mar 2019 20:18:31 -0700
Greg Kroah-Hartman wrote:
> On Fri, Mar 15, 2019 at 01:01:27PM +0000, Okash Khawaja wrote:
> > Hi,
> >
> > We have made progress on the items in TODO file of speakup driver in
> > staging directory and wanted to get some clarity
On Fri, Jul 12, 2019 at 9:38 AM Greg Kroah-Hartman
wrote:
>
> On Sun, Jul 07, 2019 at 08:57:10AM +0200, Greg Kroah-Hartman wrote:
> > On Sat, Jul 06, 2019 at 08:08:57PM +0100, Okash Khawaja wrote:
> > > On Fri, 15 Mar 2019 20:18:31 -0700
> > > Greg Kroah-Hartman wr
return -1;
> - ch = goto_buf[--num];
> + wch = goto_buf[--num];
> goto_buf[num] = '\0';
> - spkup_write(&ch, 1);
> + spkup_write(&wch, 1);
> return 1;
> }
> if (ch < '+' || ch > 'y')
> goto oops;
> + wch = ch;
> goto_buf[num++] = ch;
> goto_buf[num] = '\0';
> - spkup_write(&ch, 1);
> + spkup_write(&wch, 1);
> maxlen = (*goto_buf >= '0') ? 3 : 4;
> if ((ch == '+' || ch == '-') && num == 1)
> return 1;
> @@ -2254,9 +2269,8 @@ static int vt_notifier_call(struct notif
> case VT_WRITE:
> if (param->c == '\b')
> speakup_bs(vc);
> - else if (param->c < 0x100) {
> - char d = param->c;
> -
> + else {
> + u16 d = param->c;
> speakup_con_write(vc, &d, 1);
> }
> break;
> Index: linux-4.10/drivers/staging/speakup/spk_types.h
> ===
> --- linux-4.10.orig/drivers/staging/speakup/spk_types.h
> +++ linux-4.10/drivers/staging/speakup/spk_types.h
> @@ -55,7 +55,7 @@ struct spk_highlight_color_track {
> /* Count of each background color */
> unsigned int bgcount[8];
> /* Buffer for characters drawn with each background color */
> - char highbuf[8][COLOR_BUFFER_SIZE];
> + u16 highbuf[8][COLOR_BUFFER_SIZE];
> /* Current index into highbuf */
> unsigned int highsize[8];
> /* Reading Position for each color */
> Index: linux-4.10/drivers/staging/speakup/speakup.h
> ===
> --- linux-4.10.orig/drivers/staging/speakup/speakup.h
> +++ linux-4.10/drivers/staging/speakup/speakup.h
> @@ -38,6 +38,7 @@
> #define B_SYM 0x0800
> #define B_CAPSYM (B_CAP|B_SYM)
>
> +/* FIXME: u16 */
> #define IS_WDLM(x) (spk_chartab[((u_char)x)]&B_WDLM)
> #define IS_CHAR(x, type) (spk_chartab[((u_char)x)]&type)
> #define IS_TYPE(x, type) ((spk_chartab[((u_char)x)]&type) == type)
Reviewed-by: Okash Khawaja
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
return -1;
> - ch = goto_buf[--num];
> + wch = goto_buf[--num];
> goto_buf[num] = '\0';
> - spkup_write(&ch, 1);
> + spkup_write(&wch, 1);
> return 1;
>
This changes the above five synths to TTY-based comms. They were chosen as a
first pass because their serial comms are straightforward, i.e. they don't use
serial input and don't do internal port knocking.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-4.10
not been changed. Along the way, this patch
also fixes a couple of spots which were calling spk_synth_immediate directly,
so that the calls now happen via the spk_syth struct.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-4.10.1/drivers/staging/speakup/serialio.c
, synth_out but more will
be added in future when incorporating inputs in the tty-based comms. Also at
the moment, synth_out method has one implementation which uses serial i/o.
Later in this patch set, an alternate tty-based implementation will be added.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel
witch to accessing
serial ports through the TTY subsystem, whenever appropriate.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-4.10.1/drivers/staging/speakup/Makefile
===
--- linux-4.10.1.orig/drivers/st
e decision of
calling spk_stop_serial_interrupt() to that synth. TTY-based synths which
follow in this patchset simply wouldn't call it.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-4.10.1/drivers/staging/spe
r enumerate it while providing
the existing tty API to avoid regressions (and to debug)."
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-4.10.1/drivers/tty/tty_io.c
===
--- linux-4.10.1.orig/drivers/tt
.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-4.10.1/drivers/staging/speakup/serialio.c
===
--- linux-4.10.1.orig/drivers/staging/speakup/serialio.c
+++ linux-4.10.1/drivers/staging/speakup/serialio.c
Hi,
This patchset introduces a TTY-based way for the synths to communicate
with devices as an alternate for direct serial comms used by the synths
at the moment. It then migrates some of the synths to the TTY-based
comms. Synths migrated in this patchset are dummy, acntsa, bns and
txprt.
As such,
> to a kernel device of some kind). That needs resolving along with how you
> > "up" or "down" your new bluetooth device, or enumerate it while providing
> > the existing tty API to avoid regressions (and to debug)."
> >
> > Signed-off-by: Okash Khawaja
not been changed. Along the way, this patch
also fixes a couple of spots which were calling spk_synth_immediate directly,
so that the calls now happen via the spk_syth struct.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-4.11-rc2/drivers/staging/speakup/serialio.c
Hi,
The following patches group together most of raw serial comms with external
synth and makes rest of the code agnostic to it, so that raw serial comms
can be easily replaced by an alternate way to communicate with external
synths. Plan is to follow these patches with alternate implementation
of
s the
decision of calling spk_stop_serial_interrupt() to that synth.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-4.11-rc2/drivers/staging/speakup/serialio.c
===
--- linux-4.11-rc2.orig/drivers/staging/sp
.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-4.11-rc2/drivers/staging/speakup/serialio.c
===
--- linux-4.11-rc2.orig/drivers/staging/speakup/serialio.c
+++ linux-4.11-rc2/drivers/staging/speakup/serialio.c
synths which require input functionality.
Also at the moment, synth_out method has one implementation which uses
serial i/o. Plan is to add an alternative.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-4.11-rc2/drivers/staging/speakup/serialio.c
On Thu, Mar 16, 2017 at 11:14:09AM +0900, Greg Kroah-Hartman wrote:
> On Tue, Mar 14, 2017 at 01:41:55PM +0000, Okash Khawaja wrote:
> > This moves spk_synth_immediate and spk_serial_synth_probe functions into
> > serialio.c. These functions do outgoing serial comms. The move is a s
not been changed. Along the way, this patch
also fixes a couple of spots which were calling spk_synth_immediate directly,
so that the calls now happen via the spk_syth struct.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging/speakup/serialio.c
Hi Gustavo,
On Mon, Mar 27, 2017 at 01:37:29AM -0500, Gustavo A. R. Silva wrote:
> Fix the following sparse warning:
> symbol 'spk_serial_out' was not declared. Should it be static?
>
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/staging/speakup/serialio.c | 2 +-
> 1 file changed, 1 ins
On Mon, Mar 27, 2017 at 09:58:53AM +0200, Samuel Thibault wrote:
> Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote:
> > Thanks for this :) Could you also move the function higher in the same
> > file - above line 139 where all static functions are defined?
>
> I&#
Hi,
Any updates on this? We can start working in
tty_port_register_serdev_device() if that's okay?
Thanks,
Okash
On Wed, Mar 22, 2017 at 01:05:24AM +0100, Samuel Thibault wrote:
> Hello,
>
> So Rob, how do you see this going? Shall we introduce a serdev_device
> *tty_port_register_serdev_devic
these methods. Then migrating the synths to TTY will
include repointing these methods to their TTY implementations
Rest of the changes simply make use of serial implementation of these two
functions.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging
This is part of move away from raw serial i/o to TTY-based one. Details are in
the patch header.
Thanks,
Okash
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
witch to accessing
serial ports through the TTY subsystem, whenever appropriate.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging/speakup/Makefile
===
--- linux-staging.orig/drivers/st
This changes the above five synths to TTY-based comms. They were chosen as a
first pass because their serial comms are straightforward, i.e. they don't use
serial input and don't do internal port knocking.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-stagi
This patch simply uses the changes introduced in previous patches and migrates
apollo, ltlk, audptr, decext, spkout and dectlk. Migrations are straightforward
function pointer updates.
Signed-off by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging/speakup
This applies on top of the changes already in staging-next branch which allow
kernel access to TTY dev.
Signe-doff-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/tty/tty_io.c
===
--- linux-staging.orig
from ISR, so
there is a possibility for last_char to be stale. Therefore it is marked as
volatile. It also pulls a repeated get_index implementation into synth.c, to
be used as a utility function.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_buf2.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging/speakup/spk_ttyio.c
===
--- linux-staging.orig/drivers/staging/speakup/spk_ttyio.c
+++ linux-staging/drivers/staging/speakup/spk_tt
Hi,
Forgot to add intro. Following is what I wanted to say:
This patchset migrates all external synths from using raw serial i/o to
using tty-based comms. The synths not migrated are internal ones -
plugged directly into motherboard, communicating over ISA etc. It's
important to note that these p
synth_flush is called.
It also tries to ensure that hardware flow control is enabled, by setting
CRTSCTS using tty's termios.
Reported-by: John Covici
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging/speakup/seria
Hi,
This patch applies on top of previous patchset which migrates synths to TTY
[1]. It fixes couple of issues and tries to ensure hardware flow control is
enabled.
Thanks,
Okash
[1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1387738.html
_
Hi Alan,
On Wed, May 10, 2017 at 08:41:51PM +0100, Alan Cox wrote:
> > + if (!(tmp_termios.c_cflag & CRTSCTS)) {
> > + tmp_termios.c_cflag |= CRTSCTS;
> > + ret = tty_set_termios(tty, &tmp_termios);
> > + if (ret)
> > + pr_warn("speakup: Failed to
On Thu, May 11, 2017 at 02:33:14PM +0100, Alan Cox wrote:
> On Thu, 11 May 2017 09:29:14 +0100
> Okash Khawaja wrote:
>
> > Hi Alan,
> >
> > On Wed, May 10, 2017 at 08:41:51PM +0100, Alan Cox wrote:
> > > > +
synth_flush is called.
It also tries to ensure that hardware flow control is enabled, by setting
CRTSCTS using tty's termios.
Reported-by: John Covici
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging/speakup/seria
Hi,
On Mon, May 15, 2017 at 11:31 AM, Greg Kroah-Hartman
wrote:
> On Sat, Apr 29, 2017 at 08:52:59PM +0100, Okash Khawaja wrote:
>> This applies on top of the changes already in staging-next branch which allow
>> kernel access to TTY dev.
>>
>> Signe-doff-by: Ok
umerate it while providing
the existing tty API to avoid regressions (and to debug)."
The exported funtion is used later in this patch set to gain access to
tty_struct.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/tty/tty_io.c
synth_flush is called.
It also tries to ensure that hardware flow control is enabled, by setting
CRTSCTS using tty's termios.
Reported-by: John Covici
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging/speakup/seria
This patch simply uses the changes introduced in previous patches and migrates
apollo, ltlk, audptr, decext, spkout and dectlk. Migrations are straightforward
function pointer updates.
Signed-off by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging/speakup
witch to accessing
serial ports through the TTY subsystem, whenever appropriate.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging/speakup/Makefile
===
--- linux-staging.orig/drivers/st
This patchset migrates all external synths from using raw serial i/o to
using tty-based comms. The synths not migrated are internal ones -
plugged directly into motherboard, communicating over ISA etc. It's
important to note that these patches access TTY from inside kernel.
Here is the summary of
_buf2.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-staging/drivers/staging/speakup/spk_ttyio.c
===
--- linux-staging.orig/drivers/staging/speakup/spk_ttyio.c
+++ linux-staging/drivers/staging/speakup/spk_tt
This changes the above five synths to TTY-based comms. They were chosen as a
first pass because their serial comms are straightforward, i.e. they don't use
serial input and don't do internal port knocking.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-stagi
Hi,
On Tue, May 16, 2017 at 1:00 PM, Greg Kroah-Hartman
wrote:
> On Mon, May 15, 2017 at 06:45:37PM +0100, Okash Khawaja wrote:
>> This patch fixes the issue where TTY-migrated synths would take a while to
>> shut up after hitting numpad enter key. When calling synth_flush, even
> On 16 May 2017, at 13:28, Greg Kroah-Hartman
> wrote:
>
>> On Tue, May 16, 2017 at 01:19:10PM +0100, Okash Khawaja wrote:
>> Hi,
>>
>> On Tue, May 16, 2017 at 1:00 PM, Greg Kroah-Hartman
>> wrote:
>>> On Mon, May 15, 2017 at 06:45:37PM +0100
We should check the flush_buffer method of a tty for null before
invoking it. Some drivers such as usbserial don't implement
flush_buffer. This will be required for upcoming patches where we expand
spk_ttyio to support more than just ttyS*.
Signed-off-by: Okash Khawaja
Reviewed-by: S
In spk_ttyio_release we read tty's index but never do anything with it.
The patch removes this dead code.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
---
drivers/staging/speakup/spk_ttyio.c |3 ---
1 file changed, 3 deletions(-)
--- a/drivers/staging/speakup/spk_tt
On Mon, Jun 05, 2017 at 11:43:55PM -0400, Bo YU wrote:
> Fixed checkpatch warning by adding a blank line after declare
> expression
>
> Signed-off-by: Bo YU
Reviewed-by: Okash Khawaja
> ---
> drivers/staging/speakup/serialio.c |1 +
> 1 file changed, 1 insertion
On Mon, Jun 05, 2017 at 11:44:11PM -0400, Bo YU wrote:
> Add a space around logical symbol '|' to wipe out checkpatch check
>
> Signed-off-by: Bo YU
Reviewed-by: Okash Khawaja
> ---
> drivers/staging/speakup/serialio.c |2 +-
> 1 file changed, 1 insertion
On Mon, Jun 05, 2017 at 11:44:26PM -0400, Bo YU wrote:
> Fixed the checkpatch.pl warning:
>
> WARNING: line over 80 characters
>
> Signed-off-by: Bo YU
Reviewed-by: Okash Khawaja
> ---
> drivers/staging/speakup/serialio.c |6 --
> 1 file changed, 4 in
On Mon, Jun 05, 2017 at 11:44:40PM -0400, Bo YU wrote:
> I have aligned argument with parenthesis, so checkpatch no check also.
>
> Signed-off-by: Bo YU
Reviewed-by: Okash Khawaja
> ---
> drivers/staging/speakup/serialio.c |2 +-
> 1 file changed, 1 insertion(+), 1 del
Hi,
On Mon, Jun 05, 2017 at 11:42:59PM -0400, Bo YU wrote:
> As checkpatch.pl reported, i fixed these complaint one by one. Maybe
> patch 04 depend on patch 02.
Thanks for the patches :) I've reviewed them all
Okash
___
devel mailing list
de...@linuxdr
Migration of bns was missed out in the patch
https://patchwork.kernel.org/patch/9727725/. This patch does it by
updating relevant function pointers, just like in the patch linked
above.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
---
drivers/staging/speakup/speakup_bns.c |8
selected synths, lp*.
In order to do this, the patch also introduces a string member variable
named 'dev' to struct spk_synth. 'dev' represents the device name -
ttyUSB0 etc - which needs conversion to dev_t.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
---
dri
Hi,
These patches extend speakup support to ttyUSB* and lp*. They introduce
a new module param dev whose function is similar to ser but instead of
taking serial port number as argument, it takes strings like ttyS0 or
ttyUSB0. First patch just adds functionality to convert such strings
into dev_t.
used.
If both are non-default then dev is used.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
---
drivers/staging/speakup/speakup_acntsa.c |3 +++
drivers/staging/speakup/speakup_apollo.c |3 +++
drivers/staging/speakup/speakup_audptr.c |3 +++
drivers/staging/speakup
Hi,
On Wed, Jun 14, 2017 at 03:04:18PM +0200, Greg Kroah-Hartman wrote:
> The console stuff is odd though, but that is each driver defining the
> name for itself, major/minor does not apply. Also, a separate driver is
> not having to figure this all out. I wonder if we could just add a tty
> co
Hi,
On Wed, Jun 14, 2017 at 9:23 AM, Dan Carpenter wrote:
[...]
>
> Could you call it "dev_name" instead? I normally expect "dev" to be a
> device struct.
Thanks for the feedback. Will keep these in mind for next version of the patch.
Okash
___
devel
ned-off-by: Okash Khawaja
---
include/linux/tty.h |3 +++
1 file changed, 3 insertions(+)
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -422,6 +422,9 @@ static inline int __init tty_init(void)
{ return 0; }
static inline const char *tty_name(const struct tty_struct *tty)
{ ret
Hi,
On Thu, Jun 15, 2017 at 07:52:51AM +0100, Okash Khawaja wrote:
> On Wed, Jun 14, 2017 at 03:04:18PM +0200, Greg Kroah-Hartman wrote:
> > The console stuff is odd though, but that is each driver defining the
> > name for itself, major/minor does not apply. Also, a separate dr
On Sat, Jun 17, 2017 at 12:25:34PM +0200, Greg Kroah-Hartman wrote:
> On Sat, Jun 17, 2017 at 11:16:44AM +0100, Okash Khawaja wrote:
> > Hi,
> >
> > On Thu, Jun 15, 2017 at 07:52:51AM +0100, Okash Khawaja wrote:
> > > On Wed, Jun 14, 2017 at 03:04:18PM +
ned-off-by: Okash Khawaja
---
include/linux/tty.h |3 +++
1 file changed, 3 insertions(+)
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -422,6 +422,9 @@ static inline int __init tty_init(void)
{ return 0; }
static inline const char *tty_name(const struct tty_struct *tty)
{ ret
Hi,
The patchset now contains a separate patch for dev name-to-number
conversion functionality inside tty_io.c.
These patches extend speakup support to ttyUSB* and lp*. They introduce
a new module param dev whose function is similar to ser but instead of
taking serial port number as argument, it
The function converts strings like ttyS0 and ttyUSB0 to dev_t like
(4, 64) and (188, 0). It does this by scanning tty_drivers list for
corresponding device name and index. If the driver is not registered,
this function returns -ENODEV. It also acquires tty_mutex.
Signed-off-by: Okash Khawaja
used.
If both are non-default then dev is used.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
---
drivers/staging/speakup/speakup_acntsa.c |3 +++
drivers/staging/speakup/speakup_apollo.c |3 +++
drivers/staging/speakup/speakup_audptr.c |3 +++
drivers/staging/speakup
sed in. It currently supports ttyS*, ttyUSB* and, for selected
synths, lp*.
The patch also introduces a string member variable named 'dev_name' to
struct spk_synth. 'dev_name' represents the device name - ttyUSB0 etc -
which needs conversion to dev_t.
Signed-off-by: Okash Khawaja
Hi,
Thanks for the reviews. Couple of things inlined below.
On Sun, Jun 18, 2017 at 04:35:21PM +0300, Andy Shevchenko wrote:
>
> > +const char *lp_supported[] = { "acntsa", "bns", "dummy", "txprt" };
>
> static ?
Sure!
> > + if (ser < 0 || ser > (255 - 64)) {
>
> > +pr_e
On Mon, Jun 19, 2017 at 09:15:33AM +0800, Greg Kroah-Hartman wrote:
> > +int ser_to_dev(int ser, dev_t *dev_no)
> > +{
> > + if (ser < 0 || ser > (255 - 64)) {
> > +pr_err("speakup: Invalid ser param. \
> > + Must be between 0 and 191 inclusive.\n");
>
>
On Sun, Jun 18, 2017 at 04:27:42PM +0300, Andy Shevchenko wrote:
> This doesn't have actual parameter name.
> Btw, I would drop dev_ suffix completely from parameter (you have it
> in function name).
Good call, thanks.
> > + * Locking: this acquires tty_mutex
>
> ...and releases.
>
> Perhap
sed in. It currently supports ttyS*, ttyUSB* and, for selected
synths, lp*.
The patch also introduces a string member variable named 'dev_name' to
struct spk_synth. 'dev_name' represents the device name - ttyUSB0 etc -
which needs conversion to dev_t.
Signed-off-by: Okash Khawaja
The function converts strings like ttyS0 and ttyUSB0 to dev_t like
(4, 64) and (188, 0). It does this by scanning tty_drivers list for
corresponding device name and index. If the driver is not registered,
this function returns -ENODEV. It also acquires tty_mutex.
Signed-off-by: Okash Khawaja
Hi,
I have updated the patches based on feedback. For patch 1, In favour of
consistency, I've updated the code which extracts trailing digits so
that it is like similar code in tty_find_polling_driver. Also fixed
checkpatch warnings.
Here's summary of the patches
Patch 1 adds functionality to co
used.
If both are non-default then dev is used.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Reviewed-by: Andy Shevchenko
---
drivers/staging/speakup/speakup_acntsa.c |3 +++
drivers/staging/speakup/speakup_apollo.c |3 +++
drivers/staging/speakup/speakup_audptr.c |3
removing the cached synth - is never called.
Next time the failing synth is added again it succeeds because
synth_add finds it cached inside synths[].
This patch fixes this by caching a synth only after do_synth_init
succeeds.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
---
drivers
: incorrect type in argument 2 (different address spaces)
expected void const [noderef] *from
got void *buf
This patch casts the user space pointers to have __user by using __force.
Signed-off-by: Okash Khawaja
---
drivers/staging/gdm72xx/gdm_wimax.c | 10 --
1 file changed, 8 insertions
Thanks, that's a cleaner approach. Apologies for delayed reply as I'm in middle
of a house move. I'll send an updated patch soon.
Okash
> On 2 Dec 2015, at 13:17, Dan Carpenter wrote:
>
> Probably it's better to create a different struct:
>
> struct udata_s {
>unsigned int size;
>void
> On 11 Dec 2015, at 10:52, Dan Carpenter wrote:
>
>> On Fri, Dec 11, 2015 at 10:33:13AM +, Okash Khawaja wrote:
>> Thanks, that's a cleaner approach. Apologies for delayed reply as I'm in
>> middle of a house move. I'll send an updated patch soon.
, in order to make the
distinction explicit. Finally, it explicitly casts the argument passed
to `gdm_update_fsm()` using __force to avoid the warning "cast removes
address space of expression".
Signed-off-by: Okash Khawaja
---
drivers/staging/gdm72xx/gdm_wimax.c | 7 ---
drive
ction names and signatures same - other than the __user attribute -
ensures that object inheritance continues to work as it was, but address
space discrepency is removed. That removes a whole bunch of address
space warnings.
Signed-off-by: Okash Khawaja
---
drivers/staging/lustre/lustre/in
1 - 100 of 162 matches
Mail list logo
