[PATCH 2/3] staging: rtl8188eu: remove header file ip.h

"ip.h" is included in four files but not being used, so remove "include/ip.h" header file and inclusion of this header file. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_recv.c |1 - drivers/staging/rtl8188eu/core/rtw_xmit.c |

[PATCH 1/3] staging: rtl8188eu: remove header file if_ether.h

"if_ether.h" is included in three files but not being used, so remove "include/if_ether.h" header file and inclusion of this header file. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_recv.c |1 - drivers/staging/rtl8188eu/hal/rtl8188eu_recv

[PATCH 3/3] staging: rtl8188eu: remove header file ethernet.h

"ethernet.h" is included in three files but only "rtw_recv.c" using two macros defined in "ethernet.h", so move used macros in "rtw_recv.c" and remove "include/ethernet.h" header file and inclusion of this header file. Signed-off-by: navin patid

[PATCH v2 3/3] staging: rtl8188eu: remove header file ethernet.h

"ethernet.h" is included in three files but only "rtw_recv.c" using two macros defined in "ethernet.h", so move used macros in "rtw_recv.c" and remove "include/ethernet.h" header file and inclusion of this header file. v2: First version of this pa

Re: [PATCH 3/3] staging: rtl8188eu: remove header file ethernet.h

I've submitted second version of this patch. regards, --navin-patidar On Wed, Feb 12, 2014 at 2:03 AM, Greg KH wrote: > On Sun, Feb 09, 2014 at 02:10:46PM +0530, navin patidar wrote: >> "ethernet.h" is included in three files but only "rtw_recv.c" using two &

[PATCH] staging: rtl8188eu: remove unused header files

Remove h2clbk.h and nic_spec.h header files. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/h2clbk.h | 35 drivers/staging/rtl8188eu/include/nic_spec.h | 44 -- 2 files changed, 79 deletions(-) delete mode 100644 drivers

[PATCH 00/10] staging: rtl8188eu: Refactor and cleanup led related code.

From: navin patidar This patch series refactors and performs various cleanups on the driver's code responsible for led functionality. navin patidar (10): staging: rtl8188eu: Remove empty header file staging: rtl8188eu: Remove rtw_led_blink_cmd() function. staging: rtl8188eu: R

[PATCH 01/10] staging: rtl8188eu: Remove empty header file

drv_types_linux.h is empty, so remove the header file and its reference. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h |1 - .../staging/rtl8188eu/include/drv_types_linux.h| 24 2 files changed, 25 deletions(-) delete mode

[PATCH 02/10] staging: rtl8188eu: Remove rtw_led_blink_cmd() function.

rtw_led_blink_cmd() isn't being used by driver. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_cmd.c| 35 --- drivers/staging/rtl8188eu/include/rtw_cmd.h |1 - 2 files changed, 36 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH 05/10] staging: rtl8188eu: Simplify led blinking strategy code.

to other blinking strategies e.g. SW_LED_MODE[0|2|3|4|5|6]. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_led.c | 1412 +++--- 1 file changed, 101 insertions(+), 1311 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers

[PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

_ReadLEDSetting() doesn't read led settings this function actually initialize member variables of struct led_priv, we should do that inside rtl8188eu_InitSwLeds(). Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188eu_led.c |4 drivers/staging/rtl8188e

[PATCH 04/10] staging: rtl8188eu: Remove _InitHWLed() function.

_InitHWLed() function does nothing. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 0dfd62b..617e4c6

[PATCH 06/10] staging: rtl8188eu: Remove enum LED_STRATEGY_871x .

Now driver has only one type of led blinking strategy, so we don't need enum LED_STRATEGY_871x variable to store led blinking strategy type. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188eu_led.c |1 - drivers/staging/rtl8188eu/include/rtw_led.h |

[PATCH 07/10] staging: rtl8188eu: refactor led related structures.

struct led_priv contains two variables SwLed0 and SwLed1 but only SwLed0 is being used by SwLedControlModel1() function. SwLedControlModel1() function performs led operations. This patch removes SwLed1 and code which uses SwLed1. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core

[PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_led.h | 30 +-- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_led.h b/drivers/staging/rtl8188eu/include/rtw_led.h index 2f81fab..2ad7e4a

[PATCH 08/10] staging: rtl8188eu: Remove unused macros.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_led.h | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_led.h b/drivers/staging/rtl8188eu/include/rtw_led.h index ed1c687..2f81fab 100644 --- a/drivers

[PATCH 10/10] staging: rtl8188eu: Remove unused enum LED_CTL_MODE members.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_led.h | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_led.h b/drivers/staging/rtl8188eu/include/rtw_led.h index 2ad7e4a..c5194b6 100644

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

Hi dan it's just a cleanup patch and i also tested all patches of this patch series on the hardware (TP-LINK TL-WN723N). my mistake i should have added "Tested-by" tag for all patches. Tested-by: navin patidar regards, --navin-patidar On Tue, Apr 22, 2014 at 3:41 PM, Dan C

Re: [PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

dan, It is ok to rearrange and remove members of enum LED_STATE_871x and enum LED_CTL_MODE. these enum are not related to firmware . regards, --navin-patidar On Tue, Apr 22, 2014 at 4:05 PM, Dan Carpenter wrote: > It's ok to renumber all of these? It's not something the firmwar

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

as well as > declaring that you own the copyright to the material. I didn't know that signed-off-by implies both tested and authored. thanks for clearing that up. regards, --navin-patidar ___ devel mailing list de.

[PATCH] staging: rtl8188eu: Use USB subsystem functions to check endpoint type

Use inline functions provided by USB subsystem to check endpoint type, instead of macros implemented by driver to do the same. Unnecessary debugging messages are also removed. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 92 --- 1

[PATCH 1/2] staging: rtl8188eu: Remove debugging messages from usb_dvobj_init()

Unnecessary debugging messages are removed from usb_dvobj_init(). Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 34 +++ 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b

[PATCH 2/2] staging: rtl8188eu: Use USB subsystem functions to check endpoint type

Use inline functions provided by USB subsystem to check endpoint type, instead of inline functions implemented by driver to do the same. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 57 +-- 1 file changed, 10 insertions(+), 47

Re: [PATCH] staging: rtl8188eu: Use USB subsystem functions to check endpoint type

On Mon, Apr 28, 2014 at 2:55 PM, Dan Carpenter wrote: > On Sat, Apr 26, 2014 at 10:13:55PM +0530, navin patidar wrote: >> Use inline functions provided by USB subsystem to check endpoint type, >> instead of macros implemented by driver to do the same. >> >> Unnecessary

[PATCH 00/15] staging: rtl8188eu: clean-up struct recv_buf

Following patches remove unnecessary member variables of struct recv_buf. navin patidar (15): staging: rtl8188eu: Remove function rtw_dequeue_recvbuf() staging: rtl8188eu: Remove function rtw_enqueue_recvbuf_to_head() staging: rtl8188eu: Remove function rtw_enqueue_recvbuf() staging

[PATCH 01/15] staging: rtl8188eu: Remove function rtw_dequeue_recvbuf()

rtw_dequeue_recvbuf() is not being used by driver. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_recv.c| 25 - drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 26 deletions(-) diff --git a/drivers/staging/rtl8188eu/core

[PATCH 03/15] staging: rtl8188eu: Remove function rtw_enqueue_recvbuf()

rtw_enqueue_recvbuf() is not being used by driver. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_recv.c| 12 drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c

[PATCH 02/15] staging: rtl8188eu: Remove function rtw_enqueue_recvbuf_to_head()

rtw_enqueue_recvbuf_to_head() is not being used by driver. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_recv.c| 12 drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8188eu/core

[PATCH 04/15] staging: rtl8188eu: Remove 'struct list_head list' from struct recv_buf

Users of 'struct list_head list' variable e.g. rtw_enqueue_recvbuf(), rtw_enqueue_recvbuf_to_head() and rtw_dequeue_recvbuf() are already removed. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 - drivers/staging/rtl8188eu/include/rtw_recv.h |

[PATCH 05/15] staging: rtl8188eu: Remove 'spinlock_t recvbuf_lock' from struct recv_buf

recvbuf_lock is initialized inside rtl8188eu_init_recv_priv() but never used. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 - drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging

[PATCH 06/15] staging: rtl8188eu: Remove 'dma_addr_t dma_transfer_addr' from struct recv_buf

Remove unused variable dma_transfer_addr. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index 4a19a06..bf9af77

[PATCH 07/15] staging: rtl8188eu: Remove 'int transfer_len' from struct recv_buf

Driver is not making any use of value stored in this variable. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |2 -- drivers/staging/rtl8188eu/hal/usb_ops_linux.c |1 - drivers/staging/rtl8188eu/include/rtw_recv.h |1 - drivers/staging/rtl8188eu

[PATCH 08/15] staging: rtl8188eu: Remove pdata, phead, ptail and pend from struct recv_buf

Driver is not making use of value stored in removed variables. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |8 drivers/staging/rtl8188eu/hal/usb_ops_linux.c |9 - drivers/staging/rtl8188eu/include/rtw_recv.h |4 drivers

[PATCH 10/15] staging: rtl8188eu: Remove 'pallocated_buf' from struct recv_buf

pallocated_buf is not being used by driver. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - drivers/staging/rtl8188eu/os_dep/recv_linux.c |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers

[PATCH 11/15] staging: rtl8188eu: Remove 'alloc_sz' from struct recv_buf

Driver isn't making any use of value stored in alloc_sz variable. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 - drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188e

[PATCH 12/15] staging: rtl8188eu: Remove 'u32 len' from struct recv_buf

Remove unused variable 'u32 len'. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 - drivers/staging/rtl8188eu/include/rtw_recv.h |1 - drivers/staging/rtl8188eu/os_dep/recv_linux.c |1 - 3 files changed, 3 deletions(-) diff --git

[PATCH 09/15] staging: rtl8188eu: Remove 'irp_pending' from struct recv_buf

irp_pending is initialized to false inside rtw_os_recvbuf_resource_alloc() and value of irq_pending never changed after that, so 'if (!precvbuf->irp_pending)' inside rtw_os_read_port() function will be always true. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/inclu

[PATCH 13/15] staging: rtl8188eu: Remove 'u32 ref_cnt' from struct recv_buf

Driver isn't making any use of value stored in variable ref_cnt. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |2 -- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - drivers/staging/rtl8188eu/os_dep/recv_linux.c |1 - 3 files chang

[PATCH 14/15] staging: rtl8188eu: Remove rtl8188eu_init_recvbuf() function

rtl8188eu_init_recvbuf() function definition is empty now, so remove it. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c|4 drivers/staging/rtl8188eu/hal/usb_ops_linux.c |2 -- drivers/staging/rtl8188eu/include/rtl8188e_recv.h |1 - 3

[PATCH 15/15] staging: rtl8188eu: Remove 'u8 *pbuf' from struct recv_buf

Instead of using pbuf to pass sbk data pointer to usb_fill_bulk_urb(), we can use precvbuf->pskb->data to do that. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_ops_linux.c |5 + drivers/staging/rtl8188eu/include/rtw_recv.h |1 - drivers/staging/rtl

[PATCH 04/13] staging: rtl8188eu: Remove struct zero_bulkout_context

From: navin patidar Remove unused struct zero_bulkout_context. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep

[PATCH 00/13]staging: rtl8188eu: Remove unused functions and variables

From: navin patidar Following patches remove unused functions, variables and functions with empty definition. navin patidar (13): staging: rtl8188eu: Remove 'semaphore allrxreturnevt' from struct recv_priv staging: rtl8188eu: Remove unused member variables of struct

[PATCH 03/13] staging: rtl8188eu: Remove 'spinlock_t lock' from struct recv_priv

From: navin patidar Remove unused variable 'spinlock_t lock'. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_recv.c|2 -- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/

[PATCH 05/13] staging: rtl8188eu: Remove function rtw_os_recv_resource_init()

From: navin patidar rtw_os_recv_resource_init() has empty defination, so we can remove it. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_recv.c |2 -- drivers/staging/rtl8188eu/include/recv_osdep.h |1 - drivers/staging/rtl8188eu/os_dep/recv_linux.c |7

[PATCH 02/13] staging: rtl8188eu: Remove unused member variables of struct recv_priv

From: navin patidar Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_recv.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index 5b3bf29..d52cfe8 100644 --- a/drivers

[PATCH 01/13] staging: rtl8188eu: Remove 'semaphore allrxreturnevt' from struct recv_priv

From: navin patidar Remove unused variable 'semaphore allrxreturnevt'. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_recv.c|2 -- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 3 deletions(-) diff --git a/drivers/staging/rtl8

[PATCH 07/13] staging: rtl8188eu: Remove function rtw_hostapd_mlme_rx()

From: navin patidar rtw_hostapd_mlme_rx() has empty defination, so we can remove it. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c |2 -- drivers/staging/rtl8188eu/include/recv_osdep.h |1 - drivers/staging/rtl8188eu/os_dep/recv_linux.c |5

[PATCH 06/13] staging: rtl8188eu: Remove function rtw_os_recv_resource_free()

From: navin patidar rtw_os_recv_resource_free() has empty defination, so we can remove it. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_recv.c |2 -- drivers/staging/rtl8188eu/include/recv_osdep.h |1 - drivers/staging/rtl8188eu/os_dep/recv_linux.c |5

[PATCH 08/13] staging: rtl8188eu: Remove function rtw_os_recvbuf_resource_free()

From: navin patidar Use usb_free_urb() instead of rtw_os_recvbuf_resource_free() to free URB. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |2 +- drivers/staging/rtl8188eu/include/recv_osdep.h |1 - drivers/staging/rtl8188eu/os_dep/recv_linux.c

[PATCH 10/13] staging: rtl8188eu: Remove unused inline function get_rx_status()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_recv.h |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index e5b4e10..dac2e0c 100644 --- a/drivers/staging/rtl8188eu

[PATCH 11/13] staging: rtl8188eu: Remove 'void *precvbuf' from struct recv_frame

Remove unused variable 'void *precvbuf'. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_ops_linux.c |1 - drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c

[PATCH 09/13] staging: rtl8188eu: Remove unused inline function recvframe_push()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_recv.h | 20 1 file changed, 20 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index 68c2ad5f..e5b4e10 100644 --- a/drivers

[PATCH 13/13] staging: rtl8188eu: Remove 'u8 fragcnt' from struct recv_frame

Remove unused variable 'u8 fragcnt'. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index b0fbdbd..f0c2

[PATCH 12/13] staging: rtl8188eu: Remove 'int frame_tag' from struct recv_frame

Remove unused variable 'int frame_tag'. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index e14ba98..b0fb

[PATCH 00/28] staging: rtl8188eu: Remove unnecessary functions.

Following patches remove functions which are unused or have empty definition. navin patidar (28): staging: rtl8188eu: Remove function with empty definition _InitBeaconMaxError(). staging: rtl8188eu: Remove function with empty definition _InitOperationMode() staging: rtl8188eu

[PATCH 01/28] staging: rtl8188eu: Remove function with empty definition _InitBeaconMaxError().

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 617e4c6..9ce6173 100644 --- a/drivers/staging/rtl8188eu/hal

[PATCH 03/28] staging: rtl8188eu: Remove function with empty definition _ps_open_RF()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |7 --- drivers/staging/rtl8188eu/include/rtl8188e_hal.h |1 - 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c

[PATCH 02/28] staging: rtl8188eu: Remove function with empty definition _InitOperationMode()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 9ce6173..2e7b81ce 100644 --- a/drivers/staging/rtl8188eu/hal

[PATCH 04/28] staging: rtl8188eu: Remove unused function _ps_close_RF()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 2fe1135..1a83d31 100644 --- a/drivers/staging/rtl8188eu/hal

[PATCH 06/28] staging:rtl8188eu:Remove funtion Hal_CustomizeByCustomerID_8188EU()

Function has empty defination. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 4c3f8c8..141f85a 100644 --- a

[PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 1a83d31..4c3f8c8 100644 --- a/drivers/staging/rtl8188eu/hal

[PATCH 07/28] staging: rtl8188eu: Remove unused function rtl8188e_PHY_ConfigRFWithParaFile()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index 8079fc6..b50df3e 100644 --- a

[PATCH 08/28] staging: rtl8188eu: Remove unused function rtl8192c_PHY_GetHWRegOriginalValue()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index b50df3e..79f86db 100644 --- a/drivers

[PATCH 09/28] staging: rtl8188eu: Remove unused function PHY_UpdateTxPowerDbm8188E()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 37 drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |1 - 2 files changed, 38 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging

[PATCH 10/28] staging:rtl8188eu: Remove unused function phy_DbmToTxPwrIdx()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 44 --- 1 file changed, 44 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index 7cc7f44..16f46c3 100644 --- a

[PATCH 11/28] staging: rtl8188eu: Remove unused funtion PHY_GetTxPowerLevel8188E()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 46 --- 1 file changed, 46 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index 16f46c3..099345f 100644 --- a

[PATCH 12/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 34 --- 1 file changed, 34 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index 099345f..a7872c8 100644 --- a

[PATCH 13/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index a7872c8..941ff74 100644 --- a/drivers/staging

[PATCH 14/28] staging: rtl8188eu: Remove unused structure rf_shadow

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c index b1cb5c4..2f1348f 100644 --- a

[PATCH 15/28] staging: rtl8188eu: Remove unused function rtl8188e_RF_ChangeTxPath()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c index 2f1348f..52103da 100644 --- a

[PATCH 16/28] staging: rtl8188eu: Remove unused function odm_DIGbyRSSI_LPS()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c | 45 --- 1 file changed, 45 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 89a26e3..d8482ab 100644 --- a/drivers/staging/rtl8188eu

[PATCH 17/28] staging: rtl8188eu: Remove function odm_DynamicBBPowerSaving()

odm_DynamicBBPowerSaving() has empty defination. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index d8482ab..2e105b4 100644 --- a

[PATCH 18/28] staging: rtl8188eu: Remove unused function odm_DynamicBBPowerSavingInit()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 2e105b4..e8ad880 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c +++ b

[PATCH 19/28] staging:rtl8188eu: Remove unused function iodm_1R_CCA()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index e8ad880..7319b3e 100644 --- a/drivers/staging/rtl8188eu

[PATCH 20/28] staging: rtl8188eu: Remove unused function odm_RefreshRateAdaptiveMaskMP()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 7319b3e..01946cc 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c +++ b/drivers/staging

[PATCH 21/28] staging: rtl8188eu: Remove unused function odm_RefreshRateAdaptiveMaskAPADSL()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 01946cc..cc73188 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c +++ b/drivers/staging

[PATCH 22/28] staging: rtl8188eu: Remove unused funtion odm_DynamicTxPowerNIC()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index cc73188..8dd5f7e 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c +++ b/drivers

[PATCH 23/28] staging: rtl8188eu: Remove unused function odm_SwAntDivChkAntSwitchCallback()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 8dd5f7e..4442181 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c +++ b

[PATCH 24/28] staging: rtl8188eu: Remove unused function ConvertTo_dB()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 4442181..425c50a4 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c

[PATCH 25/28] staging: rtl8188eu: Remove function with empty defination ODM_CheckPowerStatus()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c index 056052d..7c22658 100644 --- a/drivers

[PATCH 26/28] staging: rtl8188eu: Remove unused function DM_DIG_LowerBound_88E()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c index 323eb93..7c1043c 100644 --- a/drivers/staging

[PATCH 27/28] staging: rtl8188eu: Remove unused function ODM_DynamicPrimaryCCA_DupRTS()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c index 7c1043c..a90b2c5 100644 --- a/drivers/staging/rtl8188eu

[PATCH 28/28] staging: rtl8188eu:Remove function with empty defination odm_DynamicPrimaryCCA()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |1 - drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |5 - drivers/staging/rtl8188eu/include/odm_RTL8188E.h |2 -- 3 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c

[PATCH 13/28] staging: rtl8188eu: Remove unused funtion PHY_ScanOperationBackup8188E()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index a7872c8..941ff74 100644 --- a/drivers/staging

Re: [PATCH 13/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

Subject line of this patch isn't correct, so please ignore it. I've submitted new patch with "[PATCH 13/28] staging: rtl8188eu: Remove unused funtion PHY_ScanOperationBackup8188E()" subject line. regards, navin patidar On Sun, May 18, 2014 at 8:49 PM, navin patidar wrote: &g

Re: [PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

On Mon, May 19, 2014 at 4:22 PM, Dan Carpenter wrote: > On Sun, May 18, 2014 at 08:48:58PM +0530, navin patidar wrote: >> Signed-off-by: navin patidar >> --- >> drivers/staging/rtl8188eu/hal/usb_halinit.c |8 >> 1 file changed, 8 deletions(-) >>

Re: [PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

On Tue, May 20, 2014 at 12:34 AM, Dan Carpenter wrote: > On Mon, May 19, 2014 at 09:19:07PM +0530, navin patidar wrote: >> > You have changed it to return _FAIL instead of true. Perhaps that is ok >> > but you need to explain it in the changelog. >> > >> oops

Re: [PATCH 00/13]staging: rtl8188eu: Remove unused functions and variables

Hi Greg, Please merge this patchset, It has been pending for some time. regards, navin patidar On Wed, May 7, 2014 at 9:27 AM, wrote: > From: navin patidar > > Following patches remove unused functions, variables and functions with empty > definition. > > navin patidar

[PATCH 02/24] staging: rtl8188eu: Remove unused function rtw_hal_intf_ps_func()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_intf.c |9 - drivers/staging/rtl8188eu/include/hal_intf.h |3 --- 2 files changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal/hal_intf.c index

[PATCH 03/24] staging: rtl8188eu: Remove unused function pointer ->interface_ps_func

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |2 -- drivers/staging/rtl8188eu/include/hal_intf.h |3 --- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 0cb84ae

[PATCH 01/24] staging: rtl8188eu: Remove unused function rtw_interface_ps_func()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c|9 - drivers/staging/rtl8188eu/include/rtw_pwrctrl.h |2 -- 2 files changed, 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core

[PATCH 04/24] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 9020129..141f85a 100644 --- a/drivers/staging/rtl8188eu/hal

[PATCH 08/24] staging: rtl8188eu: Remove function rtw_hal_dm_deinit()

rtw_hal_dm_deinit() calls rtl8188e_deinit_dm_priv() using funtion pointer. rtl8188e_deinit_dm_priv() has empty defination, so we can remove rtw_hal_dm_deinit() and later rtl8188e_deinit_dm_priv() also will be removed. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_intf.c

[PATCH 06/24] staging: rtl8188eu: Remove unused function odm_Init_RSSIForDM()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_HWConfig.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_HWConfig.c b/drivers/staging/rtl8188eu/hal/odm_HWConfig.c index 0145a11..f2e1d02 100644 --- a/drivers/staging/rtl8188eu/hal

[PATCH 05/24] staging: rtl8188eu: Remove unused function ODM_MacStatusQuery()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_HWConfig.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_HWConfig.c b/drivers/staging/rtl8188eu/hal/odm_HWConfig.c index a755df3..0145a11 100644 --- a/drivers/staging/rtl8188eu

[PATCH 07/24] staging: rtl8188eu: Remove function with empty defination dm_CheckStatistics()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index cf88bf2..4e9f797 100644 --- a/drivers/staging/rtl8188eu

[PATCH 09/24] staging: rtl8188eu: Remove unused function pointer ->dm_init

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 - drivers/staging/rtl8188eu/include/hal_intf.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/hal

[PATCH 11/24] staging: rtl8188eu: remove unused header inclusion from rtw_mp.c

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mp.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mp.c b/drivers/staging/rtl8188eu/core/rtw_mp.c index 705f666..17427a6 100644 --- a/drivers/staging/rtl8188eu/core/rtw_mp.c +++ b

[PATCH 10/24] staging: rtl8188eu: Remove unused function rtl8188e_deinit_dm_priv()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c |4 drivers/staging/rtl8188eu/include/rtl8188e_dm.h |1 - 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index

[PATCH 14/24] staging: rtl8188eu: Remove unused macros in odm_interface.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 548a309..3fc3e3c 100644 --- a/drivers

  1   2   3   4   5   6   >