* Remove multiple blank lines in order to get rid of checkpatch.pl
"CHECK" output
Signed-off-by: Michael Hornung
---
drivers/staging/rtl8712/ieee80211.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.h
b/drivers/staging/rtl8712/i
* Add missing spaces around bitwise OR operation in order to get
rid of checkpatch.pl's "CHECK: spaces preferred around that '|'"
Signed-off-by: Michael Hornung
---
drivers/staging/rtl8712/ieee80211.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
* Do coding style cleanups on file ieee80211.h and get rid of
all checkpatch.pl output.
Michael Hornung (6):
staging: rtl8712: Coding style: Remove multiple blank lines
staging: rtl8712: Coding style: Make use of BIT macro
staging: rtl8712: Coding style: Fix missing spaces
staging
* Fix alignment which did not match open parenthesis
Signed-off-by: Michael Hornung
---
drivers/staging/rtl8712/ieee80211.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/ieee80211.h
b/drivers/staging/rtl8712/ieee80211.h
index 830452b..e5ec6c2
* Fix checkpatch.pl output about not including the paragraph
about writing to the Free Software Foundation's mailing address
Signed-off-by: Michael Hornung
---
drivers/staging/rtl8712/ieee80211.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rt
* Remove unused CamelCase in order to get rid of the corresponding
checkpatch.pl "CHECK: Avoid CamelCase: "
Signed-off-by: Michael Hornung
---
drivers/staging/rtl8712/ieee80211.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/ieee80211.h
b/drivers/stagi
* Fix sparse warning "Using plain integer as NULL pointer"
Signed-off-by: Michael Hornung
---
drivers/staging/most/aim-network/networking.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/aim-network/networking.c
b/drivers/staging/most/a
Add compat handler for "queue message" ioctl.
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 36 ++
1 file changed, 36 insertions(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drive
Add compat handler for "get config" ioctl.
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 32 ++
1 file changed, 32 insertions(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drive
Add compat handler for "dequeue messagen" ioctl and move
parts in common with the regular ioctl to vchiq_ioctl_dequeue_message.
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 168 -
1 file changed, 100 insertions(+), 68
cleanup the entire ioctl
structure.
Tests Runs:
vchiq_test -f 10
vchiq_test -p 1
Tests were run from both a native debian arm64 install and a debian
armhf chroot on an RPI 3.
Signed-off-by: Michael Zoran
Michael Zoran (9):
VC04_SERVICES: Add compat ioctl data structures
VC04_SERVICES
Add compat handler for "create service" ioctl and move
parts in common with the regular ioctl to vchiq_ioctl_create_service
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 180 +
1 file changed, 112 insertions(+), 68 deletion
Add the top level compat ioctl handler as a placeholder
for adding additional handlers.
The ioctls are first filtered and forwarded to the
regular ioctl handler if the ioctl does not require
any extra compatibility processing.
Signed-off-by: Michael Zoran
---
.../vc04_services/interface
Add compat handler for "await_completion" ioctl and move
parts in common with the regular ioctl to vchiq_ioctl_await_completion
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 398 ++---
1 file changed, 267 insertions(+), 131
Add compat handler for "queue bulk" ioctls and move
parts in common with the regular ioctls to vchiq_ioctl_queue_bulk
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 206 ++---
1 file changed, 141 insertions(+), 65 deletions(-)
di
Add compat handler for "dump mem" ioctl.
Signed-off-by: Michael Zoran
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drivers/staging/vc0
This change adds the compatibility data structures for compatibility
ioctls and defines compatibility ioctl definitions for the ioctls
that have changed.
Signed-off-by: Michael Zoran
---
.../interface/vchiq_arm/vchiq_ioctl.h | 96 ++
1 file changed, 96
On Wed, 2017-01-18 at 18:13 +0100, Greg KH wrote:
> On Wed, Jan 18, 2017 at 07:04:45AM -0800, Michael Zoran wrote:
> > This change adds the compatibility data structures for
> > compatibility
> > ioctls and defines compatibility ioctl definitions for the ioctls
On Wed, 2017-01-18 at 18:23 +0100, Greg KH wrote:
> On Wed, Jan 18, 2017 at 09:18:43AM -0800, Michael Zoran wrote:
> > On Wed, 2017-01-18 at 18:13 +0100, Greg KH wrote:
> > > On Wed, Jan 18, 2017 at 07:04:45AM -0800, Michael Zoran wrote:
> > > > This change adds the
On Thu, 2017-01-19 at 02:01 +0300, Dan Carpenter wrote:
> On Wed, Jan 18, 2017 at 07:04:46AM -0800, Michael Zoran wrote:
> > Add the top level compat ioctl handler as a placeholder
> > for adding additional handlers.
> >
> > The ioctls are first filtered and forward
On Thu, 2017-01-19 at 11:00 +0300, Dan Carpenter wrote:
> On Wed, Jan 18, 2017 at 11:37:55PM -0800, Michael Zoran wrote:
> > This whole driver is a chicken and egg problem. The existing code
> > is
> > so hard to read and maintain, that it's hard to improve it in a
On Thu, 2017-01-19 at 12:14 +0300, Dan Carpenter wrote:
> On Wed, Jan 18, 2017 at 07:04:48AM -0800, Michael Zoran wrote:
> > Add compat handler for "queue message" ioctl.
> >
> > Signed-off-by: Michael Zoran
> > ---
> > .../vc04_ser
On Thu, 2017-01-19 at 13:10 +0300, Dan Carpenter wrote:
> One thing I will say is that I have scripts to review when people
> pull
> parts of an ioctl into a separate patch. So when you do that, please
> don't make too many white space changes if you can avoid it. Those
> confuse my scripts.
>
On Thu, 2017-01-19 at 14:34 +0300, Dan Carpenter wrote:
> On Thu, Jan 19, 2017 at 03:27:56AM -0800, Michael Zoran wrote:
> > On Thu, 2017-01-19 at 13:10 +0300, Dan Carpenter wrote:
> > All these silly white space issues in the existing code could be
> > fixed
> > in
On Thu, 2017-01-19 at 13:22 +0100, Greg KH wrote:
> On Thu, Jan 19, 2017 at 04:07:15AM -0800, Michael Zoran wrote:
> > On Thu, 2017-01-19 at 14:34 +0300, Dan Carpenter wrote:
> > > On Thu, Jan 19, 2017 at 03:27:56AM -0800, Michael Zoran wrote:
> > > > On Thu,
On Thu, 2017-01-19 at 15:56 +0300, Dan Carpenter wrote:
> Hm... I had never used checkpatch.pl --fix until a few minutes ago.
>
> Basically sending a zillion patches is the only way to do anything in
> the linux-kernel. You're not allowed to break the build, introduce
> new compile warnings or b
On Fri, 2017-01-20 at 14:00 +0300, Dan Carpenter wrote:
> What Greg said. No one is saying you have to clean this code up,
> it's
> just that you were adding new code. I actually didn't really have a
> big
> issue with any of the patches except #2.
>
Cool. I guess I was just going through some
cleaning up
the other ioctls.
Tests Runs:
vchiq_test -f 10
vchiq_test -p 1
Tests were run from both a native debian arm64 install and a debian
armhf chroot on an RPI 3.
Signed-off-by: Michael Zoran
Michael Zoran (7):
staging: vchiq_arm: Add compat ioctl for create service
staging: vchiq_arm
Add compat ioctl for queue message
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 185 ++---
1 file changed, 129 insertions(+), 56 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drivers/staging
Add compat ioctl for dequeue message
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 221 +
1 file changed, 137 insertions(+), 84 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drivers/staging
Add compat ioctl for await completion
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 498 ++---
1 file changed, 341 insertions(+), 157 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drivers
Add compat ioctl for queue bulk
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 274 ++---
1 file changed, 180 insertions(+), 94 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drivers/staging
Add compat ioctl for dump mem
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 60 +-
1 file changed, 48 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drivers/staging
general pattern is developed that can be used for cleaning up
the other ioctls.
This change contains the general framework and the ioctl handler for
the create service ioctl.
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 360 -
1 file
Add compat ioctl for get config
Signed-off-by: Michael Zoran
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 97 +-
1 file changed, 74 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drivers/staging
On Mon, 2017-01-23 at 14:38 +0300, Dan Carpenter wrote:
> I'm attaching how I would basically like to see patch 1/7 done. It's
> not perfect, I did it as quickly as possible and haven't tested
> anything. I would normally be more careful if I were sending this
> for
> inclusion so there are no si
(VCHI_SERVICE_HANDLE_T handle,
void __user *data,
unsigned int size)
Signed-off-by: Michael Zoran
---
.../staging/vc04_services/interface/vchi/vchi.h| 6
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 33 ++
2 files
,
unsigned int size)
int
vchi_queue_user_message(VCHI_SERVICE_HANDLE_T handle,
void __user *data,
unsigned int size)
Signed-off-by: Michael Zoran
Michael Zoran (3):
staging: vc04_services: Add vchi_queue_kernel_message function
(VCHI_SERVICE_HANDLE_T handle,
void *data,
unsigned int size)
Signed-off-by: Michael Zoran
---
.../staging/vc04_services/interface/vchi/vchi.h| 6 ++
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 22 ++
2 files
The vchi_msg_queue function which is used by other drivers
to queue a message is difficult to understand and overly
generic.
Make the function static and remove it from the exported
symbols.
Signed-off-by: Michael Zoran
---
drivers/staging/vc04_services/interface/vchi/vchi.h| 8
,
unsigned int size)
int
vchi_queue_user_message(VCHI_SERVICE_HANDLE_T handle,
void __user *data,
unsigned int size)
Changes:
V2 - Add missing symbol export of vchiq_queue_user_message
Signed-off-by: Michael Zoran
Michael Zoran (3
(VCHI_SERVICE_HANDLE_T handle,
void *data,
unsigned int size)
Signed-off-by: Michael Zoran
---
.../staging/vc04_services/interface/vchi/vchi.h| 6 ++
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 22 ++
2 files
The vchi_msg_queue function which is used by other drivers
to queue a message is difficult to understand and overly
generic.
Make the function static and remove it from the exported
symbols.
Signed-off-by: Michael Zoran
---
drivers/staging/vc04_services/interface/vchi/vchi.h| 8
(VCHI_SERVICE_HANDLE_T handle,
void __user *data,
unsigned int size)
Signed-off-by: Michael Zoran
---
.../staging/vc04_services/interface/vchi/vchi.h| 6
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 34 ++
2 files
On Wed, 2017-01-25 at 15:10 +0300, Dan Carpenter wrote:
> On Tue, Jan 24, 2017 at 12:34:04PM -0800, Michael Zoran wrote:
> > The vchi_msg_queue function which is used by other drivers
> > to queue a message is difficult to understand and overly
> > generic. Remove it and rep
On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote:
> On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote:
> > Just for clarity, when you mean staging code? Are you talking about
> > the
> > entire vc04_services driver or are we talking about the
> >
On Wed, 2017-01-25 at 14:33 +0100, Greg KH wrote:
> On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote:
> > On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote:
> > > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote:
> > > > Just for clari
On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote:
> > Again, that's not my decision. I can go either way. But if the
> > decision was made to delete it, I think the 4.10 version should
> > also be
> > deleted because the same logic applies. Nothing uses it 4.10
> > either
> > and 4.10 is s
On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote:
> On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote:
> > > Again, that's not my decision. I can go either way. But if the
> > > decision was made to delete it, I think the 4.10 version should
> > >
On Wed, 2017-01-25 at 08:53 -0800, Michael Zoran wrote:
> On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote:
> > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote:
> > > > Again, that's not my decision. I can go either way. But if
> > > > the
>
On Wed, 2017-01-25 at 18:39 +0100, Stefan Wahren wrote:
> > Michael Zoran hat am 25. Januar 2017 um 17:53
> > geschrieben:
> >
> >
> > On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote:
> > > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote:
On Wed, 2017-01-25 at 10:09 -0800, Michael Zoran wrote:
> On Wed, 2017-01-25 at 18:39 +0100, Stefan Wahren wrote:
> > > Michael Zoran hat am 25. Januar 2017 um
> > > 17:53
> > > geschrieben:
> > Looking at the TODO shows 3 candidates: vc_mem, bcm2835-camera,
On Wed, 2017-01-25 at 12:27 -0800, Eric Anholt wrote:
> Greg KH writes:
>
> > On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote:
> > > On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote:
> > > > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michae
warnings.
Tested on a RPI 3 running in ARM64 mode with the
vlc player and alsautils.
Signed-off-by: Michael Zoran
---
drivers/staging/Kconfig| 2 +
drivers/staging/Makefile | 2 +
drivers/staging/bcm2835-audio/Kconfig | 7
On Thu, 2017-01-26 at 09:27 +0300, Dan Carpenter wrote:
> Thanks!
>
> regards,
> dan carpenter
Dan, the bcm2835-camera driver is generally very high quality code. I
was looking at it just now. Very clean compared to the driver I e-
mailed.
The camera driver does have a 64 bit issue, but for th
On Thu, 2017-01-26 at 15:56 +0300, Dan Carpenter wrote:
Send it. Absolutely.
>
> regards,
> dan carpenter
>
Does it need to compile on all platforms, or can it simply compile on
arm32 until a few small issues get worked out.
___
devel mailing list
On Thu, 2017-01-26 at 16:25 +0300, Dan Carpenter wrote:
> On Thu, Jan 26, 2017 at 05:13:02AM -0800, Michael Zoran wrote:
> > On Thu, 2017-01-26 at 15:56 +0300, Dan Carpenter wrote:
> > Send it. Absolutely.
> > >
> > > regards,
> > > dan carpenter
>
On Thu, 2017-01-26 at 13:21 +, Peter Robinson wrote:
> On Thu, Jan 26, 2017 at 12:39 AM, Michael Zoran
> wrote:
> > Initial cleanup of bcm2835-audio driver for the
> > bcm2535(Raspberry PI)
> >
> > Driver provides HDMI audio through ALSA and is built
> >
On Thu, 2017-01-26 at 14:04 +, Peter Robinson wrote:
> On Thu, Jan 26, 2017 at 1:54 PM, Michael Zoran
> wrote:
> > On Thu, 2017-01-26 at 13:21 +, Peter Robinson wrote:
> > > On Thu, Jan 26, 2017 at 12:39 AM, Michael Zoran > > net>
> > > wrote:
&
The bcm2835-audio driver has a legacy code path for initializing
devices without a device tree. Delete this code path and remove
the non device tree devices.
Signed-off-by: Michael Zoran
---
drivers/staging/bcm2835-audio/bcm2835.c | 271 +---
1 file changed, 2
perforam
some validation on the message response and call the handler function
directly instead of through the callback pointer.
Signed-off-by: Michael Zoran
---
drivers/staging/bcm2835-audio/bcm2835-pcm.c| 9 +-
drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 35
This driver makes no sense outside of ARM or ARM64.
Add an explicit build dependency on:
(ARM || ARM64 || COMPILE_TEST)
Also set the default build to n
Signed-off-by: Michael Zoran
---
drivers/staging/bcm2835-audio/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging
On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote:
> This is derived from the downstream tree's build system, but with
> just
> a single Kconfig option.
>
> For now the driver only builds on 32-bit arm -- the aarch64 build
> breaks due to the driver using arm-specific cache flushing functions.
Add a TODO list of possible cleanup items.
Signed-off-by: Michael Zoran
---
drivers/staging/bcm2835-audio/TODO | 29 +
1 file changed, 29 insertions(+)
create mode 100644 drivers/staging/bcm2835-audio/TODO
diff --git a/drivers/staging/bcm2835-audio/TODO
b/drivers
On Thu, 2017-01-26 at 12:14 -0800, Eric Anholt wrote:
> Michael Zoran writes:
>
> > The vchi_msg_queue function which is used by other drivers
> > to queue a message is difficult to understand and overly
> > generic. Remove it and replace it with two more specific
,
unsigned int size)
int
vchi_queue_user_message(VCHI_SERVICE_HANDLE_T handle,
void __user *data,
unsigned int size)
Changes:
V2 - Add missing symbol export of vchiq_queue_user_message
Signed-off-by: Michael Zoran
Reviewed-by: Eric
(VCHI_SERVICE_HANDLE_T handle,
void *data,
unsigned int size)
Signed-off-by: Michael Zoran
---
.../staging/vc04_services/interface/vchi/vchi.h| 6 ++
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 22 ++
2 files
The vchi_msg_queue function which is used by other drivers
to queue a message is difficult to understand and overly
generic.
Make the function static and remove it from the exported
symbols.
Signed-off-by: Michael Zoran
---
drivers/staging/vc04_services/interface/vchi/vchi.h| 8
(VCHI_SERVICE_HANDLE_T handle,
void __user *data,
unsigned int size)
Signed-off-by: Michael Zoran
---
.../staging/vc04_services/interface/vchi/vchi.h| 6
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 34 ++
2 files
I'm looking at linux-next:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
First it looks this is some kind of startup notification mechanism and
it is used by the custom RPI kernel on www.github.com. Client drivers
call vchiq_add_connected_callback to register for a notificati
Resending to a larger e-mail list...
On Mon, 2017-01-30 at 04:57 -0800, Michael Zoran wrote:
> I'm looking at linux-next:
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
>
> First it looks this is some kind of startup notification mechanism
> and
> i
On Mon, 2017-01-30 at 08:56 -0800, Eric Anholt wrote:
> Michael Zoran writes:
>
> > This driver makes no sense outside of ARM or ARM64.
> > Add an explicit build dependency on:
> > (ARM || ARM64 || COMPILE_TEST)
> >
> > Also set the default build to n
&
On Tue, 2017-01-31 at 00:01 +0300, Dan Carpenter wrote:
> It's hard to review this because there are no callers and the hash
> you're talking about is an RPI hash... You have no idea how lazy I
> am.
>
> You're right, that code looks racy but it's almost certainly harmless
> depending on how it's
The function vchi_msg_queue was made static in vc04_services
and replaced with vchi_queue_kernel_message.
Change the call to vchi_msg_queue to vchi_queue_kernel_message
Signed-off-by: Michael Zoran
---
.../staging/media/platform/bcm2835/mmal-vchiq.c| 23 --
1 file
The function vchi_msg_queue was made static in vc04_services
and replaced with vchi_queue_kernel_message.
Change the call to vchi_msg_queue to vchi_queue_kernel_message
Signed-off-by: Michael Zoran
---
drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 15 +++
1 file changed, 3
On Wed, 2017-02-01 at 18:04 +0100, Stefan Wahren wrote:
> Am 01.02.2017 um 15:31 schrieb Michael Zoran:
> > The function vchi_msg_queue was made static in vc04_services
> > and replaced with vchi_queue_kernel_message.
> >
> > Change the call to vchi_msg_queue t
Removed unnecessary spaces around parenthesis as reported by checkpatch.pl
Signed-off-by: Michael Rupprecht
---
drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
b
Dave: I'd personally like to see the current version of vchi stabbed,
poisoned, beaten, shot, chained and thrown in a river.:)
Would it be possible to find another transport for this driver to
remove the dependency on VCHI? Given the process of improving drivers
in stagging, I don't expect VCHI t
On Wed, 2017-02-08 at 01:19 +0300, Dan Carpenter wrote:
> On Tue, Feb 07, 2017 at 01:13:34PM -0800, Eric Anholt wrote:
> > Dan Carpenter writes:
> >
> > > There is a bunch of vc04_services that we're still looking to
> > > merge in
> > > the near future. Please hold off deleting these until we a
Emilio López writes:
> These tests are based on the libsync test suite from Android.
> This commit lays the ground for future tests, as well as includes
> tests for a variety of basic allocation commands.
Hi Emilio,
Just a few comments on the Makefile.
> diff --git a/tools/testing/selftests/sy
Emilio López writes:
> El 22/09/16 a las 06:43, Michael Ellerman escribió:
>> Emilio López writes:
>>
>> Please don't include the *kernel* headers, they're really not meant to
>> be used in userspace programs :)
>>
>>> +CFLAGS += -I../../../..
Emilio López writes:
> Hi,
>
> El 27/09/16 a las 01:23, Michael Ellerman escribió:
>> Emilio López writes:
>>> El 22/09/16 a las 06:43, Michael Ellerman escribió:
>>>> Emilio López writes:
>>>>
>>>> Please don't include
operations sent by the Hyper-V host to fail until the daemon is restarted.
Signed-off-by: Michael Gissing
---
tools/hv/hv_vss_daemon.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c
index 5d51d6f..0ecbdab 100644
--- a
On Mon, 2016-10-24 at 13:54 +0300, Dan Carpenter wrote:
> On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote:
> > From: Michael Zoran
> >
> > Signed-off-by: Michael Zoran
> > ---
> > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_
On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote:
> On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote:
> > I didn't think it looked totally correct, but I'm not sure it's any
> > more broken then what is already in the tree.
>
> It's
On Mon, 2016-10-24 at 14:58 +0300, Dan Carpenter wrote:
> On Mon, Oct 24, 2016 at 04:39:49AM -0700, Michael Zoran wrote:
> > On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote:
> > > On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote:
> > > > I didn
On Mon, 2016-10-24 at 15:24 +0200, Greg KH wrote:
> On Sun, Oct 23, 2016 at 10:29:32PM -0700, mzo...@crowfest.net wrote:
> > From: Michael Zoran
> >
> > The original arm implementation uses dmac_map_area which is not
> > portable. Replace it with an architecture neu
On Mon, 2016-10-24 at 15:23 +0200, Greg KH wrote:
> On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote:
> > From: Michael Zoran
> >
> > Signed-off-by: Michael Zoran
> > ---
> > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
At this point, I need to take a step back from this whole thing and
evaluate where this is all going. I started this arm64 thing for fun
as a tinker idea, and it is quickly becoming more then I think I want
to get involved with at this time.
I'm not saying I won't return to this at a later time o
On Tue, 2016-10-25 at 08:00 -0700, Michael Zoran wrote:
> On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote:
> > mzo...@crowfest.net writes:
> >
> > > */
> > >
> > > static int
> > > create_pagelist(char __user *buf, size_t count, un
On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote:
> mzo...@crowfest.net writes:
>
> > */
> >
> > static int
> > create_pagelist(char __user *buf, size_t count, unsigned short
> > type,
> > - struct task_struct *task, PAGELIST_T ** ppagelist)
> > + struct task_struct *task, PAG
On Tue, 2016-10-25 at 09:16 -0700, Eric Anholt wrote:
> Michael Zoran writes:
>
> > On Tue, 2016-10-25 at 08:00 -0700, Michael Zoran wrote:
> > > On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote:
> > > > mzo...@crowfest.net writes:
> > > >
&g
edback from Eric Anholt .
Signed-off-by: Michael Zoran
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 152 +
1 file changed, 93 insertions(+), 59 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
b/drivers/staging/vc04_se
this cleanup could have been broken down to chunks,
all the changes are to a single file and submitting it as a single
related change should make reviewing the diff much easier then if it
were submitted piecemeal.
Signed-off-by: Michael Zoran
---
.../interface/vchiq_arm/vchiq_2835_arm.c
On Fri, 2016-10-28 at 11:31 -0400, Greg KH wrote:
> On Fri, Oct 28, 2016 at 08:16:51AM -0700, Michael Zoran wrote:
> > The conversion to dma_map_sg left a few loose ends. This change
> > ties up those loose ends.
> >
> > 1. Settings the DMA mask is mandatory on 6
On Fri, 2016-10-28 at 11:42 -0400, Greg KH wrote:
> On Fri, Oct 28, 2016 at 08:36:34AM -0700, Michael Zoran wrote:
> > On Fri, 2016-10-28 at 11:31 -0400, Greg KH wrote:
> > > On Fri, Oct 28, 2016 at 08:16:51AM -0700, Michael Zoran wrote:
> > > > The conversion to dm
Setting the DMA mask is optional on 32 bit but
is mandatory on 64 bit. Set the DMA mask and coherent
to force all DMA to be in the 32 bit address space.
This is considered a "good practice" and most drivers
already do this.
Signed-off-by: Michael Zoran
---
.../staging/vc04_services
st element and ensure
the chain end is marked.
Signed-off-by: Michael Zoran
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
b/drivers/staging/vc0
s were not implemented anyway so no need to fix them. It's
easier to just remove them.
Signed-off-by: Michael Zoran
---
.../staging/vc04_services/interface/vchi/vchi.h| 25 +-
.../interface/vchiq_arm/vchiq_2835_arm.c | 11 -
.../vc04_services/interface/vchiq_arm/vch
Signed-off-by: Michael Zoran
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 223 +++--
1 file changed, 113 insertions(+), 110 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
b/drivers/staging/vc04_services/interface/vchiq_arm
801 - 900 of 1079 matches
Mail list logo
