Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote: > Michael Zoran writes: > > > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > > > Michael Zoran writes: > > > > > > > > > Since the API is completely documented, I see

Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

On Tue, 2017-03-21 at 12:09 -0700, Michael Zoran wrote: > On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote: > > Michael Zoran writes: > > > > > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > > > > Michael Zoran writes: > > > > >

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

On Tue, 2017-03-21 at 23:30 +0300, Dan Carpenter wrote: > I've read Stefan's review comments and intervened where I didn't > understand them.  The recent ones are very specific and reasonable... > > Just send a v2.  I don't get what the deal is... Partly because Eric and Stefan have publically an

[PATCH char-misc 1/1] x86/hyperv: Add interrupt handler annotations

Add standard interrupt handler annotations to hyperv_vector_handler(). Signed-off-by: Michael Kelley --- arch/x86/kernel/cpu/mshyperv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index 4488cf0..20f6849

[PATCH 1/1] scsi: storvsc: Avoid allocating memory for temp cpumasks

Current code allocates 240 Kbytes (in typical configs) for each synthetic SCSI controller to use as temp cpumask variables. Recode to avoid needing the temp cpumask variables and remove the memory allocation. Signed-off-by: Michael Kelley --- This patch is for the 4.18/scsi-queue branch and

[PATCH 4/5] Drivers: hv: vmbus: Add hooks for per-CPU IRQ

ff-by: Michael Kelley Reviewed-by: James Morris --- arch/x86/include/asm/mshyperv.h | 4 drivers/hv/hv.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h index 3cd1431..27d0e83 100644 --- a/arch/x86/includ

[PATCH 5/5] Drivers: hv: Enable CONFIG_HYPERV on ARM64

Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on ARM64, causing the Hyper-V specific code to be built. Signed-off-by: Michael Kelley Reviewed-by: James Morris --- drivers/hv/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hv/Kconfig b/drivers

[PATCH 2/5] arm64: hyperv: Add core Hyper-V include files

formally published. The TLFS is available here: docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/reference/tlfs mshyperv.h defines Linux-specific structures and routines for interacting with Hyper-V on ARM64. Signed-off-by: Michael Kelley Reviewed-by: James Morris --- MAINTAINERS

[PATCH 1/5] arm64: mm: Add slow_virt_to_phys()

Add slow_virt_to_phys() function for ARM64 that parallels the same function on x86/x64. This is needed by the architecture independent Hyper-V VMbus driver at drivers/hv/channel.c. The implementation directly translates the virtual address using the ARM64 'at' instruction. Signed-off-b

[PATCH 0/5] Enable Linux guests on Hyper-V on ARM64

hing more generic, so the code uses the Hyper-V terminology. This will be fixed when Hyper-V updates the usage in the TLFS. Michael Kelley (5): arm64: mm: Add slow_virt_to_phys() arm64: hyperv: Add core Hyper-V include files arm64: hyperv: Add support for Hyper-V as a hypervisor Drivers:

[PATCH 3/5] arm64: hyperv: Add support for Hyper-V as a hypervisor

This code is architecture dependent code and is mostly driven by architecture independent code in the VMbus driver in drivers/hv/hv.c and drivers/hv/vmbus_drv.c. This code is built only when CONFIG_HYPERV is enabled. Signed-off-by: Michael Kelley Reviewed-by: James Morris --- MAINTA

[PATCH] staging: rtl8723bs: fix comparsion to NULL - coding style

Fix comparsion to NULL issues found by checkpatch. Use !x instead of x == NULL. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers

[PATCH] staging: rtl8723bs: fix brace coding style issues

Remove braces from single line if statements. Also fix a comparsion to NULL in one of the conditions. Issues found by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_debug.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH] staging: rtl8723bs: remove rtw_set_tx_chksum_offload()

The function rtw_set_tx_chksum_offload() has empty definition. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 -- drivers/staging/rtl8723bs/include/xmit_osdep.h | 2 -- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 5 - 3 files changed, 9 deletions

[PATCH] staging: rtl8723bs: do not use assignment in if condition

Fix checkpatch error 'do not use assignment in if condition'. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging

Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition

On 06/22/18 12:57, Dan Carpenter wrote: On Fri, Jun 22, 2018 at 03:54:22AM -0700, Joe Perches wrote: On Fri, 2018-06-22 at 13:40 +0300, Dan Carpenter wrote: On Thu, Jun 21, 2018 at 08:22:30PM +0200, Michael Straube wrote: Fix checkpatch error 'do not use assignment in if condition'.

Re: [PATCH] staging: rtl8723bs: fix brace coding style issues

"%u", &g_wait_hiq_empty) != 1) return -EINVAL; return count; regards, dan carpenter Regards, Michael ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition

On 06/22/18 19:28, Joe Perches wrote: On Fri, 2018-06-22 at 14:48 +0200, Michael Straube wrote: On 06/22/18 12:57, Dan Carpenter wrote: On Fri, Jun 22, 2018 at 03:54:22AM -0700, Joe Perches wrote: On Fri, 2018-06-22 at 13:40 +0300, Dan Carpenter wrote: On Thu, Jun 21, 2018 at 08:22:30PM

[PATCH] staging: rtl8723bs: refactor rtw_macaddr_cfg()

ress use a random one to reduce the likelihood of mac address collision. Thanks to Joe Perches and Dan Carpenter. Signed-off-by: Michael Straube --- .../staging/rtl8723bs/core/rtw_ieee80211.c| 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drive

Re: [PATCH v4 00/13] staging: lustre: lnet: code cleanups

Hm, that's unfortunate - but my own fault for lack of proper etiquette. I'll give this a week or two to settle, and build up patches against other parts of lustre in the meantime. BTW, you keep mentioning a v5 that I sent. Where is that, exactly? The last round of patches I sent I've kept labele

Re: [PATCH v4 00/13] staging: lustre: lnet: code cleanups

Thanks for the explanation. -- Mike Shuey On Sat, May 23, 2015 at 8:39 AM, Sudip Mukherjee wrote: > On Sat, May 23, 2015 at 08:09:54AM -0400, Michael Shuey wrote: >> BTW, you keep mentioning a v5 that I sent. Where is that, exactly? >> The last round of patches I sent I've k

[PATCH 3/3] staging: rtl8188eu: remove return variable from rtw_pwr_unassociated_idle

Function rtw_pwr_unassociated_idle returns boolean values. Remove the return variable ret and the exit label to simplify the function a little bit. Return true or false directly instead. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 10 +++--- 1 file

[PATCH 1/3] staging: rtl8188eu: remove unnecessary parentheses in rtw_pwrctrl.c

Remove unnecessary parentheses reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core

[PATCH 2/3] staging: rtl8188eu: cleanup declarations in rtw_pwrctrl.c

Replace tabs with spaces in declarations to cleanup whitespace. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging

[PATCH] staging: rtl8188eu: use break to exit while loop

The variable bContinual in Efuse_PgPacketRead() is only used to break out of a while loop. Remove the variable and use break instead. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH] staging/vc04_services/bcm2835-camera: distinct numeration and names for devices

Create a static atomic counter for numerating cameras. Use the Media Subsystem Kernel Internal API to create distinct device-names, so that the camera-number (given by the counter) matches the camera-name. Co-developed-by: Kay Friedrich Signed-off-by: Kay Friedrich Signed-off-by: Michael Kupfer

Re: [PATCH] media: allegro: add the missed check for v4l2_m2m_ctx_init

On Mon, 09 Dec 2019 16:58:07 +0800, Chuhong Yuan wrote: > allegro_open() misses a check for v4l2_m2m_ctx_init(). > Add a check and error handling code to fix it. > > Fixes: f20387dfd065 ("media: allegro: add Allegro DVT video IP core driver") > Signed-off-by: Chuhong Yu

[PATCH 2/2] staging: rtl8188eu: add spaces around operators in rtw_mlme_ext.c

Add missing spaces around operators to improve readability and clear checkpatch issues. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 113 +- 1 file changed, 57 insertions(+), 56 deletions(-) diff --git a/drivers/staging/rtl8188eu/core

[PATCH 1/2] staging: rtl8188eu: cleanup comparsions to NULL in rtw_mlme_ext.c

Cleanup comparsions to NULL reported by checkpatch. if (x == NULL) -> if (!x) if (x != NULL) -> if (x) Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 38 +-- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/s

[PATCH] staging: rtl8188eu: use break to exit while loop

The variable bContinual in Efuse_PgPacketRead() is only used to break out of a while loop. Remove the variable and use break instead. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH] staging: rtl8188eu: Add device code for TP-Link TL-WN727N v5.21

This device was added to the stand-alone driver on github. Add it to the staging driver as well. Link: https://github.com/lwfinger/rtl8188eu/commit/b9b537aa25a8 Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH 1/2] staging: rtl8188eu: remove else after return

Remove else after return in rtl88eu_dm_antenna_diversity() to improve readability and clear a checkpatch warning. WARNING: else is not generally useful after a break or return Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 26 +++- 1 file

[PATCH 2/2] staging: rtl8188eu: refactor rtl88eu_dm_update_rx_idle_ant()

Refactor rtl88eu_dm_update_rx_idle_ant() to reduce indentation level and clear line over 80 characters checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 56 ++-- 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a

[PATCH] staging: rtl8723bs: remove ODM_GetRightChnlPlaceforIQK()

exist. Remove ODM_GetRightChnlPlaceforIQK() and replace the uses of the return value with zero. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/HalPhyRf.c | 30 --- drivers/staging/rtl8723bs/hal/HalPhyRf.h | 8 - .../staging/rtl8723

[PATCH] staging: rtl8188eu: remove unused parameters from rtw_check_network_type

4688 416047 6592f drivers/staging/rtl8188eu/r8188eu.o Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ap.c| 4 ++-- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 2 +- drivers/staging/rtl8188eu/include/ieee80211.h | 2 +- 3 files changed, 4 insertions(+), 4 dele

[PATCH 3/5] staging: rtl8188eu: cleanup long lines in rtl8188e_dm.c

Cleanup lines over 80 characters in rtl8188e_dm.c by adding appropriate line breaks. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 26 ++--- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH 2/5] staging: rtl8188eu: convert rtw_hal_antdiv_before_linked() to bool

Function rtw_hal_antdiv_before_linked() returns boolean values, so change the return type from u8 to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +- drivers/staging/rtl8188eu/include/hal_intf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[PATCH 1/5] staging: rtl8188eu: refactor rtw_hal_antdiv_before_linked()

Refactor rtw_hal_antdiv_before_linked() to clear checkpatch warnings. WARNING: line over 80 characters WARNING: else is not generally useful after a break or return Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 17 + 1 file changed, 9

[PATCH 4/5] staging: rtl8188eu: remove unnecessary parentheses in rtl8188e_dm.c

Remove unnecessary parentheses reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal

[PATCH 5/5] staging: rtl8188eu: cleanup whitespace in rtl8188e_dm.c

Replace tabs with spaces and/or remove spaces to use typical kernel horizontal whitespace. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 44 ++--- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH 3/3] staging: rtl8188eu: remove unused enum and defines

IQK_BB_REG_NUM_MAX, RTL8711_RF_MAX_SENS, RTL8711_RF_DEF_SENS, NUM_REGULATORYS and enum _RTL8712_RF_MIMO_CONFIG_ are not used in the driver code, remove them. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/odm.h| 1 - drivers/staging/rtl8188eu/include/rtw_rf.h | 16

[PATCH 2/3] staging: rtl8188eu: remove redundant defines

Remove redundant defines from hal8188e_phy_cfg.h and rtl8188e_dm.h. All of them are defined in odm.h with the same values. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/hal8188e_phy_cfg.h | 5 - drivers/staging/rtl8188eu/include/rtl8188e_dm.h | 7 +-- 2 files

[PATCH 1/3] staging: rtl8188eu: remove else after break or return

Remove unnecessary else after break or return to improve readability and clear checkpatch warnings. WARNING: else is not generally useful after a break or return Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_efuse.c| 9 ++-- .../staging/rtl8188eu/core/rtw_ieee80211

[PATCH 1/3] staging: rtl8192e: simplify rtl92e_evm_db_to_percent()

Use clamp() to simplify function rtl92e_evm_db_to_percent() and reduce object file size. Signed-off-by: Michael Straube --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c

[PATCH 3/3] staging: rtl8712: simplify evm_db2percentage()

Use clamp() to simplify function evm_db2percentage() and reduce object file size. Signed-off-by: Michael Straube --- drivers/staging/rtl8712/rtl8712_recv.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging

[PATCH 2/3] staging: rtl8192u: simplify rtl819x_evm_dbtopercentage()

Use clamp() to simplify function rtl819x_evm_dbtopercentage() and reduce object file size. Signed-off-by: Michael Straube --- drivers/staging/rtl8192u/r8192U_core.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers

Re: [PATCH v3] media: allegro: add missed checks in allegro_open()

)) { > + ret = PTR_ERR(channel->fh.m2m_ctx); > + goto error; > + } > + > + v4l2_fh_init(&channel->fh, vdev); This call sets channel->fh.ctrl_handler to vdev->ctrl_handler, which has previously been overriden by the driver t

Re: [PATCH v3] media: allegro: add missed checks in allegro_open()

On Tue, 21 Jan 2020 19:59:46 +0800, Chuhong Yuan wrote: > On Tue, Jan 21, 2020 at 4:23 PM Michael Tretter > wrote: > > > > On Mon, 13 Jan 2020 13:59:51 +0800, Chuhong Yuan wrote: > > > allegro_open() misses checks for v4l2_m2m_ctx_init() and results of > >

Re: [PATCH] media: allegro: fix spelling mistake "to" -> "too"

On Thu, 23 Jan 2020 01:06:43 +, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a v4l2_err message. Fix it. > > Signed-off-by: Colin Ian King Reviewed-by: Michael Tretter > --- > drivers/staging/media/allegro-dvt/allegro-core.c | 2 +-

[PATCH] staging: rtl8188eu: remove unnecessary RETURN label

Remove unnecessary RETURN label and use return directly instead. Since the return type of rtw_free_netdev() is void, remove the return at the end of the function. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 10 +++--- 1 file changed, 3 insertions

[PATCH] staging: rtl8188eu: rename variable pnetdev -> netdev

Rename the local variable pnetdev in rtw_alloc_etherdev_with_old_priv to avoid hungarian notation and clear the last checkpatch warning in the file osdep_service.c. rtl8188eu/os_dep/osdep_service.c:32: WARNING: line over 80 characters Signed-off-by: Michael Straube --- drivers/staging

Wohltätigkeitsspende von 2.000.000 Millionen Euro

Lieber Freund, Ich bin Herr Mike Weirsky, New Jersey, Vereinigte Staaten von Amerika, der Mega-Gewinner von $ 273million In Mega Millions Jackpot, spende ich an 5 zufällige Personen, wenn Sie diese E-Mail erhalten, dann wurde Ihre E-Mail nach einem Spinball ausgewählt.Ich habe den größten Teil

[PATCH] staging: rtl8188eu: Add device id for MERCUSYS MW150US v2

This device was added to the stand-alone driver on github. Add it to the staging driver as well. Link: https://github.com/lwfinger/rtl8188eu/commit/2141f244c3e7 Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH] staging: rtl8188eu: remove some 5 GHz code

off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c b/drivers/staging/rtl8188eu/core/rtw_ieee80211.c index 29f615443e8f..e186982d5908 100644 --- a/d

[PATCH] staging: rtl8188eu: cleanup long line in odm.c

Cleanup line over 80 characters by removing unnecessary parentheses. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index

[PATCH v2] staging: rtl8188eu: cleanup long line in odm.c

Cleanup line over 80 characters by removing unnecessary test 'pDM_Odm->RSSI_Min <= 25'. The above test 'pDM_Odm->RSSI_Min > 25' already guarantees that it is <= 25. Signed-off-by: Michael Straube --- v1 -> v2: Remove 'pDM_Odm->RSSI_Min <= 25'

Re: [PATCH] staging: rtl8188eu: cleanup long line in odm.c

On 2020-03-26 01:08, Joe Perches wrote: On Wed, 2020-03-25 at 22:59 +0100, Michael Straube wrote: Cleanup line over 80 characters by removing unnecessary parentheses. [] diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c [] @@ -590,7 +590,7 @@ void

[PATCH] staging: rtl8188eu: remove unnecessary parentheses

Remove all remaining unnecessary parentheses reported by checkpatch. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_ieee80211.c| 4 +- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 +- drivers/staging/rtl8188eu/hal/odm.c | 52 +- drivers/staging

[PATCH] staging: rtl8188eu: refactor Efuse_GetCurrentSize()

Refactor while loop in Efuse_GetCurrentSize() to reduce indentation level and clear line over 80 characters checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 33 +++--- 1 file changed, 16 insertions(+), 17 deletions(-) diff

[PATCH 2/2] staging: rtl8188eu: remove unnecessary variable

The variable 'bStopBlinking' is used in if tests immediately after its value is set. Use the conditions for setting 'bStopBlinking' diretly in the subsequent if tests and remove the variable. Slightly reduces object file size by 16 bytes (gcc 9.2.1 x86_64). Signed-off

[PATCH 1/2] staging: rtl8188eu: remove unnecessary asignment

Remove unnecessary asignment in SwLedBlink1(). The code path with the asignment 'pLed->BlinkTimes = 0' is only executed when 'pLed->BlinkTimes' is already zero and the value is not changed between the test 'if (pLed->BlinkTimes == 0)' and the asi

[PATCH] staging: rtl8188eu: remove 5 GHz if test

-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c index bce777e4bf6c..8d035f67ef61 100644 --- a/drivers/stag

[PATCH 0/3] staging: rtl8188eu: checkpatch cleanups in hal/fw.c

This series clears the last remaining checkpatch issues in the file hal/fw.c. Michael Straube (3): staging: rtl8188eu: rename define to upper case staging: rtl8188eu: cleanup long line in fw.c staging: rtl8188eu: make const char array static drivers/staging/rtl8188eu/hal/fw.c

[PATCH 2/3] staging: rtl8188eu: cleanup long line in fw.c

Add line break to avoid line length over 80 characters. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/fw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index dbf7883f9ed7

[PATCH 3/3] staging: rtl8188eu: make const char array static

Make const char array 'fw_name' static. Clears a checkpatch warning and reduces object file size by 17 bytes (gcc 9.3.1 x86_64). WARNING: const array should probably be static const Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/fw.c | 2 +- 1 file changed, 1 inser

[PATCH 1/3] staging: rtl8188eu: rename define to upper case

Rename 'FWDL_ChkSum_rpt' to 'FWDL_CHKSUM_RPT' as defines are normaly named all upper case. Also clears a camel case checkpatch warning. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/fw.c| 4 ++-- drivers/staging/rtl8188eu/include/rtl81

[PATCH] staging: rtl8712: correct spelling mistake in comment

Correct a spelling mistake discovered by checkpatch. attatch -> attach Signed-off-by: Michael Straube --- drivers/staging/rtl8712/usb_halinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/usb_halinit.c b/drivers/staging/rtl8712/usb_halini

[PATCH] staging: rtl8188eu: remove some superfluous comments

Remove some obviously superflous comments. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/odm.c | 2 -- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 2 -- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 --- 3 files changed, 7 deletions(-) diff --git a/drivers

Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

Hi Laurent, On 02/20/2014 12:36 PM, Laurent Pinchart wrote: > Hi Michael, > > What's the status of this patch ? Do expect Prabhakar to pick it up, or do > you > plan to push all your IRQF_DISABLED removal patches in one go ? It's true a good number of my patches haven&#

Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

Hi Prabhakar On 02/25/2014 07:02 AM, Prabhakar Lad wrote: > Hi Michael, > > On Mon, Feb 24, 2014 at 11:01 AM, Prabhakar Lad > wrote: >> Hi Michael, >> >> On Thu, Feb 20, 2014 at 6:47 PM, Michael Opdenacker >> wrote: >>> Hi Laurent, >>> >&

[PATCH] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

27;pmc_init_seeprom' was not declared. Should it be static? drivers/staging/cxt1e1/pmc93x6_eeprom.c:521:1: warning: symbol 'pmc_verify_cksum' was not declared. Should it be static? Also incorporates many indentation and coding style fixes as well as the removal of a volatile varia

[PATCH r2 0/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

This patch series resolves the following sparse warnings: CHECK drivers/staging/cxt1e1/pmc93x6_eeprom.c drivers/staging/cxt1e1/pmc93x6_eeprom.c:158:1: warning: symbol 'eeprom_put_byte' was not declared. Should it be static? drivers/staging/cxt1e1/pmc93x6_eeprom.c:183:1: warning: symbol 'eepr

[PATCH r2 1/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Removes sparse warnings. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 78cc170..e16f0d6 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -28,6 +28,7

[PATCH r2 2/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Indentation fixes using Lindent. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index e16f0d6..a027708 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -44,10

[PATCH r2 3/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Comment block fixes. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index a027708..572bd2e 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -49,10 +49,10

[PATCH r2 4/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Removes volatile variable. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 572bd2e..ab6fa73 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -286,7 +286,7

[PATCH r2 5/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Removes spaces before & where needed. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index ab6fa73..d7d240a 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eepr

[PATCH r2 6/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Removes parens as are not necessary for return. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index d7d240a..6153499 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1

[PATCH r2 7/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Removes unncessary curly braces. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 6153499..ba588f1 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -133,9

Re: [PATCH r2 0/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

On Sun, Mar 23, 2014 at 08:58:21AM -0700, Greg Kroah-Hartman wrote: > On Sun, Mar 23, 2014 at 09:01:48AM -0500, Michael Welling wrote: > > This patch series resolves the following sparse warnings: > > > > CHECK drivers/staging/cxt1e1/pmc93x6_eeprom.c >

[PATCH v3 0/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

This patch series resolves the following sparse warnings: CHECK drivers/staging/cxt1e1/pmc93x6_eeprom.c drivers/staging/cxt1e1/pmc93x6_eeprom.c:158:1: warning: symbol 'eeprom_put_byte' was not declared. Should it be static? drivers/staging/cxt1e1/pmc93x6_eeprom.c:183:1: warning: symbol 'eepr

[PATCH v3 1/7] STAGING: cxt1e1: Remove sparse warnings

Removes sparse warnings by including a header and adding static to some functions. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 78cc170..e16f0d6 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b

[PATCH v3 2/7] STAGING: cxt1e1: Indentation fixes

Indentation fixes using Lindent. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index e16f0d6..a027708 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -44,10

[PATCH v3 3/7] STAGING: cxt1e1: Fixes comment blocks

Comment block fixes. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index a027708..572bd2e 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -49,10 +49,10

[PATCH v3 4/7] STAGING: cxt1e1: Remove volatile variable

Removes volatile variable. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 572bd2e..ab6fa73 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -286,7 +286,7

[PATCH v3 5/7] STAGING: cxt1e1: Formatting fixes checkpatch issues

Removes spaces before & where needed. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index ab6fa73..d7d240a 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eepr

[PATCH v3 6/7] STAGING: cxt1e1: More formatting fixes

Removes parens as are not necessary for return. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index d7d240a..6153499 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1

[PATCH v3 7/7] STAGING: cxt1e1: Remove curly braces

Removes unnecessary curly braces from for loop in eeprom_delay. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 6153499..ba588f1 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging

[PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

Add direct #include statements for declarations of csum_tcpudp_magic() and csum_ipv6_magic(). While the needed #include's are picked up indirectly for the x86 architecture, they aren't on other architectures, resulting in compile errors. Signed-off-by: Michael Kelley --- drivers/

Re: [PATCH] staging: vboxvideo: Add vboxvideo to drivers/staging

f-by from teh virtual box developers here that they are ok with this work happening? Michael, can you reply with your S-o-b please ? I haven't gone through your patch yet, but on the assumption that it matches what is in our repository plus the white-space changes you sent last night you have my

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

not trying to argue here, just to get an idea for my own planning. Regards Michael Dave. -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

ould be explained by waiting for a moderator, though I don't get a warning that the message is waiting for approval. For now we have disabled that on vbox-dev too (I assume that was the list you meant). Regards Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

style throws a bit of a spanner in that). Please be clear, I am not trying to dictate to anyone. The code is GPL, it is fine to include it with whatever modifications you deem appropriate. Since individual distributions are already doing that, it will still simplify our life somewhat if it is

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

ports to its stable kernels. Regards Michael [...] -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

13.06.2017 15:59, Greg Kroah-Hartman wrote: > On Tue, Jun 13, 2017 at 03:45:14PM +0200, Michael Thayer wrote: >> 13.06.2017 14:48, Greg Kroah-Hartman wrote: >> [Discussion of vboxvideo coding style.] >>> Once your code is accepted into the main kernel tree, why would you &g

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

as the subject is relevant to it. Regards, and sorry for the annoyance Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgerich

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

nversion to Atomic would probably have to happen at some time or another anyway. I have put that off (out-of-tree) so far because I was tracking the AST driver as closely as possible as the simplest way of picking up fixes, and because Dave, who wrote that, knows much more about drm drivers

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

d-up code? Of course, I am open to patches or suggestions as to how to simplify the code in our repository as long as they do not affect other platforms (vboxguest builds and runs for five different operating system kernels). Regards Michael > Regards, > > Hans -- Michael Thayer | Virt

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

small as possible will make sense for me. Regards Michael [...] -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht Münch

[PATCH 2/6] staging: rtl8712: Coding style: Make use of BIT macro

* Replace all occurences of (1< --- drivers/staging/rtl8712/ieee80211.h | 92 ++--- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.h b/drivers/staging/rtl8712/ieee80211.h index bba978e..8ca3444 100644 --- a/drivers

<    3   4   5   6   7   8   9   10   11   >