On Fri, Nov 06, 2015 at 07:25:31PM -0800, Greg KH wrote:
> On Fri, Nov 06, 2015 at 08:07:06PM -0500, Jubin John wrote:
> > --- a/drivers/staging/rdma/hfi1/hfi.h
> > +++ b/drivers/staging/rdma/hfi1/hfi.h
> > @@ -1084,6 +1084,10 @@ struct hfi1_devdata {
> > /* Save
likely(vl >= num_vls)) {
>
> Can you prove that unlikely() makes a measured difference here? If not,
> please remove it. If you can, please provide the proof in the changelog
> when you resend it.
Unfortunately, I can't prove this so will remove in v2.
Thanks,
Jubin John
_
Updated these 2 patches based on feedback received.
Changes in v2:
- Removed volatile for receive context tail dummy address
- Removed unlikely() in sdma_select_engine_vl()
Ira Weiny (1):
staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid
Mark F. Brown (1):
staging/rdma/
: Ira Weiny
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/sdma.c | 12 ++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/sdma.c b/drivers/staging/rdma/hfi1/sdma.c
index 2a1da21..d7982a7 100644
--- a/drivers/staging/rdma/hfi1/sdma.c
Signed-off-by: Mark F. Brown
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 18 +++---
drivers/staging/rdma/hfi1/hfi.h |4
drivers/staging/rdma/hfi1/init.c | 28
3 files changed, 47 insertions(+), 3 deletions(-)
diff --git a
This patch fixes the checkpatch issue:
CHECK: Prefer using the BIT macro
Reviewed-by: Dean Luick
Reviewed-by: Ira Weiny
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.h | 48 ++--
drivers/staging/rdma/hfi1
From: Mark F. Brown
The krcvqs parameter is displayed incorrectly in sysfs.
The workaround is to set the param type as uint.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Mitko Haralanov
Signed-off-by: Mark F. Brown
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/hfi.h |2
Change the default number of krcvqs to number of numa nodes + 1
based on the performance data collected.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rdma
-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 31 ---
1 files changed, 24 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c
index e489819..16302d6 100644
--- a/drivers
Space between concantenated string elements is more human
readable and fixes the checkpatch issue:
CHECK: Concatenated strings should use spaces between elements
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 10 +-
drivers/staging
From: Harish Chegondi
This would reduce L2 cache misses on s_sde in the _hfi1_schedule_send
function when invoked from post_send thereby improving performance of
post_send.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Harish Chegondi
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1
Marciniszyn
Signed-off-by: Vennila Megavannan
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 110 +++-
drivers/staging/rdma/hfi1/chip.h |5 +
drivers/staging/rdma/hfi1/chip_registers.h |1 +
drivers/staging/rdma/hfi1/hfi.h
From: Dean Luick
Read an EFI variable for the device description. Create the
infrastructure for additional variable reads.
Reviewed-by: Easwar Hariharan
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/Makefile |2 +-
drivers/staging/rdma/hfi1/chip.c
From: Dean Luick
The variable "index" increments the same as dd->ndevcntrs.
Just use the later. Remove uneeded usage of "index" in the
fill loop - it is not used there or later in the function.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: J
: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/eprom.c| 119 +++---
drivers/staging/rdma/hfi1/file_ops.c | 18 ++
include/uapi/rdma/hfi/hfi1_user.h| 10 +--
3 files changed, 77 insertions(+), 70
From: Ira Weiny
Rcv bubbles were improperly calculated for HFIs, fix that here.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Arthur Kepner
Signed-off-by: Ira Weiny
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/mad.c | 64 +-
1 files changed, 2
From: Vennila Megavannan
Removed the RxCtxRHQS counter being dumped into dev_cntrs
Reviewed-by: Dennis Dalessandro
Signed-off-by: Vennila Megavannan
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |2 --
drivers/staging/rdma/hfi1/chip.h |1
From: Mike Marciniszyn
The current is_bx() will incorrectly match on other steppings.
is_a0() is removed in favor of is_ax().
Reviewed-by: Mark Debbage
Signed-off-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 46
On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote:
> On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote:
> > This patch fixes the checkpatch issue:
> > CHECK: Prefer using the BIT macro
> >
> > Reviewed-by: Dean Luick
> > Reviewed-by:
On Fri, Nov 13, 2015 at 11:09:22AM -0500, Jubin John wrote:
> On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote:
> > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote:
> > > This patch fixes the checkpatch issue:
> > > CHECK: Prefer using the BIT
On Fri, Nov 13, 2015 at 01:03:44PM -0500, Jubin John wrote:
> On Fri, Nov 13, 2015 at 11:09:22AM -0500, Jubin John wrote:
> > On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote:
> > > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote:
> > > > T
From: Dean Luick
Add aeth name syndrome decode
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/trace.c | 29 ++---
1 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rdma
From: Edward Mascarenhas
Clean up comments
Reviewed-by: Mike Marciniszyn
Signed-off-by: Edward Mascarenhas
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |1 -
drivers/staging/rdma/hfi1/driver.c |2 +-
drivers/staging/rdma/hfi1/hfi.h|4 ++--
drivers/staging
From: Kaike Wan
This patch fixes a few qp.h comments.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Kaike Wan
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/qp.h |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/qp.h b/drivers
From: Dean Luick
Add support for an automatic fallback for firmware names.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/firmware.c | 189 --
1 files changed, 157 insertions(+), 32 deletions
From: Dean Luick
Add CNP opcode decode
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/trace.h |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/trace.h
b/drivers/staging/rdma
From: Dean Luick
Add one-time LCB reset on driver load to pre-emptively work
around any LCB power cycle issues.
Reviewed-by: Easwar Hariharan
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 20
drivers/staging/rdma
Enabling CONFIG_SDMA_VERBOSITY exposes a timing issue in the
driver/DC firmware. Removing the CCE_INT_* CSR reads from
sdma_dumpstate and a sdma_dumpstate call from the sdma_sendctrl()
works around the issue
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1
From: Dean Luick
An SPC freeze is not an error. Remove the messages.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rdma/hfi1
-off-by: Jubin John
---
drivers/staging/rdma/hfi1/mad.c | 32
1 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/mad.c b/drivers/staging/rdma/hfi1/mad.c
index 32f7037..e151359 100644
--- a/drivers/staging/rdma/hfi1/mad.c
+++ b
From: Harish Chegondi
Currently, if hfi1_register_ib_device() call is unsuccessful, workqueues
are not being destroyed before bailing out. This patch fixes this issue.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Harish Chegondi
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1
From: Dean Luick
When sending a diagnostic packet, if the send context does not
have enough room, force a credit return and try again.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/diag.c |8
1 files changed, 8
From: Dean Luick
The longest quiet timeout is now 6s. Extend the driver wait.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers
From: Dean Luick
Only warn when link up pkeys are not what we expect. Also, allow
for the pkey to already be initialized.
Reviewed-by: Arthur Kepner
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |8
1 files changed, 4 insertions(+), 4
From: Dean Luick
Change reported unknown frame messages into a counter.
These are informational, no errors.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 18 ++
drivers/staging/rdma/hfi1/chip.h
From: Dean Luick
Correctly reduce the number of VLs when limited by the number
of SDMA engines.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git
-by: Dean Luick
Reviewed-by: Arthur Kepner
Signed-off-by: Harish Chegondi
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c
index f26b9d5
d-by: Mike Marciniszyn
Signed-off-by: Andrea Lowe
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/mad.c | 38 ++
1 files changed, 26 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/mad.c b/drivers/staging/rdma/hfi1/mad.c
ind
From: Joel Rosenzweig
Provides error status counters for CceErrStatus, Send*ErrStatus,
RcvErrStatus and MISC_ERR_STATUS
Reviewed-by: Mitko Haralanov
Reviewed-by: Mike Marciniszyn
Signed-off-by: Joel Rosenzweig
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 3185
On Sat, Nov 14, 2015 at 12:41:02PM +0530, Sudip Mukherjee wrote:
> On Fri, Nov 13, 2015 at 11:09:22AM -0500, Jubin John wrote:
> > On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote:
> > > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote:
> >
On Wed, Nov 11, 2015 at 11:22:15AM +0300, Dan Carpenter wrote:
> On Wed, Nov 11, 2015 at 02:33:30AM -0500, Jubin John wrote:
> > @@ -8288,6 +8367,21 @@ static int init_cntrs(struct hfi1_devdata *dd)
> > dd->ndevcntrs++;
> >
staging/rdma/hfi1: Adjust EPROM partitions, add EPROM commands
Harish Chegondi (1):
staging/rdma/hfi1: Move s_sde to the read mostly portion of the
hfi1_qp structure
Ira Weiny (1):
staging/rdma/hfi1: Remove rcv bubbles code
Jubin John (3):
staging/rdma/hfi1: Use BIT macro
sta
From: Harish Chegondi
This would reduce L2 cache misses on s_sde in the _hfi1_schedule_send
function when invoked from post_send thereby improving performance of
post_send.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Harish Chegondi
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1
From: Vennila Megavannan
Removed the RxCtxRHQS counter being dumped into dev_cntrs
Reviewed-by: Dennis Dalessandro
Signed-off-by: Vennila Megavannan
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |2 --
drivers/staging/rdma/hfi1/chip.h |1
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.h | 48 ++--
drivers/staging/rdma/hfi1/common.h |4 +-
drivers/staging/rdma/hfi1/diag.c |4 +-
drivers/staging/rdma/hfi1/hfi.h| 22
drivers/staging/rdma/hfi1/init.c
-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 31 ---
1 files changed, 24 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c
index d858f36..6c942f6 100644
--- a/drivers
From: Mark F. Brown
The krcvqs parameter is displayed incorrectly in sysfs.
The workaround is to set the param type as uint.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Mitko Haralanov
Signed-off-by: Mark F. Brown
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/hfi.h |2
Space between concantenated string elements is more human
readable and fixes the checkpatch issue:
CHECK: Concatenated strings should use spaces between elements
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 10 +-
drivers/staging
From: Ira Weiny
Rcv bubbles were improperly calculated for HFIs, fix that here.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Arthur Kepner
Signed-off-by: Ira Weiny
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/mad.c | 64 +-
1 files changed, 2
Marciniszyn
Signed-off-by: Vennila Megavannan
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 110 +++-
drivers/staging/rdma/hfi1/chip.h |5 +
drivers/staging/rdma/hfi1/chip_registers.h |1 +
drivers/staging/rdma/hfi1/hfi.h
From: Dean Luick
Read an EFI variable for the device description. Create the
infrastructure for additional variable reads.
Reviewed-by: Easwar Hariharan
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/Makefile |2 +-
drivers/staging/rdma/hfi1/chip.c
From: Dean Luick
The variable "index" increments the same as dd->ndevcntrs.
Just use the later. Remove uneeded usage of "index" in the
fill loop - it is not used there or later in the function.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: J
: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/eprom.c| 119 +++---
drivers/staging/rdma/hfi1/file_ops.c | 18 ++
include/uapi/rdma/hfi/hfi1_user.h| 10 +--
3 files changed, 77 insertions(+), 70
From: Mike Marciniszyn
The current is_bx() will incorrectly match on other steppings.
is_a0() is removed in favor of is_ax().
Reviewed-by: Mark Debbage
Signed-off-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 44
Change the default number of krcvqs to number of numa nodes + 1
based on the performance data collected.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rdma
) in the
CONFIG_PRESCAN_RXQ ifdef block. This function is independent of
CONFIG_PRESCAN_RXQ and should be outside this block.
Fixes: 82c2611daaf0 ("staging/rdma/hfi1: Handle packets with invalid RHF on
context 0")
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/sta
Does it fail to apply to staging-next or staging-testing or something else?
>
> As both trees are now the same, it fails to apply to both at the moment
> :)
I will refresh this patch against the latest staging-next.
Thanks,
Jubin John
>
> thanks,
>
> greg k-h
> --
>
: Ira Weiny
Signed-off-by: Jubin John
---
Changes in v2:
- Removed unlikely() in sdma_select_engine_vl()
Changes in v3:
- Refreshed patch against latest staging-next
drivers/staging/rdma/hfi1/sdma.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a
Changes in v2:
- Added more information in commit messages of patches 01, 02
03, 04, 05, 07 and 09
- Fixed driver name to hfi1 in subject line of patch 06
- Refreshed patch 10 on top of staging-next
- Dropped patch 18 (staging/rdma/hfi1: Workaround
the decode with the fix:
aeth syn 0x00 ACK
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- Added more information in commit message
drivers/staging/rdma/hfi1/trace.c | 29 ++---
1 files changed, 22
by: Mike Marciniszyn
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- Added more information in commit message
drivers/staging/rdma/hfi1/trace.h |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/trace.h
b/drive
From: Dean Luick
Add support for an automatic fallback for firmware names to support
debug-signed and production-signed firmware images.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- Added more information in commit message
From: Dean Luick
Add one-time LCB reset on driver load to pre-emptively work
around any LCB power cycle issues.
Reviewed-by: Easwar Hariharan
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- Fixed driver name to hfi1 in subject line
drivers/staging/rdma/hfi1
-by: Dean Luick
Reviewed-by: Arthur Kepner
Signed-off-by: Harish Chegondi
Signed-off-by: Jubin John
---
Changes in v2:
- No changes
drivers/staging/rdma/hfi1/chip.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers
-off-by: Jubin John
---
Changes in v2:
- No changes
drivers/staging/rdma/hfi1/mad.c | 32
1 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/mad.c b/drivers/staging/rdma/hfi1/mad.c
index a122565..6fb4eab 100644
--- a
From: Harish Chegondi
Currently, if hfi1_register_ib_device() call is unsuccessful, workqueues
are not being destroyed before bailing out. This patch fixes this issue.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Harish Chegondi
Signed-off-by: Jubin John
---
Changes in v2:
- No
x27;t have
enough SDMA (4) mechanisms for the typical number of VLs.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- Added more information in commit message
drivers/staging/rdma/hfi1/chip.c |6 +++---
1 files changed, 3 inser
From: Edward Mascarenhas
Clean up comments by deleting numbering and terms internal to Intel.
The information on the actual bugs is not deleted.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Edward Mascarenhas
Signed-off-by: Jubin John
---
Changes in v2:
- Added more information in
From: Dean Luick
The longest quiet timeout is now 6s. Extend the driver wait to 6s.
The driver wasn't following our internal specification: 6 seconds.
This patch corrects that issue.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes
From: Dean Luick
When sending a diagnostic packet, if the send context does not
have enough room, force a credit return and try again.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- No changes
drivers/staging/rdma/hfi1
From: Joel Rosenzweig
Provides error status counters for CceErrStatus, Send*ErrStatus,
RcvErrStatus and MISC_ERR_STATUS
Reviewed-by: Mitko Haralanov
Reviewed-by: Mike Marciniszyn
Signed-off-by: Joel Rosenzweig
Signed-off-by: Jubin John
---
Changes in v2:
- Refreshed patch on top of
From: Dean Luick
Change reported unknown frame messages into a counter.
These are informational, no errors.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- No changes
drivers/staging/rdma/hfi1/chip.c | 18
From: Kaike Wan
This patch fixes a few incorrect header file comments in qp.h
Reviewed-by: Mike Marciniszyn
Signed-off-by: Kaike Wan
Signed-off-by: Jubin John
---
Changes in v2:
- Added more information in commit message
drivers/staging/rdma/hfi1/qp.h |8
1 files
From: Dean Luick
An SPC freeze is not an error. Remove the messages.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- No changes
drivers/staging/rdma/hfi1/chip.c |2 --
1 files changed, 0 insertions(+), 2 deletions
From: Dean Luick
Only warn when link up pkeys are not what we expect. Also, allow
for the pkey to already be initialized.
Reviewed-by: Arthur Kepner
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
Changes in v2:
- No changes
drivers/staging/rdma/hfi1/chip.c |8
d-by: Mike Marciniszyn
Signed-off-by: Andrea Lowe
Signed-off-by: Jubin John
---
Changes in v2:
- No changes
drivers/staging/rdma/hfi1/mad.c | 38 ++
1 files changed, 26 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/mad.c
Hi Greg,
Is this patch series still in your queue? I just wanted to make sure it
didn't get dropped.
Thanks,
Jubin John
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Dean Luick
Remove an invalid sanity check that compares the local link
credits with the peer link credits. The two have no dependency
on each other.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |3 +--
1
Fix the spelling of user_credit_return_threshold, it was incorrectly
spelled as user_credit_return_theshold causing two module parameters,
one with typo, to be shown in modinfo
Reviewed-by: Ira Weiny
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/init.c
from process context to promote it to ACTIVE.
Signed-off-by: Jim Snow
Signed-off-by: Brendan Cunningham
Reviewed-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |5 ++-
drivers/staging/rdma/hfi1/chip.h |2 +
drivers/staging/rdma/hfi1/driver.c | 66
On Fri, Dec 18, 2015 at 09:42:20AM +0300, Dan Carpenter wrote:
> Nice. Whenever you see a bug like this, you should report it to
> kernel-janitors because you know that 10 other people have made the same
> mistake.
Sure, I will do that for similar bugs.
>
> I will take care of it.
Thank you.
>
mostly portion of the
hfi1_qp structure
Jubin John (2):
staging/rdma/hfi1: Use BIT macro
staging/rdma/hfi1: Change default krcvqs
Mark F. Brown (1):
staging/rdma/hfi1: change krcvqs module parameter type from byte to
uint
Vennila Megavannan (1):
staging/rdma/hfi1: adding
Change the default number of krcvqs to number of numa nodes + 1
based on the performance data collected.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
Changes in v2:
- None
Changes in v3:
- Refreshed patch against latest staging-testing
drivers/staging/rdma/hfi1
From: Mark F. Brown
The krcvqs parameter is displayed incorrectly in sysfs.
The workaround is to set the param type as uint.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Mitko Haralanov
Signed-off-by: Mark F. Brown
Signed-off-by: Jubin John
---
Changes in v2:
- None
Changes in v3
From: Harish Chegondi
This would reduce L2 cache misses on s_sde in the _hfi1_schedule_send
function when invoked from post_send thereby improving performance of
post_send.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Harish Chegondi
Signed-off-by: Jubin John
---
Changes in v2
Signed-off-by: Jubin John
---
Changes in v2:
- Updated commit message with more information about changes in patch
Changes in v3:
- Refreshed patch against latest staging-testing
drivers/staging/rdma/hfi1/chip.h | 48 ++--
drivers/staging
From: Dean Luick
The variable "index" increments the same as dd->ndevcntrs.
Just use the later. Remove uneeded usage of "index" in the
fill loop - it is not used there or later in the function.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by:
Marciniszyn
Signed-off-by: Vennila Megavannan
Signed-off-by: Jubin John
---
Changes in v2:
- None
Changes in v3:
- Refreshed patch against latest staging-testing
drivers/staging/rdma/hfi1/chip.c | 110 +++-
drivers/staging/rdma/hfi1/chip.h
-off-by: Jubin John
---
Changes in v2:
- No changes
Changes in v3:
- Refreshed patches against latest staging-testing
drivers/staging/rdma/hfi1/mad.c | 33 -
1 files changed, 20 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rdma/hfi1
These patches were part of series:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-December/082248.html
but did not apply cleanly to the staging-testing branch.
Refreshed the remaining 2 patches against the latest staging-testing.
Changes in v2:
- Added more informa
From: Edward Mascarenhas
Clean up comments by deleting numbering and terms internal to Intel.
The information on the actual bugs is not deleted.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Edward Mascarenhas
Signed-off-by: Jubin John
---
Changes in v2:
- Added more information in
On Fri, Dec 18, 2015 at 09:31:39AM +0300, Dan Carpenter wrote:
> Possible off by one, but mostly the whitespace makes me itch.
>
> Jim was not on the CC list.
>
> On Thu, Dec 17, 2015 at 07:24:15PM -0500, Jubin John wrote:
> > From: Jim Snow
> >
> > The link st
from process context to promote it to ACTIVE.
Reviewed-by: Dean Luick
Reviewed-by: Ira Weiny
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jim Snow
Signed-off-by: Brendan Cunningham
Signed-off-by: Jubin John
---
Changes in v2:
- Fixed whitespace
- Converted armed->act
On Mon, Jan 04, 2016 at 10:23:46PM +0200, Leon Romanovsky wrote:
> On Mon, Jan 04, 2016 at 11:21:19AM -0500, Jubin John wrote:
> > From: Jim Snow
> >
> > } else {
> > + /* Auto activate link on non-SC15 packet receive */
> > +
from process context to promote it to ACTIVE.
Reviewed-by: Dean Luick
Reviewed-by: Ira Weiny
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jim Snow
Signed-off-by: Brendan Cunningham
Signed-off-by: Jubin John
---
Changes in v2:
- Fixed whitespace
- Converted armed->act
to the read mostly portion of the
hfi1_qp structure
Jubin John (2):
staging/rdma/hfi1: Use BIT macro
staging/rdma/hfi1: Change default krcvqs
Mark F. Brown (1):
staging/rdma/hfi1: change krcvqs module parameter type from byte to
uint
Vennila Megavannan (1):
staging/rdma/hfi1: adding
Change the default number of krcvqs to number of numa nodes + 1
based on the performance data collected.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
Changes in v2:
- None
Changes in v3:
- Refreshed patch against latest staging-next
drivers/staging/rdma/hfi1
From: Harish Chegondi
This would reduce L2 cache misses on s_sde in the _hfi1_schedule_send
function when invoked from post_send thereby improving performance of
post_send.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Harish Chegondi
Signed-off-by: Jubin John
---
Changes in v2
Signed-off-by: Jubin John
---
Changes in v2:
- Updated commit message with more information about changes in patch
Changes in v3:
- Refreshed patch against latest staging-next
drivers/staging/rdma/hfi1/chip.h | 48 ++--
drivers/staging/rdma
From: Mark F. Brown
The krcvqs parameter is displayed incorrectly in sysfs.
The workaround is to set the param type as uint.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Mitko Haralanov
Signed-off-by: Mark F. Brown
Signed-off-by: Jubin John
---
Changes in v2:
- None
Changes in v3
1 - 100 of 133 matches
Mail list logo
