On August 29, 2019 2:59:01 PM EDT, Peikan Tsai wrote:
>On Thu, Aug 29, 2019 at 05:27:22PM +0200, Christian Brauner wrote:
>> On Thu, Aug 29, 2019 at 09:53:59AM -0400, Joel Fernandes wrote:
>> > On Thu, Aug 29, 2019 at 08:42:29AM +0200, Greg KH wrote:
>> > > On T
self and it applies
cleanly, but I have no way to test it.
That 'res->start' error_release could end up a NULL pointer deref.
- Joel
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Oct 08, 2018 at 09:46:01PM -0700, Joel Fernandes wrote:
> On Fri, Apr 06, 2018 at 10:23:04AM -0400, Mauro Carvalho Chehab wrote:
> > As warned:
> > drivers/staging/media/davinci_vpfe/dm365_ipipe.c:1834 vpfe_ipipe_init()
> > error: we previously assumed 're
On Thu, Dec 06, 2018 at 03:52:43PM +, Daniel Bovensiepen wrote:
> Fixed spelling in comment section.
>
> Signed-off-by: Daniel Bovensiepen
Acked-by: Joel Fernandes (Google)
> ---
> drivers/staging/android/ashmem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 dele
7;).
However that is just my opinion and I am ok with either naming.
thanks!
- Joel
>
> Simple atomic and non-atomic counters api provides interfaces for simple
> atomic and non-atomic counters that just count, and don't guard resource
> lifetimes. Counters will wrap ar
version doesn't change the overflow wrap around behavior.
>
> Signed-off-by: Shuah Khan
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
> ---
> drivers/android/binder.c | 41 ---
> drivers/android/binder_internal.h | 3 ++-
>
On Mon, Sep 28, 2020 at 01:34:31PM -0700, Kees Cook wrote:
> On Sun, Sep 27, 2020 at 07:35:26PM -0400, Joel Fernandes wrote:
> > On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote:
> > > This patch series is a result of discussion at the refcount_t BOF
> > > th
;buffer->data + buf_offset;
> +
> + t->security_ctx = (uintptr_t)kptr +
> + binder_alloc_get_user_buffer_offset(&target_proc->alloc);
> + memcpy(kptr, secctx, secctx_sz);
Just for my clarification, instead of storing the string in the transaction
buffer, would it not be better to store the security context id in
t->security_ctx, and then do the conversion to string later, during
binder_thread_read? Then some space will also be saved in the transaction
buffer?
thanks,
- Joel
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Jan 14, 2019 at 10:50:24AM -0800, Todd Kjos wrote:
> On Mon, Jan 14, 2019 at 10:33 AM Joel Fernandes wrote:
> >
> > On Mon, Jan 14, 2019 at 09:10:21AM -0800, Todd Kjos wrote:
> > > To allow servers to verify client identity, allow a node
> > > flag t
uses TASK_INTERRUPTIBLE to avoid
> + * increasing load and is freezable.
> + */
> +#define wait_event_freezable_hrtimeout(wq_head, condition, timeout)
> \
You should document the variable names in the header comments.
Also, this new API appears to conflict with defini
t skeptical if
your API will behave as expected (or at least consistently with other wait
APIs).
> That being said, I am not sure that the try_to_freeze() call does anything
> in the vsoc case because there is no call to set_freezable() so the thread
> still has PF_NOFREEZE...
I traced this, and PF_NOFREEZE is not set by default for tasks.
thanks,
- Joel
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
el thread may clear PF_NOFREEZE for itself by calling
> set_freezable()".
>
> Looking at the kthreadd() definition it seems like new tasks have
> PF_NOFREEZE set by default[2].
>
> I'll take some time to check this in practice in the next days.
>
> Anyways, thanks for your time !
Yeah, no problem.
thanks,
- Joel
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
knew things will turn this way
after a painful death of my beloved husband during the Algerian civil war.
My Name is Mrs. Akia Joel. I am writing this mail to you with heavy heart. I
married to Mr. Mike Joel for 32 years without a child. He worked with the
nation's gross domestic product
sleeping.
>
> The result is a potential performance gain during freeze, since less
> tasks have to be awaken.
I'm curious did you try the freezing process and see if pointless wakeups are
reduced? That would be an added bonus if you did.
Otherwise seems like a nice change.
I think you sent to wrong address of Alistair on these and other patches.
Corrected address.
On Fri, Feb 01, 2019 at 06:39:03AM +0100, Hugo Lefeuvre wrote:
> simplify handle_vsoc_cond_wait (drivers/staging/android/vsoc.c) using newly
> added wait_event_freezable_hrtimeout helper and remove useles
discuss more if you want.
thanks,
- Joel
>From the docs:
__GFP_NOFAIL - Indicate that this allocation is in no way allowed to fail
(think twice before using).
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproj
: syzbot
> Signed-off-by: Tetsuo Handa
> Cc: sta...@vger.kernel.org
> ---
Please in the future, include some information about what changed from
previous patches, or atleast add a cover letter. And use patch revision
numbers. It is hard to know what changed from previous review.
Th
sleeping.
>
> The result is a potential performance gain during freeze, since less
> tasks have to be awaken.
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
>
> Signed-off-by: Hugo Lefeuvre
> ---
> include/linux/wait.h | 6 +++---
> 1 file changed, 3 insertions(+),
off-by: Hugo Lefeuvre
> ---
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
> include/linux/wait.h | 25 +
> 1 file changed, 21 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/wait.h b/include/linux/wait.h
> index 5f3efabc36f4..c4
On Thu, Feb 07, 2019 at 12:30:50AM +0100, Hugo Lefeuvre wrote:
> Hi Joel,
>
> > I'm curious did you try the freezing process and see if pointless wakeups
> > are
> > reduced? That would be an added bonus if you did.
>
> I'm currently testing these chan
On Wed, Feb 06, 2019 at 08:45:32AM +0900, Tetsuo Handa wrote:
> Joel Fernandes wrote:
> > On Tue, Feb 05, 2019 at 07:28:41PM +0900, Tetsuo Handa wrote:
> > > ashmem_pin() is calling range_shrink() without checking whether
> > > range_alloc() succeeded. Since memory alloc
On Sat, Feb 09, 2019 at 11:24:03AM +0900, Tetsuo Handa wrote:
> On 2019/02/08 23:45, Joel Fernandes wrote:
> > On Wed, Feb 06, 2019 at 08:45:32AM +0900, Tetsuo Handa wrote:
> >> Joel Fernandes wrote:
> >>> On Tue, Feb 05, 2019 at 07:28:41PM +0900, Tetsuo Handa wrote:
On Thu, Feb 14, 2019 at 3:42 PM Todd Kjos wrote:
>
> On Thu, Feb 14, 2019 at 11:45 AM Joel Fernandes wrote:
[snip]
> > > + * check_buffer() - verify that buffer/offset is safe to access
> > > + * @alloc: binder_alloc for this proc
> > > + * @buffer: binder buffer
On Thu, Feb 14, 2019 at 03:53:54PM -0500, Joel Fernandes wrote:
> On Thu, Feb 14, 2019 at 3:42 PM Todd Kjos wrote:
> >
> > On Thu, Feb 14, 2019 at 11:45 AM Joel Fernandes wrote:
> [snip]
> > > > + * check_buffer() - verify that buffer/offset is safe to access
> &
On Thu, Feb 14, 2019 at 01:55:19PM -0800, 'Todd Kjos' via kernel-team wrote:
> On Thu, Feb 14, 2019 at 1:25 PM Joel Fernandes wrote:
> >
> > On Thu, Feb 14, 2019 at 03:53:54PM -0500, Joel Fernandes wrote:
> > > On Thu, Feb 14, 2019 at 3:42 PM Todd Kjos wrote:
&g
t; Signed-off-by: Tetsuo Handa
> Cc: sta...@vger.kernel.org
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
> ---
> drivers/staging/android/ashmem.c | 42
> +++-
> 1 file changed, 24 insertions(+), 18 deletions(-)
>
> diff --gi
On Mon, Feb 25, 2019 at 2:11 PM Tetsuo Handa
wrote:
>
> On 2019/02/26 6:55, Joel Fernandes wrote:
> >> @@ -763,6 +767,8 @@ static int ashmem_pin_unpin(struct ashmem_area *asma,
> >> unsigned long cmd,
> >>
> >> out_unlock:
> >>
Signed-off-by: Tetsuo Handa
> Cc: sta...@vger.kernel.org
Properly this time,
Reviewed-by: Joel Fernandes
thanks,
- Joel
> ---
> drivers/staging/android/ashmem.c | 42
> +++-
> 1 file changed, 24 insertions(+), 18 deletions(-)
>
> diff -
ult in
> > > calling zap_page_range() with an invalid vma which manifests as a
> > > use-after-free in zap_page_range().
> > >
> > > The fix is to check alloc->vma after acquiring the mmap_sem (which we
> > > were acquiring anyway) and skip zap_page_range
I am sure AOSP contributions to make
LMKd better by using the PSI backend would be appreciated. Please consider
collaborating on that and help out, thanks. Check the cover-letter of that
patch [1] where LMKd is mentioned.
thanks,
- Joel
[1] https://www.mail-arch
On Mon, Mar 11, 2019 at 12:32:33PM -0400, Joel Fernandes wrote:
> On Sun, Mar 10, 2019 at 01:34:03PM -0700, Sultan Alsawaf wrote:
> [...]
> >
> > /* Perform scheduler related setup. Assign this task to a CPU. */
> > retval = sched_fork(clone_flags, p);
> >
7;t be so
spontaneous that unwanted tasks are killed because the system went into
panic mode. It should be averaged out which I believe is what PSI does.
thanks,
- Joel
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
he way another approach that can provide a quick and asynchronous
notification of when the process memory is freed, is to monitor
sched_process_exit trace event using eBPF. You can tell eBPF the PID
that you want to monitor before the SIGKILL. As soon as the process
dies and its memory is freed,
On Thu, Mar 14, 2019 at 01:49:11PM -0700, Sultan Alsawaf wrote:
> On Thu, Mar 14, 2019 at 10:47:17AM -0700, Joel Fernandes wrote:
> > About the 100ms latency, I wonder whether it is that high because of
> > the way Android's lmkd is observing that a process has died. There
a zombie. That's
> why I designed my original exithand patch to fire death notification
> upon transition to the zombie state, not upon process table removal,
> and I expect pidfd_wait (or whatever we call it) to act the same way.
Agreed. Looking forward to the patches. :)
thanks,
- Joel
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
dy exist, to do a perfectly adequate job.
> >
> > We do want killed processes to die promptly. That's why I support
> > boosting a process's priority somehow when lmkd is about to kill it.
> > The precise way in which we do that --- involving not only actual
> &
getting pidfd_send_signal() into shape and
> was reluctant to put more ideas/work into this if it gets shutdown.
> Once we have pidfd_send_signal() the wait discussion makes sense.
Ok. It looks like that is almost in though (fingers crossed :)).
thanks,
- Joel
> > wrote:
> > > >
> > > > On Fri, Mar 15, 2019 at 11:49 AM Joel Fernandes
> > > > wrote:
> > > > >
> > > > > On Fri, Mar 15, 2019 at 07:24:28PM +0100, Christian Brauner wrote:
> > > > > [..]
> > >
On Mon, Mar 18, 2019 at 01:29:51AM +0100, Christian Brauner wrote:
> On Sun, Mar 17, 2019 at 08:40:19AM -0700, Daniel Colascione wrote:
> > On Sun, Mar 17, 2019 at 4:42 AM Christian Brauner
> > wrote:
> > >
> > > On Sat, Mar 16, 2019 at 09:53:06PM -0400, Joel Fer
On Tue, Mar 19, 2019 at 11:14:17PM +0100, Christian Brauner wrote:
[snip]
> >
> > ---8<---
> >
> > From: Joel Fernandes
> > Subject: [PATCH] Partial skeleton prototype of pidfd_wait frontend
> >
> > Signed-off-by: Joel Fe
to set CONFIG_PROCFS=N - even
> > > though that's crazy - and still be able to use pidfds. This is also a
> > > point akpm asked about when I did the pidfd_send_signal work.
> >
> > I agree that you shouldn't need CONFIG_PROCFS=Y to use pidfds. One
> &
On March 20, 2019 3:02:32 AM EDT, Daniel Colascione wrote:
>On Tue, Mar 19, 2019 at 8:59 PM Christian Brauner
> wrote:
>>
>> On Tue, Mar 19, 2019 at 07:42:52PM -0700, Daniel Colascione wrote:
>> > On Tue, Mar 19, 2019 at 6:52 PM Joel Fernandes
> wrote:
>> &
On Wed, Mar 20, 2019 at 07:26:50PM +0100, Christian Brauner wrote:
> On Wed, Mar 20, 2019 at 07:33:51AM -0400, Joel Fernandes wrote:
> >
> >
> > On March 20, 2019 3:02:32 AM EDT, Daniel Colascione
> > wrote:
> > >On Tue, Mar 19, 2019 at 8:59 PM Christian B
gt; review the actual code.
No problem, pidfd_wait is also fine with me and we can change it later to
translate_pid or something else if needed.
Agreed that lets get to some code writing now that (I hope) we are all on the
same page and discuss on actual code.
- Joel
nce.
>
> Co-developed-by: Christian Brauner
> Signed-off-by: Christian Brauner
> Signed-off-by: Hridya Valsaraju
> ---
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
> drivers/android/binderfs.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git
inderfs instance instead of global devices
> being created by the binder driver.
>
> Co-developed-by: Christian Brauner
> Signed-off-by: Christian Brauner
> Signed-off-by: Hridya Valsaraju
> ---
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
>
> Changes in v2:
&
inderfs instance instead of global devices
> being created by the binder driver.
>
> Co-developed-by: Christian Brauner
> Signed-off-by: Christian Brauner
> Signed-off-by: Hridya Valsaraju
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
> ---
>
> Changes in v2:
&
kmem_cache
> for the binder_thread.
Awesome change and observation!!!
Reviewed-by: Joel Fernandes (Google)
(Another thought: how did you discover this? Are you using some tools to look
into slab fragmentation?).
thanks,
- Joel
> Signed-off-by: Peikan Tsai
> ---
> drivers/android/bin
e
kmalloc()s troubling in the kernel :-(. Say you have a 5000 objects of 512
allocation, each 300 bytes. 212 * 5000 is around 1MB. Which is arguably not
neglible on a small memory system, right?
thanks,
- Joel
___
devel mailing list
de...@linuxdriverproject
Which is fine. I have done it both ways. Is this a rule written somewhere?
>:)
>
If I am not mistaken, this is Hridya's first set of kernel patches.
Congrats on landing it upstream and to everyone for reviews! (assuming
nothing falls apart on the way to Linus tree).
thanks,
- Joel
copying
> the name of the binder device instead of stashing a pointer to it.
>
> Reported-by: Jann Horn
> Fixes: 03e2e07e3814 ("binder: Make transaction_log available in binderfs")
> Link:
> https://lore.kernel.org/r/cag48ez14q0-f8lqsvcnbyr2o6gpw8shxsm4u5jmd9mpstem...@mail
On Wed, Oct 09, 2019 at 12:40:12PM +0200, Christian Brauner wrote:
> On Tue, Oct 08, 2019 at 02:05:16PM -0400, Joel Fernandes wrote:
> > On Tue, Oct 08, 2019 at 03:01:59PM +0200, Christian Brauner wrote:
> > > When a binder transaction is initiated on a binder device coming fro
On Wed, Oct 09, 2019 at 04:29:11PM +0200, Christian Brauner wrote:
> On Wed, Oct 09, 2019 at 10:21:29AM -0400, Joel Fernandes wrote:
> > On Wed, Oct 09, 2019 at 12:40:12PM +0200, Christian Brauner wrote:
> > > On Tue, Oct 08, 2019 at 02:05:16PM -0400, Joel Fernandes wrote:
>
On Wed, Oct 09, 2019 at 05:10:45PM +0200, Christian Brauner wrote:
> On Wed, Oct 09, 2019 at 10:55:58AM -0400, Joel Fernandes wrote:
> > On Wed, Oct 09, 2019 at 04:29:11PM +0200, Christian Brauner wrote:
> > > On Wed, Oct 09, 2019 at 10:21:29AM -0400, Joel Fernandes wrote:
>
L, Tim
> Murray, Michal Hocko, Suren Baghdasaryan, linux-mm, Arve Hjønnevåg,
> Ingo Molnar, Steven Rostedt, Oleg Nesterov, Joel Fernandes, Andy
> Lutomirski, kernel-team
>
> > On Tue, May 07, 2019 at 01:12:36AM -0700, Sultan Alsawaf wrote:
> > > On Tue, May 07, 2019 at
t a right idea to do that?
> > > > Thanks!
> > > >
> > >
> > > Yes, I do think that's the right approach. We're working on moving Ion
> > > out of staging and this is something I mentioned to John Stultz. I
areas.
Because we know that we have a shmem file underneath, call the shmem
implementation of fallocate directly instead of going through the
user-space interface for fallocate.
Bug: 21951515
Signed-off-by: Tobias Lindskog
Signed-off-by: Jeff Vander Stoep
Signed-off-by: Joel Fernandes (G
On Mon, Jul 16, 2018 at 11:48:51AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Jul 06, 2018 at 02:44:16PM -0700, Joel Fernandes wrote:
> > From: Tobias Lindskog
> >
> > When ashmem_shrink is called from direct reclaim on a user thread, a
> > call to do_fallocate will ch
Hjønnevåg
> Cc: Todd Kjos
> Cc: Martijn Coenen
> Cc: de...@driverdev.osuosl.org
> Cc: linux-ker...@vger.kernel.org
> Cc: kernel-t...@android.com
> Cc: Joel Fernandes
> Signed-off-by: Alistair Strachan
> ---
> v2: Removed unnecessary use of unlikely() macro
>
>
x-ker...@vger.kernel.org
> Cc: kernel-t...@android.com
> Cc: Joel Fernandes
> Suggested-by: Greg Kroah-Hartman
> Signed-off-by: Alistair Strachan
Acked-by: Joel Fernandes (Google)
thanks,
- Joel
___
devel mailing li
On Wed, Jun 20, 2018 at 02:21:57PM -0700, Daniel Colascione wrote:
> On Tue, Jun 19, 2018 at 9:32 PM, Joel Fernandes
> wrote:
> > On Tue, Jun 19, 2018 at 05:57:35PM -0700, Alistair Strachan wrote:
> > > The ashmem driver did not check that the size/offset of the vma pass
map is done on the ashmem
> region, then the permission checks will be skipped. Fix that by disallowing
> mapping operation on the backing shmem file.
Reviewed-by: Joel Fernandes (Google)
thanks!
- Joel
>
> Reported-by: Jann Horn
> Signed-off-by: Suren Baghdasaryan
> Cc: stab
.
>
> Cc: Greg Kroah-Hartman
> Cc: Joel Fernandes
Reviewed-by: Joel Fernandes (Google)
thanks,
- Joel
> Cc: Greg Hartman
> Cc: kernel-t...@android.com
> Cc: de...@driverdev.osuosl.org
> Signed-off-by: Alistair Delva
> ---
> drivers/staging/android/Kcon
As suggested by checkpatch.pl, use dev_info() instead of
printk(KERN_INFO ...) to print message.
Signed-off-by: Joel Porquet
---
Only tested by compilation.
drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging
brief on my personality; my name is Juliet Joel, an African based in
U.K.I am 33 years of age, married with 3 lovely kids. I dropped my Shipping
business because it wasn't producing profitable income. I have had so much
problems with the British Authority just because am a foreigner I be
tions, and just leaves anonymous enum type definitions:
enum {
...
};
Signed-off-by: Joel Porquet
---
Only test by compilation.
drivers/staging/silicom/bypasslib/bp_ioctl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/silicom/bypasslib/bp_
ed memory. Therefore the race
> that lockdep is warning about is not valid. Resolve this by introducing a
> separate lockdep class for the backing shmem inodes.
>
> [1]: https://lkml.kernel.org/lkml/0b5f9d059aa20...@google.com/
>
> Signed-off-by: Suren Baghda
27;s not used, and is only causing problems
> > > > for everyone involved.
> > > >
> > > > Cc: "Arve Hjønnevåg"
> > > > Cc: "Christian König"
> > > > Cc: Christian Brauner
> > > > Cc: Ch
binder_alloc_buffer_lookup() doesn't exist and is named
"binder_alloc_prepare_to_free()". Correct the code comments to reflect
this.
Signed-off-by: Joel Fernandes (Google)
---
drivers/android/binder_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
nr_to_scan is the number of pages to be freed however ashmem doesn't
discount nr_to_scan correctly as it frees ranges. It should be
discounting them by pages than by ranges. Correct the issue.
Cc: sur...@google.com
Signed-off-by: Joel Fernandes (Google)
---
drivers/staging/android/ashmem.
This patch fixes the following checkpatch.pl issues caused by the new
function: ether_addr_copy
Signed-off-by: Joel Pelaez Jorge
---
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers/staging/slicoss/slicoss.c
index 12aafe3..4ff39aa 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b
This patch fixes the following checkpatch.pl issues caused by the new
function: ether_addr_copy
Signed-off-by: Joel Pelaez Jorge
---
drivers/staging/slicoss/slicoss.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c
El 17/03/14 23:49, Jingoo Han escribió:
On Tuesday, March 18, 2014 2:04 PM, Joel Pelaez Jorge wrote:
@@ -810,8 +810,8 @@ static int slic_mac_set_address(struct net_device
*dev, void *ptr)
if (!is_valid_ether_addr(addr->sa_data))
return -EINVAL;
- memcpy(
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
symbol 'r8192_wx_handlers_def' was not declared. Should it be static
Signed-off-by: Joel Pelaez Jorge
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/stagin
ned-off-by: Joel Pelaez Jorge
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index 498995d..f17584d 100644
--- a/drivers/staging/rtl8192
El 06/04/14 13:49, Joe Perches escribió:
On Sun, 2014-04-06 at 13:43 -0500, Joel Pelaez Jorge wrote:
Fix a sparse warning, non static symbol is no declared as such.
And fix a conflict with static function declared extern to include
rtl_wx.h header.
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
El 06/04/14 14:01, Greg Kroah-Hartman escribió:
On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote:
Fix a sparse warning, non static symbol is no declared as such.
And fix a conflict with static function declared extern to include
rtl_wx.h header.
drivers/staging/rtl8192e
El 06/04/14 15:26, Greg Kroah-Hartman escribió:
> On Sun, Apr 06, 2014 at 02:12:44PM -0500, Joel Pelaez Jorge wrote:
>> El 06/04/14 14:01, Greg Kroah-Hartman escribió:
>>> On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote:
>>>> Fix a sparse warning, no
In the kernel driver: rtl8192e, exists some problems related
to source check, using the tool sparse, but for fix it, is necessary
remove a bad declaration that keep off the patch.
Because it is resolved before apply the "main" patch.
Joel Pelaez Jorge (2):
Staging: rtl8192e: Remove b
Remove extern declaration to a static function:
iw_statistics *r8192_get_wireless_stats(struct net_device *dev);
Signed-off-by: Joel Pelaez Jorge
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.h
b
symbol 'r8192_wx_handlers_def' was not declared. Should it be static?
Signed-off-by: Joel Pelaez Jorge
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
b/drivers/staging/rtl8192e/rtl8192e/rtl_
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning: symbol
'r8192_wx_handlers_def' was not declared. Should it be static?
Resolved incluing the fixed header to rtl_wx.c
Also, isn't declared as constant variable, so it declared as such.
And delete unnecessary cast in rtl_core.c
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning: symbol
'r8192_wx_handlers_def' was not declared. Should it be static?
Resolved incluing the fixed header to rtl_wx.c
Also, isn't declared as constant variable, so it declared as such.
And delete unnecessary cast in rtl_core.c
Remove support for building against ancient WIRELESS_EXT versions,
only leaving support for the current version: 22
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h| 14 -
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 5 +--
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c |
Remove support for building against ancient WIRELESS_EXT versions,
only leaving support for the current version: 22
Signed-off-by: Joel Pelaez Jorge
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h| 14 -
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 5 +--
drivers/staging
Remove support for building against ancient WIRELESS_EXT versions,
only leaving support for the current version: 22
Signed-off-by: Joel Pelaez Jorge
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h| 14 -
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 5 +
drivers
ed. Should it be static?
>>
>> These functions are used outside of this file so using static will not
>> work. Fix the warning by declaring the functions in the header file,
>> ieee80211.h
>>
>> Signed-off-by: Jeremiah Mahler
>> Cc: Greg Kroah-Hartman
>&g
e condition in pin
> ioctls)
> Reported-by: syzbot+d7a918a7a8e1c952b...@syzkaller.appspotmail.com
> Signed-off-by: Yisheng Xie
Greg,
Could you take this patch for the stable trees? I do see it in staging
already. I couldn't find it in stable so wanted to bring it to
On Thu, Mar 30, 2023 at 02:49:54PM +0200, Greg KH wrote:
> On Thu, Mar 30, 2023 at 08:44:35PM +0800, Joel Camilo Chang Gonzalez wrote:
> > Remove parentheses not needed in if statement
> >
> > Signed-off-by: Joel Camilo Chang Gonzalez
> > ---
> > drivers/staging
Remove parentheses not needed in if statement
Signed-off-by: Joel Camilo Chang Gonzalez
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index af3825578d85
Remove redundant parentheses
Signed-off-by: Joel Camilo Chang Gonzalez
---
drivers/staging/ks7010/ks_wlan_net.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
b/drivers/staging/ks7010/ks_wlan_net.c
index e03c87f0bfe7
91 matches
Mail list logo
