On Thu, Jan 29, 2015 at 3:52 PM, Rickard Strandqvist
wrote:
> The last one was more interesting, se below.
> But I can not really see how any error should be handled here?
> Proposal to change to:
>
> if (kstrtol(tempbuf, 16, &num) == 0 && num == 0)
That whole chunk of code looks odd. Why the
On Thu, Jan 29, 2015 at 5:46 PM, Chris Rorvick wrote:
> That whole chunk of code looks odd. Why the base 16 conversion when
> we already know it's a decimal digit? Seems like this would work
> without the hassle of the string conversion:
Hmm, or probably even better to do this
On Fri, Jan 30, 2015 at 11:35 AM, Rickard Strandqvist
wrote:
> 2015-01-30 15:20 GMT+01:00 Dan Carpenter :
>> Yes. Please send that as a patch which can be applied.
>>
>> regards,
>> dan carpenter
>>
>
>
> Hi
>
> Okay, I'll do it this wee
much easier
to understand and the resulting function is still viewable within a
single screen.
Signed-off-by: Chris Rorvick
---
drivers/staging/emxx_udc/emxx_udc.c | 52 ++---
1 file changed, 14 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/emxx_udc
On Fri, Jan 30, 2015 at 5:30 PM, Chris Rorvick wrote:
> +
> + ep->ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP0_PACKETSIZE);
> +
Damn. I looked this over twice before sending this and still only
noticed this stupid typo after sending it. Will send a v2 shortly.
S
much easier
to understand and the resulting function is still viewable within a
single screen.
Signed-off-by: Chris Rorvick
---
As made obvious by the previous version of this patch: compile tested
only.
Regards,
Chris
drivers/staging/emxx_udc/emxx_udc.c | 52
checkpatch.pl reported two warnings: A bare "unsigned" and an
unnecessary cast. Fixed both.
Signed-off-by: Chris Cesare
---
drivers/staging/comedi/drivers/serial2002.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/serial2002.c
checkpatch.pl warns about a bare unsigned and an unnecessary cast. Patchset
splits fixes for these into two separate patches.
Chris Cesare (2):
staging: comedi: serial2002: Fix bare unsigned styling issue
staging: comedi: serial2002: Fix unnecessary cast styling issue
drivers/staging/comedi
checkpatch.pl warns that a cast of 1 to (long long) is unnecessary.
Remove the cast and also add code to check and make sure that
maxdata_list[chan] is not shifted too far, as suggested by Ian
Abbott.
Signed-off-by Chris Cesare
---
drivers/staging/comedi/drivers/serial2002.c | 5 -
1 file
checkpatch.pl warns about a bare unsigned. Add type int to make
explicit and suit the coding style.
Signed-off-by Chris Cesare
---
drivers/staging/comedi/drivers/serial2002.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/serial2002.c
b
result.
--
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Markus Mayer writes:
> After introducing generic strltolower() and strtolower(), spk_strlwr()
> is no longer needed.
>
> Signed-off-by: Markus Mayer
> Acked-by: Samuel Thibault
Acked-by: Chris Brannon
Haven't looked at much kernel code in a while, but this l
Walt Feasel writes:
> Modified email address per the TODO file in
> speakup's email listing, also verified email
> address from speakup's website
NAK. The website needs updating, because it has Kirk's old addresses.
k...@reisers.ca is correct.
___
dev
Walt Feasel writes:
> Make email correction for k...@reisers.ca
>
> Signed-off-by: Walt Feasel
Acked-by: Chris Brannon
> ---
> v2 makes changes to correct for email format patch submission
>
> drivers/staging/speakup/TODO | 2 +-
> 1 file changed, 1 insertion(+)
Replace hard-coded function names in strings with '"%s...", __func__' in the
r8190_rtl8256.c file. Issue found by checkpatch.pl.
Signed-off-by: Chris Coffey
---
Patch generated on staging tree, staging-testing branch.
drivers/staging/rtl8192u/r8190_rtl8256.c | 10 +
Replace hard-coded function names in strings with "%s", __func__
in the goldfish_nand.c file. Issue found by checkpatch.pl.
Signed-off-by: Chris Coffey
---
drivers/staging/goldfish/goldfish_nand.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
Aleksei Fedotov writes:
> This patch fixes the checkpatch.pl warnings:
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Aleksey Fedotov
Acked-by: Chris Brannon
Seems fine t
My observation is just that if I remove the "NO_IOMEM if !PCI" from
arch/tile/Kconfig, my build fails with ioremap() undefined. No doubt I
could work around that, but my assumption was that NO_IOMEM was exactly the
right thing to express the fact that without PCI there is no I/O memory :-
On 7/17/2014 5:05 PM, Arnd Bergmann wrote:
On Thursday 17 July 2014 16:41:14 Chris Metcalf wrote:
On 7/17/2014 7:28 AM, Chen Gang wrote:
According to current source code, tile still has chance to choose
NO_IOMEM, for me, welcome the tile's maintainer's ideas or suggestions.
I&#x
s.
For this instance, I would go farther and suggest you may want
__GFP_RETRY_MAYFAIL | __GFP_NOWARN to prevent userspace from triggering
the lowmemkiller/oomkiller here.
(I would kill low_order_gfp_flags / high_order_gfp_flags and avoid the
obfuscation.)
-Chris
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Include the local ethtool.h header file in mtk_eth_soc.h so
implementation files have centralized access to it.
This fixes the following sparse warning:
drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol
'mtk_set_ethtool_ops' was not declared. Should it be static?
Signed-off
This fixes the following sparse warning:
drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol
'mtk_set_ethtool_ops' was not declared. Should it be static?
Signed-off-by: Chris Coffey
---
Changes in v2:
- Per GregKH's feedback (thanks!), don't add unnecessary new .
mmc_host *host, u32
> ocr,
> if (!mmc_host_is_spi(host)) {
> err = mmc_select_card(card);
> if (err)
> - return err;
> + goto free_card;
> }
>
> err =
_pci_sdmmc.o
> -
> obj-$(CONFIG_MMC_SDHCI_PLTFM)+= sdhci-pltfm.o
> obj-$(CONFIG_MMC_SDHCI_CNS3XXX) += sdhci-cns3xxx.o
> obj-$(CONFIG_MMC_SDHCI_ESDHC_IMX)+= sdhci-esdhc-imx.o
Thanks, pushed to mmc-next for 3.12.
- Chris.
--
Chris Ball <http://pri
== 0 || ret == -ERESTART)) {
if (ret == -ERESTART)
value = param->data.u.n.default_val;
spk_reset_default_value("pitch", synth->default_pitch,
value);
spk_reset_default_value("vol", synth->default_vol,
value);
}
-- Chris
ition of
the if statement to this:
if (param->var_id == VOICE && ret != -ERANGE) {
Or possibly better:
if (param->var_id == VOICE && ret == 0) {
I'd say please resend with that fix, or if not, I can send a one-line
patch to be applied
rflow bug:
Good catch. In fact, we shouldn't be using input at all! Instead, we
need to use the value of the voice parameter after it was changed. That
will be a valid index into the two tables. My patch does so.
-- Chris
___
devel maili
e for some time and it can be removed. What is
> happening is libcfs_nid2str is being
> called which requires lnet.ko now. This is a layer violation. I will be
> sending a patch very shortly.
>
Thanks, good to hear.
--chris
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
101 - 128 of 128 matches
Mail list logo
