Proposal

Hello there, I hope this message finds you in good spirits especially during this challenging time of coronavirus pandemic. I hope you and your family are well and keeping safe. Anyway, I am Chris Pavlides, a broker working with Flippiebecker Wealth. I got your contact (along with few other

Re: [PATCH] Fixed coding style problems.

Thanks for the feedback! I will retry the submission. Regards, Chris ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: comedi: shortened a long line

Hi Joe, Thank you for the feedback! I understand better now and will resend the patch. Regards, Chris Opperman ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: comedi: Improved readability of function comedi_nsamples_left.

Hi Greg, I've added changelog text to the patch below. Appreciate your feedback! Regards, Chris Opperman >8--8< Improved the readability of comedi_nsamples_left: a) Reduced nesting by using more return calls. b

[PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue

Fix a coding style issue as identified by checkpatch.pl Signed-off-by: Chris Bloomfield --- drivers/staging/ralink-gdma/ralink-gdma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c index 655df317d0ee

Re: Staging status of speakup

reproducer do you need here? It's straightforward to reproduce in casual use, at least with a software synthesizer. I don't know whether it affects hardware synths. -- Chris ___ devel mailing list de...@linuxdriverproject.org http://driverdev.lin

[PATCH] staging: rtl8723au: change typecast to match type returned by htons()

[unsigned] [short] [usertype] drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36:got restricted __be16 [usertype] This patch fixes the issue by using an endian-specific typecast that will always match the type returned by htons(). Signed-off-by: Chris Ruffin --- drivers/staging/rtl8723au/core

Re: [PATCH] staging: lustre: lustre: obdclass: lprocfs_status.c: Fix for possible null pointer dereference

/* Specified units override the multiplier */ - if (units) + if (units > 1) mult = mult < 0 ? -units : units; Chris ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] drivers: staging: lustre: Use mult if units not specified

hat it only applies when units are specified. Signed-off-by: Chris Rorvick --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/o

Re: [PATCH] drivers: staging: lustre: Use mult if units not specified

On Tue, Dec 16, 2014 at 5:35 AM, Dan Carpenter wrote: > On Tue, Dec 16, 2014 at 11:14:35AM +, Dilger, Andreas wrote: > > > > Sorry, that isn't right. Chris' patch is actually doing the right thing > > to check for units > 1. > > It's not right bec

[PATCH v2 0/2] lprocfs_write_frac_u64_helper cleanup

Added a second patch to address Dan Carpenter's concern with the complexity of passing the sign through `mult'. Compile tested only. Chris Rorvick (2): drivers: staging: lustre: Use mult if units not specified drivers: staging: lustre: Track sign separately drivers/staging/lus

[PATCH v2 2/2] drivers: staging: lustre: Track sign separately

suffix is specified, but having the effect of taking the absolute value of the user-provided data. Signed-off-by: Chris Rorvick --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdcla

[PATCH v2 1/2] drivers: staging: lustre: Use mult if units not specified

hat it only applies when units are specified. Signed-off-by: Chris Rorvick --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/o

[PATCH v3 0/2] lprocfs_write_frac_u64_helper cleanup

Added Andreas as reviewer (thanks!) v2: Added a second patch to address Dan Carpenter's concern with the complexity of passing the sign through `mult'. Compile tested only. Chris Rorvick (2): drivers: staging: lustre: Use mult if units not specified drivers: staging: lustre:

[PATCH v3 1/2] drivers: staging: lustre: Use mult if units not specified

hat it only applies when units are specified. Signed-off-by: Chris Rorvick Reviewed-by: Andreas Dilger --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b

[PATCH v3 2/2] drivers: staging: lustre: Track sign separately

suffix is specified, but having the effect of taking the absolute value of the user-provided data. Signed-off-by: Chris Rorvick Reviewed-by: Andreas Dilger --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/st

[PATCH 02/25] staging: line6: Remove line6_pod_transmit_paramter()

This function was no longer used as of commit 2807904441d4 (staging: line6: drop MIDI parameter sysfs attrs). Signed-off-by: Chris Rorvick --- drivers/staging/line6/pod.c | 9 - drivers/staging/line6/pod.h | 2 -- 2 files changed, 11 deletions(-) diff --git a/drivers/staging/line6

[PATCH 01/25] staging: line6: Remove `device_bit' from properties

The `device_bit' member was no longer used as of commit 2807904441d4 (staging: line6: drop MIDI parameter sysfs attrs). Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 44 +++--- drivers/staging/line6/driver.h | 5 drivers/staging/line6/

[PATCH 03/25] staging: line6: Remove unsupported X3 devices

Support for these devices appears to have never been completed. Remove them from the device table along with a minimal amount of supporting code. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 26 -- drivers/staging/line6/pcm.c | 2 -- drivers

[PATCH 09/25] staging: line6: Remove useless comments

Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c index 6dc8a0d..acde205 100644 --- a/drivers/staging/line6/driver.c +++ b/drivers/staging/line6/driver.c @@ -61,7

[PATCH 00/25] line6usb cleanup

idate configuration settings into the properties entries and use function pointers setup at initialization to remove much of the conditional logic. I have a TonePort UX2 that I've used for testing, meaning that some of this is really only compile-tested. Regards, Chris Chris Rorvick (25): stag

[PATCH 07/25] staging: line6: Key off of device type

hat map to specific interfaces on the device so that this conditional logic can be flattened out. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 203 --- drivers/staging/line6/driver.h | 4 +- drivers/staging/line6/pcm.c | 38 ---

[PATCH 04/25] staging: line6: Cleanup device table

Wrap USB_DEVICE to avoid repeating the Line 6 vendor ID. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c

[PATCH 12/25] staging: line6: List out capabilities individually

igned-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 54 +++-- drivers/staging/line6/usbdefs.h | 4 --- 2 files changed, 36 insertions(+), 22 deletions(-) diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c index c988b78..6f

[PATCH 10/25] staging: line6: Rename capability macros

Including "BIT" in the macro name is pointless. Replace with "CAP" to provide some context for what its value represents. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 8 drivers/staging/line6/midi.c | 2 +- drivers/staging/line6/pcm.c

[PATCH 06/25] staging: line6: Index properties array with device type

c and use the device type (via the .driver_info member) instead. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c index 2797e41..c0

[PATCH 08/25] staging: line6: Remove idVendor and idProduct macros

These are now only used to build the device table. Each entry in this table is already clearly documented as to what device it maps to so the macros become unnecessary indirection. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 56

[PATCH 05/25] staging: line6: Define a device type enum

Define an enum containing the supported devices and associate each entry in the device table to the respective value. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 54 -- drivers/staging/line6/driver.h | 21 2 files

[PATCH 13/25] staging: line6: Split out PODxt Live interfaces

The PODxt Live device has both a POD and a Variax interface. Add device type entries for each of these. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 112 - drivers/staging/line6/driver.h | 8 +-- drivers/staging/line6/pcm.c

[PATCH 11/25] staging: line6: Use explicit indexes when defining properties

Specify the index of the properties entry explicitly to define this structure more robustly. Also, drop the `L6PROP' macro in favor of initializing each member explicitly on its own line since horizontal space is limited and more attributes will be added later. Signed-off-by: Chris Ro

[PATCH 15/25] staging: line6: Filter on Pocket POD interface

The driver only supports interface 1 of the Pocket POD. Use the device table to filter on this. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/staging/line6/driver.c b/drivers/staging

[PATCH 22/25] staging: line6: Pass *_process_message() `usb_line6' pointers

Casting the `struct usb_line6' pointer at the call point makes the code difficult to read. This is substantially cleaned up by moving the cast into the callees. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 13 - drivers/staging/line6/pod.c| 3 ++- dr

[PATCH 14/25] staging: line6: Split out POD HD500 interfaces

The driver uses a different altsetting depending on the interface. Add device type entries for each of these. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 41 - drivers/staging/line6/driver.h | 3 ++- drivers/staging/line6/pcm.c

[PATCH 21/25] staging: line6: Pass *_init() `usb_line6' pointers

Casting the `struct usb_line6' pointer at the call point makes the code difficult to read. This is substantially cleaned up by moving the cast into the callees. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 21 ++--- drivers/staging/line6/pod.c

[PATCH 19/25] staging: line6: Remove stale Pocket POD PCM endpoints

Commit 1027f476f507 (staging: line6: sync with upstream) removed PCM from the Pocket POD capabilities but left the endpoint configuration. Signed-off-by: Chris Rorvick --- drivers/staging/line6/pcm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/line6/pcm.c b/drivers

[PATCH 16/25] staging: line6: Filter on UX2 interfaces

The driver only supports interface 0 of the TonePort UX2 and POD Studio UX2 devices. Use the device table to filter on this. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/staging

[PATCH 17/25] staging: line6: Move altsetting to properties

The device type can now be used to determine the altsetting for the interface. Drop the conditional logic and make this value a property. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 74 +- drivers/staging/line6/driver.h | 2 ++ 2

[PATCH 24/25] staging: line6: Call *_disconnect() via pointer

Which *_disconnect() to call on disconnect is known at initialization. Add a function pointer to the `usb_line6' struct and use to call into the appropriate logic instead of evaluating the conditional logic. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c

[PATCH 25/25] staging: line6: Make *_disconnect() functions static

Remove declarations from the header and move the definitions up in the source so they need not be forward declared. Signed-off-by: Chris Rorvick --- drivers/staging/line6/pod.c | 58 ++-- drivers/staging/line6/pod.h | 1 - drivers/staging/line6/podhd.c

[PATCH 23/25] staging: line6: Call *_process_message() via pointer

Which *_process_message() function (if any) to call when data is received is known at initialization. Add a function pointer to the `usb_line6' struct and use to call into the appropriate logic instead of evaluating the conditional logic for each message. Signed-off-by: Chris Ro

[PATCH 20/25] staging: line6: Move audio endpoints to properties

The device type can now be used to determine the addresses of the audio endpoints for the interface. Drop the conditional logic and make these values properties. Signed-off-by: Chris Rorvick --- drivers/staging/line6/capture.c | 9 drivers/staging/line6/driver.c | 38

[PATCH 18/25] staging: line6: Move control endpoints to properties

The device type can now be used to determine the addresses of the control endpoints for the interface. Drop the conditional logic and make these values properties. Signed-off-by: Chris Rorvick --- drivers/staging/line6/driver.c | 73 +- drivers/staging

Re: [PATCH 00/25] line6usb cleanup

> At Fri, 9 Jan 2015 23:35:46 -0600, > Chris Rorvick wrote: >> >> I have a TonePort UX2 that I've used for testing, meaning that some of >> this is really only compile-tested. > > If anyone is responsible for testing with real hardware, I'll happily >

[PATCH v4 1/2] staging: lustre: Use mult if units not specified

hat it only applies when units are specified. Signed-off-by: Chris Rorvick Reviewed-by: Andreas Dilger --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b

[PATCH v4 0/2] lprocfs_write_frac_u64_helper cleanup

mult'. Compile tested only. Chris Rorvick (2): staging: lustre: Use mult if units not specified staging: lustre: Track sign separately drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 9 + 1 file changed, 5 insertions(+), 4 del

[PATCH v4 2/2] staging: lustre: Track sign separately

suffix is specified, but having the effect of taking the absolute value of the user-provided data. Signed-off-by: Chris Rorvick Reviewed-by: Andreas Dilger --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/st

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

rce for that lying around here somewhere. This is "here there be dragons" territory. I think the only specification of the format is in the source code. -- Chris ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriv

[PATCH] staging: rtl8723bs: indicate disconnection when disconnecting

indicate the disconnection events during disconnection so the cfg80211_connect can connect to a different AP without problem. Signed-off-by: Chris Chiu --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep

[PATCH] staging: most: Fix build errors

et '_module_drivers/staging' failed make: *** [_module_drivers/staging] Error 2 Update the Makefile variables and paths with the new directory structure to fix these errors. Signed-off-by: Chris Coffey --- drivers/staging/most/Makefile | 14 +++--- 1 file changed, 7 insertions(+),

Re: [PATCH] staging: most: Fix build errors

On Tue, Nov 28, 2017 at 08:26:07AM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 27, 2017 at 09:12:39PM +0000, Chris Coffey wrote: > > This patch fixes build errors that occur when trying to build the > > MOST modules. For example, the cdev module build fails with: > > >

Re: [patch 1/3] speakup: extend synth buffer to 16bit unicode characters

ngs. > synth_putwc, synth_putwc_s, synth_putws and synth_putws_s helpers are > however added to put 16bit characters and strings. > > Signed-off-by: Samuel Thibault Reviewed-by: Chris Brannon Looks good to me. ___ devel m

Re: [patch 3/3] speakup: add unicode variant of /dev/softsynth

e Linux only supports 16bit characters, > we can just hardcode the UTF-8 encoding. > > Signed-off-by: Samuel Thibault Reviewed-by: Chris Brannon Looks good to me. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

> situations. > > Signed-off-by: Elena Reshetova > Signed-off-by: Hans Liljestrand > Signed-off-by: Kees Cook > Signed-off-by: David Windsor This looks OK to me. Acked-by: Chris Leech > --- > drivers/scsi/libiscsi.c| 8 > drivers/scsi/qedi/qedi_is

Re: [PATCHv2 1/2] speakup: make get_char actually get unicode characters

t; VC. This fixes by just turning the use_unicode parameter to 1. > > Signed-off-by: Samuel Thibault > Tested-by: Zahari Yurukov Reviewed-by: Chris Brannon ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCHv2 2/2] speakup: Support spelling unicode characters

void speak_char(u16 ch) > return; > } This is going to misidentify some Unicode characters >= 0x100 as capital. You probably want to add ch < 0x100 tests to the if(is_char ...) conditions, like you did in spell_word. Please resend with that fix and you'll get

Re: [PATCH] speakup: Fix bogus caps on speaking unicode characters

Samuel Thibault writes: > commit 33590c185299 ("speakup: Support spelling unicode characters") > mistakenly passed unicode characters to IS_CHAR(), which only > supports latin1. Let's assume non-latin1 is lower case, like is done > in spell_word().

Re: [PATCHv2 2/2] speakup: Support spelling unicode characters

Samuel Thibault writes: > This supports spelling unicode characters by just passing them to > the speech synthesis in direct mode. > > Signed-off-by: Samuel Thibault Reviewed-by: Chris Brannon ___ devel mailing list de...@linuxdriverproj

Re: [PATCH 0/3] staging: media: Replace a bit shift.

(+), 44 deletions(-) Most of these replacements add redundant parentheses around the BIT macro. IMHO this makes the code less readable. So I suggest (BIT(c)) -> BIT(c). Cheers, Chris ___ devel mailing list de...@linuxdriverproject.org h

[PATCH] Fixed coding style problems.

This patch fixes a coding style problem in drivers/staging/comedi/drivers.c and is submitted for task 10 of the eudyptula challenge. Signed-off-by: Chris Opperman --- drivers/staging/comedi/drivers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi

[PATCH] staging: comedi: shortened a long line

Shortened a long line to improve readability in drivers/staging/comedi/drivers.c Signed-off-by: Chris Opperman --- drivers/staging/comedi/drivers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c index

[PATCH] staging: comedi: Improved readability of function comedi_nsamples_left.

Signed-off-by: Chris Opperman --- drivers/staging/comedi/drivers.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c index 9d73347..3207ae2 100644 --- a/drivers/staging/comedi

Re: [PATCH] staging: comedi: Improved readability of function comedi_nsamples_left.

Hi Dan, Thank you for the feedback, I'll update V4 of the patch accordingly and resend. I'll soon get a hang of the workflow! :) Best Regards, Chris Opperman ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverp

[PATCH v4] staging: comedi: Improved readability of function comedi_nsamples_left.

mprove readability of comedi_nsamples_left: a) Reduce nesting by using more return statements. b) Declare variables scans_left and samples_left at start of function. c) Change type of scans_Left to unsigned long long to avoid cast. Signed-off-by: Chris Opperman --- drivers/staging/comedi/drivers.

Re: [PATCH v4] staging: comedi: Improved readability of function comedi_nsamples_left.

Hi Dan/Ian, Noted your comments regarding additional text, thanks! Just curious whether the "scissors" format given at the link below is valid? https://kernelnewbies.org/PatchTipsAndTricks It is given as an alternative to placing additional text below the cut-off line. Kind Rega

[PATCH v5] staging: comedi: Improved readability of function comedi_nsamples_left.

Improve readability of comedi_nsamples_left: a) Reduce nesting by using more return statements. b) Declare variables scans_left and samples_left at start of function. c) Change type of scans_Left to unsigned long long to avoid cast. Signed-off-by: Chris Opperman --- Changes v5: a) Moved

Re: [PATCH v5] staging: comedi: Improved readability of function comedi_nsamples_left.

Hi Ian, Thank you! Are there any more steps for me to take to complete this patch process? Kind Regards, Chris Opperman ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4] staging: comedi: Improved readability of function comedi_nsamples_left.

Hi Ian/Dan, In that case I'll stick to the cut-off line format in future. Thanks! Kind Regards, Chris Opperman ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: wlan-ng: improved readability of function prism2_add_key

Improve readability of prism2_add_key: a) Reduce nesting and removed goto statement by using more return statements. b) Added temporary "key" variable to reduce line length. Signed-off-by: Chris Opperman --- Improve readability of prism2_add_key: a) Reduce nesting and removed goto st

Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key

at be more acceptable? Kind Regards, Chris Opperman ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key

Hi Dan, The header also states "DO NOT EDIT OR MODIFY". As you suggested, I will rather leave this patch for now. P.S. Please advise if there is anything specific I can help out with, or I'll keep looking for more obvious fixes I can make while I'm learning the ropes.

Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key

Okay, in that case I will fix and resend the patch. Kind Regards, Chris Opperman ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging: wlan-ng: improved readability of function prism2_add_key

Improve readability of prism2_add_key: a) Reduce nesting and removed goto statement by using more return statements. Signed-off-by: Chris Opperman --- drivers/staging/wlan-ng/cfg80211.c | 40 +- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git a

[PATCH] staging: lustre: osc: clean up whitespace and align function parameters

Minor changes to remove excessive whitespace and improve readability of functions. Signed-off-by: Chris Hanna --- drivers/staging/lustre/lustre/osc/lproc_osc.c | 56 +++--- drivers/staging/lustre/lustre/osc/osc_cache.c | 112 ++-- drivers/staging/lustre/lustre/osc/osc_io.c

[PATCH resend] staging: lustre: osc: clean up whitespace and align function parameters

Signed-off-by: Chris Hanna Minor changes to remove excessive whitespace and improve readability of functions. --- Sending again due to tree mismatch. drivers/staging/lustre/lustre/osc/lproc_osc.c | 18 +- drivers/staging/lustre/lustre/osc/osc_cache.c | 196

Re: [PATCH resend] staging: lustre: osc: clean up whitespace and align function parameters

Thanks for noticing, I'll re-submit correctly. Chris On 6/3/15 1:54 AM, Sudip Mukherjee wrote: > On Tue, Jun 02, 2015 at 11:32:19AM -0400, Chris Hanna wrote: >> Signed-off-by: Chris Hanna >> >> Minor changes to remove excessive whitespace and improve >>

[PATCH resend] staging: lustre: osc: clean up whitespace and align function parameters

Minor changes to remove excessive whitespace and improve readability of osc functions. Signed-off-by: Chris Hanna --- Sending again due to tree mismatch. drivers/staging/lustre/lustre/osc/lproc_osc.c | 18 +- drivers/staging/lustre/lustre/osc/osc_cache.c | 196

[PATCH] staging: lustre: ptlrpc: clean up whitespace and align function params

Minor changes to remove excessive whitespace and improve readability of ptlrpc functions. Signed-off-by: Chris Hanna --- drivers/staging/lustre/lustre/ptlrpc/client.c | 90 drivers/staging/lustre/lustre/ptlrpc/events.c | 60 +++--- drivers/staging/lustre/lustre/ptlrpc

Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN

Hi Greg & All, On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote: > On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote: > > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote: > > > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > > > > The code

Re: [PATCH 1/2] staging: octeon: delete driver

I'll pipe up on this thread too On Tue, 2019-12-10 at 02:42 -0800, Guenter Roeck wrote: > On 12/10/19 1:15 AM, Greg Kroah-Hartman wrote: > > This driver has been in the tree since 2009 with no real movement to get > > it out. Now it is starting to cause build issues and other problems for > > peo

Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN

On Tue, 2020-02-04 at 07:36 +, gre...@linuxfoundation.org wrote: > On Tue, Feb 04, 2020 at 12:54:26AM +0000, Chris Packham wrote: > > Hi Greg & All, > > > > On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote: > > > On Mon, Dec 02, 2019 at 09:

Re: [PATCH 1/2] staging: octeon: delete driver

On Tue, 2020-02-04 at 07:09 +, gre...@linuxfoundation.org wrote: > On Tue, Feb 04, 2020 at 04:02:15AM +0000, Chris Packham wrote: > > I'll pipe up on this thread too > > > > On Tue, 2019-12-10 at 02:42 -0800, Guenter Roeck wrote: > > > On 12/10/1

[PATCH 4/6] MIPS: octeon: remove typedef declaration for cvmx_helper_link_info

Remove declaration of union cvmx_helper_link_info as typedef and update uses to use the union. Signed-off-by: Chris Packham --- arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++-- arch/mips/cavium-octeon/executive/cvmx-helper-rgmii.c | 6 +++--- arch/mips/cavium-octeon/executive

[PATCH 5/6] MIPS: octeon: remove typedef declaration for cvmx_pko_command_word0

Remove the typedef and update usage to use the union. Signed-off-by: Chris Packham --- arch/mips/cavium-octeon/executive/cvmx-helper.c | 2 +- arch/mips/include/asm/octeon/cvmx-pko.h | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/mips/cavium-octeon

[PATCH 0/6] Re-instate octeon staging drivers

This series re-instates the octeon drivers that were recently removed and addresses the build issues that lead to that decision. I've approached Cavium/Marvell about taking a more active interest in getting the code out of staging and into their proper location. No reply on that (yet).

[PATCH 6/6] Revert "staging/octeon: Mark Ethernet driver as BROKEN"

This reverts commit 075a1e87d1e2358d0b0301ac8f8e7f25051decf1. Now that the build issues have been fixed we can resume build testing. Signed-off-by: Chris Packham --- drivers/staging/octeon/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/octeon/Kconfig b/drivers

[PATCH 3/6] MIPS: octeon: remove typedef declaration for cvmx_wqe

Remove typedef declaration from struct cvmx_wqe and replace its previous uses with new struct declaration. Signed-off-by: Chris Packham --- .../cavium-octeon/executive/cvmx-helper.c | 2 +- .../include/asm/octeon/cvmx-helper-util.h | 2 +- arch/mips/include/asm/octeon/cvmx-pko.h

[PATCH 2/6] Revert "staging: octeon: delete driver"

This reverts commit 710d7fbe21ee2ceab121f1f84a20edf68f9f9742. Re-instate the code so subsequent commits can clean it up and get it building properly. Signed-off-by: Chris Packham --- drivers/staging/Kconfig |2 + drivers/staging/Makefile |1 + drivers

Re: [PATCH 0/6] Re-instate octeon staging drivers

:52写道： > > > > > > > > > > On Wed, Feb 05, 2020 at 01:11:10PM +1300, Chris Packham wrote: > > > > > > This series re-instates the octeon drivers that were recently > > > > > > removed and > > > > > > addresses the

Re: [PATCH]staging: slicoss: Fix possible reuse of freed memory in timer function

there is somewhere I can ship H/W in the states, I¹ll gladly do so. Best regards, Chris On 2/11/14, 2:37 AM, "Denis Kirjanov" wrote: >On 2/10/14, Kirill Tkhai wrote: >> Do not call kfree() till timer function is finished. >> >> [This was found using grep. Compiled t

Re: [PATCH v2 0/3] mmc: rtsx: fix bug and support nonblocking request

in. > > We offer a concise tuning searching method, it is much easier to read. > > At last we add support for nonblocking request, which will improve card read > speed at about 10% write speed about 5% normally. Thanks, all 3 patches pushed to mmc-next for 3.15. - Chris. -- C

Re: [PATCH] mmc: sdhci: add support for realtek rts5250

ed to mmc-next for 3.15. - Chris. -- Chris Ball <http://printf.net/> ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4 1/3] mfd: Add realtek USB card reader driver

Hi, On Mon, Feb 24 2014, Roger wrote: > Would you please help comment PATCH 2/3 and 3/3 (for mmc and memstick, > respectively) or give Acks? Thus we can proceed with applying or > revision if necessary. For 2/3: Acked-by: Chris Ball Thanks, - Chris. -- Chris Ball <http:

[PATCH] added pca9570 driver

does not seem to have either a staging/gpio nor a staging/include/linux/i2c directory to put the driver's files in. Please let me know what else I need to read and do, to make this patch into something that stands a chance of being accepted upstream. All the best, Chris. --- drivers/gp

[PATCH] Staging: rtl8188eu: core: rtw_debug: fixed a parentheses coding style issue

Removed unnecessary parentheses. Signed-off-by: Chris Elliott --- drivers/staging/rtl8188eu/core/rtw_debug.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_debug.c b/drivers/staging/rtl8188eu/core/rtw_debug.c index 2c4afb8

[PATCH] dma-buf, drm, ion: Propagate error code from dma_buf_start_cpu_access()

c11e391da2a8fe973c3c2398452000bed505851e Author: Daniel Vetter Date: Thu Feb 11 20:04:51 2016 -0200 dma-buf: Add ioctls to allow userspace to flush Testcase: igt/gem_concurrent_blit/*dmabuf*interruptible Testcase: igt/prime_mmap_coherency/ioctl-errors Signed-off-by: Chris Wilson Cc: Tiago Vignatti Cc

Re: [PATCH] dma-buf: Update docs for SYNC ioctl

eir flush. There are a few other possible deadlocks that are also avoided with EAGAIN (again, the issue is more or less the lack of fine grained locking). -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ devel mailing list d

Re: [PATCH] dma-buf: Update docs for SYNC ioctl

On Wed, Mar 23, 2016 at 04:32:59PM +0100, David Herrmann wrote: > Hi > > On Wed, Mar 23, 2016 at 12:56 PM, Chris Wilson > wrote: > > On Wed, Mar 23, 2016 at 12:30:42PM +0100, David Herrmann wrote: > >> My question was rather about why we do this? Semantics for EINTR

Re: [RFC v2 1/8] dma-buf/fence: add fence_collection fences

er fence_default_wait? You enable signaling on all, then wait sequentially. The code looks redundant and could just use fence_default_wait instead. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: wilc1000: fix warning while printing

size_t should print using %zu, but here it was use %lu. we were getting warning while printing. Signed-off-by: Chris Park --- drivers/staging/wilc1000/wilc_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

On Wed, Jan 28, 2015 at 4:42 PM, Rickard Strandqvist wrote: > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. Each of these changes adds a warning ... > diff --git a/drivers/staging/emxx_udc/emxx_udc.c > b/drivers/staging/emxx_

  1   2   >