>Yeah. That is often the fastest way to fix all the checkpatch warnings.
>
>Checkpatch warnings are pretty mechanical. Just send like 100 patches
>at a time until everything is fixed. Don't overthink. Say your patch
>breaks the alignment then you have to fix that, but oth
>On Fri, Oct 23, 2015 at 03:59:14PM -0400, James Simmons wrote:
>> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
>> b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
>> index 635a93c..d6d70d8 100644
>> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
>> ++
t;> 1 files changed, 70 insertions(+), 65 deletions(-)
>
>Doesn't apply, did I already queue up this series?
I did a second version of those patches. In one batch you will notice [PATCH
v2].
The reason I did a second batch was to break up the "fix checkpat
a3959f ("staging: lustre: fix remaining checkpatch issues for
>libcfs_hash.h")
Surprise this was merged which is why I did a second series for this.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>On Tue, Nov 03, 2015 at 05:49:00PM -0600, Frank Zago wrote:
>> Yes, but for consistency, all 4 functions should be changed.
>
>Thanks for the review. I will send a v2.
Greg merged your original patch so it will be a new patch.
___
dev
>Hello Dan,
>
>Thanks to report this. This issue was fixed in our code but not up streamed
>yet. The patch is available
>http://git.whamcloud.com/?p=fs%2Flustre->release.git;a=commit;h=d47f00d5a420b594b49564b2e00efca4602c3fb5
I just pushed a proper pa
s/staging/lustre/lustre/ldlm/ldlm_pool.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
>
Acked-by: James Simmons
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
index 20cf389..e59b286 100644
--- a/drivers/staging/lust
vers/staging/lustre/lustre/ldlm/ldlm_pool.c | 25 +
> 1 file changed, 13 insertions(+), 12 deletions(-)
Acked-by: James Simmons
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
index 1a4eef6..2beb36b 100644
--- a/drivers/s
e/lustre/ldlm/ldlm_pool.c | 10 +-
> 1 file changed, 1 insertion(+), 9 deletions(-)
Acked-by: James Simmons
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
index 2beb36b..20cf389 100644
--- a/drivers/staging/lustre/lustre/ldlm
/staging/lustre/lustre/libcfs/tracefile.c | 9 ++---
> 1 file changed, 2 insertions(+), 7 deletions(-)
Acked-by: James Simmons
diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.c
b/drivers/staging/lustre/lustre/libcfs/tracefile.c
index d55dda8..211047f 100644
--- a/drivers/stagin
bcfs/module.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: James Simmons
diff --git a/drivers/staging/lustre/lustre/libcfs/module.c
b/drivers/staging/lustre/lustre/libcfs/module.c
index 50e8fd2..516a9e7 100644
--- a/drivers/staging/lustre/lustre/libcfs/module.c
+++ b/
re/llite/dir.c | 9 ++---
> 1 file changed, 2 insertions(+), 7 deletions(-)
Acked-by: James Simmons
diff --git a/drivers/staging/lustre/lustre/llite/dir.c
b/drivers/staging/lustre/lustre/llite/dir.c
index 5c9502b..842e6d6 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/driv
> 2 files changed, 3 insertions(+), 2 deletions(-)
Acked-by: James Simmons
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
index b349847..f4fa725 100644
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
+++ b/drive
(0, &cptab->ctb_nodemask);
Yep and additional patch exist to fix this. Should I just push the fix for this
or drop this patch and create
a new patch that is combo of both fixes.
BTW Greg this new batch of patches are order independent. Sorry for not
pointing that out. The rest of the
pa
>Just did a fresh git pull --rebase and tried to do 'make deb-pkg' with
>an Ubuntu config (which enables lustre). I got the following:
>
>depmod: WARNING: found 2 modules in dependency cycles!
>depmod: WARNING:
>/home/arges/src/kernel/linux/./debian/tmp/lib/modules/4
any issues raising this to say 180 seconds. This is the
> > > value we
> > currently have for I/O
> > > timeout.
> >
> > So you want to replace it by "180 * HZ", which is ... another magic number?
>
> Ideally, I want this to be adjustable li
From: Nitesh A Jain
To: gre...@linuxfoundation.org
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org,
Nitesh A Jain
Subject: [PATCH] Staging: bcm: Bcmchar.c: fixed a space before semicolon coding
style issue
Date: Tue, 24 Dec 2013 22:51:14 +0530
Message-Id
Signed-off-by: James A Shackleford
---
(For Eudyptula Challenge)
---
drivers/staging/ozwpan/ozhcd.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index b3d401a..91bb29e 100644
--- a/drivers/staging/ozwpan
Add missing __user macro to second parameter of ethtool_ioctl().
This removes the need for the offending (void *) cast of the user space pointer
rq->ifr_data.
Signed-off-by: James A Shackleford
---
drivers/staging/vt6655/device_main.c |6 +++---
1 file changed, 3 insertions(+), 3 deleti
This patch fixes the following sparse warning in bpctl_mod.c:
warning: symbol 'bpvm_lock' was not declared. Should it be static?
Signed-off-by: James A Shackleford
---
drivers/staging/silicom/bpctl_mod.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
3:6: warning: symbol 'skein_1024_process_block' was not
declared. Should it be static?
by including the header skein_block.h, which contains the declarations in
question.
Signed-off-by: James A Shackleford
---
drivers/staging/skein/skein_block.c |1 +
1 file changed, 1 insertion(+)
diff
147:11: warning: symbol 'SKEIN_1024_IV_512' was not declared. Should
it be static?
skein_iv.h:167:11: warning: symbol 'SKEIN_1024_IV_1024' was not declared.
Should it be static?
by declaring the initialization vectors in question as static. The header
skein_iv.h is only includ
as not declared. Should it
be static?
Signed-off-by: James A Shackleford
---
drivers/staging/vt6655/dpc.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/dpc.c b/drivers/staging/vt6655/dpc.c
index 7ddaf26..696564b 100644
--- a/drivers/staging/vt66
) in the
function declaration matches the definition.
Signed-off-by: James A Shackleford
---
drivers/staging/vt6655/iwctl.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/iwctl.h b/drivers/staging/vt6655/iwctl.h
index 871bd7c..4ad5e48 100644
--- a
Update declaration of iwctl_private_args to match definition in iwctl.c
Signed-off-by: James A Shackleford
---
drivers/staging/vt6655/iwctl.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/iwctl.h b/drivers/staging/vt6655/iwctl.h
index 4ad5e48
?
iwctl.c:1644:5: warning: symbol 'iwctl_giwgenie' was not declared. Should it be
static?
iwctl.c:1669:5: warning: symbol 'iwctl_siwencodeext' was not declared. Should
it be static?
iwctl.c:1783:5: warning: symbol 'iwctl_giwencodeext' was not declared. Should
it be st
Signed-off-by: James A Shackleford
---
drivers/staging/vt6655/baseband.c | 300 ++---
1 file changed, 150 insertions(+), 150 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.c
b/drivers/staging/vt6655/baseband.c
index 6f95fb6..490ca96 100644
--- a
From: Raghavendra
Fixed coding style issues
Signed-off-by: A Raghavendra Rao
---
drivers/staging/rtl8192e/dot11d.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/dot11d.c
b/drivers/staging/rtl8192e/dot11d.c
index 53da610..ef9da86
Replaced 'printk' with 'netdev_' function
Signed-off-by: A Raghavendra Rao
---
drivers/staging/rtl8192e/dot11d.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/dot11d.c
b/drivers/staging/rtl8192e/dot11d.c
index 53d
Replaced 'printk' with 'netdev_' function
Signed-off-by: A Raghavendra Rao
---
drivers/staging/rtl8192e/dot11d.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/dot11d.c
b/drivers/staging/rtl8192e/dot11d.c
index 53d
On Thu, Jun 19, 2014 at 04:35:02PM -0700, Greg KH wrote:
> On Sun, Jun 01, 2014 at 10:19:31PM -0400, James A Shackleford wrote:
> > The function iwctl_siwscan() is defined in iwctl.c as:
> > int iwctl_siwscan(struct net_device *dev,
> > struct
The functions iwctl_giwscan() and iwctl_siwscan() are only referenced
within iwctl.c -- so, remove their function declarations from iwctl.h
and mark these functions as static.
Signed-off-by: James A Shackleford
---
drivers/staging/vt6655/iwctl.c |4 ++--
drivers/staging/vt6655/iwctl.h
This patch allocates a few pages and performs an ioread8_rep() from the bus
address, which are then copied to userspace. This fixes the sparse warning:
drivers/staging/goldfish/goldfish_audio.c:136:43: warning: incorrect type in
argument 2 (different address spaces)
drivers/staging/goldfish
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h |5 -
drivers/staging/rtl8712/rtl8712_cmd.c |2 +-
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8712/osdep_service.h
b/drivers/staging/rtl8712/osdep_service.h
index
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h |5 -
drivers/staging/rtl8712/rtl8712_recv.c |2 +-
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8712/osdep_service.h
b/drivers/staging/rtl8712/osdep_service.h
index
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8712/osdep_service.h
b/drivers/staging/rtl8712/osdep_service.h
index 37ec56b..9316eab 100644
--- a/drivers/staging/rtl8712/osdep_service.h
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8712/osdep_service.h
b/drivers/staging/rtl8712/osdep_service.h
index 9316eab..425f0f1 100644
--- a/drivers/staging/rtl8712/osdep_service.h
_init_listhead is just an inline wrapper around INIT_LIST_HEAD. This
patch removes the wrapper and directly uses INIT_LIST_HEAD instead.
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h |7 +--
drivers/staging/rtl8712/rtl8712_recv.c|4
is_list_empty is just an inline wrapper around list_empty. This patch
removes the wrapper and directly uses list_empty instead.
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h | 10 +-
drivers/staging/rtl8712/rtl8712_recv.c |4 ++--
drivers/staging
list_insert_tail is just an inline wrapper around list_add_tail. This
patch removes the wrapper and directly uses list_add_tail.
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h |6 --
drivers/staging/rtl8712/rtl8712_recv.c| 10 +-
drivers
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8712/osdep_service.h
b/drivers/staging/rtl8712/osdep_service.h
index 77b1443..3dfc473 100644
--- a/drivers/staging/rtl8712/osdep_service.h
get_next is just an inline wrapper around return list->next. This
patch removes the wrapper and directly uses list->next where
applicable.
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h |5 -
drivers/staging/rtl8712/rtl8712_recv.c
_queue_empty is an inline wrapper around list_empty. This patch removes this
wrapper function and instead calls list_empty directly.
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h |5 -
drivers/staging/rtl8712/rtl8712_cmd.c |2 +-
drivers
get_list_head is an inline that returns &list->head. This patch removes this
inline and directly applies &list->head where applicable.
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h |5 -
drivers/staging/rtl8712/rtl8712_recv.c
list_delete is just an inline wrapper around list_del_init. This patch
removes the wrapper and directly uses list_del_init.
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h |5 -
drivers/staging/rtl8712/rtl8712_recv.c|8
drivers/staging
used
only in code for ioctl 0xff and first lines of this ioctl do the
same work. So this patch deletes part of unneeded code
(initialization of wpa_Result to zero in device_open()) and
declares wpa_Reslult as static to avoid sparse warning.
Signed-off-by: Vladimir A. Nazarenko
---
drivers/stag
wpa_supplicant we
can safely remove this unused ioctl.
Signed-off-by: Vladimir A. Nazarenko
---
drivers/staging/vt6655/ioctl.c | 32
1 file changed, 32 deletions(-)
diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c
index 970e80d..f8e990f 100644
This variable unused, so remove it.
Signed-off-by: Vladimir A. Nazarenko
---
drivers/staging/vt6655/device_main.c | 8
drivers/staging/vt6655/ioctl.c | 4
2 files changed, 12 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655
It's never enabled, so we can safely remove it.
Signed-off-by: Vladimir A. Nazarenko
---
drivers/staging/vt6655/device_main.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main.c
index de
There is code encapsulated in #if 1, let's remove it.
Signed-off-by: Vladimir A. Nazarenko
---
drivers/staging/vt6655/device_main.c | 4
drivers/staging/vt6655/wpactl.c | 3 ---
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/st
It's never enabled, so we can safely remove it.
Signed-off-by: Vladimir A. Nazarenko
---
drivers/staging/vt6655/device_main.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main.c
index 6a
Hi Greg,
We spoke about this several months ago. Since then, there has been no
life from any of the maintainers or anybody at Atmel. Meanwhile Dan
Carpenter has posted a patch for a security vulnerability in ozwpan
that hasn't been reviewed or merged. There is nobody willing to
maintain it
On Mon, Aug 10, 2015 at 3:31 PM, Jason A. Donenfeld wrote:
> Meanwhile Dan
> Carpenter has posted a patch for a security vulnerability in ozwpan
> that hasn't been reviewed or merged.
Sorry, I see that you did in fact pick up this patch, so I retract
that statement.
Nonetheless,
Ozwpan is completely unmaintained and potentially a security problem. As
this is a staging driver, it should be removed, since it has been
abandoned. Marking it as orphaned is the first step here.
Signed-off-by: Jason A. Donenfeld
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1
On Tue, Jul 08, 2014 at 01:16:53PM +0300, Dan Carpenter wrote:
> On Tue, Jun 24, 2014 at 10:52:41PM -0400, James A Shackleford wrote:
> > Signed-off-by: James A Shackleford
> > ---
> > drivers/staging/rtl8712/osdep_service.h |5 -
> > 1 file changed, 5 deletio
The inline function _init_workitem() is just a wrapper around INIT_WORK().
Oddly, this wrapper accepts 3 parameters while INIT_WORK() only accepts 2.
The third parameter is unused.
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h | 5 -
drivers/staging
The inline function _set_workitem() simply wraps schedule_work(). Removed.
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h | 5 -
drivers/staging/rtl8712/rtl8712_led.c | 2 +-
drivers/staging/rtl8712/rtl871x_pwrctrl.c | 4 ++--
3 files changed, 3
_workitem is just a #define for work_struct. Remove the #define and
use struct work_struct directly instead.
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/drv_types.h | 2 +-
drivers/staging/rtl8712/osdep_service.h | 1 -
drivers/staging/rtl8712/rtl871x_led.h | 2
The inline function thread_enter() accepts a single ignored parameter and is
just a wrapper for allow_signal(SIGTERM). Removed.
Signed-off-by: James A Shackleford
---
drivers/staging/rtl8712/osdep_service.h | 5 -
drivers/staging/rtl8712/rtl8712_cmd.c | 2 +-
2 files changed, 1 insertion
ers/staging/rtl8192u/r8192U_core.c:4876:5: warning: symbol
'GetRxPacketShiftBytes819xUsb' was not declared. Should it be static?
Signed-off-by: A Raghavendra Rao
---
drivers/staging/rtl8192u/r8192U_core.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --
ers/staging/rtl8192u/r8192U_core.c:4876:5: warning: symbol
'GetRxPacketShiftBytes819xUsb' was not declared. Should it be static?
Signed-off-by: A Raghavendra Rao
---
drivers/staging/rtl8192u/r8192U_core.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --
-than=]
The variable to 'struct p80211msg_p2req_readpda' was previously being created
on the stack, which inturn exeeded the frame size limit, resulting in a
sparse warning. This patch alloctes the memory to the structure dynamically
and the operations are left unchanged.
Signed
he "crypto: Remove unnecessary memzero_explicit()" patch for
> > now as there can be a bit more discussion on what is best. It will be
> > introduced as a separate patch later on after this one is merged.
>
> To this larger audience a
(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
See also: git log --oneline '--author=Alexander A. Klimov
' v5.7..master
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
See also: git log --oneline '--author=Alexander A. Klimov
' v5.7..master
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
See also: git log --oneline '--author=Alexander A. Klimov
' v5.7..master
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.
Signed-off-by: Alexander A. Klimov
---
Continuing my work started at 93431e0607e5.
See also: git log --oneline '--author=Alexander A. Klimov
' v5.7..master
Peace, mercy and blessings of God be upon you, my beloved. I am happy
to meet you here as friends.
My name is Melena Alicia
I am a Canadian but I live in the USA.
I am 48 years old.
I used to work for foreign petroleum exploration company and also
engaged in business investments before my
On 10/5/18 10:58 PM, Scott Tracy wrote:
> Signed-off-by: Scott Tracy
> ---
> drivers/staging/rtlwifi/core.c | 5 +++--
> drivers/staging/rtlwifi/efuse.c | 5 +++--
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/core.c b/dr
Thanks
--
Gustavo
> Signed-off-by: Maxime Desroches
> ---
> drivers/staging/rts5208/rtsx_card.c | 96 +++--
> 1 file changed, 37 insertions(+), 59 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_card.c
> b/drivers/staging/rts5208/rtsx_
Hi,
On 10/8/18 9:33 AM, Loic Tourlonias wrote:
> Remove useless code inside if_0 endif
>
> Signed-off-by: Loic Tourlonias
> ---
> drivers/staging/emxx_udc/emxx_udc.h | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h
>
nzip_vle_lz4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/unzip_vle_lz4.c
> b/drivers/staging/erofs/unzip_vle_lz4.c
> index f5b665f..501cfe0 100644
> --- a/drivers/staging/erofs/unzip_vle_lz4.c
> +++ b/drivers/sta
;Structurally dead code")
Fixes: 347e244884c3 ("staging: comedi: tio: implement global tio/ctr routing")
Signed-off-by: Gustavo A. R. Silva
---
drivers/staging/comedi/drivers/ni_tio.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/comedi/drivers/ni_tio.c
b/d
On 10/12/18 11:04 AM, Ian Abbott wrote:
> On 11/10/2018 20:05, Gustavo A. R. Silva wrote:
>> Currently, there are multiple missing break statements in two switch code
>> blocks. This makes the execution path to fall all the way down through
>> to the default cases, whi
e it turns out
>> the userland hv_kvp_daemon needs the info of operation, adapter_id and
>> addr_family. With the incorrect fc62c3b1977d, the host can't get the
>> VM's IP via KVP.
>>
>> And, fc62c3b1977d added a "break;", but actually forgot to initialize
>
There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The older
style of one-element or zero-length arrays should no longer be used[2
On 2/11/21 05:06, Dan Carpenter wrote:
> On Wed, Feb 10, 2021 at 04:49:37PM -0600, Gustavo A. R. Silva wrote:
>> There is a regular need in the kernel to provide a way to declare having
>> a dynamically sized set of trailing elements in a structure. Kernel code
>> should
On 2/20/21 12:21, Atul Gopinathan wrote:
> The variable "info_element" is of the following type:
> struct rtllib_info_element *info_element
>
> rtllib_info_element is a struct containing the following fields as
> defined in drivers/staging/rtl8192e/rtllib.h:
>
There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The older
style of one-element or zero-length arrays should no longer be used[2].
Use
through to the next case.
Notice that in order to enable -Wimplicit-fallthrough for Clang, this
change[1] is meant to be reverted at some point. So, this patch helps
to move in that direction.
Something important to mention is that there is currently a discrepancy
between GCC and Clang when dealing with
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of just
letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva
---
drivers/staging
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of just
letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva
---
drivers/staging
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva
---
drivers/staging/media/atomisp/pci
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva
---
drivers/staging/qlge/qlge_main.c | 1
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva
---
drivers/staging/vt6656/main_usb.c | 1
On 11/20/20 12:28, Joe Perches wrote:
> On Fri, 2020-11-20 at 12:21 -0600, Gustavo A. R. Silva wrote:
>> Hi all,
>>
>> This series aims to fix almost all remaining fall-through warnings in
>> order to enable -Wimplicit-fallthrough for Clang.
>>
>> In prepa
Hi,
On 11/20/20 12:53, Jakub Kicinski wrote:
> On Fri, 20 Nov 2020 12:21:39 -0600 Gustavo A. R. Silva wrote:
>> This series aims to fix almost all remaining fall-through warnings in
>> order to enable -Wimplicit-fallthrough for Clang.
>>
>> In preparation to enable
On Mon, Nov 23, 2020 at 04:03:45PM -0400, Jason Gunthorpe wrote:
> On Fri, Nov 20, 2020 at 12:21:39PM -0600, Gustavo A. R. Silva wrote:
>
> > IB/hfi1: Fix fall-through warnings for Clang
> > IB/mlx4: Fix fall-through warnings for Clang
> > IB/qedr: Fix fall-th
201 - 300 of 428 matches
Mail list logo
