[PATCH 3/7 RESEND] staging: et131x: reduce split lines in et131x_rx_dma_memory_free

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 63d28ae..881ae4f 100644 --- a/drivers/staging/et131x

[PATCH 4/7 RESEND] staging: et131x: reduce split lines in nic_return_rfd

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 881ae4f..90ef45b 100644 --- a/drivers/staging/et131x/et131x.c +++ b

[PATCH 1/7 v2] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index e3a71d3..f86e713 100644 --- a/drivers/staging/et131x/et131x.c +++ b

[PATCH 4/7 v2] staging: et131x: reduce split lines in nic_return_rfd

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index f925ce6..5c431c3 100644 --- a/drivers/staging/et131x/et131x.c +++ b

[PATCH 1/2] staging: et131x: improve code consistency: access struct rx_ring

Let all the code use a pointer called rx_ring to access struct rx_ring members. Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 48 + 1 file changed, 20 insertions(+), 28 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers

[PATCH 2/2] staging: et131x: improve code consistency: access struct tx_ring

Let all the code use a pointer called tx_ring to access struct tx_ring members. Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 190 1 file changed, 95 insertions(+), 95 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers

[PATCH v3 3/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_free

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 9272548..5a45465 100644 --- a/drivers/staging/et131x

[PATCH v3 2/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_alloc

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 48 - 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index d16ac57..9272548 100644 --- a/drivers/staging

[PATCH v3 1/7] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 5dd2170..d16ac57 100644 --- a/drivers/staging/et131x/et131x.c +++ b

[PATCH v3 7/7] staging: et131x: remove unnecessary pointer typecast

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 89bd8ca..fdb19df 100644 --- a/drivers/staging/et131x/et131x.c +++ b

[PATCH v3 5/7] staging: et131x: reduce split lines in nic_rx_pkts

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index f498eec..89bd8ca 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drivers/staging

[PATCH v3 4/7] staging: et131x: reduce split lines in nic_return_rfd

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 5a45465..f498eec 100644 --- a/drivers/staging/et131x/et131x.c +++ b

[PATCH v3 6/7] staging: et131x: remove item that have been done in TODO file

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/README | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README index 8da96a6..3befc45 100644 --- a/drivers/staging/et131x/README +++ b/drivers/staging/et131x/README @@ -13,10 +13,6

Re: [PATCH v3 1/7] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

On Mon, Dec 9, 2013 at 4:53 PM, Greg Kroah-Hartman wrote: > On Mon, Dec 09, 2013 at 04:46:08PM +0800, ZHAO Gang wrote: >> Signed-off-by: ZHAO Gang >> --- >> drivers/staging/et131x/et131x.c | 24 ++-- >> 1 file changed, 10 insertions(+), 14 deleti

[PATCH v4 2/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_alloc

Signed-off-by: ZHAO Gang Acked-by: Mark Einon --- drivers/staging/et131x/et131x.c | 48 - 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index d16ac57..9272548 100644 --- a

[PATCH v4 1/7] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

Signed-off-by: ZHAO Gang Acked-by: Mark Einon --- drivers/staging/et131x/et131x.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 5dd2170..d16ac57 100644 --- a/drivers/staging

[PATCH v4 4/7] staging: et131x: reduce split lines in nic_return_rfd

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 5a45465..f498eec 100644 --- a/drivers/staging/et131x/et131x.c +++ b

[PATCH v4 6/7] staging: et131x: remove item that have been done in TODO file

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/README | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README index 8da96a6..3befc45 100644 --- a/drivers/staging/et131x/README +++ b/drivers/staging/et131x/README @@ -13,10 +13,6

[PATCH v4 5/7] staging: et131x: reduce split lines in nic_rx_pkts

Signed-off-by: ZHAO Gang Acked-by: Mark Einon --- drivers/staging/et131x/et131x.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index f498eec..89bd8ca 100644 --- a/drivers/staging/et131x/et131x.c

[PATCH v4 7/7] staging: et131x: remove unnecessary pointer typecast

Signed-off-by: ZHAO Gang Acked-by: Mark Einon --- drivers/staging/et131x/et131x.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 89bd8ca..fdb19df 100644 --- a/drivers/staging

[PATCH v4 3/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_free

Signed-off-by: ZHAO Gang Acked-by: Mark Einon --- drivers/staging/et131x/et131x.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 9272548..5a45465 100644 --- a/drivers

Re: [PATCH] et131x: fix allocation failures

add Cc to devel mailing list On Wed, 2014-02-05 at 19:56:19 +0800, Alan wrote: > We should check the ring allocations don't fail. > If we get a fail we need to clean up properly. The allocator assumes the > deallocator will be used on failure, but it isn't. Fix this and add a > missing check again

[PATCH RESEND 1/3] staging: et131x: stop read when hit max delay in et131x_phy_mii_read

stop read and return error when hit max delay time. Signed-off-by: Zhao, Gang Acked-by: Mark Einon --- Acked at post: http://article.gmane.org/gmane.linux.kernel/1599347 drivers/staging/et131x/et131x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/et131x/et131x.c b

[PATCH RESEND 2/3] staging: et131x: remove spinlock adapter->lock

adapter->lock is only used in et131x_multicast(), which is eventually called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode() is always called by (net_device *)dev->addr_list_lock hold, to protect from concurrent access. So adapter->lock is redundant. Signed-off-by: Z

[PATCH RESEND 3/3] staging: et131x: fix make W=1 build warning

not used [-Wunused-but-set-variable] u32 pm_csr; ^ Signed-off-by: Zhao, Gang --- drivers/staging/et131x/et131x.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 6413500..0c44014 100644 --- a/drivers

[PATCH] staging: gasket: core: Fix a coding style issue in gasket_core.c

Fix a coding alignment issue found by checkpatch.pl. Signed-off-by: Zhixu Zhao --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c index 67325fbaf760

[PATCH v2] staging: gasket: core: Fix a coding style issue in gasket_core.c

A coding alignment issue is found by checkpatch.pl. Fix it by using a temporary for gasket_dev->bar_data[bar_num]. Signed-off-by: Zhixu Zhao --- Please ignore the last email (if you received it) because I forgot to Cc the mailing list. Sorry for the noise... Changes in v2: - gasket_

Re: [PATCH v2] staging: gasket: core: Fix a coding style issue in gasket_core.c

ns[bar_num]` are not the same thing as I see it. Besides, `struct gasket_bar_data` doesn't have a `size` field (it does have a `length_bytes` field). So... did I miss anything? -- Zhixu Zhao https://github.com/zhaozhixu ___ devel mailing list de...@

Re: [PATCH v2] staging: gasket: core: Fix a coding style issue in gasket_core.c

On Thu, Jun 18, 2020 at 12:11:27AM +0800, Zhixu Zhao wrote: > A coding alignment issue is found by checkpatch.pl. > Fix it by using a temporary for gasket_dev->bar_data[bar_num]. > > Signed-off-by: Zhixu Zhao Hi, there~ Does anybody have any further comments on this? Can it be

[PATCH v3] staging: gasket: core: Fix a coding style issue in gasket_core.c

A coding alignment issue is found by checkpatch.pl. Fix it by using a temporary for gasket_dev->bar_data[bar_num]. Signed-off-by: Zhixu Zhao --- Changes in v2: - gasket_dev->bar_data[bar_num] was used everywhere. Now replace it with a `struct gasket_bar_data *data`, making the cod

[PATCH] staging: Add Mediatek High Frequency Manager Framework

_manager/core/hf_manager.c new file mode 100644 index ..a4d4298d5265 --- /dev/null +++ b/drivers/staging/hf_manager/core/hf_manager.c @@ -0,0 +1,1419 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2020 MediaTek Inc. + * Author: Hongxu Zhao + */ + +#define pr_fmt(fmt) &

Re: [PATCH] staging: Add Mediatek High Frequency Manager Framework

On Tue, 2020-08-04 at 10:11 +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 04, 2020 at 03:52:49PM +0800, hongxu.zhao wrote: > > Add a new sensor framework into linux kernel which can support multi client > > request sensor data. > > There are the following features: > > 1.Ringbuffer between ma

Re: [PATCH] staging: Add Mediatek High Frequency Manager Framework

ency Manager Framework to show > > manager details and client details, is not for device drivers. > > Then it is not needed :) > > > we recommend device driver(like test/test_app.c) use sysfs which under > > High Frequency Manager Framework. > > Then you need to document it really well as to what you are doing here. > > But again, please try working with the IIO framework as that is what we > have today. Any improvements you make to it will help everyone out. > > Adding a third way to handle sensor data to the kernel is probably not > going to work well for anyone... Yes, I approve your ideas, but iio framework is too much more complicated and widely used, if I improve iio framework maybe not compatible with old interface. Then I decide add a new framework to staging. :) thanks hognxu zhao ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] android: binder: fix dangling pointer comparison

在 2016/6/16 6:39, Jann Horn 写道: On Thu, Jun 16, 2016 at 12:31 AM, Arve Hjønnevåg wrote: On Wed, Jun 15, 2016 at 3:09 PM, Jann Horn wrote: If /dev/binder is opened and the opener process then e.g. calls execve, proc->vma_vm_mm will still point to the location of the now-freed mm_struct. If t

Re: [PATCH v2] android: binder: fix dangling pointer comparison

在 2016/8/18 23:23, Greg Kroah-Hartman 写道: On Tue, Aug 16, 2016 at 07:44:59PM -0700, Arve Hjønnevåg wrote: On Mon, Aug 15, 2016 at 7:58 AM, Greg Kroah-Hartman wrote: On Thu, Jun 16, 2016 at 12:45:33AM +0200, Jann Horn wrote: If /dev/binder is opened and the opener process then e.g. calls exe

<    1   2