At 2020-06-18 03:10:02, "Dan Carpenter" wrote:
>On Thu, Jun 18, 2020 at 12:11:27AM +0800, Zhixu Zhao wrote:
>> diff --git a/drivers/staging/gasket/gasket_core.c
>> b/drivers/staging/gasket/gasket_core.c
>> index 67325fbaf760..28dab302183b 100644
>> --- a
09:17 +0200, Greg KH wrote:
>> > > > On Wed, Jul 15, 2020 at 07:44:40AM +0800, Zhixu Zhao wrote:
>> > > > > On Thu, Jun 18, 2020 at 12:11:27AM +0800, Zhixu Zhao wrote:
>> > > > > > A coding alignment issue is fou
Co-developed-by: Liu Shuo
Signed-off-by: Liu Shuo
Signed-off-by: Zhao Yakui
---
drivers/staging/acrn/Makefile | 3 +-
drivers/staging/acrn/acrn_hv_defs.h | 65
drivers/staging/acrn/acrn_hypercall.c | 136 ++
drivers/staging/acrn
destroyed, the low-level
ACRN hypervisor will free the corresponding vcpu implicitly.
Co-developed-by: Jason Chen CJ
Signed-off-by: Jason Chen CJ
Co-developed-by: Liu Shuo
Signed-off-by: Liu Shuo
Signed-off-by: Zhao Yakui
---
drivers/staging/acrn/Makefile | 3 +-
drivers/staging/acrn
CJ
Signed-off-by: Jason Chen CJ
Signed-off-by: Zhao Yakui
---
arch/x86/kernel/cpu/acrn.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c
index 676022e..95db5c4 100644
--- a/arch/x86/kernel/cpu/acrn.c
+++ b/arch
interrupt is triggered.
Co-developed-by: Gao, Shiqing
Signed-off-by: Gao, Shiqing
Co-developed-by: Jason Chen CJ
Signed-off-by: Jason Chen CJ
Signed-off-by: Zhao Yakui
---
drivers/staging/acrn/acrn_dev.c | 77 +++
drivers/staging/acrn/acrn_drv_internal.h
can construct the DSDT with Power frequence/C-state idle
for guest system.
Co-developed-by: Jason Chen CJ
Signed-off-by: Jason Chen CJ
Co-developed-by: Victor Sun
Signed-off-by: Victor Sun
Signed-off-by: Zhao Yakui
---
drivers/staging/acrn/acrn_dev.c | 75
vices/system/cpu/cpuX/online
Currently this is mainly used in user-space device model before
booting other ACRN guest.
Co-developed-by: Jason Chen CJ
Signed-off-by: Jason Chen CJ
Signed-off-by: Zhao Yakui
---
drivers/staging/acrn/acrn_dev.c | 45 +
1
(int client_id);
Co-developed-by: Jason Chen CJ
Signed-off-by: Jason Chen CJ
Co-developed-by: Yin FengWei
Signed-off-by: Yin FengWei
Co-developed-by: Liu Shuo
Signed-off-by: Liu Shuo
Signed-off-by: Zhao Yakui
---
drivers/staging/acrn/Makefile | 3 +-
drivers/staging/acrn
.
This is similar to that in XEN/HyperV.
Co-developed-by: Jason Chen CJ
Signed-off-by: Jason Chen CJ
Signed-off-by: Zhao Yakui
---
arch/x86/include/asm/acrn.h | 3 +++
arch/x86/kernel/cpu/acrn.c | 12
2 files changed, 15 insertions(+)
diff --git a/arch/x86/include/asm/acrn.h b
X2APIC caps.
The remaining patches add the ACRN driver module, which accepts the ioctl
from user-space and then communicate with the low-level ACRN hypervisor
by using hypercall.
Zhao Yakui (15):
x86/acrn: Report X2APIC for ACRN guest
x86/acrn: Add two APIs to add/remove driver-specific upcall ISR
space module also needs to check the driver version.
Co-developed-by: Jason Chen CJ
Signed-off-by: Jason Chen CJ
Co-developed-by: Liu Shuo
Signed-off-by: Liu Shuo
Signed-off-by: Zhao Yakui
---
drivers/staging/acrn/acrn_dev.c | 47 +++
include/uapi/linux
instruction.
Co-developed-by: Jason Chen CJ
Signed-off-by: Jason Chen CJ
Signed-off-by: Zhao Yakui
---
arch/x86/include/asm/acrn.h | 54 +
1 file changed, 54 insertions(+)
diff --git a/arch/x86/include/asm/acrn.h b/arch/x86/include/asm/acrn.h
index
: monitor the interrupt info for one guest OS
Co-developed-by: Jason Chen CJ
Signed-off-by: Jason Chen CJ
Co-developed-by: Mingqiang Chi
Signed-off-by: Mingqiang Chi
Signed-off-by: Zhao Yakui
---
drivers/staging/acrn/acrn_dev.c | 48 +++
drivers/staging
r the interrupt injection
on acrn_hsm side.
Co-developed-by: Shuo Liu
Signed-off-by: Shuo Liu
Signed-off-by: Zhao Yakui
---
drivers/staging/acrn/Makefile | 4 +-
drivers/staging/acrn/acrn_dev.c | 19 ++
drivers/staging/acrn/acrn_drv_internal.h | 10 +
drivers/staging
Shuo
Signed-off-by: Zhao Yakui
---
drivers/staging/acrn/Makefile | 4 +-
drivers/staging/acrn/acrn_dev.c | 27 +++
drivers/staging/acrn/acrn_drv_internal.h | 90 +++---
drivers/staging/acrn/acrn_mm.c| 227
drivers/staging
: Zhao Yakui
---
drivers/staging/acrn/acrn_dev.c | 41 +
1 file changed, 41 insertions(+)
diff --git a/drivers/staging/acrn/acrn_dev.c b/drivers/staging/acrn/acrn_dev.c
index 28258fb..93f45e3 100644
--- a/drivers/staging/acrn/acrn_dev.c
+++ b/drivers/staging
: Zhao Yakui
---
drivers/staging/Kconfig | 2 +
drivers/staging/Makefile| 1 +
drivers/staging/acrn/Kconfig| 18 ++
drivers/staging/acrn/Makefile | 2 +
drivers/staging/acrn/acrn_dev.c | 123
5 files changed, 146 insertions
On 2019年08月16日 14:39, Borislav Petkov wrote:
On Fri, Aug 16, 2019 at 10:25:41AM +0800, Zhao Yakui wrote:
The first three patches are the changes under x86/acrn, which adds the
required APIs for the driver and reports the X2APIC caps.
The remaining patches add the ACRN driver module, which
On 2019年08月16日 15:03, Greg KH wrote:
On Fri, Aug 16, 2019 at 08:39:25AM +0200, Borislav Petkov wrote:
On Fri, Aug 16, 2019 at 10:25:41AM +0800, Zhao Yakui wrote:
The first three patches are the changes under x86/acrn, which adds the
required APIs for the driver and reports the X2APIC caps
On 2019年08月16日 15:05, Greg KH wrote:
On Fri, Aug 16, 2019 at 10:25:45AM +0800, Zhao Yakui wrote:
ACRN hypervisor service module is the important middle layer that allows
the Linux kernel to communicate with the ACRN hypervisor. It includes
the management of virtualized CPU/memory/device
On 2019年08月16日 21:39, Dan Carpenter wrote:
On Fri, Aug 16, 2019 at 10:25:52AM +0800, Zhao Yakui wrote:
+int acrn_ioreq_create_client(unsigned short vmid,
+ioreq_handler_t handler,
+void *client_priv,
+char
On 2019年08月16日 21:12, Dan Carpenter wrote:
On Fri, Aug 16, 2019 at 10:25:51AM +0800, Zhao Yakui wrote:
+ case IC_VM_INTR_MONITOR: {
+ struct page *page;
+
+ ret = get_user_pages_fast(ioctl_param, 1, 1, &page);
+ if (unlikely(ret != 1) || !
On 2019年08月16日 20:58, Dan Carpenter wrote:
On Fri, Aug 16, 2019 at 10:25:49AM +0800, Zhao Yakui wrote:
+int hugepage_map_guest(struct acrn_vm *vm, struct vm_memmap *memmap)
+{
+ struct page *page = NULL, *regions_buf_pg = NULL;
+ unsigned long len, guest_gpa, vma;
+ struct
On 2019年08月19日 13:25, Greg KH wrote:
On Mon, Aug 19, 2019 at 09:44:25AM +0800, Zhao, Yakui wrote:
On 2019年08月16日 14:39, Borislav Petkov wrote:
On Fri, Aug 16, 2019 at 10:25:41AM +0800, Zhao Yakui wrote:
The first three patches are the changes under x86/acrn, which adds the
required APIs
On 2019年08月19日 18:34, Dan Carpenter wrote:
On Fri, Aug 16, 2019 at 10:25:56AM +0800, Zhao Yakui wrote:
diff --git a/drivers/staging/acrn/acrn_dev.c b/drivers/staging/acrn/acrn_dev.c
index 0602125..6868003 100644
--- a/drivers/staging/acrn/acrn_dev.c
+++ b/drivers/staging/acrn/acrn_dev.c
On 2019年08月19日 15:39, Dan Carpenter wrote:
On Mon, Aug 19, 2019 at 01:32:54PM +0800, Zhao, Yakui wrote:
In fact as this driver is mainly used for embedded IOT usage, it doesn't
handle the complex cleanup when such error is encountered. Instead the clean
up is handled in free_guest_vm.
On 2019年08月16日 21:05, Dan Carpenter wrote:
On Fri, Aug 16, 2019 at 10:25:50AM +0800, Zhao Yakui wrote:
+ case IC_ASSIGN_PTDEV: {
+ unsigned short bdf;
+
+ if (copy_from_user(&bdf, (void *)ioctl_param,
This casting is ugly and you also need a __user tag
Mark, could you look at this patch? It has not been acked.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sat, 2014-02-15 at 06:54:06 +0800, Larry Finger wrote:
> This alignment entry in union recv_frame does nothing. It certainly
> dues not ensure alignment.
^
typo here.
I accidently sent this as a private mail before, better to resend to
the list.
>
> Suggested-by: jes.soren...@redha
/ declared in . So this
change is safe.
This change is a preparation for the removal of function
ieee80211_{dsss_chan_to_freq, freq_to_dsss_chan}.
Signed-off-by: Zhao, Gang
---
add Cc to linux-wireless for consistency.
drivers/staging/wlan-ng/cfg80211.c | 7 +--
1 file changed, 5 insertions
Alan, thanks for resending this patch. But it seems you overlooked
something we discussed earlier.
On Mon, 2014-02-17 at 22:13:08 +0800, Alan wrote:
> We should check the ring allocations don't fail.
> If we get a fail we need to clean up properly. The allocator assumes the
> deallocator will be u
On Wed, 2014-02-19 at 19:43:15 +0800, One Thousand Gnomes wrote:
> On Wed, 19 Feb 2014 09:14:19 +0800
> "Zhao\, Gang" wrote:
>
>> Alan, thanks for resending this patch. But it seems you overlooked
>> something we discussed earlier.
>>
>> On Mon, 2014-0
On Thu, 2014-02-20 at 17:03:39 +0800, Dan Carpenter wrote:
> On Thu, Feb 20, 2014 at 11:03:45AM +0800, Zhao, Gang wrote:
>> On Wed, 2014-02-19 at 19:43:15 +0800, One Thousand Gnomes wrote:
>> > On Wed, 19 Feb 2014 09:14:19 +0800
>> > "Zhao\, Gang" wrote:
>&
_free() can handle this situation correctly.
Signed-off-by: Zhao, Gang
---
I didn't notice Alan's et131x patch on the list have been applied.
Now combine my comments on that patch to a new patch for review.
drivers/staging/et131x/et131x.c | 5 -
1 file changed, 4 insertions(+),
On Fri, 2014-02-21 at 15:38:56 +0800, Dan Carpenter wrote:
> I don't think this is the right thing because it is needless code.
> Overall it doesn't really simplify anything.
>
> You are worried that reviewers will be confused and think there is a
> leak in et131x_rx_dma_memory_alloc() and then add
On Fri, 2014-02-21 at 20:35:50 +0800, Dan Carpenter wrote:
> On Fri, Feb 21, 2014 at 08:22:21PM +0800, Zhao, Gang wrote:
>> > If we add your patch and the reviewer does a search for fb[0] then it is
>> > confusing what the right thing to do is.
>>
>> My fault.
Then replace all the instances of "rx_local->fbr[id]" with fbr.
3. delete unnecessary variable in function et131x_init
variable u32 numrfd is not necessary in this function.
4. some code style change
Signed-off-by: ZHAO Gang
---
v3 -> v4:
don't split dev_er
On Fri, Nov 22, 2013 at 5:18 AM, Mark Einon wrote:
> On Wed, Nov 20, 2013 at 03:53:50PM +0800, ZHAO Gang wrote:
>> This patch set should apply to current staging-next tree
>>
>> ZHAO Gang (5):
>> staging: et131x: clean up code
>> staging: et131x: drop pack
On Fri, Nov 22, 2013 at 5:20 AM, Mark Einon wrote:
> On Wed, Nov 20, 2013 at 03:58:37PM +0800, ZHAO Gang wrote:
>> remove items that have been done
>>
>> Signed-off-by: ZHAO Gang
>
> If the two small issues in patch 1/5 are fixed:
Fixed in v4 of patch 1/5 I sent
On Fri, Nov 22, 2013 at 4:08 PM, Dan Carpenter wrote:
> On Fri, Nov 22, 2013 at 10:54:27AM +0800, ZHAO Gang wrote:
>> 1. change function name: et1310_phy_power_down -> et1310_phy_power_switch
>> change function name to better describe its functionality.
>>
>>
On Fri, Nov 22, 2013 at 4:57 PM, Dan Carpenter wrote:
> This is a lot of spaghetti. Just write it like this:
>
>
> if (adapter->tx_ring.used >= NUM_TCB)
> goto drop;
> if (adapter->flags & FMP_ADAPTER_FAIL_SEND_MASK)
> goto drop;
> if (!neti
On Fri, Nov 22, 2013 at 5:00 PM, Dan Carpenter wrote:
> On Fri, Nov 22, 2013 at 04:44:48PM +0800, ZHAO Gang wrote:
>> >
>> > Otherwise this patch seems nice but it needs to be split up and resent.
>>
>> By the way, this mailing list is surely an open list, but I
On Fri, Nov 22, 2013 at 5:17 PM, Denis Kirjanov wrote:
> On 11/22/13, Mark Einon wrote:
>> On Wed, Nov 20, 2013 at 03:55:27PM +0800, ZHAO Gang wrote:
>>> As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
>>> when tx failed.
>>>
>>>
On Fri, Nov 22, 2013 at 7:56 PM, Denis Kirjanov wrote:
> If you have no free TX descriptors that means that something went
> wrong and it's a BUG. You have to tell the stack to stop sending
> packets using netif_stop_queue() and reenable transmissions once tx
> descriptors will be available. There
On Fri, Nov 22, 2013 at 8:13 PM, Dan Carpenter wrote:
> On Fri, Nov 22, 2013 at 07:37:58PM +0800, ZHAO Gang wrote:
>> On Fri, Nov 22, 2013 at 5:00 PM, Dan Carpenter
>> wrote:
>> > On Fri, Nov 22, 2013 at 04:44:48PM +0800, ZHAO Gang wrote:
>> >> >
>>
1. As TODO list suggested, do this sort of things to reduce split lines:
struct fbr_lookup *fbr;
fbr = rx_local->fbr[id];
Then replace all the instances of "rx_local->fbr[id]" with fbr.
2. Some code style changes
Signed-off-by: ZHAO Gang
---
v4 -> v5:
Change function name from et1310_phy_power_down to et1310_phy_power_switch
to better describe its functionality.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers
Variable u32 numrfd is not necessary in this function.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 0a6cc62..6df7145 100644
--- a
As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
when tx failed.
et131x_tx calls function et131x_send_packets, I put the work of
et131x_send_packets directly into et131x_tx, and made some changes to
let the code more readable.
Signed-off-by: ZHAO Gang
---
v3 -> v4: no cha
stop read and return error when hit max delay time.
Signed-off-by: ZHAO Gang
Acked-by: Mark Einon
---
v3 -> v4 -> v5: version bump, sequence number bump
drivers/staging/et131x/et131x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/s
adapter->lock is only used in et131x_multicast(), which is eventually
called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode()
is always called by (net_device *)dev->addr_list_lock hold, to protect from
concurrent access. So adapter->lock is redundant.
Signed-off-by:
remove items that have been done
Signed-off-by: ZHAO Gang
Acked-by: Mark Einon
---
v3 -> v4 -> v5: version bump, sequence number bump
drivers/staging/et131x/README | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
This patch set is based on previous sent v5 of 7 patches for et131x.
ZHAO Gang (3):
staging: et131x: simplify rx dma code
staging: et131x: simplify tx dma code
staging: et131x: fix build warning
drivers/staging/et131x/et131x.c | 298 +---
1 file changed
et131x_rx_dma_memory_alloc
Instead, allocate all rx dma memory in one dma_alloc_coherent call makes less
code,
makes it easy to handle dma allocation error, and makes
et131x_rx_dma_memory_free
as simple as it could be.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 219
combine two dma_alloc_coherent to one
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 72 -
1 file changed, 20 insertions(+), 52 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 409949f
but not
used [-Wunused-but-set-variable]
u32 pm_csr;
^
drivers/staging/et131x//et131x.c: In function ‘et131x_multicast’:
drivers/staging/et131x//et131x.c:4315:16: warning: unused variable ‘flags’
[-Wunused-variable]
unsigned long flags;
^
Signed-off-by: ZHAO Gang
On Wed, Nov 27, 2013 at 5:02 PM, Dan Carpenter wrote:
> On Wed, Nov 27, 2013 at 03:45:12PM +0800, ZHAO Gang wrote:
>> @@ -2208,8 +2204,11 @@ static int et131x_rx_dma_memory_alloc(struct
>> et131x_adapter *adapter)
>> rx_ring = &adapter->rx_ring;
>>
>&
On Wed, Nov 27, 2013 at 6:06 PM, Dan Carpenter wrote:
> Ok, yeah. This patch is the right thing. I had a couple minor style
> complaints.
I am happy to hear this.
>
> On Wed, Nov 27, 2013 at 03:45:12PM +0800, ZHAO Gang wrote:
>> The original code allocate rx dma
On Wed, Nov 27, 2013 at 8:04 PM, Dan Carpenter wrote:
> On Wed, Nov 27, 2013 at 07:37:30PM +0800, ZHAO Gang wrote:
>> On Wed, Nov 27, 2013 at 5:02 PM, Dan Carpenter
>> wrote:
>> > On Wed, Nov 27, 2013 at 03:45:12PM +0800, ZHAO Gang wrote:
>> >&g
On Wed, Nov 27, 2013 at 6:13 PM, Dan Carpenter wrote:
> On Wed, Nov 27, 2013 at 03:45:14PM +0800, ZHAO Gang wrote:
>> fix make -W1 warning:
>> drivers/staging/et131x//et131x.c: In function
>> ‘et1310_setup_device_for_multicast’:
>> drivers/staging/et131x//et131x.
On Wed, Nov 27, 2013 at 9:26 PM, Dan Carpenter wrote:
> On Wed, Nov 27, 2013 at 08:43:57PM +0800, ZHAO Gang wrote:
>> >> + /* Update the pointer */
>> >> + dma_addr += fbr->buffsize;
>> >
&g
combine two dma_alloc_coherent to one
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 70 +++--
1 file changed, 19 insertions(+), 51 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 7c6031e
et131x_rx_dma_memory_free: they only need to call one kfree instead of
two, it reduces the lines of code.
ZHAO Gang (4):
staging: et131x: simplify rx dma code
staging: et131x: simplify tx dma code
staging: et131x: fix build warning
staging: et131x: some code style change
drivers/staging/et131x/et131x.c | 290
et131x_rx_dma_memory_alloc
Instead, allocate all rx dma memory in one dma_alloc_coherent call makes less
code,
makes it easy to handle dma allocation error, and makes
et131x_rx_dma_memory_free
as simple as it could be.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 202
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 7305fb5..764f7d0 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging
but not
used [-Wunused-but-set-variable]
u32 pm_csr;
^
drivers/staging/et131x//et131x.c: In function ‘et131x_multicast’:
drivers/staging/et131x//et131x.c:4315:16: warning: unused variable ‘flags’
[-Wunused-variable]
unsigned long flags;
^
Signed-off-by: ZHAO Gang
Signed-off-by: ZHAO Gang
---
I now see the good point of separating code style changes from others.
If your code is right, just edit code style change patch until reviewers
are satisfied :-)
drivers/staging/et131x/et131x.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions
On Thu, Nov 28, 2013 at 3:58 PM, Dan Carpenter wrote:
> On Thu, Nov 28, 2013 at 12:53:39AM +0800, ZHAO Gang wrote:
>> @@ -2208,8 +2203,11 @@ static int et131x_rx_dma_memory_alloc(struct
>> et131x_adapter *adapter)
>> rx_ring = &adapter->rx_ring;
>>
>&
et131x_rx_dma_memory_alloc
Instead, allocate all rx dma memory in one dma_alloc_coherent call makes less
code,
makes it easy to handle dma allocation error, and makes
et131x_rx_dma_memory_free
as simple as it could be.
Also add error check to kmalloc.
Signed-off-by: ZHAO Gang
---
drivers/staging
adapter->lock is only used in et131x_multicast(), which is eventually
called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode()
is always called by (net_device *)dev->addr_list_lock hold, to protect from
concurrent access. So adapter->lock is redundant.
Signed-off-by:
On Wed, Dec 4, 2013 at 12:38 AM, Greg Kroah-Hartman
wrote:
> On Sat, Nov 23, 2013 at 12:21:29AM +0800, ZHAO Gang wrote:
>> 1. As TODO list suggested, do this sort of things to reduce split lines:
>> struct fbr_lookup *fbr;
>> fbr = rx_local->fbr[id];
>&
On Wed, Dec 4, 2013 at 3:09 PM, Greg Kroah-Hartman
wrote:
> On Wed, Dec 04, 2013 at 01:51:41PM +0800, ZHAO Gang wrote:
>> On Wed, Dec 4, 2013 at 12:38 AM, Greg Kroah-Hartman
>> wrote:
>> > On Sat, Nov 23, 2013 at 12:21:29AM +0800, ZHAO Gang wrote:
>> >> 1. As
but not
used [-Wunused-but-set-variable]
u32 pm_csr;
^
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 3fa1763..65fa0ed 100644
--- a/drivers
Change function name from et1310_phy_power_down to et1310_phy_power_switch
to better describe its functionality.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers
As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
when tx failed.
et131x_tx calls function et131x_send_packets, I put the work of
et131x_send_packets directly into et131x_tx, and made some changes to
let the code more readable.
Signed-off-by: ZHAO Gang
---
drivers/staging
combine two dma_alloc_coherent to one
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 70 +++--
1 file changed, 19 insertions(+), 51 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index a3d1b53
et131x_rx_dma_memory_alloc
Instead, allocate all rx dma memory in one dma_alloc_coherent call makes less
code,
makes it easy to handle dma allocation error, and makes
et131x_rx_dma_memory_free
as simple as it could be.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 202
1. As TODO list suggested, do this sort of things to reduce split lines:
struct fbr_lookup *fbr;
fbr = rx_local->fbr[id];
Then replace all the instances of "rx_local->fbr[id]" with fbr.
2. Some code style change
Signed-off-by: ZHAO Gang
---
driver
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 65fa0ed..772d299 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers
but not
used [-Wunused-but-set-variable]
u32 pm_csr;
^
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 3fa1763..65fa0ed 100644
--- a/drivers
Variable u32 numrfd is not necessary in this function.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 263a478..f4ab56a 100644
--- a
remove items that have been done
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/README | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index 8da96a6..00a34ea 100644
--- a/drivers/staging/et131x/README
+++ b/drivers
adapter->lock is only used in et131x_multicast(), which is eventually
called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode()
is always called by (net_device *)dev->addr_list_lock hold, to protect from
concurrent access. So adapter->lock is redundant.
Signed-off-by:
stop read and return error when hit max delay time.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 6441e25..0fe7b17 100644
--- a/drivers/staging/et131x
On Wed, Dec 4, 2013 at 5:05 PM, Mark Einon wrote:
> On Wed, Dec 04, 2013 at 03:24:18PM +0800, ZHAO Gang wrote:
>> The original code allocate rx dma memory in several dma_alloc_coherent calls,
>> which causes some problems:
>> 1. since dma_alloc_coherent allocate at leas
On Wed, Dec 4, 2013 at 8:01 PM, ZHAO Gang wrote:
> On Wed, Dec 4, 2013 at 5:05 PM, Mark Einon wrote:
>> On Wed, Dec 04, 2013 at 03:24:18PM +0800, ZHAO Gang wrote:
>>> The original code allocate rx dma memory in several dma_alloc_coherent
>>> calls,
>>> whic
On Thu, Dec 5, 2013 at 7:23 AM, Greg Kroah-Hartman
wrote:
> On Wed, Dec 04, 2013 at 03:24:14PM +0800, ZHAO Gang wrote:
>> As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
>> when tx failed.
>
> Really? That's ok to do? Seems like you are changing t
On Wed, Dec 4, 2013 at 10:53 PM, Mark Einon wrote:
> On Wed, Dec 04, 2013 at 09:32:27PM +0800, ZHAO Gang wrote:
>>
>> By re-examine the code I found the calculation is not correct. The
>> real impact is too big to apply this patch, so this patch and
>> followin
On Tue, Dec 3, 2013 at 7:29 AM, Jingoo Han wrote:
> Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
> is not preferred.
>
> Signed-off-by: Jingoo Han
> ---
Greg, this patch should be reverted. It do the opposite things.
> drivers/vme/boards/vme_vmivme7805.c |2 +-
> drivers/vme
On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han wrote:
> Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
> is not preferred.
>
> Signed-off-by: Jingoo Han
>
I think you misunderstood the checkpatch.pl warning, it tells you what
to do, not what not to do.
WARNING: Use DEFINE_PCI_DEVICE_TA
On Thu, Dec 5, 2013 at 11:43 PM, Greg Kroah-Hartman
wrote:
> On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote:
>> On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han wrote:
>> > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
>> > is not preferred.
>
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 17ac711..b6ce68e 100644
--- a/drivers/staging/et131x
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 48 -
1 file changed, 23 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index ee231f2..17ac711 100644
--- a/drivers/staging
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 3e34c2e..8d75a3f 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index e3a71d3..ee231f2 100644
--- a/drivers/staging/et131x/et131x.c
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/README | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index 8da96a6..3befc45 100644
--- a/drivers/staging/et131x/README
+++ b/drivers/staging/et131x/README
@@ -13,10 +13,6
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index b6ce68e..3e34c2e 100644
--- a/drivers/staging/et131x/et131x.c
+++ b
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 8d75a3f..1abea42 100644
--- a/drivers/staging/et131x/et131x.c
+++ b
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index e3a71d3..0372f23 100644
--- a/drivers/staging/et131x/et131x.c
+++ b
1 - 100 of 135 matches
Mail list logo
