[PATCH 1/1] staging: media: imx: imx7-mipi-csis: simplify getting .driver_data

2019-03-19 Thread Wolfram Sang
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++ 1 file changed, 2 insert

[PATCH 2/2] staging: media: bcm2048: Remove obsolete cleanup for clientdata

2014-12-22 Thread Wolfram Sang
A few new i2c-drivers came into the kernel which clear the clientdata-pointer on exit or error. This is obsolete meanwhile, the core will do it. Signed-off-by: Wolfram Sang --- drivers/staging/media/bcm2048/radio-bcm2048.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging

Re: [PATCH 10/10] docs: fix broken documentation links

2019-05-20 Thread Wolfram Sang
ently located at > Documentation/firmware-guide/acpi/enumeration.rst. > > > Method 2: Instantiate the devices explicitly For this I2C part: Reviewed-by: Wolfram Sang signature.asc Description: PGP signature ___ devel mailing list de.

[PATCH 00/34] treewide: simplify getting the adapter of an I2C client

2019-06-08 Thread Wolfram Sang
series is only build tested. A branch can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/no_to_adapter Please apply the patches to the individual subsystem trees. There are no dependencies. Thanks and kind regards, Wolfram Wolfram Sang (34): clk: clk-cdc

[PATCH 33/34] staging: media: soc_camera: soc_mt9v022: simplify getting the adapter of a client

2019-06-08 Thread Wolfram Sang
We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang --- Please apply to your subsystem tree. drivers/staging/media/soc_camera/soc_mt9v022.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 31/34] staging: media: soc_camera: imx074: simplify getting the adapter of a client

2019-06-08 Thread Wolfram Sang
We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang --- Please apply to your subsystem tree. drivers/staging/media/soc_camera/imx074.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 32/34] staging: media: soc_camera: mt9t031: simplify getting the adapter of a client

2019-06-08 Thread Wolfram Sang
We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang --- Please apply to your subsystem tree. drivers/staging/media/soc_camera/mt9t031.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 00/34] treewide: simplify getting the adapter of an I2C client

2019-06-10 Thread Wolfram Sang
Hi Peter, > Similar things go on in: > > drivers/hwmon/lm90.c > drivers/leds/leds-is31fl319x.c > drivers/of/unittest.c Right. I'll fix them, too. > And drivers/rtc/rtc-fm3130.c has a couple of these: These are fixed in patch 26 of this series. Thanks and happy hacking, Wolfram signature

Re: [PATCH 2/2] staging: ks7010: remove dead code

2017-03-15 Thread Wolfram Sang
On Wed, Mar 15, 2017 at 01:57:32PM +1100, Tobin C. Harding wrote: > Driver has dead code compiled out using preprocessor directives. TODO > file asks for these not to be removed - ignore this. Why? signature.asc Description: PGP signature ___ devel ma

Re: Michael MIC

2017-03-16 Thread Wolfram Sang
Hi, > Is there some technical reason why module ks7010 includes a > implementation of Michael MIC instead of using the implementation in > crypto/? > > Or is this covered by the statement from the TODO > > - check what other upstream wireless mechanisms can be used instead of the > custom ones

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-03-31 Thread Wolfram Sang
> The code is untested, I have hardware in the mail. Cool! > If any one is interested and has any comments I would really like to > hear them. I am open to all suggestions (even down to trivial coding > style issues). I'll just repeat that the key move to get this driver out of staging is to ge

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-03-31 Thread Wolfram Sang
Hi, > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is > a SDW-823 and should use the ks7010 driver. Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for which no driver is known: https://wikidevi.com/wiki/Spectec_SDW-821_%28MediaTek%29 For SDW-821 (SD s

Re: [PATCH v3 07/20] i2c: Remove depends on HAS_DMA in case of platform dependency

2018-04-18 Thread Wolfram Sang
On Tue, Apr 17, 2018 at 07:49:07PM +0200, Geert Uytterhoeven wrote: > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". > In most cases this other symbol is an architecture or platform specific > symbol, or

[PATCH 49/61] staging: nvec: simplify getting .drvdata

2018-04-19 Thread Wolfram Sang
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. Please apply individually. drivers/staging/nvec/nvec.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH 47/61] staging: greybus: simplify getting .drvdata

2018-04-19 Thread Wolfram Sang
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. Please apply individually. drivers/staging/greybus/arche-platform.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 00/61] tree-wide: simplify getting .drvdata

2018-04-19 Thread Wolfram Sang
ptr = - platform_get_drvdata(pdev) + dev_get_drvdata(d) <... when != pdev - &pdev->dev + d ...> Kind regards, Wolfram Wolfram Sang (61): ARM: plat-samsung: simplify getting .drvdata ata: simplify getting .drvdata auxdisplay: simplify getting .drvda

[PATCH 48/61] staging: iio: adc: simplify getting .drvdata

2018-04-19 Thread Wolfram Sang
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. Please apply individually. drivers/staging/iio/adc/ad7606_par.c | 6 ++ 1 file changed, 2 insertions(+), 4

Re: [PATCH 12/14] i2c-parport: return proper error values from attach

2015-04-09 Thread Wolfram Sang
On Wed, Apr 08, 2015 at 04:50:38PM +0530, Sudip Mukherjee wrote: > now that we are monitoring the return value from attach, make the > required changes to return proper value from its attach function. > > Signed-off-by: Sudip Mukherjee > --- > drivers/i2c/busses/i2c-parport.c | 7 --- > 1 fi

Re: [PATCH 12/14] i2c-parport: return proper error values from attach

2015-04-09 Thread Wolfram Sang
> It doesn't really matter that the error codes are different, it matters > that they are meaningful. As much as possible you should pass error > codes from the lower layers. parport_claim_or_block() and > i2c_bit_add_bus() return proper error codes so you should record and > transmit them. Oh, s

Re: [PATCH 3/6] i2c-parport: define ports to connect

2015-05-20 Thread Wolfram Sang
y: Jean Delvare > Signed-off-by: Sudip Mukherjee I assume this goes in as one series: Acked-by: Wolfram Sang signature.asc Description: Digital signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.or

Re: [PATCH 4/6] i2c-parport: use new parport device model

2015-05-20 Thread Wolfram Sang
On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote: > Modify i2c-parport driver to use the new parallel port device model. > > Tested-by: Jean Delvare > Signed-off-by: Sudip Mukherjee > --- In general: Acked-by: Wolfram Sang > static struct parport_driver

Re: [PATCH 4/6] i2c-parport: use new parport device model

2015-05-20 Thread Wolfram Sang
> > > static struct parport_driver i2c_parport_driver = { > > > - .name = "i2c-parport", > > > - .attach = i2c_parport_attach, > > > - .detach = i2c_parport_detach, > > > + .name = "i2c-parport", > > > + .match_port = i2c_parport_attach, > > > + .detach = i2c_parport_detac

[PATCH] staging: ks7010: remove me from CC list

2020-05-02 Thread Wolfram Sang
I lost interest in this driver years ago because I could't keep up with testing the incoming janitorial patches. So, drop me from CC. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ks7010/TODO b/drivers/st

Re: ks7010 endianness question

2017-04-18 Thread Wolfram Sang
> I think we can call this question resolved. Remove the comment and > change the hostif_hdr description to > > struct hostif_hdr { > __be16 size; > __be16 event; > } __packed; > > Are you happy with this? Yes, I trust you. signature.asc Description: PGP signature ___

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-27 Thread Wolfram Sang
Hi Tobin, > over this last month :). This is the reason for this email. Can I > please take you up on the offer of the SDW-823 card, if you can find > it? Sure, I have it here. Just mail me (privately) the address to send it to and I'll ship right away. > Secondly, I think I should spend some ti

Re: [bug report] staging: ks7010: add driver from Nanonote extra-repository

2017-04-28 Thread Wolfram Sang
On Fri, Apr 28, 2017 at 04:41:33PM +0300, Dan Carpenter wrote: Adding Tobin to CC, he is way more into the driver than I am these days... > Hello Wolfram Sang, > > The patch 13a9930d15b4: "staging: ks7010: add driver from Nanonote > extra-repository" from May 31, 2016,

Re: drivers/staging/ks7010 hardware test

2017-05-25 Thread Wolfram Sang
Hi Tobin, > I began testing the card you sent today. I'm getting a firmware load > error like you mentioned. Nice. Firstly, that means the card is alive and survived the mailing. > I checked out code from when you originally merged into staging, > however I built the module in a 4.9 kernel. I t

Re: ks7010 firmware upload fail

2017-06-05 Thread Wolfram Sang
Tobin, > My question is should I be digging further into the MMC code or be doing > something else with the driver code? So, you haven't found any branch that worked? No plain v4.9 or the gen3-sdio branch from my tree? Regards, Wolfram signature.asc Description: PGP signature

[PATCH 04/27] staging: ks7010: remove checks for WIRELESS_EXT version

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang We are by far newer than that anyhow. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.c | 23 --- drivers/staging/ks7010/ks_wlan_net.c | 14 -- 2 files changed, 37 deletions(-) diff --git a/drivers/staging/ks7010

[PATCH 08/27] staging: ks7010: use kernel helper to print buffer

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang No need for an open coded one. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/Makefile | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 9 + drivers/staging/ks7010/ks_debug.c| 30 -- drivers/staging/ks7010/ks_debug.h

[PATCH 13/27] staging: ks7010: add example cfg file as a reference

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang We want to remove it, but to do so properly, it is good to have a working example. Needs to be copied to /lib/firmware in order to be used. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks79xx.cfg | 116 ++ 1 file changed, 116

[PATCH 11/27] staging: ks7010: make loading config file optional

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang We have sane defaults, so we don't need to bail out if there is no config file. Note that the config file should go away completely in favour of configuration mechanisms already upstream. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 8 +++---

[PATCH 16/27] staging: ks7010: indent ks7010_config.c

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 353 + 1 file changed, 184 insertions(+), 169 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_config.c b/drivers/staging/ks7010/ks7010_config.c index

[PATCH 07/27] staging: ks7010: use long preamble as default

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang I had a problem connecting to a network with a short preamble, so let's make the safer option the default. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/k

[PATCH 17/27] staging: ks7010: indent ks7010_sdio.h

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.h | 64 +--- 1 file changed, 30 insertions(+), 34 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index 1d16673e5dae02

[PATCH 19/27] staging: ks7010: indent ks_hostif.h

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.h | 525 ++--- 1 file changed, 262 insertions(+), 263 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h index c333ce1a4baa6e

[PATCH 27/27] staging: ks7010: fix module annotations

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang List all authors, beautify description, match license to what is stated in file headers, add firmware information. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 02/27] staging: ks7010: remove non-SDIO code and #ifdefs

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang I couldn't find any trace of code or even products using ks7010 with something else than SDIO. So, remove the conditionals. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/Makefile| 2 +- drivers/staging/ks7010/ks7010_config.c | 6 --- drivers/st

[PATCH 26/27] staging: ks7010: remove supported card table with one element

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang There is only this card supported, no need to iterate over the table. The resulting firmware filename wasn't used anyway, but came from the config file or hardcoded default. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c

[PATCH 12/27] staging: ks7010: fix printk format warnings

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Use proper type for size_t. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_config.c b/drivers/staging

[PATCH 21/27] staging: ks7010: indent ks_wlan_ioctl.h

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_wlan_ioctl.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index e7469f7338f7af..cc4669eddcc1f7 100644

[PATCH 06/27] staging: ks7010: avoid workqueue races

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang My Spectec SDW823 card oopsed when it was already inserted during boot. When debugging this, I noticed that the card init was done in a seperate workqueue which was only activated once in probe. After removing the workqueue and calling the card init directly from probe, the

[PATCH 20/27] staging: ks7010: indent ks_wlan.h

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_wlan.h | 246 +++ 1 file changed, 121 insertions(+), 125 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 58e3a5a6b44472

[PATCH 14/27] staging: ks7010: remove unecessary typedef

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Let's simply specify the struct to keep in sync with kernel coding style. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 4 +- drivers/staging/ks7010/ks7010_sdio.c | 44 - drivers/staging/ks7010/ks7010_sdio.h | 2 +- dr

[PATCH 05/27] staging: ks7010: remove code for old kernel versions

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang No need to be backwards compatible. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.c | 9 - drivers/staging/ks7010/ks_wlan.h | 28 +--- drivers/staging/ks7010/ks_wlan_net.c | 3 --- 3 files changed, 1 insertion

[PATCH 24/27] staging: ks7010: indent michael_mic.h

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/michael_mic.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ks7010/michael_mic.h b/drivers/staging/ks7010/michael_mic.h index f14f160ad46549..57ecbe34153202 100644

[PATCH 03/27] staging: ks7010: remove custom firmware loader

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang FW_LOADER works fine, no need for a open coded fallback. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/Kconfig | 1 + drivers/staging/ks7010/ks7010_config.c | 62 -- drivers/staging/ks7010/ks7010_sdio.c | 56

[PATCH 23/27] staging: ks7010: indent michael_mic.c

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/michael_mic.c | 43 ++-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c index ec8769a974427a

[PATCH 25/27] staging: ks7010: indent ks7010_sdio.c

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Unlike the previous patches which are plain indent outcomes, this has some manual fixups to be not overly strict with the 80 char limit. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 807 --- 1 file changed, 460

[PATCH 18/27] staging: ks7010: indent ks_hostif.c

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.c | 1960 1 file changed, 1080 insertions(+), 880 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 497b8aaf6daef8

[PATCH 15/27] staging: ks7010: indent eap_packet.h

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/eap_packet.h | 49 ++--- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h index b664bdd8c961db

[PATCH 00/27] staging: add driver for KS7010 based SDIO cards

2016-05-10 Thread Wolfram Sang
by me as a private person (unless something very surprising happens ;)) Please comment, review, apply... Thanks, Wolfram Wolfram Sang (27): staging: ks7010: add driver from Nanonote extra-repository staging: ks7010: remove non-SDIO code and #ifdefs staging: ks7010: remove custom

[PATCH 10/27] staging: ks7010: really iterate over multicast addresses

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang The loop variable was defined but not really used. Fix this. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c

[PATCH 09/27] staging: ks7010: delete seperate debug header

2016-05-10 Thread Wolfram Sang
From: Wolfram Sang Move the one debug macro to the generic wlan header. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 1 - drivers/staging/ks7010/ks7010_sdio.c | 1 - drivers/staging/ks7010/ks_debug.h | 28 drivers/staging

Re: [PATCH 00/27] staging: add driver for KS7010 based SDIO cards

2016-05-10 Thread Wolfram Sang
On Tue, May 10, 2016 at 11:05:34PM +0200, Greg KH wrote: > On Tue, May 10, 2016 at 03:52:13PM +0200, Wolfram Sang wrote: > > This driver can be used with later Spectec SDW-821 and all SDW-823 cards. > > See patch 1 and README for more details about its origin. To have the card &

[PATCH] staging: ks7010: rename README to TODO

2016-05-11 Thread Wolfram Sang
From: Wolfram Sang To follow common pattern for staging/. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/{README => TODO} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename drivers/staging/ks7010/{README => TODO} (100%) diff --git a/drivers/staging/ks7010/README b/d

[PATCH v2] staging: ks7010: rename README to TODO

2016-05-11 Thread Wolfram Sang
From: Wolfram Sang To follow common pattern for staging/. Signed-off-by: Wolfram Sang --- Change in V2: correct authorship, sorry for the noise! drivers/staging/ks7010/{README => TODO} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename drivers/staging/ks7010/{README => TODO

[PATCH] staging: ks7010: adapt to new trans_start handling

2016-05-11 Thread Wolfram Sang
From: Wolfram Sang trans_start is gone from netdevice, so use the new helper function to set the mark. Signed-off-by: Wolfram Sang --- This fixup is needed to build with linux/next because it contains a patch dropping trans_start. But the new helper is not there in current linux master

Re: [PATCH 00/27] staging: add driver for KS7010 based SDIO cards

2016-05-19 Thread Wolfram Sang
Hi Greg, > An add-on patch is probably easiest for everyone involved here. Any chance for the new-driver-rule for this one? Thanks, Wolfram signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://drive

[PATCH V2 03/31] staging: ks7010: remove custom firmware loader

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang FW_LOADER works fine, no need for a open coded fallback. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/Kconfig | 1 + drivers/staging/ks7010/ks7010_config.c | 62 -- drivers/staging/ks7010/ks7010_sdio.c | 56

[PATCH V2 00/31] staging: add driver for KS7010 based SDIO WLAN cards

2016-05-31 Thread Wolfram Sang
nks, Wolfram Wolfram Sang (31): staging: ks7010: add driver from Nanonote extra-repository staging: ks7010: remove non-SDIO code and #ifdefs staging: ks7010: remove custom firmware loader staging: ks7010: remove checks for WIRELESS_EXT version staging: ks7010: remove code for old kernel versi

[PATCH V2 02/31] staging: ks7010: remove non-SDIO code and #ifdefs

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang I couldn't find any trace of code or even products using ks7010 with something else than SDIO. So, remove the conditionals. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/Makefile| 2 +- drivers/staging/ks7010/ks7010_config.c | 6 --- drivers/st

[PATCH V2 07/31] staging: ks7010: use long preamble as default

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang I had a problem connecting to a network with a short preamble, so let's make the safer option the default. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/k

[PATCH V2 06/31] staging: ks7010: avoid workqueue races

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang My Spectec SDW823 card oopsed when it was already inserted during boot. When debugging this, I noticed that the card init was done in a seperate workqueue which was only activated once in probe. After removing the workqueue and calling the card init directly from probe, the

[PATCH V2 05/31] staging: ks7010: remove code for old kernel versions

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang No need to be backwards compatible. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.c | 9 - drivers/staging/ks7010/ks_wlan.h | 28 +--- drivers/staging/ks7010/ks_wlan_net.c | 3 --- 3 files changed, 1 insertion

[PATCH V2 09/31] staging: ks7010: delete seperate debug header

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Move the one debug macro to the generic wlan header. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 1 - drivers/staging/ks7010/ks7010_sdio.c | 1 - drivers/staging/ks7010/ks_debug.h | 28 drivers/staging

[PATCH V2 12/31] staging: ks7010: fix printk format warnings

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Use proper type for size_t. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_config.c b/drivers/staging

[PATCH V2 10/31] staging: ks7010: really iterate over multicast addresses

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang The loop variable was defined but not really used. Fix this. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c

[PATCH V2 13/31] staging: ks7010: add example cfg file as a reference

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang We want to remove it, but to do so properly, it is good to have a working example. Needs to be copied to /lib/firmware in order to be used. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks79xx.cfg | 116 ++ 1 file changed, 116

[PATCH V2 11/31] staging: ks7010: make loading config file optional

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang We have sane defaults, so we don't need to bail out if there is no config file. Note that the config file should go away completely in favour of configuration mechanisms already upstream. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 8 +++---

[PATCH V2 04/31] staging: ks7010: remove checks for WIRELESS_EXT version

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang We are by far newer than that anyhow. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.c | 23 --- drivers/staging/ks7010/ks_wlan_net.c | 14 -- 2 files changed, 37 deletions(-) diff --git a/drivers/staging/ks7010

[PATCH V2 08/31] staging: ks7010: use kernel helper to print buffer

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang No need for an open coded one. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/Makefile | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 9 + drivers/staging/ks7010/ks_debug.c| 30 -- drivers/staging/ks7010/ks_debug.h

[PATCH V2 24/31] staging: ks7010: indent michael_mic.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/michael_mic.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ks7010/michael_mic.h b/drivers/staging/ks7010/michael_mic.h index f14f160ad46549..57ecbe34153202 100644

[PATCH V2 23/31] staging: ks7010: indent michael_mic.c

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/michael_mic.c | 43 ++-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c index ec8769a974427a

[PATCH V2 14/31] staging: ks7010: remove unecessary typedef

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Let's simply specify the struct to keep in sync with kernel coding style. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 4 +- drivers/staging/ks7010/ks7010_sdio.c | 44 - drivers/staging/ks7010/ks7010_sdio.h | 2 +- dr

[PATCH V2 19/31] staging: ks7010: indent ks_hostif.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.h | 525 ++--- 1 file changed, 262 insertions(+), 263 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h index c333ce1a4baa6e

[PATCH V2 15/31] staging: ks7010: indent eap_packet.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/eap_packet.h | 49 ++--- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h index b664bdd8c961db

[PATCH V2 20/31] staging: ks7010: indent ks_wlan.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_wlan.h | 246 +++ 1 file changed, 121 insertions(+), 125 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 58e3a5a6b44472

[PATCH V2 21/31] staging: ks7010: indent ks_wlan_ioctl.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_wlan_ioctl.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index e7469f7338f7af..cc4669eddcc1f7 100644

[PATCH V2 17/31] staging: ks7010: indent ks7010_sdio.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.h | 64 +--- 1 file changed, 30 insertions(+), 34 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index 1d16673e5dae02

[PATCH V2 16/31] staging: ks7010: indent ks7010_config.c

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_config.c | 353 + 1 file changed, 184 insertions(+), 169 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_config.c b/drivers/staging/ks7010/ks7010_config.c index

[PATCH V2 31/31] staging: ks7010: cleanup file headers

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Remove svn-ids and fix typos in the licence declaration. Add my copyright to the sdio code which I worked on mainly. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/eap_packet.h| 6 -- drivers/staging/ks7010/ks7010_sdio.c | 8 +++- drivers/staging

[PATCH V2 26/31] staging: ks7010: remove supported card table with one element

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang There is only this card supported, no need to iterate over the table. The resulting firmware filename wasn't used anyway, but came from the config file or hardcoded default. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c

[PATCH V2 25/31] staging: ks7010: indent ks7010_sdio.c

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Unlike the previous patches which are plain indent outcomes, this has some manual fixups to be not overly strict with the 80 char limit. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 807 --- 1 file changed, 460

[PATCH V2 29/31] staging: ks7010: simplify module_init/exit

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang The printouts are not needed, the driver core has enough debug output for this if wanted. So, use a helper to save boilerplate code. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 25 + 1 file changed, 1 insertion(+), 24

[PATCH V2 27/31] staging: ks7010: fix module annotations

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang List all authors, beautify description, match license to what is stated in file headers, add firmware information. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH V2 28/31] staging: ks7010: adapt to new trans_start handling

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang trans_start is gone from netdevice, so use the new helper function to set the mark. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers

[PATCH V2 30/31] staging: ks7010: drop counting sd errors

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang They were counted but never really used anywhere. Also change the printk to a debug print, since it mostly shows on the expected -ENOMEDIUM on card removal. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 20 ++-- drivers/staging

[PATCH V2 18/31] staging: ks7010: indent ks_hostif.c

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks_hostif.c | 1960 1 file changed, 1080 insertions(+), 880 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 497b8aaf6daef8

Re: [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus

2015-07-21 Thread Wolfram Sang
> It's up to you. I think if the NV guys are ok with the tegra i2c change, > Wolfram can merge it right away for 4.3. I asked him to resend, because I *want* to merge it for 4.3 :) Only the slave-mode enablement for i2c, of course. The other patches need to go via some other tree (when they are

Re: [PATCH v3 1/4] i2c: tegra: implement slave mode

2015-07-24 Thread Wolfram Sang
Hi Andrey, On Mon, Jul 20, 2015 at 11:35:43PM +0300, Andrey Danin wrote: > Initialization code is based on NVEC driver. > > There is a HW bug in AP20 that was also mentioned in kernel sources > for Toshiba AC100. > > Signed-off-by: Andrey Danin Still doesn't work for me and I think I understan

Re: [PATCH v3 1/4] i2c: tegra: implement slave mode

2015-07-24 Thread Wolfram Sang
> At the begin of my work on this patchset I even denied clock disable call if > slave is registered (to minimize code that can affect transfer). I hacked something like this, but it seems it was not enough. > If only slave mode is used, then this logic is not needed. This is not sufficent. We

Re: [patch 1/2] staging: ks7010: parsing bugs in ks_wlan_read_config_file()

2016-06-14 Thread Wolfram Sang
On Tue, Jun 14, 2016 at 02:16:30PM +0300, Dan Carpenter wrote: > The check for the NUL terminator is wrong so it looks like this could > read beyond the end of the buffer. > > Signed-off-by: Dan Carpenter Thanks, however I have a patch very soon to be submitted which removes the config.c file co

Re: [PATCH] staging: ks7010: honor 'const' qualifier

2016-06-17 Thread Wolfram Sang
On Wed, Jun 15, 2016 at 11:53:11PM +0200, Arnd Bergmann wrote: > The recently-added ks7010 driver produces an annoying build warning: > > drivers/staging/ks7010/ks7010_config.c: In function > 'ks_wlan_read_config_file': > drivers/staging/ks7010/ks7010_config.c:263:8: error: assignment discards >

[PATCH 3/9] staging: ks7010: collect all includes and sort them

2016-06-17 Thread Wolfram Sang
Includes probably need a driver-wide clean up, but for now let's at least group all includes from the sdio file together. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/k

[PATCH 0/9] staging: ks7010: cleanups

2016-06-17 Thread Wolfram Sang
/linux.git staging/ks7010 Thanks, Wolfram Wolfram Sang (9): staging: ks7010: remove cfg file handling staging: ks7010: function declaration should be in a header file staging: ks7010: collect all includes and sort them staging: ks7010: export sdio ids staging: ks7010: unify naming to

[PATCH 1/9] staging: ks7010: remove cfg file handling

2016-06-17 Thread Wolfram Sang
example config file. The only useful action, initialization of the configuration struct, is now moved to the sdio main file. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/Makefile| 3 +- drivers/staging/ks7010/TODO| 1 - drivers/staging/ks7

[PATCH 8/9] staging: ks7010: report interface as wlan not eth

2016-06-17 Thread Wolfram Sang
Until we switch to cfg80211 (if ever), we must do this manually. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index

[PATCH 7/9] staging: ks7010: bail out when registering netdevice fails

2016-06-17 Thread Wolfram Sang
There is no need to continue then. Also, this enables us to remove an ugly static variable. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers

[PATCH 2/9] staging: ks7010: function declaration should be in a header file

2016-06-17 Thread Wolfram Sang
Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/ks7010_sdio.c | 3 --- drivers/staging/ks7010/ks_wlan.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index d4cce78106a736

  1   2   >