Re: [PATCH] drivers: staging: speakup: serialio: delay initializing 'old_serial_port.baud_base'

2013-10-30 Thread Vineet Gupta
On 10/31/2013 06:57 AM, Chen Gang wrote: > On 10/26/2013 09:18 PM, Chen Gang wrote: >> On 10/25/2013 01:29 PM, Greg KH wrote: >>> No, just use the platform-specific SERIAL_PORT_DNFS, instead of having a >>> copy of it here in this driver, which is just wrong. So please remove >>> this, and just re

Re: [PATCH] arc: include: asm: define empty SERIAL_PORT_DFNS in serial.h

2013-10-30 Thread Vineet Gupta
On 10/31/2013 07:15 AM, Chen Gang wrote: > For some architectures (e.g. arc, openrisc), BASE_BAUD isn't constant > And SERIAL_PORT_DFNS always use BASE_BAUND, and also all drivers use > SERIAL_PORT_DFNS to initialize static variables, statically. > > So need define SERIAL_PORT_DFNS as empty to tell

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-09 Thread Vineet Gupta
) { - /* FIXME :: power off ??? */ + do_kernel_poweroff(); machine_halt(); } - -void (*pm_power_off) (void) = NULL; -EXPORT_SYMBOL(pm_power_off); Acked-by: Vineet Gupta <mailto:vgu...@synopsys.com> Thx, -Vineet ___ devel mailin