On Tue, Oct 20, 2020 at 8:56 PM Elena Afanasova wrote:
>
> Reported by checkpatch.pl
Hi Elena,
Thanks for your patches. Your commit log should mention
why are you doing certain changes. Above commit log
doesn't give reviewer/maintainer an idea about what are
you fixing and why that change is nec
On Wed, Oct 21, 2020 at 12:01 AM Elena Afanasova wrote:
>
> Reported by checkpatch.pl
>
> Signed-off-by: Elena Afanasova
This patch is fixing 2 different checkpatch warnings. They
should be sent as separate patches. One for removing extra
blank lines, another one for fixing the code alignment.
On Wed, Oct 21, 2020 at 8:33 AM Deepak R Varma wrote:
>
> Multiple issues reported by checkpatch script around lines exceeding 100
> columns, indentation of function parameters, extra blank lines. These
> code formatting changes improves the code readability.
Please send separate patches while fi
This patch fixes following smatch warning:
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c:117
ieee80211_ADDBA() warn: variable dereferenced before check 'ieee' (see line 114)
As ieee can not be NULL at this point, all such checks are removed.
Signed-off-by: Vaishali Thakkar
--
On Tuesday 28 February 2017 07:21 PM, Sumantro wrote:
Fixed Warning rasied by checkpatch.pl
Hi,
Usually we prefer to have subject stating what change is done
and commit log stating why that change is done instead of
stating tool name. Though you can give credit to the tool
in the commit log af
On Wednesday 01 March 2017 03:23 PM, Sumantro wrote:
Remove unnecessary whitespaces in rtl_wc.
Problem found by checkpatch.pl.
Signed-off-by: Sumantro
You went back to the same state again. :(
Your from and signed-off-by should have this format:
'firstname lastname '
---
Changes since v
On Sun, Mar 5, 2017 at 10:10 AM, SIMRAN SINGHAL
wrote:
> On Sun, Mar 5, 2017 at 5:36 AM, Alison Schofield wrote:
>> On Thu, Mar 02, 2017 at 02:26:37PM +0100, Noralf Trønnes wrote:
>>>
>>> Den 02.03.2017 14.04, skrev simran singhal:
>>> >This patch fixes the following sparse warnings:
>>> >
>>> >d
On Sunday 28 February 2016 08:18 PM, Tapan Prakash T wrote:
> Fixed blank lines issues reported by checkpatch.pl
Hi,
I can see that you have sent 3 patches for the same file. But they are
sent as separate patches. So, this might be confusing for the maintainer.
So, in this case these are some p
-off-by: Vaishali Thakkar
---
drivers/staging/wilc1000/linux_mon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/linux_mon.c
b/drivers/staging/wilc1000/linux_mon.c
index f5296f5..2a3d875 100644
--- a/drivers/staging/wilc1000/linux_mon.c
+++ b/drivers
follows:
//
@eth_zero_addr@
expression e;
@@
-memset(e,0x00,6);
+eth_zero_addr(e);
//
Signed-off-by: Vaishali Thakkar
---
drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
follows:
//
@eth_zero_addr@
expression e;
@@
-memset(e,0x00,6);
+eth_zero_addr(e);
//
Signed-off-by: Vaishali Thakkar
---
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
On 31 Jul 2015 10:49, "Shraddha Barke" wrote:
>
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: braces {} are not necessary for single statement blocks
There should be one line space between your commit log
and Signed-off-by line.
> Signed-off-by: Shraddha Barke
> ---
> dr
hen != tmp
(
- memcpy(ptr, (T)&tmp,
\(2\|sizeof(u16)\|sizeof(__le16)\|sizeof(uint16_t)\|sizeof(e16)\));
+ put_unaligned_le16(y,ptr);
|
- memcpy(ptr, (T)&tmp, ...);
+ put_unaligned_le16(y,ptr);
)
...+>
? tmp = e
@@ type T; identifier a.tmp; @@
- T tmp;
...when != tmp
Signed-off-by: Va
This patch introduces the use of function setup_timer.
This is done using Coccinelle and semantic patch used is
as follows:
@@
expression x,y,z;
@@
- init_timer (&x);
+ setup_timer (&x, y, z);
- x.function = y;
- x.data = z;
Signed-off-by: Vaishali Thakkar
---
drivers/staging/comedi
This patch introduces the use of function setup_timer.
This is done using Coccinelle and semantic patch used is
as follows:
@@
expression x,y,z;
@@
- init_timer (&x);
+ setup_timer (&x, y, z);
- x.function = y;
- x.data = z;
Signed-off-by: Vaishali Thakkar
---
drivers/staging
Andrianov
Acked-by: Vaishali Thakkar
> ---
> drivers/staging/speakup/kobjects.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/speakup/kobjects.c
> b/drivers/staging/speakup/kobjects.c
> index 528cbdc..7fedee3 100644
> --- a/drivers/
On Monday 03 October 2016 04:21 PM, Sidhant Gupta wrote:
> Fixes a comment coding style warning by adding 2 blank lines. Issue
> found by checkpatch.
>
> Signed-off-by: Sidhant Gupta
Reviewed-by: Vaishali Thakkar
> ---
>
> Changes since v3:
> * Corrected checkpatch
17 matches
Mail list logo
