Re: [PATCH 1/1] staging: rtl8192u: Convert u4bAcParam back to little-endian after construction

On Mon, May 01, 2017 at 02:34:36PM -0700, Greg KH wrote: > On Mon, May 01, 2017 at 06:11:58PM +0100, Tuomo Rinne wrote: > > > > The commit 9304b5b0d4fe ("staging: rtl8192u: Fix sparse warnings in > > r8192U_dm.c") > > adds casting of le16 from cpu en

[PATCH] staging: speakup: Fixed coding style errors and aligned indents

Fixed indentation to use tabs and aligned all the fields to same level. Signed-off-by: Tuomo Rinne --- drivers/staging/speakup/speakup_decpc.c | 90 - 1 file changed, 44 insertions(+), 46 deletions(-) diff --git a/drivers/staging/speakup/speakup_decpc.c b

[PATCH] staging: vt6655: Fixed some coding style issues

Copied function argument names from definition to delcaration. This fixes some checkpatch warnings. Signed-off-by: Tuomo Rinne --- drivers/staging/vt6655/rxtx.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655

[PATCH] staging: vt6655: Copy argument names from function definition to declaration to fix checkpatch warnings

Copied function argument names from definition to delcaration. This fixes some checkpatch warnings. Signed-off-by: Tuomo Rinne --- drivers/staging/vt6655/rxtx.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655

[PATCH] staging: rtl8192u: Improve readability and fix sparse warnings: cast from restricted __le16

ssary scope and splitting complex variable construction to multiple lines. Signed-off-by: Tuomo Rinne --- drivers/staging/rtl8192u/r8192U_dm.c | 77 1 file changed, 42 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/st

[PATCH 3/3] staging: rtl8192u: Convert u4bAcParam back to little-endian after construction

. Unfortunately I don't have the hardware to test this change. Signed-off-by: Tuomo Rinne --- drivers/staging/rtl8192u/r8192U_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c index 5e84ed7..dc

[PATCH 2/3] staging: rtl8192u: Improve code readability

Split the u4bAcParam parameter construction to multiple lines for easier readability. Signed-off-by: Tuomo Rinne --- drivers/staging/rtl8192u/r8192U_dm.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b

[PATCH 1/3] staging: rtl8192u: Remove unnecessary scope

Remove scope unnecessary scope that is already enforced by the if statements scope. Signed-off-by: Tuomo Rinne --- drivers/staging/rtl8192u/r8192U_dm.c | 66 +--- 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c

Fix kbuild warnings

Fix kbuild warnings by passing in variable using address rather than making a copy. Tuomo Rinne (1): staging: rtl8192u: Convert u4bAcParam back to little-endian after construction drivers/staging/rtl8192u/r8192U_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.4

[PATCH 1/1] staging: rtl8192u: Convert u4bAcParam back to little-endian after construction

The commit 9304b5b0d4fe ("staging: rtl8192u: Fix sparse warnings in r8192U_dm.c") adds casting of le16 from cpu endianness. This patch converts the u4bAcParam parameter back to little-endian after it has been constructed. Signed-off-by: Tuomo Rinne --- drivers/staging/rtl8192u/r8192

[PATCH 2/3] staging: rtl8192u: Improve code readability

Split the u4bAcParam parameter construction to multiple lines for easier readability. Signed-off-by: Tuomo Rinne --- drivers/staging/rtl8192u/r8192U_dm.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b

[PATCH 3/3] staging: rtl8192u: Convert u4bAcParam to little-endian

ted. Hence on big-endian architectures the parameter will remain as little-endian. Signed-off-by: Tuomo Rinne --- drivers/staging/rtl8192u/r8192U_dm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c index 283dda

[PATCH 1/3] staging: rtl8192u: Remove unnecessary scope

Remove scope unnecessary scope that is already enforced by the if statements scope. Signed-off-by: Tuomo Rinne --- drivers/staging/rtl8192u/r8192U_dm.c | 66 +--- 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c

[PATCH 0/3] staging: rtl8192u: Refactor u4bAcParam construction

f the last patch of the series for better explanation. Tuomo Rinne (3): staging: rtl8192u: Remove unnecessary scope staging: rtl8192u: Improve code readability staging: rtl8192u: Convert u4bAcParam to little-endian drivers/staging/rtl8192u/r8192U_dm.c | 77 --