Re: [PATCH v2 1/2] staging: wilc1000: remove unused enum

2015-09-13 Thread Tony Cho
On 2015년 09월 14일 13:25, Greg KH wrote: On Mon, Sep 14, 2015 at 10:29:26AM +0900, Tony Cho wrote: On 2015년 09월 12일 11:35, Greg KH wrote: On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote: From: Glen Lee This patch removes a unused enum tenuFrameClass. Signed-off-by: Glen Lee

Re: [PATCH 2/2] staging: wilc1000: remove RX_BH_TYPE

2015-09-14 Thread Tony Cho
Hi Greg, I am sorry but please ignore this patch in this time. It's my mistake to include this patch from my queue into the series of 7 patches. Thanks, Tony. On 2015년 09월 11일 16:52, Tony Cho wrote: This patch removes the preprocessor definition, RX_BH_TYPE and use

[PATCH 0/7] remove wilc_errorsupport.h from the wilc driver

2015-09-14 Thread Tony Cho
This patch aims to remove the wilc_errorsupport.h which is unnecessary in the wilc driver. This patch replaces the error types defined by wilc driver with kernel generic error types and removes macros which handles the errors. Leo Kim (7): staging: wilc1000: remove definition WILC_IS_ERR stagi

[PATCH 1/7] staging: wilc1000: remove definition WILC_IS_ERR

2015-09-14 Thread Tony Cho
From: Leo Kim This patch removes the definition WILC_IS_ERR which is not used anymore. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_errorsupport.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 5/7] staging: wilc1000: remove definitions unused

2015-09-14 Thread Tony Cho
: Tony Cho --- drivers/staging/wilc1000/wilc_errorsupport.h | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_errorsupport.h b/drivers/staging/wilc1000/wilc_errorsupport.h index 99ded3d..054ed76 100644 --- a/drivers/staging/wilc1000

[PATCH 4/7] staging: wilc1000: remove definition WILC_ERRORREPORT

2015-09-14 Thread Tony Cho
and ERRORHANDLER in some of functions. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 6 +- drivers/staging/wilc1000/host_interface.c | 919 +- drivers/staging/wilc1000/wilc_errorsupport.h | 5 - drivers

[PATCH 3/7] staging: wilc1000: remove definition WILC_ERRORCHECK

2015-09-14 Thread Tony Cho
Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 3 ++- drivers/staging/wilc1000/wilc_errorsupport.h | 7 --- drivers/staging/wilc1000/wilc_msgqueue.c | 5 - drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 24 --- 4

[PATCH 2/7] staging: wilc1000: remove definition WILC_NULLCHECK

2015-09-14 Thread Tony Cho
From: Leo Kim This patch removes the definition WILC_NULLCHECK which is not used anymore. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 ++-- drivers/staging/wilc1000/wilc_errorsupport.h | 6 -- drivers/staging

[PATCH 7/7] staging: wilc1000: remove wilc_errorsupport

2015-09-14 Thread Tony Cho
From: Leo Kim This patch removes the file, wilc_errorsupport which is not used anymore. Remove #include "wilc_errorsupport.h" from the source code. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_errorsupport.h | 15 --- drivers/stagin

[PATCH 6/7] staging: wilc1000: replace wilc error types with kernel generic error type.

2015-09-14 Thread Tony Cho
error types. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 24 +-- drivers/staging/wilc1000/host_interface.c | 238 +++--- drivers/staging/wilc1000/linux_mon.c | 14 +- drivers/staging/wilc1000

[PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

2015-09-14 Thread Tony Cho
From: Glen Lee g_num_total_switches is never used so just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000

[PATCH 3/4] staging: wilc1000: coreconfigurator.h: remove unused defines

2015-09-14 Thread Tony Cho
From: Glen Lee The define MAX_PACKET_BUFF_SIZE and STATUS_MSG_LEN is not used in the driver. Delete two defines. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 2/4] staging: wilc1000: delete function declaration SendRawPacket

2015-09-14 Thread Tony Cho
From: Glen Lee SendRawpacket is declared but not implemented. It is not used also. So just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.h

[PATCH 4/4] staging: wilc1000: remove unused variable g_flushing_in_progress

2015-09-14 Thread Tony Cho
From: Glen Lee g_flushing_in_progress is never used so just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging

Re: [PATCH 0/7] remove wilc_errorsupport.h from the wilc driver

2015-09-14 Thread Tony Cho
On 2015년 09월 15일 15:27, Sudip Mukherjee wrote: On Tue, Sep 15, 2015 at 11:53:34AM +0900, Tony Cho wrote: This patch aims to remove the wilc_errorsupport.h which is unnecessary in the wilc driver. This patch replaces the error types defined by wilc driver with kernel generic error types and

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

2015-09-15 Thread Tony Cho
On 2015년 09월 15일 16:13, Sudip Mukherjee wrote: On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote: From: Glen Lee g_num_total_switches is never used so just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- you only deleted from the .h file but it still remains in

Re: [PATCH 2/2] staging: wilc1000: remove RX_BH_TYPE

2015-09-15 Thread Tony Cho
Hi Greg, If it's already in your tree and can be applied alone, no problem to me. I will later send remaining series of it. Thanks, Tony. On 2015년 09월 15일 22:31, Greg KH wrote: On Tue, Sep 15, 2015 at 10:17:41AM +0900, Tony Cho wrote: Hi Greg, I am sorry but please ignore this pat

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

2015-09-15 Thread Tony Cho
On 2015년 09월 15일 22:46, Greg KH wrote: On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote: On 2015년 09월 15일 16:13, Sudip Mukherjee wrote: On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote: From: Glen Lee g_num_total_switches is never used so just delete it. Signed-off-by

[PATCH v2 00/10] resend all of wilc1000 patches

2015-09-15 Thread Tony Cho
: wilc1000: delete function declaration SendRawPacket staging: wilc1000: coreconfigurator.h: remove unused defines staging: wilc1000: remove unused variable g_flushing_in_progress Tony Cho (1): staging: wilc1000: remove PANDA_BOARD drivers/staging/wilc1000/coreconfigurator.c | 165

[PATCH v2 02/10] staging: wilc1000: remove useless define PHY_802_11n

2015-09-15 Thread Tony Cho
From: Glen Lee The define PHY_802_11n is useless because wilc1000 support 802.11n as always. Remove PHY_802_11n and it related code. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers

[PATCH v2 06/10] staging: wilc1000: delete unused global variables.

2015-09-15 Thread Tony Cho
From: Glen Lee gstrConfigPktInfo, SemHandleSendPkt and SemHandlePktResp are never used in the drivers. So just delete the variables and it's related code. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 11 --- 1 file change

[PATCH v2 05/10] staging: wilc1000: remove unnecessary extern function declaration

2015-09-15 Thread Tony Cho
From: Glen Lee Function NetworkInfoReceived, GnrlAsyncInfoReceived and host_int_ScanCompleteReceived are declared in the header file already. Just removes the declaration and comments. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8

[PATCH v2 07/10] staging: wilc1000: remove unused variables

2015-09-15 Thread Tony Cho
From: Glen Lee Variable g_num_total_switches is never used so just remove it. gastrWIDs is also not used because g_num_total_switches is deleted. Remove gastrWIDs also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 127

[PATCH v2 08/10] staging: wilc1000: delete function declaration SendRawPacket

2015-09-15 Thread Tony Cho
From: Glen Lee SendRawpacket is declared but not implemented. It is not used also. So just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.h

[PATCH v2 01/10] staging: wilc1000: remove PANDA_BOARD

2015-09-15 Thread Tony Cho
This patch removes one of the platform dependencies, PANDA_BOARD from the driver codes. The device tree will provide the platform dependencies in the future commits. Signed-off-by: Tony Cho Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 drivers/staging

[PATCH v2 03/10] staging: wilc1000: remove unnecessary define FIVE_GHZ_BAND

2015-09-15 Thread Tony Cho
From: Glen Lee wilc1000 driver does not support five Ghz band. Remove FIVE_GHZ_BAND and it's related code. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wil

[PATCH v2 09/10] staging: wilc1000: coreconfigurator.h: remove unused defines

2015-09-15 Thread Tony Cho
From: Glen Lee The define MAX_PACKET_BUFF_SIZE and STATUS_MSG_LEN is not used in the driver. Delete two defines. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH v2 10/10] staging: wilc1000: remove unused variable g_flushing_in_progress

2015-09-15 Thread Tony Cho
From: Glen Lee g_flushing_in_progress is never used so just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging

[PATCH v2 04/10] staging: wilc1000: remove unused defines

2015-09-15 Thread Tony Cho
From: Glen Lee This patch removes follwing unused defines. MAX_CFG_PKTLEN MSG_HEADER_LEN QUERY_MSG_TYPE WRITE_MSG_TYPE RESP_MSG_TYPE WRITE_RESP_SUCCESS INVALID MAC_ADDR_LEN Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 1 file

[PATCH v2 1/6] staging: wilc1000: remove a macro WILC_NULLCHECK

2015-09-16 Thread Tony Cho
From: Leo Kim This patch replaces WILC_NULLCHECK with the plain statements and then removes the macro WILC_NULLCHECK in wilc_errorsupport.h which is not used anymore. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 7 +-- drivers

[PATCH v2 2/6] staging: wilc1000: remove the macro WILC_ERRORCHECK

2015-09-16 Thread Tony Cho
From: Leo Kim This patch removes the macro WILC_ERRORCHECK which is not used anymore by replacing it with the plain statements. This patch also removes the WILC_CATCH macros from some of functions not to make the build warnings. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers

[PATCH v2 3/6] staging: wilc1000: remove the macro WILC_ERRORREPORT

2015-09-16 Thread Tony Cho
ERRORHANDLER from some of functions. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 4 +- drivers/staging/wilc1000/host_interface.c | 869 +- drivers/staging/wilc1000/wilc_errorsupport.h | 5 - drivers/staging

[PATCH v2 6/6] staging: wilc1000: remove wilc_errorsupport.h

2015-09-16 Thread Tony Cho
mon.h file. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_errorsupport.h | 15 --- drivers/staging/wilc1000/wilc_msgqueue.c | 1 + drivers/staging/wilc1000/wilc_msgqueue.h | 1 - drivers/staging/wilc1000/wilc_oswrapper.h| 3 --- 4 files

[PATCH v2 4/6] staging: wilc1000: remove definitions unused

2015-09-16 Thread Tony Cho
: Tony Cho --- drivers/staging/wilc1000/wilc_errorsupport.h | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_errorsupport.h b/drivers/staging/wilc1000/wilc_errorsupport.h index 99ded3d..054ed76 100644 --- a/drivers/staging/wilc1000

[PATCH v2 0/6] removing wilc_errorsupport.h file

2015-09-16 Thread Tony Cho
This series of patch is resent in total 6 patches as version 2. This version fixes the warnings reported by checkpatch.pl not to make additional warnings. The concern for the memory leak issue is checked again in this version. The error types provided by wilc driver are being replaced by the ones

[PATCH v2 5/6] staging: wilc1000: replace wilc error types with the generic error types

2015-09-16 Thread Tony Cho
. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 24 +-- drivers/staging/wilc1000/host_interface.c | 238 +++--- drivers/staging/wilc1000/linux_mon.c | 14 +- drivers/staging/wilc1000/linux_wlan.c

[PATCH 4/8] staging: wilc1000: remove function linux_wlan_rxq_task

2015-09-16 Thread Tony Cho
From: Glen Lee linux_wlan_rxq_task is not used in the driver. Just remove it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b

[PATCH 2/8] staging: wilc1000: remove define WILC_P2P and ifdef line

2015-09-16 Thread Tony Cho
From: Glen Lee WILC_P2P is always used in the driver. So delete define WILC_P2P and ifdef line. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 2 -- drivers/staging/wilc1000/coreconfigurator.h | 2 -- drivers/staging/wilc1000

[PATCH 1/8] staging: wilc1000: remove define WILC_AP_EXTERNAL_MLME and ifdef line

2015-09-16 Thread Tony Cho
From: Glen Lee This driver use WILC_AP_EXTERNAL_MLME define always. Delete define WILC_AP_EXTERNAL_MLME and ifdef line. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 30 +++ drivers/staging/wilc1000/linux_mon.c

[PATCH 3/8] staging: wilc1000: remove define TCP_ENHANCEMENTS and it's related code

2015-09-16 Thread Tony Cho
From: Glen Lee TCP_ENHANCEMENTS is always in use. Remove define TCP_ENHANCEMENTS, ifdef line, ifndef line and codes inside ifndef. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 36 --- drivers/staging/wilc1000

[PATCH 6/8] staging: wilc1000: remove unused semaphore and it's related codes

2015-09-16 Thread Tony Cho
wlan_rxq_task which was deleted in a previous patch. So delete variable rxq_event, rxq_wait_event, rxq_wait and it's related codes. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 9 - drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1

[PATCH 8/8] staging: wilc1000: remove unused variable rxq_thread

2015-09-16 Thread Tony Cho
From: Glen Lee The rxq_thread never runs since it's kthread_run code was delete in a previous patch. Remove kthread_run and it's related codes. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 6 -- drivers/stagin

[PATCH 5/8] staging: wilc1000: remove variable rxq_thread_started

2015-09-16 Thread Tony Cho
From: Glen Lee rxq_thread_started is initiallized but never used in the driver. Remove the variable and init code line. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 1 - drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 2 files

[PATCH 7/8] staging: wicl1000: remove function pointer wlan_handle_rx_que

2015-09-16 Thread Tony Cho
From: Glen Lee The function pointer wlan_handle_rx_que is not called anywhere. Delete wlan_handle_rx_que and it's assignment code. But the function wilc_wlan_handle_rxq in assignment code is used. So leave it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wil

[PATCH v2 0/2] resend version 2 for RX_BH_TYPE patch

2015-09-17 Thread Tony Cho
This series of patch is the version 2 for the RX_BH_TYPE patch before sent. Glen Lee (2): staging: wilc1000: remove define RX_BH_TYPE staging: wilc1000: remove do-nothing ifdef statement drivers/staging/wilc1000/linux_wlan.c | 149 +- drivers/staging/wilc1000/

[PATCH v2 1/2] staging: wilc1000: remove define RX_BH_TYPE

2015-09-17 Thread Tony Cho
: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 139 -- drivers/staging/wilc1000/linux_wlan_common.h | 3 - drivers/staging/wilc1000/wilc_wfi_netdevice.h | 15 --- drivers/staging/wilc1000/wilc_wlan.c | 3 - 4 files

[PATCH v2 2/2] staging: wilc1000: remove do-nothing ifdef statement

2015-09-17 Thread Tony Cho
From: Glen Lee This patch removes do-nothing ifdef, else statement and add ifdef WILC_SDIO for disable_sdio_interrupt(). Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a

[PATCH 1/4] staging: wilc1000: Modify null check routine

2015-09-17 Thread Tony Cho
From: Leo Kim This patch modify null check routine. - Null check error non return. (Handle_RcvdGnrlAsyncInfo) Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 3/4] staging: wilc1000: remove warnings line over 80 characters

2015-09-17 Thread Tony Cho
From: Leo Kim This patch removes the warnings reported by checkpatch.pl for line over 80 characters. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan_if.h | 650 ++-- 1 file changed, 374 insertions(+), 276 deletions(-) diff

[PATCH 2/4] staging: wilc1000: remove warnings on the multiple blank lines uses

2015-09-17 Thread Tony Cho
From: Leo Kim This patch removes the warnings reported by checkpatch.pl for using multiple blank lines. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan_if.h | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 4/4] staging: wilc1000: wilc_wlan_if.h align defines

2015-09-17 Thread Tony Cho
From: Leo Kim This patch fix alignment of some defines in wilc_wlan_if.h. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan_if.h | 580 1 file changed, 290 insertions(+), 290 deletions(-) diff --git a/drivers/staging

Re: [PATCH 1/4] staging: wilc1000: Modify null check routine

2015-09-17 Thread Tony Cho
On 2015년 09월 17일 18:06, Nicolas Ferre wrote: Le 17/09/2015 10:50, Tony Cho a écrit : From: Leo Kim This patch modify null check routine. - Null check error non return. (Handle_RcvdGnrlAsyncInfo) It doesn't parse... Is it fixing a bug? What were the consequences without the return?

[PATCH v2 1/4] staging: wilc1000: fix null check routine

2015-09-17 Thread Tony Cho
-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 6fdf392..151e8c4 100644 --- a/drivers/staging/wilc1000

[PATCH v2 2/4] staging: wilc1000: remove warnings on the multiple blank lines uses

2015-09-17 Thread Tony Cho
From: Leo Kim This patch removes the warnings reported by checkpatch.pl for using multiple blank lines. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan_if.h | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH v2 0/4] v2 of the series including the null check routin

2015-09-17 Thread Tony Cho
The previous series of 4 patches include a commit message ambiguous and not enough to explain why the patch is made and needed. So, this version 2 includes the modification on the commit message of the patch for a null check fix. Leo Kim (4): staging: wilc1000: fix null check routine staging:

[PATCH v2 3/4] staging: wilc1000: remove warnings line over 80 characters

2015-09-17 Thread Tony Cho
From: Leo Kim This patch removes the warnings reported by checkpatch.pl for line over 80 characters. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan_if.h | 650 ++-- 1 file changed, 374 insertions(+), 276 deletions(-) diff

[PATCH v2 4/4] staging: wilc1000: wilc_wlan_if.h align defines

2015-09-17 Thread Tony Cho
From: Leo Kim This patch fix alignment of some defines in wilc_wlan_if.h. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan_if.h | 580 1 file changed, 290 insertions(+), 290 deletions(-) diff --git a/drivers/staging

[PATCH 05/34] staging: wilc1000 remove typedef from the union

2015-09-18 Thread Tony Cho
This patch gets rid of typedef from the union and renames tuniHostIFmsgBody with simply message_body because the Linux coding style does not recommend camelcase notation and typedef for structure, enmu and also union. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8

[PATCH 06/34] staging: wilc1000: rename uniHostIFmsgBody

2015-09-18 Thread Tony Cho
This patch changes the camelcase notation, uniHostIFmsgBody which is a member variable of structure host_if_msg to body in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 296 +++--- 1 file changed, 148

[PATCH 02/34] staging: wilc1000: remove typedef from the struct

2015-09-18 Thread Tony Cho
The Linux kernel coding style does not recommend to use typedef for the structure. This patch removes typedef from the host_if_msg structure. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 294 +++--- 1 file changed, 147 insertions(+), 147

[PATCH 03/34] staging: wilc1000: rename strHostIFmsg

2015-09-18 Thread Tony Cho
This patch changes the name, strHostIFmsg simply to msg because the camelcase notation is not recommended in Linux. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 794 +++--- 1 file changed, 397 insertions(+), 397 deletions(-) diff --git a

[PATCH 09/34] staging: wilc1000: remove typedef from the struct tstrRcvdNetworkInfo

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrRcvdNetworkInfo and renames it to rcvd_net_info in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 7 --- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed

[PATCH 04/34] staging: wilc1000: rename u16MsgId

2015-09-18 Thread Tony Cho
This patch changes the name, u16MsgId simply to id to avoid the camelcase notation. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 102 +++--- 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 07/34] staging: wilc1000: remove typedef from the struct tstrHostIFscanAttr

2015-09-18 Thread Tony Cho
This patch removes typedef from the structure tstrHostIFscanAttr and changes the camelcase name, tstrHostIFscanAttr to scan_attr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 14 +++--- 1 file changed, 7

[PATCH 08/34] staging: wilc1000: remove typedef from the struct tstrHostIFconnectAttr

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIFconnectAttr and renames it to connect_attr to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 01/34] staging: wilc1000: rename tstrHostIFmsg

2015-09-18 Thread Tony Cho
This patch changes the name, tstrHostIFmsg to host_if_msg not to use camelcase notation in the Linux. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 294 +++--- 1 file changed, 147 insertions(+), 147 deletions(-) diff --git a/drivers/staging

[PATCH 14/34] staging: wilc1000: remove typedef from the struct tstrHostIFGetChan

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIFGetChan and renames it to get_channel in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 10/34] staging: wilc1000: remove typedef from the struct tstrRcvdGnrlAsyncInfo

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrRcvdGnrlAsyncInfo and renames it to rcvd_async_info in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff

[PATCH 11/34] staging: wilc1000: remove typedef from the struct tstrHostIFkeyAttr

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIFkeyAttr and renames it to key_attr in oder to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 12/34] staging: wilc1000: remove typedef from the struct tstrHostIFCfgParamAttr

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIFCfgParamAttr and renames it to cfg_param_attr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

[PATCH 16/34] staging: wilc1000: remove typedef from the struct tstrHostIFDelBeacon

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIFDelBeacon and renames it to del_beacon in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a

[PATCH 17/34] staging: wilc1000: remove typedef from the struct tstrWILC_AddStaParam

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrWILC_AddStaParam and renames it to add_sta_param in oder to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 37 +-- drivers/staging/wilc1000/host_interface.h

[PATCH 18/34] staging: wilc1000: remove typedef from the struct tstrTimerCb

2015-09-18 Thread Tony Cho
This patch removes typedef from the tstrTimerCb and renames it to timer_cb in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 13/34] staging: wilc1000: remove typedef from the struct tstrHostIFSetChan

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIFSetChan and ranames it to set_channel in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a

[PATCH 15/34] staging: wilc1000: remove typedef from the struct tstrHostIFSetBeacon

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIFSetBeacon and renames it to set_beacon in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a

[PATCH 27/34] staging: wilc1000: remove typedef from the struct tstrHostIfBASessionInfo

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIfBASessionInfo and renames it to ba_session_info in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 17 ++--- drivers/staging/wilc1000/host_interface.h | 5

[PATCH 25/34] staging: wilc1000: remove typedef from the struct tstrHostIfSetMacAddress

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIfSetMacAddress and renames it set_mac_addr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 5 ++--- 2 files changed, 5

[PATCH 22/34] staging: wilc1000: remove typedef from the struct tstrHostIfSetDrvHandler

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIfSetDrvHandler and renames it to drv_handler in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 7 --- drivers/staging/wilc1000/host_interface.h | 4 ++-- 2 files changed

[PATCH 26/34] staging: wilc1000: remove typedef from the struct tstrHostIfGetMacAddress

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIfGetMacAddress and renames it get_mac_addr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 5 ++--- 2 files changed, 5

[PATCH 24/34] staging: wilc1000: remove typedef from the struct tstrHostIfSetOperationMode

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIfSetOperationMode and renames it to op_mode in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 4 ++-- 2 files changed, 5

[PATCH 23/34] staging: wilc1000: remove typedef from the struct tstrHostIFSetMulti

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIFSetMulti and renames it to set_multicast in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH 20/34] staging: wilc1000: remove typedef from the struct tstrHostIfStaInactiveT

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIfStaInactiveT and renames it to sta_inactive_t in oder to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 21/34] staging: wilc1000: remove typedef from the struct tstrHostIFSetIPAddr

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIFSetIPAddr and renames it to set_ip_addr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 19/34] staging: wilc1000: remove typedef from the struct tstrHostIfPowerMgmtParam

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIfPowerMgmtParam and renames it to power_mgmt_param in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff

[PATCH 28/34] staging: wilc1000: remove typedef from the struct tstrHostIFDelSta

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIFDelSta and renames it del_sta in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH 29/34] staging: wilc1000: remove typedef from the struct tstrHostIfRemainOnChan

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIfRemainOnChan and renames it to remain_ch in order to comply with the Linux coding style Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 +--- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed

[PATCH 30/34] staging: wilc1000: remove typedef from the struct tstrHostIfRegisterFrame

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIfRegisterFrame and renames it to reg_frame in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 7 ++- 2 files changed

[PATCH 33/34] staging: wilc1000: remove u32Intialized which is unnecessary

2015-09-18 Thread Tony Cho
This patch removes the global variable, u32Intialized which is not necessary from the host_interface.c file. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b

[PATCH 34/34] staging: wilc1000: delete unnecessary comments and dead code

2015-09-18 Thread Tony Cho
The comments in union message_body are not essential and cross 80 ending line, so they are deleted and also a dead code commented out in the union is deleted. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 27 +-- 1 file changed, 13 insertions

[PATCH 32/34] staging: wilc1000: remove unnecessary global variable

2015-09-18 Thread Tony Cho
The global variable msgQ_created is removed because it is not necessary. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index

[PATCH 31/34] staging: wilc1000: remove typedef from the struct tstrHostIFDelAllSta

2015-09-18 Thread Tony Cho
This patch removes typedef from the struct tstrHostIFDelAllSta and renames it to del_all_sta in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a

Re: [PATCH v2 1/4] staging: wilc1000: fix null check routine

2015-09-20 Thread Tony Cho
On 2015년 09월 19일 11:50, Greg KH wrote: On Thu, Sep 17, 2015 at 07:02:17PM +0900, Tony Cho wrote: From: Leo Kim This patch removes the potential faults which may happen when unexpectedly getting access to invalid pointer. The pointer of pstrWFIDrv is unlikely to be invalid. However, it is

Re: [PATCH 03/34] staging: wilc1000: rename strHostIFmsg

2015-09-20 Thread Tony Cho
On 2015년 09월 19일 12:00, Greg KH wrote: On Fri, Sep 18, 2015 at 06:11:05PM +0900, Tony Cho wrote: This patch changes the name, strHostIFmsg simply to msg because the camelcase notation is not recommended in Linux. Signed-off-by: Tony Cho Because of the other patches I didn't accept,

[PATCH v2 00/34] resending v2 for the patches of removing typedef

2015-09-20 Thread Tony Cho
This is the version 2 for the series of the patch that mostly removes the typedef from the structures and renames its names to comply with the Linux coding style. The version 2 is rebased again onto the staging-testing branch to synchronize with the mainstream. Tony Cho (34

[PATCH v2 01/34] staging: wilc1000: rename tstrHostIFmsg

2015-09-20 Thread Tony Cho
This patch changes the name, tstrHostIFmsg to host_if_msg not to use camelcase notation in the Linux. Signed-off-by: Tony Cho Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wilc1000/host_interface.c | 294 +++--- 1 file changed, 147 insertions(+), 147 deletions

[PATCH v2 03/34] staging: wilc1000: rename strHostIFmsg

2015-09-20 Thread Tony Cho
This patch changes the name, strHostIFmsg simply to msg because the camelcase notation is not recommended in Linux. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 794 +++--- 1 file changed, 397 insertions(+), 397 deletions(-) diff --git a

[PATCH v2 05/34] staging: wilc1000 remove typedef from the union

2015-09-20 Thread Tony Cho
This patch gets rid of typedef from the union and renames tuniHostIFmsgBody with simply message_body because the Linux coding style does not recommend camelcase notation and typedef for structure, enmu and also union. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8

[PATCH v2 04/34] staging: wilc1000: rename u16MsgId

2015-09-20 Thread Tony Cho
This patch changes the name, u16MsgId simply to id to avoid the camelcase notation. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 102 +++--- 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH v2 02/34] staging: wilc1000: remove typedef from the struct

2015-09-20 Thread Tony Cho
The Linux kernel coding style does not recommend to use typedef for the structure. This patch removes typedef from the host_if_msg structure. Signed-off-by: Tony Cho Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wilc1000/host_interface.c | 294 +++--- 1 file

[PATCH v2 10/34] staging: wilc1000: remove typedef from the struct tstrRcvdGnrlAsyncInfo

2015-09-20 Thread Tony Cho
This patch removes typedef from the struct tstrRcvdGnrlAsyncInfo and renames it to rcvd_async_info in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff

<    1   2   3   4   5   6   7   >