[PATCH 13/13] staging: wilc1000: init_irq: change argument and use netdev private wilc

From: Glen Lee This patch changes function argument type wilc with net_device and use netdev private data member wilc instead of p_nic. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 18 +++--- 1 file changed, 11 insertions(+), 7

Re: [PATCH V2] staging: wilc1000: wilc_msgqueue.c : remove the goto ERRORHANDER

On 2015년 10월 17일 13:28, Greg KH wrote: On Wed, Oct 14, 2015 at 05:52:55PM +0900, Tony Cho wrote: On 2015년 10월 14일 17:32, Mike Rapoport wrote: On Wed, Oct 14, 2015 at 02:55:43PM +0900, Tony Cho wrote: From: Leo Kim This patch removes goto ERRORHANDER and the result variable in

Re: [PATCH V2 01/40] staging: wilc1000: rename ssidLen of struct join_bss_param

On 2015년 10월 17일 13:59, Greg KH wrote: On Fri, Oct 16, 2015 at 01:37:31PM +0900, Tony Cho wrote: From: Leo Kim This patch renames ssidLen of struct join_bss_param to ssid_len to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging

Re: [PATCH 35/40] staging: wilc1000: rename variable s32Error

On 2015년 10월 17일 13:56, Greg KH wrote: On Thu, Oct 15, 2015 at 01:25:16PM +0900, Tony Cho wrote: From: Leo Kim This patch renames variable s32Error to result to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000

Re: [PATCH 03/16] staging: wilc1000: rename g_linux_wlan to wl

On 2015년 10월 17일 13:33, Greg KH wrote: On Wed, Oct 14, 2015 at 08:46:31PM +0900, Tony Cho wrote: This patch renames g_linux_wlan to wl. Why? What's wrong with g_linux_wlan? You will need to delete this entire variable soon anyway, might as well leave it alone until then. The reason

Re: [PATCH] staging/wilc: fix Kconfig dependencies, second try

Hi Arnd Bergmann, When I apply this patch, I cannot make WILC1000 module (wilc1000.ko) because CONFIG_WILC1000 is y and also I can see some link errors for the cfg80211 APIs. Can you consider this patch? Thanks, Tony. On 2015년 10월 17일 05:45, Arnd Bergmann wrote: My first attempt to fix the

[PATCH V3] staging: wilc1000: wilc_msgqueue.c : add goto statement

function. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- V3: use goto statement to seperate error types into release_lock and mem_free --- drivers/staging/wilc1000/wilc_msgqueue.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/staging

[PATCH RESEND 1/6] staging: wilc1000: rename variable s32Error

From: Leo Kim This patch renames variable s32Error to result to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 781 ++ 1 file changed, 370 insertions(+), 411 deletions(-) diff

[PATCH RESEND 3/6] staging: wilc1000: move variable FALSE_FRMWR_CHANNEL

From: Leo Kim This patch moves the variable 'FALSE_FRMWR_CHANNEL' to where local definitions are. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stagin

[PATCH RESEND 4/6] staging: wilc1000: fixes unnecessary variable replacement

From: Leo Kim This patch removes an unnecessary variable use for the errors and returns errors directly without a result variable. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 28 +--- 1 file changed, 9 insertions

[PATCH RESEND 2/6] staging: wilc1000: move variable clients_count

From: Leo Kim This patch moves static variable clients_count to around where the local variables are togther. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 0/6] WILC1000 rebase and resend some of patch series

This series of patches are resent after some of 40 patches are rebased. Leo Kim (6): staging: wilc1000: rename variable s32Error staging: wilc1000: move variable clients_count staging: wilc1000: move variable FALSE_FRMWR_CHANNEL staging: wilc1000: fixes unnecessary variable replacement s

[PATCH RESEND 5/6] staging: wilc1000: fixes alignment should match open parenthesis

From: Leo Kim This patch fixes the checks reported by checkpatch.pl for alignment should match open parenthesis. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 153 +++--- 1 file changed, 78 insertions(+), 75 deletions

[PATCH RESEND 6/6] staging: wilc1000: fixes comparison to NULL could be written

From: Leo Kim This patch fixes the checks reported by checkpatch.pl for comparison to NULL could be written. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 181 ++ 1 file changed, 87 insertions(+), 94 deletions

[PATCH V2 01/12] staging: wilc1000: change the type of wilc1000_initialized

This patch changes the type of wilc1000_initialized in the struc wilc from int to bool and also renames it to the initialized. In addition, unnecessary wilc1000_initialized codes are removed in this patch. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 13

[PATCH 00/12] WILC1000 V2 for the g_linux_wlan

The series of V2 restore the global variable, wl to g_linux_wlan which is its original name becasue it will be replaced with local structure and deleted. Tony Cho (12): staging: wilc1000: change the type of wilc1000_initialized staging: wilc1000: rename u8NoIfcs in the struct wilc staging

[PATCH V2 06/12] staging: wilc1000: rename drvHandler in the struct wilc_vif

This patch renames drvHandler in the struct wilc_vif to the hif_drv. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 24 +++ drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2

[PATCH V2 04/12] staging: wilc1000: rename aSrcAddress in the struct wilc_vif

This patch renames aSrcAddress in the struct wilc_vif to the src_addr. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- 3 files

[PATCH V2 03/12] staging: wilc1000: rename strInterfaceInfo in the sturct wilc

This patch renames strInterfaceInfo in the struct wilc to the vif. In addition, unnecessary print statements around it are removed in this patch. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 91 +++ drivers/staging/wilc1000

[PATCH V2 02/12] staging: wilc1000: rename u8NoIfcs in the struct wilc

This patch renames u8NoIfcs of the struct wilc to the vif_num to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 18 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- 2 files changed, 10 insertions(+), 10

[PATCH V2 07/12] staging: wilc1000: rename wilc_netdev in the struct wilc_vif

This patch renames wilc_netdev in the struct wilc_vif to the ndev. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 50 +++ drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 34 +++ drivers/staging/wilc1000/wilc_wfi_netdevice.h

[PATCH V2 05/12] staging: wilc1000: rename aBSSID in the sturct wilc_vif

This patch renames aBSSID in the struct wilc_vif to the bssid. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 14 +++--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- 3 files

[PATCH V2 09/12] staging: wilc1000: rename wilc_firmware in the struct wilc

This patch renames wilc_firmware in the struct wilc to the firmware. In addition, null assignments to the wl->firmware after release_firmware are removed because it is not necessary. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 15 +++ drivers/stag

[PATCH V2 12/12] staging: wilc1000: assign pointer of g_linux_wlan to sdio device data

This patch assigns wl pointer to sdio device data. The global variable g_linux_wlan will be removed finally. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 5 +++-- drivers/staging/wilc1000/linux_wlan_sdio.c| 5 +++-- drivers/staging/wilc1000

[PATCH V2 10/12] staging: wilc1000: remove COMPLEMENT_BOOT

seen. In addition, this patch removes _fail_threads_ statement to avoid the build warning after removing COMPLEMENT_BOOT conditionals. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 132 ++--- drivers/staging/wilc1000/linux_wlan_sdio.c | 9

[PATCH V2 08/12] staging: wilc1000: move clean up codes into wl_wlan_cleanup function

This patch moves clean up codes from exit_wilc_driver into the wl_wlan_cleanup newly introduced in this patch. In addition, it is called by linux_sdio_remove function. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 95 --- drivers/staging

[PATCH V2 11/12] staging: wilc1000: introduce struct wilc_sdio for sdio data

This patch introduces struct wilc_sdio for sdio driver data. The wilc_sdio is allocated and set as driver data when the sdio is probed and deallocated when the sdio is removed. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan_sdio.c | 16 1 file changed, 16

[PATCH] staging: wilc1000: fix the bug on copying bssid

ed to be copied twice. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 646e7e9..4c7e1e4 100644 --- a/drivers/staging/wil

[PATCH 06/13] staging: wilc1000: chage_virtual_intf: use netdev private wilc

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 85 --- 1 file changed, 45 insertions(+), 40 deletions(-) diff --git a

[PATCH 04/13] staging: wilc1000: mac_open: use netdev private wilc

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging

[PATCH 02/13] staging: wilc1000: wilc1000_wlan_init: use netdev private wilc

From: Glen Lee This patch use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a

[PATCH 05/13] staging: wilc1000: mac_close: use netdev private wilc instead of g_linux_wlan

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 01/13] staging: wilc1000: add wilc to netdev private data structure

ned-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 1 + drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 5701e58..8fa6b7c 100

[PATCH 03/13] staging: wilc1000: wlan_init_locks: change parameter and use wilc

From: Glen Lee This patch changes function parameter type wilc with net_device and use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 25 +++-- 1 file

[PATCH 09/13] staging: wilc1000: add_key: use netdev private wilc instead of g_linux_wlan

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 10/13] staging: wilc1000: del_key: use netdev private wilc instead of g_linux_wlan

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000

[PATCH 11/13] staging: wilc1000: wilc_mgmt_frame_register: use netdev private wilc

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 07/13] staging: wilc1000: wilc1000_wlan_deinit: change argument and use wilc

From: Glen Lee This patch changes function argument wilc with net_device and use nic->wilc instead of global variable g_linux_wlan. The null check codes should be placed before it is used so move it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wla

[PATCH 08/13] staging: wilc1000: CfgConnectResult: use netdev private wilc

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 13/13] staging: wilc1000: init_irq: change argument and use netdev private wilc

From: Glen Lee This patch changes function argument type wilc with net_device and use netdev private data member wilc instead of p_nic. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 18 +++--- 1 file changed, 11 insertions(+), 7

[PATCH 12/13] staging: wilc1000: start_ap: use netdev private data wilc

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000

Re: [PATCH V2 03/12] staging: wilc1000: rename strInterfaceInfo in the sturct wilc

Thanks for your review. I will do it later as you mentioned. Tony. On 2015년 10월 22일 20:19, Dan Carpenter wrote: Don't resend the series though. Please fix it in a later patch. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.o

Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

On 2015년 10월 23일 15:57, Dan Carpenter wrote: On Fri, Oct 23, 2015 at 02:28:21PM +0900, Glen Lee wrote: This patch add new argument wilc to wilc_handle_isr and pass wilc to the function. It's not important enough to redo the patch but why are we sometimes using "wl" and sometimes "wilc"? We

Re: [PATCH 00/19] staging/wilc1000 cleanups

Hi Arnd, First of all, I would like to say "thank you" for your efforts and contributions. We are updating the driver because new revision came up and making new patches to make it stable and elegant as Linux driver. In these days, we are sending big changes while testing such patches and also

Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

On 2015년 10월 23일 16:52, Dan Carpenter wrote: On Fri, Oct 23, 2015 at 04:36:07PM +0900, Tony Cho wrote: In addition, the function parameter names will be wilc for the variable of struct wilc. The "wl" is local variable naming as well. So if it is a parameter it is wilc but if it

Re: [PATCH 00/19] staging/wilc1000 cleanups

w and contribution. Thanks, Tony. On 2015년 10월 23일 16:51, Tony Cho wrote: Hi Arnd, First of all, I would like to say "thank you" for your efforts and contributions. We are updating the driver because new revision came up and making new patches to make it stable and elegant as Linux driver

[PATCH] staging: wilc1000: change MAINTAINERS

This patch removes Rachel Kim from the MAINTAINERS list because she retires from her position and adds Austin shin as new MAINTAINER for the Atmel wireless link controller: WILC1000 and WILC3000. Signed-off-by: Tony Cho --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 0/5] 64 bit build patch

This series of patch includes new design for 64 bits. The driver uses the redundant typecasting to communicate with the chipset, which causes several compile warnings. However, this patch uses the real data type and removes unnecessary typecasting. Also, the driver allocates the ID value to the

[PATCH 4/5] staging: wilc1000: use the real data type

From: Johnny Kim This patch changes the type of gu8FlushedJoinReqDrvHandler with his real data type becasue typecasting is not necessary. In result, typecasting which is not necessary and some building warnings is removed. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging

[PATCH 5/5] staging: wilc1000: use id value as argument

them. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 242 +++--- drivers/staging/wilc1000/host_interface.h | 1 + drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 3 files changed, 180 insertions(+), 64 dele

[PATCH 3/5] staging: wilc1000: clarify the argument type

is removed becasue it is not necessary. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 78 +++ drivers/staging/wilc1000/host_interface.h | 4 +- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a

[PATCH 2/5] staging: wilc1000: change void pointer type to real type

From: Johnny Kim This patch changes the void pointer member of the tstrHostIFmsg to the real data type because the void pointer type is ambiguous and not readable. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1

[PATCH 1/5] staging: wilc1000: replace WILC_WFIDrvHandle by tstrWILC_WFIDrv

Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 126 +++--- drivers/staging/wilc1000/host_interface.h | 104 +- drivers/staging/wilc1000/linux_wlan.c | 16 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperatio

[PATCH 0/5] staging: wilc1000: 64bit build patch

This series of patch includes new design for 64 bits. The driver uses the redundant typecasting to communicate with the chipset, which causes several compile warnings. However, this patch uses the real data type and removes unnecessary typecasting. Also, the driver allocates the ID value to the po

[PATCH 2/5] staging: wilc1000: change void pointer type to real type

From: Johnny Kim This patch changes the void pointer member of the tstrHostIFmsg to the real data type because the void pointer type is ambiguous and not readable. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1

[PATCH 1/5] staging: wilc1000: replace WILC_WFIDrvHandle by tstrWILC_WFIDrv

Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 126 +++--- drivers/staging/wilc1000/host_interface.h | 104 +- drivers/staging/wilc1000/linux_wlan.c | 16 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperatio

[PATCH 4/5] staging: wilc1000: use the real data type

From: Johnny Kim This patch changes the type of gu8FlushedJoinReqDrvHandler with his real data type becasue typecasting is not necessary. In result, typecasting which is not necessary and some building warnings is removed. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging

[PATCH 3/5] staging: wilc1000: clarify the argument type

is removed becasue it is not necessary. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 78 +++ drivers/staging/wilc1000/host_interface.h | 4 +- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a

[PATCH 5/5] staging: wilc1000: use id value as argument

them. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 249 +++--- drivers/staging/wilc1000/host_interface.h | 1 + drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 3 files changed, 186 insertions(+), 65 dele

[PATCH 0/5] staging: wilc1000: support 64bit machine and remove warnings

This includes the remaining patches for 64bits. The driver uses the redundant typecasting to communicate with the chipset, which causes several compile warnings. However, this patch uses the real data type and removes unnecessary typecasting. Also, the driver allocates the ID value to the pointer

[PATCH 1/5] staging: wilc1000: use the real data type

From: Johnny Kim This patch changes the type of gu8FlushedJoinReqDrvHandler with his real data type becasue typecasting is not necessary. In result, typecasting which is not necessary and some building warnings is removed. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging

[PATCH 2/5] staging: wilc1000: add an argument for Handle_SetWfiDrvHandler

From: Johnny Kim Similar to functions of same layer, this patch add an argument for Handle_SetWfiDrvHandler function. As a result, the redundant typecasting is removed. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 +++- 1 file

[PATCH 5/5] staging: wilc1000: define undefined operation mode

From: Johnny Kim This patch adds new define, IDLE_MODE to change comparison statement which is wrong due to typecasting to null. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 1 + 2 files

[PATCH 4/5] staging: wilc1000: change address to fixed value

From: Johnny Kim The linux_wlan_init_test_config() is called once when net driver is loaded. And because the pointer type of the pstrWFIDrv is changed with the interger type, this patch replaces it with designated value instead of pointer. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho

[PATCH 3/5] staging: wilc1000: use id value as argument

them. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 241 +++--- drivers/staging/wilc1000/host_interface.h | 1 + drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 3 files changed, 176 insertions(+), 67 dele

[PATCH 3/3] staging: wilc1000: fix potential memory leak

This patch adds kfree(mgmt_tx) when memory allocation of mgmt_tx->buff fails in the second calls of kmalloc() to avoid the memory leak from mgmt_tx first allocated before the second calls of kmalloc(). Signed-off-by: Tony Cho Signed-off-by: Chris Park --- drivers/staging/wilc1000/linux_mo

[PATCH 2/3] staging: wilc1000: remove unused preprocessor definition

This patch removes a preprocessor definition, SWITCH_LOG_TERMINAL, which is not used. Enabling this definition affects the performance. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c| 6 -- drivers/staging/wilc1000/wilc_wlan_cfg.c | 8 2 files changed, 14

[PATCH 1/3] staging: wilc1000: remove dead codes

This patch removes the preprocessor definition from the codes, as shown in the following, which is not used anymore. - WILC_FULLY_HOSTING_AP Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_mon.c | 97 --- drivers/staging/wilc1000/linux_wlan.c

Re: [PATCH 4/5] staging: wilc1000: wilc_msgqueue.c: use kmalloc with GFP_ATOMIC

On 2015년 09월 08일 00:36, Chaehyun Lim wrote: This patch use kmalloc with GFP_ATOMIC instead of WILC_MALLOC. It is inside the spin lock region. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/5] staging: wilc1000: define undefined operation mode

From: Johnny Kim This patch adds new define, IDLE_MODE to change comparison statement which is wrong due to typecasting to null. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 1 + 2 files

[PATCH 3/5] staging: wilc1000: add maintainers for Atmel 802.11 driver

This patch adds new maintainers who develops new design for Atmel 802.11 link controller and deletes Dean Lee who cannot maintain the wireless driver anymore. Signed-off-by: Tony Cho --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH 2/5] staging: wilc1000: remove meaningless line

the line for dummy headroom. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 59c9b44..dc297fc 100644 --- a/drivers

[PATCH 5/5] staging: wilc1000: delete definition USE_WIRELESS

From: "Kim, Leo" The preprocessor definition, USE_WIRELESS is always in use. So, this patch deletes the definitions from the makefile and source codes. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Makefile | 2 +- drivers/staging/wilc1000/linux_m

[PATCH 4/5] staging: wilc1000: remove unused NM73131_0_BOARD

From: "Kim, Leo" This patch removes the preprocessor definition, NM73131_0_BOARD which is not used anymore. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 40 -- drivers/staging/wilc1000/linux_wlan_common.h | 7 +-

[PATCH 2/4] staging: wilc1000: delete wilc_memory.c and wilc_memory.h

From: Glen Lee The macro WILC_MALLOC is not used in the driver anymore, so just delete files. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Makefile | 2 +- drivers/staging/wilc1000/wilc_memory.c| 16 drivers/staging/wilc1000/wilc_memory.h

[PATCH 1/4] staging: wilc1000: remove kmalloc wrapper

is one kmalloc which flag is always GFP_ATOMIC. This also changed together. Others are not holding a spin lock or in interrupt context. So use GFP_KERNEL flag for kmalloc. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 110

[PATCH 3/4] staging: wilc1000: delete wilc_oswrapper.h and wilc_platform.h

, remove wilc_oswrapper.h and wilc_platform.h. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 1 + drivers/staging/wilc1000/host_interface.c | 3 ++ drivers/staging/wilc1000/host_interface.h | 1 + drivers/staging/wilc1000/wilc_msgqueue.c

[PATCH 4/4] staging: wilc1000: remove unused PLAT_RK3026_TCHIP

From: Leo Kim This patch removes the preprocessor definition, PLAT_RK3026_TCHIP which is not used anymore. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/staging

Re: [PATCH 1/4] staging: wilc1000: remove kmalloc wrapper

On 2015년 09월 10일 03:17, Greg KH wrote: On Wed, Sep 09, 2015 at 04:08:10PM +0900, Tony Cho wrote: From: Glen Lee Call kmalloc directly. No need to wrap kmalloc. Only one function, wilc_mq_send which use WILC_MALLOC, can be running in interrupt context or process context. In this case, We

Re: [PATCH 3/4] staging: wilc1000: delete wilc_oswrapper.h and wilc_platform.h

error values defined in the errorsupport.h file so that I send you the next patch when done. Thanks, Tony. On 2015년 09월 10일 03:19, Greg KH wrote: On Wed, Sep 09, 2015 at 04:08:12PM +0900, Tony Cho wrote: From: Glen Lee wilc1000 driver runs on Linux. No need to have oswrapper or platform

[PATCH] staging: wilc1000: remove BROKEN status

This patch removes BROKEN status from the Kconfig. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/Kconfig b/drivers/staging/wilc1000/Kconfig index 51bbf46..59ccecc 100644 --- a/drivers/staging/wilc1000

[PATCH v2 1/2] staging: wilc1000: remove kmalloc wrapper

From: Glen Lee This patch calls kmalloc() directly. No need to wrap kmalloc(). All is not holding a spin lock or in interrupt context. So use GFP_KERNEL flag for kmalloc. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 110

[PATCH v2 2/2] staging: wilc1000: delete wilc_memory.c and wilc_memory.h

From: Glen Lee The macro WILC_MALLOC is not used in the driver anymore, so just delete files. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Makefile | 2 +- drivers/staging/wilc1000/wilc_memory.c| 16 drivers/staging/wilc1000/wilc_memory.h

[PATCH 1/5] staging: wilc1000: remove STATIC_MACADDRESS

This patch removes unused definition, STATIC_MACADDRESS from the linux_wlan.c file. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 77 --- 1 file changed, 77 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging

[PATCH 3/5] staging: wilc1000: remove unused global variables

This patch removes the followings from the driver because they are in debugging purpose but not used anymore. - int_clrd - int_rcvdU - int_rcvdB - android_wifi_priv_cmd structure Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 17 - drivers/staging/wilc1000

[PATCH 4/5] staging: wilc1000: remove unused enum

From: Glen Lee This patch removes a unused enum tenuFrameClass. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000

[PATCH 2/5] staging: wilc1000: remove firmware definition

This patch removes the firmware definitions, STA_FIRMWARE, AP_FIRMWARE, and P2P_CONCURRENCY_FIRMWARE from the linux_wlan.c file because they are defined in the Makefile. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 12 1 file changed, 12 deletions(-) diff

[PATCH 5/5] staging: wilc1000: coreconfigurator.c: remove unused functions

. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 151 1 file changed, 151 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c index 450c3ff..f339085

[PATCH v2 1/2] staging: wilc1000: remove unused enum

From: Glen Lee This patch removes a unused enum tenuFrameClass. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000

[PATCH v2 2/2] staging: wilc1000: coreconfigurator.c: remove unused functions

. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 1051 --- 1 file changed, 1051 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c index 450c3ff..f393424

[PATCH 0/2] resending v2 of the patch for coreconfigurator.c file

This is the version 2 for the series of the patch which removes unused functions from the coreconfigurator.c file. Some of functions was not included in the first patch. Glen Lee (2): staging: wilc1000: remove unused enum staging: wilc1000: coreconfigurator.c: remove unused functions drivers

[PATCH 1/7] staging: wilc1000: remove PANDA_BOARD

This patch removes one of the platform dependencies, PANDA_BOARD from the driver codes. The device tree will provide the platform dependencies in the future commits. Signed-off-by: Tony Cho Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 drivers/staging

[PATCH 3/7] staging: wilc1000: remove unnecessary define FIVE_GHZ_BAND

From: Glen Lee wilc1000 driver does not support five Ghz band. Remove FIVE_GHZ_BAND and it's related code. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wil

[PATCH 2/2] staging: wilc1000: remove RX_BH_TYPE

This patch removes the preprocessor definition, RX_BH_TYPE and uses the request_threaded_irq instead of kernel thread to execute the interrupt handler. As a result, linux_wlan_enable_irq() and linux_wlan_disable_irq() are also removed from the linux_wlan.c file. Signed-off-by: Tony Cho

[PATCH 4/7] staging: wilc1000: remove unused defines

From: Glen Lee This patch removes follwing unused defines. MAX_CFG_PKTLEN MSG_HEADER_LEN QUERY_MSG_TYPE WRITE_MSG_TYPE RESP_MSG_TYPE WRITE_RESP_SUCCESS INVALID MAC_ADDR_LEN Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 1 file

[PATCH 2/7] staging: wilc1000: remove useless define PHY_802_11n

From: Glen Lee The define PHY_802_11n is useless because wilc1000 support 802.11n as always. Remove PHY_802_11n and it related code. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers

[PATCH 5/7] staging: wilc1000: remove unnecessary extern function declaration

From: Glen Lee Function NetworkInfoReceived, GnrlAsyncInfoReceived and host_int_ScanCompleteReceived are declared in the header file already. Just removes the declaration and comments. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8

[PATCH 6/7] staging: wilc1000: delete unused global variables.

From: Glen Lee gstrConfigPktInfo, SemHandleSendPkt and SemHandlePktResp are never used in the drivers. So just delete the variables and it's related code. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 11 --- 1 file change

[PATCH 7/7] staging: wilc1000: remove unused variables

From: Glen Lee Variable g_num_total_switches is never used so just remove it. gastrWIDs is also not used because g_num_total_switches is deleted. Remove gastrWIDs also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 127

Re: [PATCH v2 1/2] staging: wilc1000: remove unused enum

On 2015년 09월 12일 11:35, Greg KH wrote: On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote: From: Glen Lee This patch removes a unused enum tenuFrameClass. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 1 file changed

<    1   2   3   4   5   6   7   >