[PATCH 32/32] staging: wilc1000: fix kernel fail after ifconfig wlan0 up

2015-09-30 Thread Tony Cho
From: Leo Kim This patch fix kernel fail after ifconfig wlan0 up. - if normal operation, kfree functions don't execute. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_msgqueue.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-)

[PATCH 27/32] staging: wilc1000: rename strHostIfBASessionInfo

2015-09-30 Thread Tony Cho
This patch renames strHostIfBASessionInfo to session_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b

[PATCH 29/32] staging: wilc1000: rename strHostIfRegisterFrame

2015-09-30 Thread Tony Cho
This patch renames strHostIfRegisterFrame to reg_f to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers

[PATCH 28/32] staging: wilc1000: rename strHostIfRemainOnChan

2015-09-30 Thread Tony Cho
This patch renames strHostIfRemainOnChan to remain_on_ch to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 02/12] staging: wilc1000: remove function pointer wlan_start

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes function pointer wlan_start and just call the function wilc_wlan_start. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan.c| 3

[PATCH 07/12] staging: wilc1000: remove function pointer wlan_cleanup

2015-10-01 Thread Tony Cho
(nic) { wilc_wlan_cleanup(); } The define is unnecessary so just call wilc_wlan_cleanup instead of wilc_wlan_deinit() and remove the define also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 10 +++--- drivers/staging/wilc1000/wilc_wlan.c

[PATCH 03/12] staging: wilc1000: remove function pointer wlan_stop

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes function pointer wlan_stop and just call the function wilc_wlan_stop. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 10 ++ drivers/staging/wilc1000/wilc_wlan.c

[PATCH 05/12] staging: wilc1000: remove function pointer wlan_handle_tx_que

2015-10-01 Thread Tony Cho
return value. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.c| 3 +-- drivers/staging/wilc1000/wilc_wlan.h| 1 + drivers/staging/wilc1000/wilc_wlan_if.h | 1 - 4 files changed, 4 insertions(+), 5

[PATCH 06/12] staging: wilc1000: remove function pointer wlan_handle_rx_isr

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes function pointer wlan_handle_rx_isr and just call the function wilc_handle_isr. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 5 + drivers/staging/wilc1000/wilc_wlan.c| 1 - drivers/staging/wilc1000

[PATCH 04/12] staging: wilc1000: remove function pointer wlan_add_to_tx_que

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes function pointer wlan_add_to_tx_que and just call the function wilc_wlan_txq_add_net_pkt. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 7 +++ drivers/staging/wilc1000

[PATCH 01/12] staging: wilc1000: remove function pointer wlan_firmware_download

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes function pointer wlan_firmware_download and just call the function wilc_wlan_firmware_download. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 3 ++- drivers/staging

[PATCH 08/12] staging: wilc1000: delete define ACTION and PROBE_REQ

2015-10-01 Thread Tony Cho
From: Glen Lee The define ACTION and PROBE_REQ are duplicate. They are aleady defined in host_interface.h. Just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 12/12] staging: wilc1000: remove function pointer wlan_add_mgmt_to_tx_que

2015-10-01 Thread Tony Cho
also deleted. - deleted variables gpstrWlanOps oup - modified functions wilc1000_prepare_11b_core wilc_wlan_init Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 6 -- drivers/staging/wilc1000/linux_mon.c | 3 ++- drivers/st

[PATCH 11/12] staging: wilc1000: remove function pointer wlan_cfg_get_value

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes function pointer wlan_cfg_get_value and just call the function wilc_wlan_cfg_get_val. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 5 +++-- drivers/staging/wilc1000

[PATCH 10/12] staging: wilc1000: remove function pointer wlan_cfg_get

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes function pointer wlan_cfg_get and just call the function wilc_wlan_cfg_get. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 13 - drivers/staging/wilc1000

[PATCH 09/12] staging: wilc1000: remove function pointer wlan_cfg_set

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes function pointer wlan_cfg_set and just call the function wilc_wlan_cfg_set. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 14 +++-- drivers/staging/wilc1000

[PATCH 03/10] staging: wilc1000: wilc_wfi_netdevice.h: remove unused variables

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes unused variable already_claim and hWILCWFIDrv_2. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h b/drivers

[PATCH 02/10] staging: wilc1000: coreconfigurator.c: remove unused struct

2015-10-01 Thread Tony Cho
This patch removes unused structure, tstrconfigPktInfo from the coreconfigurator.c file. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000

[PATCH 01/10] staging: wilc1000: remove typedef from enum

2015-10-01 Thread Tony Cho
This patch removes typedef from enumerated types defined in coreconfigurator.c file and also changes their names to avoid CamelCase naming convention as shown: - tenuBasicFrmType to basic_frame_type - tenuFrmSubtype to sub_frame_type - tenuInfoElemID to info_element_id Signed-off-by: Tony Cho

[PATCH 04/10] staging: wilc1000: Delete undefined DEBUG_MODE and it's related codes

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes undefined DEBUG_MODE and it's related codes. We won't use this at the moment. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 63 --- 1 file changed, 63 deletions(-) di

[PATCH 06/10] staging: wilc1000: remove function pointer cfg_wid_get

2015-10-01 Thread Tony Cho
From: Glen Lee Remove function pointer cfg_wid_get and call the function wilc_wlan_cfg_get_wid instead. Remove static from the function declaration. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan.h

[PATCH 05/10] staging: wilc1000: remove function pointer cfg_wid_set

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes function pointer cfg_wid_set and call the function wilc_wlan_cfg_set_wid instead. Remove static from the function declaration. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan.c | 5 +++-- drivers/staging/wilc1000

[PATCH 07/10] staging: wilc1000: remove function pointer cfg_wid_get_val

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes cfg_wid_get_val and call the function wilc_wlan_cfg_get_wid_value. Remove static from the function declaration. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan.h | 1

[PATCH 08/10] staging: wilc1000: remove function pointer rx_indicate

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes function pointer rx_indicate and just call the function wilc_wlan_cfg_indicate_rx instead. Remove static from the function declration. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan.c | 2 +- drivers/staging

[PATCH 09/10] staging: wilc1000: remove function pointer cfg_init

2015-10-01 Thread Tony Cho
ff-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan.c | 3 +-- drivers/staging/wilc1000/wilc_wlan.h | 4 drivers/staging/wilc1000/wilc_wlan_cfg.c | 6 +- drivers/staging/wilc1000/wilc_wlan_cfg.h | 1 + 4 files changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/st

[PATCH 10/10] staging: wilc1000: remove unused variable real_ndev

2015-10-01 Thread Tony Cho
From: Glen Lee This patch removes unused variable real_ndev. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h b/drivers/staging/wilc1000

Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

2015-10-04 Thread Tony Cho
On 2015년 10월 04일 19:28, Chandra Gorentla wrote: On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote: On Sat, Oct 03, 2015 at 02:57:30PM +0530, Chandra S Gorentla wrote: - kfree is being called for the members of the queue without de-queuing them; they are just inserted within this f

Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section

2015-10-04 Thread Tony Cho
On 2015년 10월 04일 17:43, Greg KH wrote: On Sat, Oct 03, 2015 at 02:57:29PM +0530, Chandra S Gorentla wrote: The spin_lock_irqsave is moved to just beginning of critical section. This change moves a couple of return statements out of the lock. Signed-off-by: Chandra S Gorentla --- drivers/st

[PATCH V2 2/3] staging: wilc1000: rename pUserData

2015-10-04 Thread Tony Cho
This patch renames pUserData to data to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- V2: rename strHostIfRegisterFrame to reg_frame instead of reg_f because it is ambiguous --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH V2 3/3] staging: wilc1000: rename strHostIFDelAllSta

2015-10-04 Thread Tony Cho
This patch renames strHostIFDelAllSta to del_all_sta_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- V2: rename strHostIfRegisterFrame to reg_frame instead of reg_f because it is ambiguous --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3

[PATCH V2 1/3] staging: wilc1000: rename strHostIfRegisterFrame

2015-10-04 Thread Tony Cho
This patch renames strHostIfRegisterFrame to reg_frame to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- V2: rename strHostIfRegisterFrame to reg_frame instead of reg_f because it is ambiguous --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6

[PATCH 06/18] staging: wilc1000: remove typedef from tuniHostIFkeyAttr

2015-10-04 Thread Tony Cho
From: Leo Kim This patch remove typedef from the union tuniHostIFkeyAttr. And rename it to host_if_key_attr. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 01/18] staging: wilc1000: rename tWILCpfScanResult

2015-10-04 Thread Tony Cho
From: Leo Kim This patch renames tWILCpfScanResult to wilc_scan_result. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a

[PATCH 03/18] staging: wilc1000: rename tWILCpfConnectResult

2015-10-04 Thread Tony Cho
From: Leo Kim This patch renames tWILCpfConnectResult to wilc_connect_result. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff

[PATCH 05/18] staging: wilc1000: remove typedef from tenuKeyType

2015-10-04 Thread Tony Cho
From: Leo Kim This patch remove typedef from the enum tenuKeyType. And rename it to KEY_TYPE. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions

[PATCH 07/18] staging: wilc1000: remove typedef from tstrHostIFwepAttr

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrHostIFwepAttr. And rename it to host_if_wep_attr. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 02/18] staging: wilc1000: remove typedef from tstrHiddenNetwork

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrHiddenNetwork. And, rename it to hidden_network. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 8

[PATCH 04/18] staging: wilc1000: remove typedef from AUTHTYPE_T

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the enum AUTHTYPE_T. And, rename it to AUTHTYPE. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/host_interface.h | 6 +++--- drivers/staging

[PATCH 09/18] staging: wilc1000: remove typedef from tstrHostIFpmkidAttr

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrHostIFpmkidAttr. And rename it to host_if_pmkid_attr. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 6

[PATCH 10/18] staging: wilc1000: remove typedef from tstrHostIFpmkid

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrHostIFpmkid. And rename it to host_if_pmkid. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 6 +++--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 2 files changed

[PATCH 12/18] staging: wilc1000: remove typedef from SITE_SURVEY_T

2015-10-04 Thread Tony Cho
From: Leo Kim This patch remove typedef from the enum SITE_SURVEY_T. And rename it to SITESURVEY. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++-- 2 files changed, 3 insertions(+), 3

[PATCH 15/18] staging: wilc1000: rename tWILCpfRemainOnChanReady

2015-10-04 Thread Tony Cho
From: Leo Kim This patch renames tWILCpfRemainOnChanReady to wilc_remain_on_chan_ready. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions

[PATCH 11/18] staging: wilc1000: remove typedef from tstrCfgParamVal

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrCfgParamVal. And rename it to cfg_param_val. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 8 drivers

[PATCH 14/18] staging: wilc1000: rename tWILCpfRemainOnChanExpired

2015-10-04 Thread Tony Cho
From: Leo Kim This patch renames tWILCpfRemainOnChanExpired to wilc_remain_on_chan_expired. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions

[PATCH 08/18] staging: wilc1000: remove typedef from tstrHostIFwpaAttr

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrHostIFwpaAttr. And rename it to host_if_wpa_attr. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 16/18] staging: wilc1000: wilc_wfi_cfgoperations.c : remove unused functions

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes unused functions from the wilc_wfi_cfgoperations.c. - WILC_WFI_dump_survey - WILC_WFI_auth - WILC_WFI_assoc - WILC_WFI_deauth - WILC_WFI_disassoc - WILC_WFI_set_bitrate_mask Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000

[PATCH 13/18] staging: wilc1000: remove typedef from CURRENT_TX_RATE_T

2015-10-04 Thread Tony Cho
From: Leo Kim This patch remove typedef from the enum CURRENT_TX_RATE_T. And rename it to CURRENT_TXRATE. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed, 4 insertions

[PATCH 17/18] staging: wilc1000: remove unused functions

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes unused functions. - drivers/staging/wilc1000/linux_mon.c : WILC_WFI_mon_setup - drivers/staging/wilc1000/wilc_sdio.o : sdio_set_func0_csa_address_byte0 Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_mon.c | 26

[PATCH 18/18] staging: wilc1000: host_interface.c : remove unused functions

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes unused functions from the host_interface.c(h). - Switch_Log_Terminal - Handle_DelBASession - host_int_addBASession This patch includes the removal of the comment for host_int_addBASession as well. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers

[PATCH 6/6] staging: wilc1000: change parameter names in send_config_pkt

2015-10-05 Thread Tony Cho
This patch changes the parameter names in send_config_pkt function as the followings: - u8Mode to mode - pstrWIDs to wids - u32WIDsCount to count - drvHandler to drv Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 41 ++--- drivers/staging

[PATCH 5/6] staging: wilc1000: remove bool bRespRequired from send_config_pkt

2015-10-05 Thread Tony Cho
This patch removes 4th parameter, bool bRespRequired from the send_config_pkt function because it is not used inside the funcntion. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000

[PATCH 4/6] staging: wilc1000: wilc_wfi_cfgoperations.c : removes unused local variables

2015-10-05 Thread Tony Cho
: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 30 +++ 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index fb79612..42219ea 100644 --- a

[PATCH 2/6] staging: wilc1000: rename the member variable, drvHandler of host_if_msg

2015-10-05 Thread Tony Cho
From: Leo Kim This patch renames drvHandler of struct host_if_msg to drv. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 168 +++--- 1 file changed, 84 insertions(+), 84 deletions(-) diff --git a/drivers/staging

[PATCH 1/6] staging: wilc1000: remove typedef from tstrWILC_WFIDrv

2015-10-05 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrWILC_WFIDrv and rename it to host_if_drv. This patch includes the removal of the comment for tstrWILC_WFIDrv as well. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 362

[PATCH 3/6] staging: wilc1000: host_interface.c : removes unused local variables

2015-10-05 Thread Tony Cho
From: Leo Kim This patch removes unused local variables from host_interface.c. The unused local variable, s32Error is used just to return zero, so this patch calls "returns 0" instead of "return s32Error" after removing s32Error. Signed-off-by: Leo Kim Signed-off-by: To

[PATCH 02/10] staging: wilc1000: remove typedef from tenuWIDtype

2015-10-06 Thread Tony Cho
From: Leo Kim This patch remove typedef from the enum tenuWIDtype and rename it to WID_TYPE. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wlan_if.h

[PATCH 03/10] staging: wilc1000: rename the member variable, enuWIDtype of wid

2015-10-06 Thread Tony Cho
From: Leo Kim This patch renames enuWIDtype of struct wid to type. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/host_interface.c | 186 ++-- 2 files changed, 94 insertions(+), 94

[PATCH 05/10] staging: wilc1000: rename the member variable, s32ValueSize of wid

2015-10-06 Thread Tony Cho
From: Leo Kim This patch renames s32ValueSize of struct wid to size. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 6 +- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/host_interface.c | 210

[PATCH 01/10] staging: wilc1000: remove typedef from tstrWID

2015-10-06 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrWID and rename it to wid. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/coreconfigurator.h | 7 +-- drivers/staging/wilc1000/host_interface.c

[PATCH 04/10] staging: wilc1000: rename the member variable, u16WIDid of wid

2015-10-06 Thread Tony Cho
From: Leo Kim This patch renames u16WIDid of struct wid to id. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 +- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/host_interface.c | 188

[PATCH 09/10] staging: wilc1000: remove typedef from tstrJoinBssParam

2015-10-06 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrJoinBssParam and renames it to join_bss_param. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a

[PATCH 07/10] staging: wilc1000: remove unused struct tstrWidJoinReqExt

2015-10-06 Thread Tony Cho
From: Leo Kim This patch removes struct tstrWidJoinReqExt because it's not used. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/st

[PATCH 06/10] staging: wilc1000: rename the member variable, ps8WidVal of wid

2015-10-06 Thread Tony Cho
From: Leo Kim This patch renames ps8WidVal of struct wid to val. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 4 +- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/host_interface.c | 278

[PATCH 08/10] staging: wilc1000: remove unused struct tstrBssTable

2015-10-06 Thread Tony Cho
From: Leo Kim This patch removes struct tstrBssTable with related comment. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging

[PATCH 10/10] staging: wilc1000: remove _tstrJoinParam from join_bss_param

2015-10-06 Thread Tony Cho
From: Leo Kim This patch removes struct _tstrJoinParam from the struct join_bss_param because it is not used inside the struct. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging

Re: [PATCH 02/10] staging: wilc1000: remove typedef from tenuWIDtype

2015-10-06 Thread Tony Cho
On 2015년 10월 07일 00:14, Mike Rapoport wrote: On Tue, Oct 06, 2015 at 06:42:13PM +0900, Tony Cho wrote: From: Leo Kim This patch remove typedef from the enum tenuWIDtype and rename it to WID_TYPE. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000

[PATCH 03/14] staging: wilc1000: remove typedef from tenuHostIFstate

2015-10-07 Thread Tony Cho
From: Leo Kim This patch removes typedef from the enum tenuHostIFstate and rename it to host_if_state. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 01/14] staging: wilc1000: remove typedef from tstrWILC_UsrScanReq

2015-10-07 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrWILC_UsrScanReq with related comments and renames it to user_scan_req. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff

[PATCH 02/14] staging: wilc1000: remove typedef from tstrWILC_UsrConnReq

2015-10-07 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrWILC_UsrConnReq with the related comments and renames it to user_conn_req. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions

[PATCH 09/14] staging: wilc1000: remove typedef from tenuScanEvent

2015-10-07 Thread Tony Cho
From: Leo Kim This patch removes typedef from the enum tenuScanEvent and rename it to scan_event. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 15 +-- drivers

[PATCH 08/14] staging: wilc1000: remove typedef from tstrStatistics

2015-10-07 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrStatistics and rename it to statistics. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 7 +++ drivers/staging

[PATCH 04/14] staging: wilc1000: remove typedef from tstrFoundNetworkInfo

2015-10-07 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrFoundNetworkInfo and rename it to found_net_info. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 10/14] staging: wilc1000: rename typedef from tenuCfgParam

2015-10-07 Thread Tony Cho
From: Leo Kim This patch rename typedef from the enum tenuCfgParamand rename it to cfg_param. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 05/14] staging: wilc1000: remove typedef from tstrHiddenNetworkInfo

2015-10-07 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrHiddenNetworkInfo with related comments and renames it to hidden_net_info. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions

[PATCH 07/14] staging: wilc1000: remove unused struct cfg_param_t

2015-10-07 Thread Tony Cho
From: Leo Kim This patch removes unused the struct cfg_param_t. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wilc1000

[PATCH 06/14] staging: wilc1000: remove unused struct WILC_WFIDrvHandle

2015-10-07 Thread Tony Cho
From: Leo Kim This patch removes unused the struct WILC_WFIDrvHandle with related commnets. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.h b

[PATCH 11/14] staging: wilc1000: remove typedef from tenuConnDisconnEvent

2015-10-07 Thread Tony Cho
From: Leo Kim This patch removes typedef from the enum tenuConnDisconnEvent and renames it to conn_event. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 6 +++--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 2 files changed

[PATCH 12/14] staging: wilc1000: remove typedef from tenuScanConnTimer

2015-10-07 Thread Tony Cho
From: Leo Kim This patch removes typedef from the enum tenuScanConnTimer and renames it to scan_conn_timer. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 13/14] staging: wilc1000: host_infterface.h: remove unused enum tenuWILC_StaFlag

2015-10-07 Thread Tony Cho
This patch removes unused enum tenuWILC_StaFlag from the host_interface.h. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 20 1 file changed, 20 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wilc1000

[PATCH 14/14] staging: wilc1000: remove wilc_wlan.c included in wilc_wfi_cfgoperations.c

2015-10-07 Thread Tony Cho
This patch removes "wilc_wlan.c" from the wilc_wfi_cfgoperation.c file and adds wilc_wlan.o into Makefile to compile it because there is few benefits. This patch also adds "wilc_wfi_netdevice.h" in the wilc_wlan.c file to avoid the compile errors. Signed-off-by: Tony Cho

[PATCH 02/11] staging: wilc1000: rename pstrCfgParamVal in struct cfg_param_attr

2015-10-08 Thread Tony Cho
This patch renames a variable of struct cfg_param_val in struct cfg_param_attr, pstrCfgParamVal to cfg_attr_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 144 +++--- 1 file changed, 72 insertions(+), 72

[PATCH 03/11] staging: wilc1000: rename u32SetCfgFlag of struct cfg_param_val

2015-10-08 Thread Tony Cho
This patch renames u32SetCfgFlag of struct cfg_param_val to flag to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 36 +++ drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000

[PATCH 04/11] staging: wilc1000: rename strHostIFwepAttr of union host_if_key_attr

2015-10-08 Thread Tony Cho
This patch renames strHostIFwepAttr of union host_if_key_attr to wep to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 70 ++- 1 file changed, 31 insertions(+), 39 deletions(-) diff --git a/drivers/staging

[PATCH 01/11] staging: wilc1000: replace drvHandler and hWFIDrv with hif_drv

2015-10-08 Thread Tony Cho
leted while removing the local variable because it is not useful as well. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 1264 + 1 file changed, 573 insertions(+), 691 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/dr

[PATCH 05/11] staging: wilc1000: rename strHostIFwpaAttr of union host_if_key_attr

2015-10-08 Thread Tony Cho
This patch renames strHostIFwpaAttr of union host_if_key_attr to wpa to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 95 ++- 1 file changed, 44 insertions(+), 51 deletions(-) diff --git a/drivers/staging

[PATCH 09/11] staging: wilc1000: rename u8Wepidx of struct host_if_wep_attr

2015-10-08 Thread Tony Cho
This patch renames u8Wepidx of struct host_if_wep_attr to index to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 07/11] staging: wilc1000: rename pu8WepKey of struct host_if_wep_attr

2015-10-08 Thread Tony Cho
This patch renames pu8WepKey of struct host_if_wep_attr to key in order to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 08/11] staging: wilc1000: rename u8WepKeylen of struct host_if_wep_attr

2015-10-08 Thread Tony Cho
This patch renames u8WepKeylen of struct host_if_wep_attr to key_len to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 10/11] staging: wilc1000: rename u8mode of struct host_if_wep_attr

2015-10-08 Thread Tony Cho
This patch renames u8mode of struct host_if_wep_attr to mode to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers

[PATCH 11/11] staging: wilc1000: rename tenuAuth_type of struct host_if_wep_attr

2015-10-08 Thread Tony Cho
This patch renames tenuAuth_type of struct host_if_wep_attr to auth_type to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 06/11] staging: wilc1000: rename strHostIFpmkidAttr of union host_if_key_attr

2015-10-08 Thread Tony Cho
This patch renames strHostIFpmkidAttr of union host_if_key_attr to pmkid to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000

Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

2015-10-11 Thread Tony Cho
On 2015년 10월 09일 03:29, Stanislav Kholmanskikh wrote: Hi! I noticed that drivers/staging/wilc1000/Kconfic defines: config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY bool "Dynamically allocate memory in real time" ---help--- This choice supports dynamic allocation of the

Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

2015-10-11 Thread Tony Cho
On 2015년 10월 09일 03:47, Greg KH wrote: On Thu, Oct 08, 2015 at 09:29:35PM +0300, Stanislav Kholmanskikh wrote: Hi! I noticed that drivers/staging/wilc1000/Kconfic defines: config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY bool "Dynamically allocate memory in real time" ---help---

Re: [PATCH 08/14] staging: wilc1000: remove typedef from tstrStatistics

2015-10-11 Thread Tony Cho
Hi Dan, I will find much clearer naming rules when sending version 2 for them. Thanks for your opinion, Tony. On 2015년 10월 09일 17:16, Dan Carpenter wrote: I feel like the name 'statistics' is very vague. I guess it's so vague that it's unlikely anyone else will try use it... regards, dan c

[PATCH V2 01/41] staging: wilc1000: remove typedef from tstrWILC_WFIDrv

2015-10-12 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrWILC_WFIDrv and rename it to host_if_drv. This patch includes the removal of the comment for tstrWILC_WFIDrv as well. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 354

[PATCH V2 03/41] staging: wilc1000: host_interface.c : removes unused local variables

2015-10-12 Thread Tony Cho
From: Leo Kim This patch removes unused local variables from host_interface.c. The unused local variable, s32Error is used just to return zero, so this patch calls "returns 0" instead of "return s32Error" after removing s32Error. Signed-off-by: Leo Kim Signed-off-by: To

[PATCH V2 02/41] staging: wilc1000: rename the member variable, drvHandler of host_if_msg

2015-10-12 Thread Tony Cho
From: Leo Kim This patch renames drvHandler of struct host_if_msg to drv. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 168 +++--- 1 file changed, 84 insertions(+), 84 deletions(-) diff --git a/drivers/staging

[PATCH V2 08/41] staging: wilc1000: remove typedef from tenuWIDtype

2015-10-12 Thread Tony Cho
From: Leo Kim This patch remove typedef from the enum tenuWIDtype and rename it to WID_TYPE. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wlan_if.h

[PATCH V2 10/41] staging: wilc1000: rename the member variable, u16WIDid of wid

2015-10-12 Thread Tony Cho
From: Leo Kim This patch renames u16WIDid of struct wid to id. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 +- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/host_interface.c | 186

[PATCH V2 07/41] staging: wilc1000: remove typedef from tstrWID

2015-10-12 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrWID and rename it to wid. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/coreconfigurator.h | 7 +-- drivers/staging/wilc1000/host_interface.c

<    1   2   3   4   5   6   7   >