On Sat, Apr 29, 2017 at 10:58:44PM +0200, Janusz Lisiecki wrote:
> Replace CamelCase struct field names with underscores to comply
> with the standard kernel coding style.
> Changed:
> - FhParms_t
> - DsParms_t
> - CfParms_t
> - IbssParms_t
> - ErpParams_t
>
> Signed-off-by: Janusz Lisiecki
> ---
On Sat, Apr 29, 2017 at 10:58:40PM +0200, Janusz Lisiecki wrote:
> This patchset fix CamelCases in ks7010 driver except michael_mic
> which will be replaced by kernel implementation in the future.
Series looks good to me. For what its worth;
Reviewed-by: Tobin C. Harding
> Janusz Li
On Fri, Apr 28, 2017 at 05:26:17PM +0300, Dan Carpenter wrote:
> On Fri, Apr 28, 2017 at 04:19:28PM +0200, Ilia Sergachev wrote:
> > Checkpatch emits WARNING: Avoid line continuations in quoted strings.
> >
> > Remove line continuations - split strings using quotes.
> >
> > Signed-off-by: Ilia Se
On Fri, Apr 28, 2017 at 03:01:32PM +0200, Ilia Sergachev wrote:
> On Fri, 28 Apr 2017 14:20:21 +0200
> Greg Kroah-Hartman wrote:
>
> >
> > Nope, the whole thing still doesn't apply:
> >
> > checking file drivers/staging/ks7010/ks_wlan_net.c
> > Hunk #1 FAILED at 230.
> > Hunk #2 FAILED at 343.
be
here to fix it up :)
Reviewed-by: Tobin C. Harding
Good work Cezsary, apologies for the wish-washy replies. I'm learning
also ;)
Good luck,
Tobin.
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 10 ++
> drivers/staging/ks7010/ks_hostif.h | 4 ++--
> 2 files
On Mon, May 01, 2017 at 04:11:30PM +0200, gapalinux wrote:
> On Mon, 1 May 2017 19:59:44 +1000
> "Tobin C. Harding" wrote:
>
> > On Sat, Apr 29, 2017 at 07:54:30PM +0200, Cezary Gapinski wrote:
> > > Sparse spits out a warnings about __le16 and unsigned short
&g
On Tue, May 02, 2017 at 04:18:39PM +0200, Vincent Siles wrote:
> Removing empty line at the end of the file
Hi Vincent,
Small comment on your patch series. You may have more success if your
summary phrase is in imperative mood i.e sounds like you are
commanding changes to be made to the code base
is untested. Builds on x86_64 and PowerPC.
Tobin C. Harding (3):
staging: ks7010: eap, change unsigned short to __be16
staging: ks7010: hostif, u16 data types to __le16
staging: ks7010: hostif, u32 data types to __le32
drivers/staging/ks7010/eap_packet.h | 4 +-
drivers/staging/ks7010
Sparse emits warning: cast to restricted __be16. EAP header uses
network byte order. The structures used to describe it should use
__beXX data types.
Change data type unsigned short -> __be16.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/eap_packet.h | 4 ++--
1 file changed
data.
Change all u16 data types in host interface structures to be
__le16. Update all code that touches modified data types. Check using
Sparse.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 14 ++--
drivers/staging/ks7010/ks_hostif.h | 130
-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.h | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_hostif.h
index 35d51fe..45e3a01 100644
--- a/drivers/staging/ks7010
On Tue, May 23, 2017 at 06:37:39PM +0530, Richa Jha wrote:
> Replace CamelCase variable names with underscores and remove
> hungarian prefixes to comply with the standard kernel coding style
Hi Richa,
Nice work. You may like to do all the camel case at the same
time. You could limit yourself to
On Wed, May 24, 2017 at 04:40:32PM +1200, Derek Robson wrote:
> Fixed block comment alignment, Style fix only
> Found using checkpatch
It's 'one thing per patch', this whole set does one thing. You may
like to submit it as a single patch. You won't need the file name in
the commit summary then als
On Wed, May 24, 2017 at 01:24:14PM +0530, Richa Jha wrote:
[snip]
Nice work so far. I'm having trouble with your patches. Here are a few
nitpicks to help you on your way.
There are 4 emails in the last few days with similar subjects but they
are not linked together. Also your email subject does n
On Wed, May 24, 2017 at 10:38:57PM +0800, Jamie Huang wrote:
Comment on your patch subject line. Patches to staging typically
include the driver in the subject. You can view previous commits to
get an idea using
$ git log --pretty=oneline drivers/staging/rtl8723bs/core/rtw_security.c
And from Do
On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote:
This driver is not in Greg KH's staging tree. You may like to work off
of that tree when doing staging patches.
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
To aid you future patches here are a couple of minor
Hi Wolfram,
I began testing the card you sent today. I'm getting a firmware load
error like you mentioned.
I checked out code from when you originally merged into staging,
however I built the module in a 4.9 kernel.
To help me track down the issue could you please tell me what testing
you manage
On Thu, May 25, 2017 at 12:22:15PM +0300, Aliza Minkov wrote:
> Signed-off-by: Aliza Minkov
> ---
> drivers/staging/dgnc/dgnc_driver.c | 2 --
> 1 file changed, 2 deletions(-)
Hi Aliza,
Well done getting your patch together. I think you might get an
automated message from Greg's patch robot so
On Tue, May 30, 2017 at 08:49:41AM +0200, Antoine Tenart wrote:
> Hello Derek,
>
> On Tue, May 30, 2017 at 06:09:37PM +1200, Derek Robson wrote:
> > Fixed block comments across whole ccree driver
>
> Since all these commits are doing the same logical change across a
> single driver, you could pro
for taking the time to read this and thank you in advance
for any time that you spend on this RFC. All feedback very much
appreciated.
Regards,
Tobin.
Tobin C. Harding (3):
staging: ks7010: move WEXT files to sub directory
staging: ks7010: Add cfg80211 files
MAINTAINERS: add maintainer e
Driver ks7010 does not currently have a maintainer.
Add maintainers entry for ks7010.
Signed-off-by: Tobin C. Harding
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9e98464..75250ee 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
for most of the rest of the driver at
the same time.
Add cfg80211 driver skeleton. Implement FIL.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/Makefile|6 +
drivers/staging/ks7010/README.rst | 73 ++
drivers/staging/ks7010/TODO.rst| 17 +
drivers/staging/ks7010
On Thu, Jun 01, 2017 at 12:45:37PM +0900, Greg KH wrote:
> On Thu, Jun 01, 2017 at 01:27:06PM +1000, Tobin C. Harding wrote:
> > Current driver implements the WEXT interface. WEXT is in maintenance
> > mode, we need to re-write the driver using cfg80211. The current
> >
On Thu, Jun 01, 2017 at 12:46:30PM +0900, Greg KH wrote:
> On Thu, Jun 01, 2017 at 01:27:08PM +1000, Tobin C. Harding wrote:
> > Driver ks7010 does not currently have a maintainer.
> >
> > Add maintainers entry for ks7010.
> >
> > Signed-off-by: Tobin C. Hard
Hi,
I am attempting to test the ks7010 SIDO Wi-Fi driver (drivers/staging/ks7010/).
Currently probing the driver fails because of a firmware upload error.
I am seeking ideas on where to continue troubleshooting this issue.
Test setup:
- Spectec SDW-823 WIFI card (micro SD).
- Raspberry Pi B 1 (
On Mon, Jun 05, 2017 at 09:22:12AM +0200, Wolfram Sang wrote:
> Tobin,
>
> > My question is should I be digging further into the MMC code or be doing
> > something else with the driver code?
>
> So, you haven't found any branch that worked? No plain v4.9 or the
> gen3-sdio branch from my tree?
I
On Mon, Jun 05, 2017 at 08:07:40PM -0400, Brian Masney wrote:
> On Mon, Jun 05, 2017 at 08:24:44PM +1000, Tobin C. Harding wrote:
> > On Mon, Jun 05, 2017 at 09:22:12AM +0200, Wolfram Sang wrote:
> > > Tobin,
> > >
> > > > My question is should I be diggin
in variables
> that do not have a specified endianness.
>
> Signed-off-by: Perry Hooker
For what it's worth
Reviewed-By: Tobin C. Harding
> ---
> drivers/staging/ks7010/ks_hostif.c | 24 +---
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
Driver ks7010 does not currently have a maintainer.
Take ownership of the driver and add an entry for the ks7010 driver to
the maintainers database.
Signed-off-by: Tobin C. Harding
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Kconfig so
build completes successfully but does not process any files from the
WEXT directory.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/Kconfig| 6 +-
drivers/staging/ks7010/Makefile | 5 +
drivers/staging/ks7010/{ => wext}/T
WEXT code has been moved to a sub directory and is no longer included
in the module build. We should make a note of this for future
developers.
Add note to WEXT code TODO file informing developers that code is not
included in module build.
Signed-off-by: Tobin C. Harding
---
drivers/staging
03 adds the new cfg80211 driver code.
Patch 04 adds an entry to the MAINTAINERS database.
Code is untested. Builds on x86_64 and PowerPC. Code is clear of any
warnings from checkpatch.pl, Sparse, and Spatch (kchecker).
Tobin C. Harding (4):
staging: ks7010: move WEXT files to sub directory
On Wed, Jun 14, 2017 at 12:22:31PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 14, 2017 at 04:30:35PM +1000, Tobin C. Harding wrote:
> > Current driver implements the WEXT interface. WEXT is in maintenance
> > mode, we need to re-write the driver using the cfg80211 API. The cur
On Wed, Jun 14, 2017 at 12:24:21PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 14, 2017 at 04:30:37PM +1000, Tobin C. Harding wrote:
> > Currently we are in the process of replacing the WEXT interface with
> > the cfg80211 API. WEXT code is currently within a sub directory and
&
On Thu, Jun 15, 2017 at 09:59:06AM +1000, Tobin C. Harding wrote:
> On Wed, Jun 14, 2017 at 12:24:21PM +0200, Greg Kroah-Hartman wrote:
> > On Wed, Jun 14, 2017 at 04:30:37PM +1000, Tobin C. Harding wrote:
> > > Currently we are in the process of replacing the WEXT interf
On Mon, Jun 19, 2017 at 03:28:19PM +, Kershner, David A wrote:
>
> > -Original Message-
> > From: Derek Robson [mailto:robso...@gmail.com]
> > Sent: Friday, June 16, 2017 11:13 PM
> > To: Kershner, David A ;
> > gre...@linuxfoundation.org; Sell, Timothy C ;
> > Binder, David Anthony ;
drivers/staging/android/ion/ion.c checkpatch produces alignment checks.
This patch is whitespace only and fixes these checks.
Signed-off-by: Tobin C Harding
---
drivers/staging/android/ion/ion.c | 64 +++
1 file changed, 32 insertions(+), 32 deletions
drivers/staging/android/ion/ion.c checkpatch produces
'Comparison to NULL could be written ...' checks.
This patch replaces comparison to NULL with !var as suggested by checkpatch.
Signed-off-by: Tobin C Harding
---
drivers/staging/android/ion/ion.c | 6 +++---
1 file changed, 3
drivers/staging/android/ion/ion.c checkpatch produces line over 80
character warnings.
This patch is whitespace only and fixes these warnings.
Signed-off-by: Tobin C Harding
---
drivers/staging/android/ion/ion.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers
drivers/staging/android/ion/ion.c produces 2 warnings and 29 checks.
This patch set fixes both warnings and all but 4 of the checks. All
except the last patch are trivial.
Signed-off-by: Tobin C Harding
---
Patch 1/4 is whitespace only.
This is my first Linux kernel patch.
thanks
Tobin C
drivers/staging/android/ion/ion.c calls BUG_ON in places where WARN_ON will
suffice.
This patch replaces two such occurences. Two other occurences remain.
Signed-off-by: Tobin C Harding
---
Changing the remaining two BUG_ON's causes changes to the programm logic.
This is my first patch s
kzalloc call followed by copy_to_user can be replaced by call to memdup_user.
Signed-off-by: Tobin C Harding
---
drivers/gpu/drm/gma500/gma_display.c | 2 +-
drivers/staging/lustre/lustre/llite/dir.c | 22 +++---
2 files changed, 8 insertions(+), 16 deletions(-)
diff
kzalloc call followed by copy_to_user can be replaced by call to memdup_user.
Signed-off-by: Tobin C Harding
---
drivers/gpu/drm/gma500/gma_display.c | 2 +-
drivers/staging/lustre/lustre/llite/dir.c | 22 +++---
2 files changed, 8 insertions(+), 16 deletions(-)
diff
kzalloc call followed by copy_to_user can be replaced by call to memdup_user.
Signed-off-by: Tobin C Harding
---
drivers/staging/lustre/lustre/llite/dir.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/dir.c
b/drivers
A number of function definitions were found to be candidates for
static scoping. This patch adds static to these functions.
Signed-off-by: Tobin C Harding
---
drivers/staging/lustre/lustre/llite/vvp_dev.c | 8
drivers/staging/lustre/lustre/llite/vvp_io.c | 6
On Wed, Jun 14, 2017 at 04:30:34PM +1000, Tobin C. Harding wrote:
[snip]
Please drop this series.
thanks,
Tobin.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Checkpatch emits multiple warnings of type
CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
Fix parenthesis alignment in line with checkpatch suggestion.
---
drivers/staging/rtlwifi/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/stagi
Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the
driver. Both functions call rtl_addr_delay(), this function is unused
outside of these call sites.The driver (and kernel) code base is cleaner
if unused functions are removed.
Remove unused functions.
---
drivers/staging/rtlwifi
checkpatch emits multiple warnings of type
WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply
Replace two calls to kzalloc() with calls to kcalloc().
---
drivers/staging/rtlwifi/efuse.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/r
.
Tobin C. Harding (3):
staging: rtlwifi: fix parenthesis alignment
staging: rtlwifi: use kcalloc instead of multiply
staging: rtlwifi: remove unused functions
drivers/staging/rtlwifi/core.c | 43 +++--
drivers/staging/rtlwifi/core.h | 4
drivers
On Tue, Sep 05, 2017 at 09:46:55AM -0500, Larry Finger wrote:
> On 09/05/2017 01:53 AM, Tobin C. Harding wrote:
> >Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the
> >driver. Both functions call rtl_addr_delay(), this function is unused
> >outside of these
On Wed, Jan 10, 2018 at 06:30:35PM +0100, Jonny Schaefer wrote:
> From: Luis Gerhorst
>
> This fixes the checkpatch message:
>
> CHECK: Alignment should match open parenthesis
> #1380: FILE: drivers/staging/fbtft/fbtft-core.c:1380:
> + dev_warn(dev,
> + "n
On Wed, Feb 28, 2018 at 09:19:07PM -0800, Quytelda Kahja wrote:
> The case statement in get_ap_information() should not use literal integers
> to parse information element IDs when these values are provided by name
> in 'enum ieee80211_eid' in the header 'linux/ieee80211.h'.
Nice. Magic number re
On Wed, Feb 28, 2018 at 09:19:07PM -0800, Quytelda Kahja wrote:
...
I would normally respond to the cover letter but here goes.
Reviewed-by: Tobin C. Harding
thanks,
Tobin.
___
devel mailing list
de...@linuxdriverproject.org
http
On Wed, Feb 28, 2018 at 09:19:09PM -0800, Quytelda Kahja wrote:
> The code that generates a WLAN capability mask is repeated in five
> functions. This change refactors that code into a new function, which is
> called now in each of those functions.
Perhaps in future something like:
Code to gener
On Thu, Mar 01, 2018 at 02:15:00PM +0300, Dan Carpenter wrote:
> On Thu, Mar 01, 2018 at 05:37:21PM +1100, Tobin C. Harding wrote:
> > On Wed, Feb 28, 2018 at 09:19:09PM -0800, Quytelda Kahja wrote:
> > > The code that generates a WLAN capability mask is repeated in five
>
On Thu, Mar 01, 2018 at 05:28:26PM -0800, Quytelda Kahja wrote:
> Tobin,
> I understand your point, and I've read submitting-patches.rst. I made
> that wording choice because I was looking at some older commits that
> were worded like that. I'm fairly new to the kernel workflow, so I
> was just t
On Fri, Mar 02, 2018 at 12:05:03PM +0300, Dan Carpenter wrote:
> There are so many rules for kernel developers to deal with. Is it worse
> to go over the 80 character limit or align the parameters properly? Is
> it OK to start the subject with a lower case letter? I get in trouble
> for using th
On Tue, Mar 06, 2018 at 09:46:08PM -0800, Kees Cook wrote:
> The kernel would like to remove all VLA usage. This switches to a
> simple kasprintf() instead.
>
> Signed-off-by: Kees Cook
> ---
> drivers/staging/lustre/lustre/llite/xattr.c | 19 +--
> 1 file changed, 13 insertions(
The kernel would like to have all stack VLA usage removed[1]. The
arrays are fixed here (declared with a const variable) but they appear
like VLAs to the compiler. We can use a pre-processor define to fix the
warning.
[1]: https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Tobin C. Harding
On Thu, Mar 08, 2018 at 10:01:07PM -0800, Joe Perches wrote:
> On Fri, 2018-03-09 at 16:50 +1100, Tobin C. Harding wrote:
> > The kernel would like to have all stack VLA usage removed[1]. The
> > arrays are fixed here (declared with a const variable) but they appear
> > like
The kernel would like to have all stack VLA usage removed[1]. The
array here is fixed (declared with a const variable) but it appears
like VLA to the compiler. We can use a pre-processor define to quiet
the compiler.
[1]: https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Tobin C. Harding
On Fri, Mar 09, 2018 at 12:16:21AM -0600, Gustavo A. R. Silva wrote:
>
> I sent a patch for this six hours ago:
>
> https://patchwork.kernel.org/patch/10268591/
>
> --
> Gustavo
lol, I knew there would be a race on to fix these :) And you got it
right, bonus points. Let's drop this one then.
, let's just allocate the memory instead of using the
stack. This saves stack space and removes the VLA build warning.
kmalloc a buffer for dumping state instead of using the stack.
[1]: https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Tobin C. Harding
---
v1 of this patch already merged
On Mon, Mar 12, 2018 at 12:37:53PM +1100, Tobin C. Harding wrote:
> The kernel would like to have all stack VLA usage removed[1]. The array
> here is fixed (declared with a const variable) but it appears like a VLA
> to the compiler. Also, currently we are putting 768 bytes on the
>
On Mon, Mar 12, 2018 at 06:58:04AM +0100, Stefan Wahren wrote:
> Hi Tobin,
>
> > "Tobin C. Harding" hat am 12. März 2018 um 06:46
> > geschrieben:
> >
> >
> > On Mon, Mar 12, 2018 at 12:37:53PM +1100, Tobin C. Harding wrote:
> > > The
501 - 566 of 566 matches
Mail list logo
