[PATCH 0/2] staging: wlan-ng: fix coding style issues in hfa384x_usb.c

Fix two checkpatch issues in hfa384x_usb.c. One warning for a line over 80 characters remains (due to a long macro name). Tim Collier (2): staging: wlan-ng: add missing parameter name to prototype staging: wlan-ng: fix line-break style issue drivers/staging/wlan-ng/hfa384x_usb.c | 5

[PATCH] staging: wlan-ng: fix SPDX comment style in headers

Several of the wlan-ng header files had C++-style SPDX comments. Fixed checkpatch warnings by replacing with C-style comments, as per the kernel docs. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x.h | 2 +- drivers/staging/wlan-ng/p80211conv.h | 2 +- drivers

[PATCH] staging: wlan-ng: fix block comment alignment in p80211metastruct.h

Fix checkpatch warning for misaligned * characters in the block comment at the start of p80211metastruct.h; with this change the file is checkpatch clean. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metastruct.h | 88 +++--- 1 file changed, 44 insertions

[PATCH] staging: wlan-ng: fix coding style issues in p80211netdev.h

Fix two issues with parameters not aligned to opening parenthesis, as reported by checkpatch. File is now clean for checkpatch. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211netdev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng

[PATCH] staging: wlan-ng: fix coding style issues in p80211netdev.h

Fix two issues with parameters not aligned to opening parenthesis, as reported by checkpatch. File is now clean for checkpatch. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211netdev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng

[PATCH] staging: wlan-ng: fix coding style issues in p80211netdev.c

Fix 2 "Alignment should match open parenthesis" messages issued by checkpatch. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/stagi

Re: [PATCH] staging: wlan-ng: fix coding style issues in p80211netdev.h

Sorry. This is a duplicate of the previous path for p80211netdev.h, sent in error. Please ignore. On Wed, May 16, 2018 at 08:48:54AM +0100, Tim Collier wrote: > Fix two issues with parameters not aligned to opening parenthesis, as > reported by checkpatch. File is now clean for chec

[PATCH 1/2] staging: wlan-ng: convert P80211SKB_FRMMETA to inline function in p80211conv

the new function. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211conv.c | 4 ++-- drivers/staging/wlan-ng/p80211conv.h | 15 --- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c

[PATCH 0/2] staging: wlan-ng: fix coding style issues in p80211conv.h

Replace two macros defined in p80211conv.h with equivalent inline functions to avoid potential issues with repeated use of macro arguments as reported by checkpatch. With these changes, which must be applied in order, p80211conv.h is checkpatch clean. Tim Collier (2): staging: wlan-ng: convert

[PATCH 2/2] staging: wlan-ng: convert P80211SKB_RXMETA to inline function in p80211conv

the new function. This change depends on the similar change for P80211SKB_FRMMETA having been applied. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- drivers/staging/wlan-ng/p80211conv.c | 4 ++-- drivers/staging/wlan-ng/p80211conv.h | 11 +++ 3 files

[PATCH] staging: wlan-ng: remove unused declarations from p80211types.h

After this change, checkpatch reports that p80211types.h has no obvious issues. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211types.h | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/stagi

[PATCH 0/4] staging: wlan-ng: coding style changes

Changes to fix issues reported by checkpatch. Tim Collier (4): staging: wlan-ng: fix coding style (indentation) in prism2mib.c staging: wlan-ng: replace WLAN_CTL_FRAMELEN with inline function in p80211hdr.h staging: wlan-ng: replace macro with inline function in prism2mgmt.c staging

[PATCH 4/4] staging: wlan-ng: add parentheses to macro argument usage in prism2mgmt.c

Fix two "CHECK: Macro argument 'N' may be better as '(N)' to avoid precedence issue" messages, reported by checkpatch, by adding parentheses around the offending macro argument references. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/prism2mgmt.c | 4 ++--

[PATCH 3/4] staging: wlan-ng: replace macro with inline function in prism2mgmt.c

checkpatch gives the following message for the p80211rate_to_p2bit macro: CHECK: Macro argument reuse 'n' - possible side-effects? To fix the message, replace the macro with an equivalent inline function. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/prism2m

[PATCH 2/4] staging: wlan-ng: replace WLAN_CTL_FRAMELEN with inline function in p80211hdr.h

so updated accordingly. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211hdr.h | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211hdr.h b/drivers/staging/wlan-ng/p80211hdr.h index 26b178721414..6564810fd

[PATCH 1/4] staging: wlan-ng: fix coding style (indentation) in prism2mib.c

Fix "CHECK: Alignment should match open parenthesis" reported by checkpatch.pl. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/prism2mib.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/stagi

<    1   2