Dan Carpenter
Tim Collier (62):
staging: wlan-ng: rename DIDmsg_dot11req_mibget in p80211metadef.h
staging: wlan-ng: rename DIDmsg_dot11req_mibget_mibattribute in
p80211metadef.h
staging: wlan-ng: rename DIDmsg_dot11req_mibget_resultcode in
p80211metadef.h
staging: wlan-ng: re
Rename DIDmsg_dot11req_mibset_mibattribute in p80211metadef.h to
DIDMSG_DOT11REQ_MIBSET_MIBATTRIBUTE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/st
Rename DIDmsg_lnxreq_wlansniff in p80211metadef.h to
DIDMSG_LNXREQ_WLANSNIFF to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2sta
Rename DIDmsg_p2req_ramdl_state to DIDMSG_P2REQ_RAMDL_STATE in
p80211metadef.h to fix "Avoid CamelCase" message from checkpatch and
conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2fw.
Rename DIDmsg_p2req_readpda_resultcode in p80211metadef.h to
DIDMSG_P2REQ_READPDA_RESULTCODE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/stagi
Rename DIDmsg_p2req_readpda in p80211metadef.h to DIDMSG_P2REQ_READPDA
to fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2fw.
Rename DIDmsg_dot11req_mibget_mibattribute in p80211metadef.h to
DIDMSG_DOT11REQ_MIBGET_MIBATTRIBUTE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/st
Rename DIDmsg_lnxreq_hostwep in p80211metadef.h to
DIDMSG_LNXREQ_HOSTWEP to fix "Avoid CamelCase" message from checkpatch
and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/p80211req
Rename DIDmsg_dot11req_mibget in p80211metadef.h to
DIDMSG_DOT11REQ_MIBGET to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 2 +-
drivers/staging/wlan-ng/p80211met
Rename DIDmsg_lnxreq_autojoin in p80211metadef.h to
DIDMSG_LNXREQ_AUTOJOIN to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 4 ++--
drivers/staging/wlan-ng/p80211met
Rename DIDmsg_dot11ind_authenticate in p80211metadef.h to
DIDMSG_DOT11IND_AUTHENTICATE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
1 file changed, 1 inser
Rename DIDmsg_dot11req_mibget_resultcode in p80211metadef.h to
DIDMSG_DOT11REQ_MIBGET_RESULTCODE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/stagi
Rename DIDmsg_p2req_ramdl_write_addr in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_WRITE_ADDR to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/
Rename DIDmsg_dot11req_mibset in p80211metadef.h to
DIDMSG_DOT11REQ_MIBSET to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 4 ++--
drivers/staging/wlan-ng/p80211met
Rename DIDmsg_p2req_ramdl_write in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_WRITE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2fw.
Rename DIDmsg_dot11req_start in p80211metadef.h to
DIDMSG_DOT11REQ_START to fix "Avoid CamelCase" message from checkpatch
and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2sta.c
Rename DIDmsg_dot11req_scan_results in p80211metadef.h to
DIDMSG_DOT11REQ_SCAN_RESULTS to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 2 +-
drivers/stagi
Rename DIDmsg_dot11req_scan in p80211metadef.h to DIDMSG_DOT11REQ_SCAN
to fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 2 +-
drivers/staging/wlan-ng/p80211met
Rename DIDmsg_lnxreq_ifstate in p80211metadef.h to
DIDMSG_LNXREQ_IFSTATE to fix "Avoid CamelCase" message from checkpatch
and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/p80211req
Rename DIDmsg_lnxreq_commsquality in p80211metadef.h to
DIDMSG_LNXREQ_COMMSQUALITY to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 2 +-
drivers/staging/wlan-ng/p8021
Rename DIDmsg_dot11req_mibset_resultcode in p80211metadef.h to
DIDMSG_DOT11REQ_MIBSET_RESULTCODE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/stagi
Rename DIDmsg_p2req_readpda_pda in p80211metadef.h to
DIDMSG_P2REQ_READPDA_PDA to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2fw.
Rename DIDmsg_p2req_ramdl_state_exeaddr in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_STATE_EXEADDR to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/stagi
Rename DIDmsg_dot11ind_associate in p80211metadef.h to
DIDMSG_DOT11IND_ASSOCIATE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
1 file changed, 1 insertion(+),
Rename DIDmib_dot11smt_dot11PrivacyTable to
DIDMIB_DOT11SMT_PRIVACYTABLE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines. Also shorten
name by removing repeated use of "DOT11" to ease readability and
reduce long lines.
Signed
Rename DIDmsg_p2req_ramdl_state_resultcode in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_STATE_RESULTCODE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/st
Rename DIDmsg_p2req_ramdl_state_enable in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_STATE_ENABLE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/stagi
Rename DIDmsg_p2req_ramdl_write_data in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_WRITE_DATA to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/
Rename DIDmsg_p2req_ramdl_write_resultcode in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_WRITE_RESULTCODE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/st
lity and reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 6 +++---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/p80211req.c | 8
drivers/staging/wlan-ng/prism2mib.c | 8
4 files changed, 12 inserti
Rename DIDmsg_p2req_ramdl_write_len to DIDMSG_P2REQ_RAMDL_WRITE_LEN to
fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2fw.c | 2 +
nd reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211metadef.h
b/drivers/staging/wlan-ng/p80211metadef.h
index bcc44621664a..a74af59737ce 100644
--- a/dri
nd reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 4 ++--
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/p80211req.c | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
Rename DIDmsg_p2req_flashdl_state in p80211metadef.h to
DIDMSG_P2REQ_FLASHDL_STATE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/p
quot;DOT11" and "DOT11PHY" to ease readability and reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 4 ++--
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 2 +-
3 files changed, 4 insertions(+), 4 dele
"DOT11" to
ease readability and reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211metadef.h
b/dri
Rename DIDmib_cat_dot11smt in p80211metadef.h to DIDMIB_CAT_DOT11SMT
to fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
1 file changed, 1 insertion(+), 1 deletio
g lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/p80211metadef.h
b/drivers/staging/wlan-ng/p80211metadef.h
index a386b6cb15bc..79f6813cd9d6 100644
--- a/drivers/staging/wla
Rename DIDmib_p2_p2NIC_p2PRISupRange in p80211metadef.h to
DIDMIB_P2_NIC_PRISUPRANGE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines. Also shorten
name by removing repeated use of "P2" to ease readability and reduce
long lines.
ines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211metadef.h
b/drivers/staging/wlan-ng/p80211metadef.h
index d04e78
Rename DIDmib_cat_lnx in p80211metadef.h to DIDMIB_CAT_LNX to fix
"Avoid CamelCase" message from checkpatch and conform to the coding
style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
Rename DIDmsg_p2req_flashdl_write in p80211metadef.h to
DIDMSG_P2REQ_FLASHDL_WRITE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/p
Rename DIDmib_cat_dot11phy in p80211metadef.h to DIDMIB_CAT_DOT11PHY
to fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Rename DIDmib_p2_p2MAC_p2CurrentTxRate in p80211metadef.h to
DIDMIB_P2_MAC_CURRENTTXRATE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines. Also shorten
name by removing repeated use of "P2" to ease readability and reduce
long lines.
to ease readability and reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211metadef.h
b/drivers/staging/wla
;DOT11" to ease readability and reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211metadef.h
b/drivers/staging/wla
Rename DIDmib_p2_p2Static_p2CnfPortType in p80211metadef.h to
DIDMIB_P2_STATIC_CNFPORTTYPE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines. Also shorten
name by removing repeated use of "P2" to ease readability and reduce
long lines.
nd
reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/p80211metadef.h
b/drivers/staging/wlan-ng/p80211metadef.h
index 9e865f82cf98..53f380f2f66f 100644
--- a/dri
p80211metadef.h and p80211metastruct.h both have comments stating they
are autogenerated and should not be edited. However, neither is
generated during build and both have had numerous manual edits since
the driver has been in staging.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng
ines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/p80211metadef.h
b/drivers/staging/wlan-ng/p80211metadef.h
index 5d06b342b980..dae733524342 100644
--- a/drivers/staging/wlan-ng/p
ease readability and reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 2 +-
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/w
Rename DIDmib_cat_p2 in p80211metadef.h to DIDMIB_CAT_P2 to fix "Avoid
CamelCase" message from checkpatch and conform to the coding style
guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
Rename DIDmib_lnx_lnxConfigTable in p80211metadef.h to
DIDMIB_LNX_CONFIGTABLE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines. Also shorten
name by removing repeated use of "LNX" to ease readability and
reduce long lines.
Signed
;DOT11" to ease readability and reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 4 ++--
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/p80211req.c | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 2 +-
4 files changed, 5 insert
"DOT11" to
ease readability and reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 2 +-
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/
d "DOT11PHY" to ease readability and reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 2 +-
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff -
ease readability and reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/p80211netdev.c | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-n
Combine previously split lines for an assignment; now fits in 80
characters as the name of the macro being assigned was shortened.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng
to ease readability and reduce long lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 6 +++---
drivers/staging/wlan-ng/p80211metadef.h | 2 +-
drivers/staging/wlan-ng/p80211req.c | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 2 +-
4 files changed, 6 insert
Rename DIDmib_p2_p2Static in p80211metadef.h to DIDMIB_P2_STATIC to
fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines. Also shorten name by removing repeated use of
"P2" to ease readability and reduce long lines.
Signed-off-by: Tim C
Rename DIDmib_p2_p2MAC in p80211metadef.h to DIDMIB_P2_MAC to fix
"Avoid CamelCase" message from checkpatch and conform to the coding
style guidelines. Also shorten name by removing repeated use of "P2"
to ease readability and reduce long lines.
Signed-off-by: Tim Collier
For switch statements with case blocks make the format consistent by
applying K&R formatting, a space before the opening brace, single
indentation of contained code, break inside the block and closing
brace aligned with case.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x_u
The reformatting of case blocks has shortened some lines such that
previously split lines can be rejoined without exceeding 80
characters. Rejoined those lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x_usb.c | 6 ++
drivers/staging/wlan-ng/prism2sta.c | 17
Formatting changes to resolve 80 character limit warnings reported by
checkpatch.
Tim Collier (3):
staging: wlan-ng: formatting change in cfg80211.c
staging: wlan-ng: reformatting in hfa384x.h to fit 80 character limit
staging: wlan-ng: reformatting in prism2mib.c to fit 80 character
Reformat lines over 80 characters in hfa384x.h to resolve "line over
80 characters" warnings reported by checkpatch.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x.h | 26 ++
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/drive
Reformat lines over 80 characters in prism2mib.c to resolve "line over
80 characters" warnings reported by checkpatch.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/prism2mib.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git
Resolve "line over 80 characters" warning reported by checkpatch by
splitting function header over 2 lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c
Remove the unused crcend variable from the crcimage function.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/prism2fw.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c
b/drivers/staging/wlan-ng/prism2fw.c
index a2c851c74bef..bb572b7fdfee 100644
usb_get_intfdata returns a void pointer. It is not necessary to
explicitly cast to the desired type and removing the casts is
consistent with most use of usb_get_intfdata.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/prism2usb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
Fix compilation errors (remove references to 2 undefined fields in the
URB struct) when DEBUG_USB is defined for the wlan-ng driver.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x_usb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b
Remove unnecessary casts from void* to structure pointer.
Fix compilation with DEBUG_USB macro defined.
Remove unused field from usb ctlx structure.
Formatting changes suggested by checkpatch.
Tim Collier (5):
staging: wlan-ng: remove unnecessary casts from prism2usb.c
staging: wlan-ng
Realign parameter in function declaration to fix checkpatch.pl warning
that parameter needed to be aligned with the opening parenthesis of
the declaration.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
The variant field in struct hfa384x_usbctlx is not referenced anywhere
in the driver, so remove it.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wlan-ng/hfa384x.h
index
Shorten several lines reported as over 80 characters by checkpatch.pl.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x.h | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wlan-ng/hfa384x.h
his change moves the retrieval to just before the point where the URB
is reposted so that the correct transfer buffer is retrieved and
initialization of the device succeeds.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Fix issues reported by checkpatch regarding the correct point to split
lines for coninuation and unnecessary parentheses.
Tim Collier (3):
staging: wlan-ng: fix expression continuation in prism2fw.c
staging: wlan-ng: fix expression continuation in prism2mgmt.c
staging: wlan-ng: remove
checkpatch reports "CHECK: Logical continuations should be on the
previous line" when a continuation line begins with an
operator. Reformat the code so that the operator appears at the end of
the line being continued.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/pris
checkpatch reports "CHECK: Logical continuations should be on the
previous line" when a continuation line begins with an
operator. Reformat the code so that the operator appears at the end of
the line being continued.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/prism2m
remove parentheses reported as unnecessary by checkpatch
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/prism2mgmt.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c
b/drivers/staging/wlan-ng/prism2mgmt.c
index
Apply a coding style change suggested by checkpatch and correct a
comment.
Tim Collier (2):
staging: wlan-ng: remove volatile from reapable field in
hfa384x_usbctlx
staging: wlan-ng: correction to comment in hfa384x_usb
drivers/staging/wlan-ng/hfa384x.h | 2 +-
drivers/staging/wlan
The comment for hfa384x_docmd incorrectly states that usercb_data
should be NULL for DOASYNC calls; in fact, it should be NULL for
DOWAIT calls (this is consistent with the other similar functions and
the rest of the comment text).
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng
s threads are protected by the hw->ctlxq.lock
spinlock, where hw is the device struct, so appears thread-safe.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers
Remove the following unused definitions from p80211types.h:
* struct p80211enum
* struct p80211enumpair
* struct catlistitem declaration and associated function pointer
typedefs (along with preceding block comment)
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211types.h | 27
ersion control multiple times.
Patches should be applied in order as there are some dependencies.
Tim Collier (12):
staging: wlan-ng: remove redundant code in "#if 0" blocks
staging: wlan-ng: avoid use of camel case macro names in
p80211metadef.h
staging: wlan-ng: shorten names of &
Remove two blocks of code that checkpatch identified as redundant
because they were enclosed in "#if...#endif". In the case of
prism2fw.c the associated "TODO" comment was retained.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211netdev.c | 4
dri
r-case) to conform to the coding
guidelines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 48 ++---
drivers/staging/wlan-ng/p80211metadef.h | 118
drivers/staging/wlan-ng/p80211netdev.c | 8 +--
drivers/staging/wlan-ng/p
Shorten the names of the p80211metadef.h macros prefixed with
"DIDMIB_DOT11MAC_" by removing repeat use of "DOT11" to reduce long
lines and ease readabbility.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 4 ++--
drivers/staging/wlan-ng/
Shorten the names of the p80211metadef.h macros prefixed with
"DIDMIB_DOT11PHY_" by removing repeat use of "DOT11PHY" and "DOT11" to
reduce long lines and ease readabbility.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 6 +
Shorten the names of the p80211metadef.h macros prefixed with
"DIDMIB_DOT11SMT_" (also in lower-case) by removing repeat use of
"DOT11" to reduce long lines and ease readabbility.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 20 ++---
Shorten the names of the p80211metadef.h macros prefixed with
"DIDMIB_LNX_" by removing repeat use of "LNX" to reduce long lines and
ease readabbility.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/p80211metadef.h | 4 ++--
drivers/staging/wlan-ng/prism2mib.c
Combine previously split lines for an assignment; now fits in 80
characters as the name of the macro being assigned was shortened.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng
The reformatting of case blocks has shortened some lines such that
previously split lines can be rejoined without exceeding 80
characters. Rejoined those lines.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x_usb.c | 6 ++
drivers/staging/wlan-ng/prism2sta.c | 17
For switch statements with case blocks make the format consistent by
applying K&R formatting, a space before the opening brace, single
indentation of contained code, break inside the block and closing
brace aligned with case.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x_u
p80211metadef.h and p80211metastruct.h both have comments stating they
are autogenerated and should not be edited. However, neither is
generated during build and both have had numerous manual edits since
the driver has been in staging.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng
Remove braces from an if statement with only a single line in the if
block.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x_usb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
Shorten the names of the p80211metadef.h macros prefixed with
"DIDMIB_P2_" by removing repeat use of "P2" to reduce long lines and
ease readabbility.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/cfg80211.c | 2 +-
drivers/staging/wlan-ng/p80211metadef.h | 10
On Wed, Aug 29, 2018 at 02:39:30PM +0300, Dan Carpenter wrote:
> On Tue, Aug 28, 2018 at 08:26:22PM +0100, Tim Collier wrote:
> > Remove braces from an if statement with only a single line in the if
> > block.
> >
> > Signed-off-by: Tim Collier
> > ---
> >
On Wed, Aug 29, 2018 at 02:37:36PM +0300, Dan Carpenter wrote:
> On Tue, Aug 28, 2018 at 08:26:13PM +0100, Tim Collier wrote:
> > checkpatch reported a number of "Avoid CamelCase" issues for macros
> > defined in p80211metadef.h (and for files that used these macros).
&g
Fix checkpatch warning due to line break after '(', leaving an over 80
character warning due to long macro name.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x_usb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384
Fix checkpatch warning for missing parameter name for function
prototype.
Signed-off-by: Tim Collier
---
drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index
1 - 100 of 116 matches
Mail list logo
