Re: [PATCH -next] staging: nvec: minor coding style fix

2021-02-15 Thread Thierry Reding
ged, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v8 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-03-22 Thread Thierry Reding
ct spelling errors > - Correct apply() function > - Round values > - Fix divisions in arm32 mode > - Small cleanups > > drivers/pwm/Kconfig | 9 ++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-raspberrypi-poe.c | 206 ++++

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-10 Thread Thierry Reding
On Thu, Nov 05, 2020 at 02:44:08AM +0300, Dmitry Osipenko wrote: > Add OPP and SoC core voltage scaling support to the display controller > driver. This is required for enabling system-wide DVFS on older Tegra > SoCs. > > Tested-by: Peter Geis > Tested-by: Nicolas Chauvet > Signed-off-by: Dmitry

Re: [PATCH v1 07/30] soc/tegra: Add sync state API

2020-11-10 Thread Thierry Reding
On Thu, Nov 05, 2020 at 02:44:04AM +0300, Dmitry Osipenko wrote: > Introduce sync state API that will be used by Tegra device drivers. This > new API is primarily needed for syncing state of SoC devices that are left > ON after bootloader or permanently enabled. All these devices belong to a > shar

Re: [PATCH v1 18/30] pwm: tegra: Support OPP and core voltage scaling

2020-11-10 Thread Thierry Reding
On Thu, Nov 05, 2020 at 02:44:15AM +0300, Dmitry Osipenko wrote: [...] > +static void tegra_pwm_deinit_opp_table(void *data) > +{ > + struct device *dev = data; > + struct opp_table *opp_table; > + > + opp_table = dev_pm_opp_get_opp_table(dev); > + dev_pm_opp_of_remove_table(dev); >

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-12 Thread Thierry Reding
On Thu, Nov 12, 2020 at 10:57:27PM +0300, Dmitry Osipenko wrote: > 11.11.2020 14:38, Ulf Hansson пишет: > > On Sun, 8 Nov 2020 at 13:19, Dmitry Osipenko wrote: > >> > >> 05.11.2020 18:22, Dmitry Osipenko пишет: > >>> 05.11.2020 12:45, Ulf Hansson пишет: > >>> ... > I need some more time to re

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-13 Thread Thierry Reding
On Fri, Nov 13, 2020 at 01:14:45AM +0300, Dmitry Osipenko wrote: > 12.11.2020 23:43, Thierry Reding пишет: > >> The difference in comparison to using voltage regulator directly is > >> minimal, basically the core-supply phandle is replaced is replaced with > >> a po

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-13 Thread Thierry Reding
On Fri, Nov 13, 2020 at 08:13:49PM +0300, Dmitry Osipenko wrote: > 13.11.2020 19:15, Mark Brown пишет: > > On Fri, Nov 13, 2020 at 06:55:27PM +0300, Dmitry Osipenko wrote: > >> 13.11.2020 17:29, Mark Brown пишет: > > > >>> It's not clear if it matters - it's more a policy decision on the part > >>

Re: [PATCH 16/16] staging: media: tegra-vde: add proper SPDX identifiers on file that did not have it.

2019-04-02 Thread Thierry Reding
is impossible > for any tool to properly parse. > > Cc: Dmitry Osipenko > Cc: Mauro Carvalho Chehab > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-me...@vger.kernel.org > Cc: linux-te...@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > --- > drivers/

Re: [PATCH] media: staging: tegra-vde: Disable building with COMPILE_TEST

2019-08-29 Thread Thierry Reding
On Thu, Aug 29, 2019 at 01:39:32PM +0200, Hans Verkuil wrote: > On 8/26/19 3:31 PM, YueHaibing wrote: > > If COMPILE_TEST is y and IOMMU_SUPPORT is n, selecting TEGRA_VDE > > to m will set IOMMU_IOVA to m, this fails the building of > > TEGRA_HOST1X and DRM_TEGRA which is y like this: > > > > driv

Re: [PATCH] media: staging: tegra-vde: Disable building with COMPILE_TEST

2019-08-29 Thread Thierry Reding
On Thu, Aug 29, 2019 at 04:58:22PM +0300, Dmitry Osipenko wrote: > 29.08.2019 15:40, Thierry Reding пишет: > > On Thu, Aug 29, 2019 at 01:39:32PM +0200, Hans Verkuil wrote: > >> On 8/26/19 3:31 PM, YueHaibing wrote: > >>> If COMPILE_TEST is y and IOMMU_SUPPORT is n,

Re: [PATCH v3] ARM: tegra: Enable Tegra VDE driver in tegra_defconfig

2019-10-29 Thread Thierry Reding
On Sun, Jun 23, 2019 at 08:07:25PM +0300, Dmitry Osipenko wrote: > The video decoder driver was tested by time and works absolutely fine. > The reason why it is in staging is because it doesn't provide common V4L > interface yet, this shouldn't stop driver enabling in the defconfig since > our user

Re: [PATCH v3] ARM: dts: tegra30: Connect SMMU with Video Decoder Engine

2019-10-29 Thread Thierry Reding
On Sun, Jun 23, 2019 at 08:07:24PM +0300, Dmitry Osipenko wrote: > Enable IOMMU support for the video decoder. > > Signed-off-by: Dmitry Osipenko > --- > > No changes since v1. > > arch/arm/boot/dts/tegra30.dtsi | 1 + > 1 file changed, 1 insertion(+) Applied to for-5.5/arm/dt, thanks. Thier

Re: [PATCH 1/2] staging: android: ion: Deletion of unnecessary checks before two function calls

2014-12-02 Thread Thierry Reding
> 3 files changed, 6 insertions(+), 12 deletions(-) Acked-by: Thierry Reding pgp21exAuQEUm.pgp Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 2/2] ARM: dts: tegra20: Add video decoder node

2017-10-12 Thread Thierry Reding
On Thu, Oct 12, 2017 at 03:06:17PM +0300, Dmitry Osipenko wrote: > Hello Vladimir, > > On 12.10.2017 10:43, Vladimir Zapolskiy wrote: > > Hello Dmitry, > > > > On 10/11/2017 11:08 PM, Dmitry Osipenko wrote: > >> Add a device node for the video decoder engine found on Tegra20. > >> > >> Signed-off

Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-10-17 Thread Thierry Reding
On Tue, Oct 17, 2017 at 03:13:54PM -0500, Rob Herring wrote: [...] > > diff --git > > a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt > > b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt [...] > > +- resets : Must contain an entry for each entry in reset-n

Re: [PATCH v1 2/2] ARM: dts: tegra30: Add Memory Client reset to VDE

2018-07-09 Thread Thierry Reding
On Sun, May 20, 2018 at 04:48:46PM +0300, Dmitry Osipenko wrote: > Hook up Memory Client reset of the Video Decoder to the decoders DT node. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boot/dts/tegra30.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied, thanks. Thi

Re: [PATCH v1 1/2] ARM: dts: tegra20: Add Memory Client reset to VDE

2018-07-09 Thread Thierry Reding
On Sun, May 20, 2018 at 04:48:44PM +0300, Dmitry Osipenko wrote: > Hook up Memory Client reset of the Video Decoder to the decoders DT node. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boot/dts/tegra20.dtsi | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Applied, thanks.

[PATCH 08/14] staging: media: tegra-vde: Track struct device *

2018-08-13 Thread Thierry Reding
From: Thierry Reding The pointer to the struct device is frequently used, so store it in struct tegra_vde. Also, pass around a pointer to a struct tegra_vde instead of struct device in some cases to prepare for subsequent patches referencing additional data from that structure. Signed-off-by

[PATCH 05/14] staging: media: tegra-vde: Properly mark invalid entries

2018-08-13 Thread Thierry Reding
From: Thierry Reding Entries in the reference picture list are marked as invalid by setting the frame ID to 0x3f. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/tegra-vde

[PATCH 13/14] ARM: tegra: Add BSEV clock and reset for VDE on Tegra30

2018-08-13 Thread Thierry Reding
From: Thierry Reding Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra30.dtsi | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi index a6781f653310..492917d61bab 100644 --- a/arch/arm/boot/dts

[PATCH 04/14] staging: media: tegra-vde: Use DRM/KMS framebuffer modifiers

2018-08-13 Thread Thierry Reding
From: Thierry Reding VDE on Tegra20 through Tegra114 supports reading and writing frames in 16x16 tiled layout. Similarily, the various block-linear layouts that are supported by the GPU on Tegra124 can also be read from and written to by the Tegra124 VDE. Enable userspace to specify the

[PATCH 01/14] staging: media: tegra-vde: Support BSEV clock and reset

2018-08-13 Thread Thierry Reding
From: Thierry Reding The BSEV clock has a separate gate bit and can not be assumed to be always enabled. Add explicit handling for the BSEV clock and reset. This fixes an issue on Tegra124 where the BSEV clock is not enabled by default and therefore accessing the BSEV registers will hang the

[PATCH 10/14] staging: media: tegra-vde: Keep VDE in reset when unused

2018-08-13 Thread Thierry Reding
From: Thierry Reding There is no point in keeping the VDE module out of reset when it is not in use. Reset it on runtime suspend. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/tegra-vde

[PATCH 00/14] staging: media: tegra-vdea: Add Tegra124 support

2018-08-13 Thread Thierry Reding
From: Thierry Reding Hi, this set of patches perform a bit of cleanup and extend support to the VDE implementation found on Tegra114 and Tegra124. This requires adding handling for a clock and a reset for the BSEV block that is separate from the main VDE block. The new VDE revision also

[PATCH 11/14] ARM: tegra: Enable VDE on Tegra124

2018-08-13 Thread Thierry Reding
From: Thierry Reding Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra124.dtsi | 40 + 1 file changed, 40 insertions(+) diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi index b113e47b2b2a..8fdca4723205 100644 --- a/arch/arm

[PATCH 14/14] ARM: tegra: Enable SMMU for VDE on Tegra124

2018-08-13 Thread Thierry Reding
From: Thierry Reding The video decode engine can use the SMMU to use buffers that are not physically contiguous in memory. This allows better memory usage for video decoding, since fragmentation may cause contiguous allocations to fail. Signed-off-by: Thierry Reding --- arch/arm/boot/dts

[PATCH 06/14] staging: media: tegra-vde: Print out invalid FD

2018-08-13 Thread Thierry Reding
From: Thierry Reding Include the invalid file descriptor when reporting an error message to help diagnosing why importing the buffer failed. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 12/14] ARM: tegra: Add BSEV clock and reset for VDE on Tegra20

2018-08-13 Thread Thierry Reding
From: Thierry Reding Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra20.dtsi | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi index 15b73bd377f0..abb5738a0705 100644 --- a/arch/arm/boot/dts

[PATCH 03/14] staging: media: tegra-vde: Prepare for interlacing support

2018-08-13 Thread Thierry Reding
From: Thierry Reding The number of frames doubles when decoding interlaced content and the structures describing the frames double in size. Take that into account to prepare for interlacing support. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 73

[PATCH 07/14] staging: media: tegra-vde: Add some clarifying comments

2018-08-13 Thread Thierry Reding
From: Thierry Reding Add some comments specifying what tables are being set up in VRAM. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers

[PATCH 09/14] staging: media: tegra-vde: Add IOMMU support

2018-08-13 Thread Thierry Reding
From: Thierry Reding Implement support for using an IOMMU to map physically discontiguous buffers into contiguous I/O virtual mappings that the VDE can use. This allows importing arbitrary DMA-BUFs for use by the VDE. While at it, make sure that the device is detached from any DMA/IOMMU mapping

[PATCH 02/14] staging: media: tegra-vde: Support reference picture marking

2018-08-13 Thread Thierry Reding
From: Thierry Reding Tegra114 and Tegra124 support reference picture marking, which will cause BSEV to write picture marking data to SDRAM. Make sure there is a valid destination address for that data to avoid error messages from the memory controller. Signed-off-by: Thierry Reding

Re: [PATCH 01/14] staging: media: tegra-vde: Support BSEV clock and reset

2018-08-14 Thread Thierry Reding
On Mon, Aug 13, 2018 at 06:09:46PM +0300, Dmitry Osipenko wrote: > On Monday, 13 August 2018 17:50:14 MSK Thierry Reding wrote: > > From: Thierry Reding > > > > The BSEV clock has a separate gate bit and can not be assumed to be > > always enabled. Add explicit hand

Re: [PATCH 00/14] staging: media: tegra-vdea: Add Tegra124 support

2018-09-03 Thread Thierry Reding
On Mon, Sep 03, 2018 at 02:18:15PM +0200, Hans Verkuil wrote: > Hi Thierry, Dmitry, > > Dmitry found some issues, so I'll wait for a v2. > > Anyway, this driver is in staging with this TODO: > > - Implement V4L2 API once it gains support for stateless decoders. > > I just wanted to mention that

Re: [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGEcheckpatch checks

2017-03-08 Thread Thierry Reding
On Thu, Mar 02, 2017 at 03:57:01PM +0100, Marc Dietrich wrote: > Hi Simran, > > Am Donnerstag, 2. März 2017, 15:48:13 CET schrieb SIMRAN SINGHAL: > > On Thursday, March 2, 2017 at 8:06:40 PM UTC+5:30, Julia Lawall wrote: > > > On Thu, 2 Mar 2017, simran singhal wrote: > > > > Resolve strict checkp

Re: [PATCH] staging: nvec: Remove unnecessary cast on void pointer

2017-03-08 Thread Thierry Reding
| > - (T*) > e > ) > > Signed-off-by: simran singhal > --- > drivers/staging/nvec/nvec_kbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v1 0/3] Tegra GPIO: Minor code clean up

2019-12-19 Thread Thierry Reding
gpio: tegra: Use generic readl_relaxed/writel_relaxed accessors > gpio: tegra: Properly handle irq_set_irq_wake() error > gpio: tegra: Use NOIRQ phase for suspend/resume > > drivers/gpio/gpio-tegra.c | 21 ++--- > 1 file changed, 10 insertions(+), 11 deletions(-) Patches loo

Re: [PATCH -next] media: tegra: Make tegra210_video_formats static

2020-05-12 Thread Thierry Reding
On Mon, May 11, 2020 at 07:20:15PM +0800, Samuel Zou wrote: > Fix the following sparse warning: > > drivers/staging/media/tegra-video/tegra210.c:589:33: warning: symbol > 'tegra210_video_formats' was not declared. > > The tegra210_video_formats has only call site within tegra210.c > It should be

Re: [PATCH v3 1/2] drivers/base: permit base components to omit the bind/unbind ops

2014-02-10 Thread Thierry Reding
On Fri, Feb 07, 2014 at 04:55:00PM +0100, Jean-Francois Moine wrote: > Some simple components don't need to do any specific action on > bind to / unbind from a master component. > > This patch permits such components to omit the bind/unbind > operations. > > Signed-off-by: Jean-Francois Moine >

Re: [PATCH v12][ 09/12] drm/panel: Add Eukrea mbimxsd51 displays.

2014-04-09 Thread Thierry Reding
On Mon, Apr 07, 2014 at 02:44:48PM +0200, Denis Carikli wrote: [...] > +static const struct panel_desc eukrea_mbimxsd51_dvisvga = { > + .modes = &eukrea_mbimxsd51_dvisvga_mode, > + .num_modes = 1, > + .size = { > + .width = 0, > + .height = 0, > + }, > +}; [.

[PATCH 1/2] staging: fsl-mc: Do not allow building as a module

2016-02-15 Thread Thierry Reding
From: Thierry Reding This driver uses functionality (MSI IRQ domain) whose symbols aren't exported, and hence the modular build fails. While arguably there might be reasons to make these symbols available to modules, that change would be fairly involved and the set of exported functions s

[PATCH 2/2] staging: fsl-mc: Avoid section mismatch

2016-02-15 Thread Thierry Reding
From: Thierry Reding The fsl_mc_allocator_driver_exit() function is marked __exit, but is called by the error handling code in fsl_mc_allocator_driver_init(). This results in a section mismatch, which in turn could lead to executing random code. Remove the __exit annotation to fix this. Cc: J

Re: [PATCH 1/2] staging: fsl-mc: Do not allow building as a module

2016-02-18 Thread Thierry Reding
On Mon, Feb 15, 2016 at 02:22:22PM +0100, Thierry Reding wrote: > From: Thierry Reding > > This driver uses functionality (MSI IRQ domain) whose symbols aren't > exported, and hence the modular build fails. While arguably there might > be reasons to make these symbols availa

[PATCH 2/2] pwm: Remove .can_sleep from struct pwm_chip

2017-01-04 Thread Thierry Reding
All PWM devices have been marked as "might sleep" since v4.5, there is no longer a need to differentiate on a per-chip basis. Signed-off-by: Thierry Reding --- drivers/pwm/pwm-atmel-hlcdc.c | 1 - drivers/pwm/pwm-atmel.c | 1 - drivers/pwm/pwm-bcm-kona.c| 1 - drivers/pwm/pw

[PATCH 1/2] pwm: Remove pwm_can_sleep()

2017-01-04 Thread Thierry Reding
The last user of this function has been removed, so it is no longer needed. Signed-off-by: Thierry Reding --- drivers/pwm/core.c | 12 include/linux/pwm.h | 7 --- 2 files changed, 19 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 172ef8245811

[PATCH] [media] staging: media: Fix build for iMON LIRC driver

2013-10-15 Thread Thierry Reding
Add a missing , between parameters in a call to dev_info(). Signed-off-by: Thierry Reding --- drivers/staging/media/lirc/lirc_imon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c index 8180187

Re: [PATCH 21/31] staging: nvec: use reset framework

2013-11-29 Thread Thierry Reding
> merged into other subsystems if needed to avoid/resolve dependencies. > --- > drivers/staging/nvec/nvec.c | 11 --- > drivers/staging/nvec/nvec.h | 5 - > 2 files changed, 12 insertions(+), 4 deletions(-) Reviewed-by: Thierry Reding pgpJY2PXFUGX6.pgp Description

Re: [PATCHv5][ 3/8] staging: imx-drm: Correct BGR666 and the board's dts that use them.

2013-12-06 Thread Thierry Reding
On Thu, Dec 05, 2013 at 07:28:07PM +0100, Denis Carikli wrote: [...] > diff --git a/arch/arm/boot/dts/imx51-apf51dev.dts > b/arch/arm/boot/dts/imx51-apf51dev.dts > index f36a3aa..3b6de6a 100644 > --- a/arch/arm/boot/dts/imx51-apf51dev.dts > +++ b/arch/arm/boot/dts/imx51-apf51dev.dts > @@ -19,7 +19

Re: [PATCHv5][ 2/8] staging: imx-drm: Add RGB666 support for parallel display.

2013-12-06 Thread Thierry Reding
On Thu, Dec 05, 2013 at 07:28:06PM +0100, Denis Carikli wrote: [...] > diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c > b/drivers/staging/imx-drm/ipu-v3/ipu-dc.c [...] > @@ -155,6 +156,8 @@ static int ipu_pixfmt_to_map(u32 fmt) > return IPU_DC_MAP_BGR666; > case V4L2_PIX_

Re: [PATCHv5][ 5/8] staging: imx-drm: parallel display: add regulator support.

2013-12-06 Thread Thierry Reding
On Thu, Dec 05, 2013 at 07:28:09PM +0100, Denis Carikli wrote: [...] > diff --git a/drivers/staging/imx-drm/parallel-display.c > b/drivers/staging/imx-drm/parallel-display.c [...] > @@ -260,6 +275,13 @@ static int imx_pd_probe(struct platform_device *pdev) > if (ret) > return r

Re: [PATCHv5][ 2/8] staging: imx-drm: Add RGB666 support for parallel display.

2013-12-06 Thread Thierry Reding
On Fri, Dec 06, 2013 at 02:29:22PM +0100, Lucas Stach wrote: > Am Freitag, den 06.12.2013, 14:14 +0100 schrieb Thierry Reding: > > On Thu, Dec 05, 2013 at 07:28:06PM +0100, Denis Carikli wrote: > > [...] > > > diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c > &g

Re: [RFC PATCH 0/8] component helper improvements

2014-05-14 Thread Thierry Reding
On Sun, Apr 27, 2014 at 12:00:25AM +0100, Russell King - ARM Linux wrote: > A while back, Laurent raised some comments about the component helper, > which this patch set starts to address. > > The first point it addresses is the repeated parsing inefficiency when > deferred probing occurs. When D

Re: [PATCH] imx-drm: imx-hdmi: move memory and resource allocation into probe function

2014-05-14 Thread Thierry Reding
On Wed, May 14, 2014 at 11:24:14PM +0200, Philipp Zabel wrote: > Move memory allocation and resource acquisition from the bind function into > the probe function. This calls the devres managed functions once instead of > possibly multiple times in the bind function and avoids leaking memory (as > l

Re: [PATCH v14 08/10] drm/panel: Add Eukrea mbimxsd51 displays.

2014-06-24 Thread Thierry Reding
On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: [...] > diff --git > a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt > b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt [...] > @@ -0,0 +1,7 @@ > +Eukrea DVI-SVGA (800x600 pixels) DVI out

Re: [PATCH v14 08/10] drm/panel: Add Eukrea mbimxsd51 displays.

2014-06-24 Thread Thierry Reding
On Tue, Jun 24, 2014 at 02:52:11PM -0500, Rob Herring wrote: > On Tue, Jun 24, 2014 at 10:06 AM, Russell King - ARM Linux > wrote: [...] > > On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: [...] > >> diff --git > >> a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vg

Re: [PATCH v14 08/10] drm/panel: Add Eukrea mbimxsd51 displays.

2014-06-24 Thread Thierry Reding
On Tue, Jun 24, 2014 at 11:56:39PM +0200, Eric Bénard wrote: > Hi Thierry, > > Le Tue, 24 Jun 2014 23:49:37 +0200, > Thierry Reding a écrit : > > > On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: > > [...] > > > diff --git > > > a/D

Re: [PATCH v14 06/10] drm: drm_display_mode: add signal polarity flags

2014-06-24 Thread Thierry Reding
On Tue, Jun 24, 2014 at 03:57:46PM +0100, Russell King - ARM Linux wrote: > On Mon, Jun 16, 2014 at 12:11:20PM +0200, Denis Carikli wrote: > > We need a way to pass signal polarity informations > > between DRM panels, and the display drivers. > > > > To do that, a pol_flags field was added to dr

Re: [PATCH 1/2] staging: nvec: remove unnecessary 'else' after 'return' statement

2014-07-06 Thread Thierry Reding
t; drivers/staging/nvec/nvec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Thierry Reding pgp74td0RBKxI.pgp Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverp

Re: [PATCH 2/2] staging: nvec: remove unneccessary 'out of memory' message

2014-07-06 Thread Thierry Reding
; drivers/staging/nvec/nvec.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Thierry Reding pgpcKewibAJKl.pgp Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverp

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Thierry Reding
On Sun, Jul 13, 2014 at 12:22:02PM -0700, Greg Kroah-Hartman wrote: > On Sun, Jul 13, 2014 at 04:25:06PM +0200, Lars-Peter Clausen wrote: > > On 07/13/2014 04:03 PM, Richard Weinberger wrote: > > >Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: > > >>On 07/13/2014 03:40 PM, Richard Weinberger wrot

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 09:27:58AM +0800, Chen Gang wrote: [...] > diff --git a/include/linux/device.h b/include/linux/device.h > index c2421e0..a7500c3 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -630,7 +630,16 @@ extern unsigned long devm_get_free_pages(struct device

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 05:29:31PM +0800, Chen Gang wrote: > > > On 07/17/2014 05:20 PM, Arnd Bergmann wrote: > > On Thursday 17 July 2014 09:27:58 Chen Gang wrote: > >> gfp_t gfp_mask, unsigned int > >> order); > >> extern void devm_free_pages(struct de

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote: [...] > score should set HAS_IOMEM and doesn't > even have public compilers This begs an interesting question. Should it be made a requirement to have publicly available compilers for new architectures so that the

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 12:33:32PM +0200, Arnd Bergmann wrote: > On Thursday 17 July 2014 11:56:58 Thierry Reding wrote: > > On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote: > > [...] > > > score should set HAS_IOMEM and doesn't >

[PATCH] staging/nvec: Pass proper resource to mfd_add_devices()

2014-07-21 Thread Thierry Reding
From: Thierry Reding The mfd_add_devices() parameter takes a struct resource * as fifth argument, but the nvec driver passes in a void __iomem *. The driver gets away with it because none of the subdevices ever directly access the registers. While at it, use platform_get_irq() instead of

[PATCH] staging/nvec: Remove double const qualifier

2014-07-21 Thread Thierry Reding
From: Thierry Reding The SIMPLE_DEV_PM_OPS macro already uses the const qualifier, so there's no need to repeat it. Signed-off-by: Thierry Reding --- drivers/staging/nvec/nvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/st

Re: [PATCH] staging/nvec: Pass proper resource to mfd_add_devices()

2014-07-21 Thread Thierry Reding
On Mon, Jul 21, 2014 at 02:39:15PM -0700, Greg Kroah-Hartman wrote: > On Mon, Jul 21, 2014 at 10:01:36PM +0200, Marc Dietrich wrote: > > Hi Thierry, > > > > On Mon, 21 Jul 2014 13:52:41 +0200 > > Thierry Reding wrote: > > > > > From: Thierry Reding &g

[PATCH 2/2] staging/nvec: Use platform_get_irq()

2014-07-29 Thread Thierry Reding
From: Thierry Reding As opposed to platform_get_resource(), the platform_get_irq() function has special code to handle driver probe deferral when booting using DT and where an interrupt provider hasn't been registered yet. While this is unlikely to become an issue for nvec, platform_get_irq

[PATCH 1/2] staging/nvec: Do not pass resource to mfd_add_devices()

2014-07-29 Thread Thierry Reding
From: Thierry Reding The mfd_add_devices() function takes a struct resource * as fifth argument, but the nvec driver passes in a void __iomem *. The driver gets away with it because none of the subdevices ever directly access the registers. Since subdevices never need to access the registers we

Re: [PATCH v5 3/4] ARM: dts: tegra20: Add device tree node to describe IRAM

2017-12-20 Thread Thierry Reding
On Tue, Dec 12, 2017 at 03:26:09AM +0300, Dmitry Osipenko wrote: > From: Vladimir Zapolskiy > > All Tegra20 SoCs contain 256KiB IRAM, which is used to store > resume code and by a video decoder engine. > > Signed-off-by: Vladimir Zapolskiy > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boo

Re: [PATCH v5 4/4] ARM: dts: tegra20: Add video decoder node

2017-12-20 Thread Thierry Reding
On Tue, Dec 12, 2017 at 03:26:10AM +0300, Dmitry Osipenko wrote: > Add Video Decoder Engine device node. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boot/dts/tegra20.dtsi | 27 +++ > 1 file changed, 27 insertions(+) Applied, thanks. Thierry signature.asc Descr

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-22 Thread Thierry Reding
On Thu, May 21, 2020 at 08:39:02PM +0300, Dan Carpenter wrote: > On Thu, May 21, 2020 at 05:22:05PM +0200, Rafael J. Wysocki wrote: > > On Thu, May 21, 2020 at 11:15 AM Dan Carpenter > > wrote: > > > > > > On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote: > > > > Hi, Dan, >

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-22 Thread Thierry Reding
On Fri, May 22, 2020 at 04:23:18PM +0300, Dan Carpenter wrote: > On Fri, May 22, 2020 at 03:10:31PM +0200, Thierry Reding wrote: > > On Thu, May 21, 2020 at 08:39:02PM +0300, Dan Carpenter wrote: > > > On Thu, May 21, 2020 at 05:22:05PM +0200, Rafael J. Wysocki wrote: > >

Re: [PATCH v2 3/4] media: staging: tegra-vde: Turn ON power domain on shutdown

2020-06-26 Thread Thierry Reding
; drivers/staging/media/tegra-vde/vde.c | 19 +++ > 1 file changed, 19 insertions(+) Unfortunate that we have to do this, but looks fine: Acked-by: Thierry Reding signature.asc Description: PGP signature ___ deve

Re: [PATCH v2 2/4] media: staging: tegra-vde: Runtime PM is always available on Tegra

2020-06-26 Thread Thierry Reding
Signed-off-by: Dmitry Osipenko > --- > drivers/staging/media/tegra-vde/vde.c | 16 > 1 file changed, 16 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH v2 4/4] media: staging: tegra-vde: Power-cycle hardware on probe

2020-06-26 Thread Thierry Reding
On Wed, Jun 24, 2020 at 06:08:47PM +0300, Dmitry Osipenko wrote: > VDE partition is left turned ON after bootloader on most devices, hence > let's ensure that it's turned OFF in order to lower power leakage while > hardware is idling by turning it ON and OFF during of the driver's probe. > > Signe