On Tue, 2018-10-16 at 13:01 -0300, Marcelo Schmitt wrote:
> Fixes close parenthesis alignment to match open parenthesis at
> iio/drivers/staging/iio/adc/ad7606.c line 379.
>
> Signed-of-by: Marcelo Schmitt
Hi Marcelo,
Some suggestions from my side
1) Your subject line should look like "Sta
On Mon, 2018-10-22 at 22:44 +0530, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated old non-descriptor
> interface for ldac_pin.
>
> Signed-off-by: Nishad Kamdar
> ---
Hi Nishad,
I have been working on implementing device tree bindings for this
driver and removing platfo
This patchset introduces device tree bindings for adt7316
driver and removes the usage of platform data from it.
Also, it sets the data field to it's appropriate value in
the i2c read function which was nowhere being set before.
Shreeya Patel (7):
Staging: iio: adt7316: Set the data
adt7316_i2c_read function nowhere sets the data field.
It is necessary to have an appropriate value for it.
Hence, assign the value stored in 'ret' variable to data field.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 2 ++
1 file changed, 2 insertion
ret = 0 indicates a case of no error but no data read from
the bus which is an invalid case. This case doesn't ever happen
in reality. It should perhaps be handled for correctness though.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 4
1 file chang
ADT7316, add of_device_id
table which specifies the supported devices through compatible
property.
Note that there is a fall back path in i2c that will result
in i2c_device_id table being used if there is no of_devcie_id table.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c
Make the driver use device tree instead of the platform data.
Hence, use devm_gpiod_get_optional function to get the data from
device tree for ldac-pin and accordingly make the needed changes
in the driver.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 14
There is no need to store irq_flags into the structure as it
is always set to the same thing. Hence switch irq_flags to a
local variable.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 1 -
drivers/staging/iio/addac/adt7316-spi.c | 1 -
drivers/staging/iio/addac
Most of the drivers in IIO uses irq_type as the name for
storing the interrupt type and hence change the name from
irq_flags to irq_type for maintaining the consistency.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 8
1 file changed, 4 insertions(+), 4
ff-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
index 9c72538baf9e..c647875a64f5 100644
--- a/drivers/staging/iio/addac/adt7
*[1/5] appropriate.
Shreeya Patel (5):
Staging: iio: adt7316: Add of_device_id table
Staging: iio: adt7316: Use device tree data to set ldac_pin
Staging: iio: adt7316: Switch irq_flags to a local variable
Staging: iio: adt7316: Change the name from irq_flags to irq_type
Staging: iio: adt7316: Use d
should be a fall back path
with which desired kernel modules can be loaded. Hence, add
of_device_id table in the i2c driver to be able to use when there
is no dt table.
Signed-off-by: Shreeya Patel
---
Changes in v2:
- Make the commit message appropriate and assign of_match_table
in the driver
Make the driver use device tree instead of the platform data.
Hence, use devm_gpiod_get_optional function to get the data from
device tree for ldac-pin and accordingly make the needed changes
in the driver.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 14
There is no need to store irq_flags into the structure as it
is always set to the same thing. Hence switch irq_flags to a
local variable.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 1 -
drivers/staging/iio/addac/adt7316-spi.c | 1 -
drivers/staging/iio/addac
Most of the drivers in IIO uses irq_type as the name for
storing the interrupt type and hence change the name from
irq_flags to irq_type for maintaining the consistency.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 8
1 file changed, 4 insertions(+), 4
ff-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
index 9c72538baf9e..c647875a64f5 100644
--- a/drivers/staging/iio/addac/adt7
On Wed, 2018-11-21 at 08:21 +, Ardelean, Alexandru wrote:
> On Tue, 2018-11-20 at 22:30 +0530, Shreeya Patel wrote:
> > ADT7316 driver no more uses platform data and hence use device tree
> > data instead of platform data for assigning irq_type field.
> > Switch case fi
On Tue, 2018-12-04 at 18:49 -0700, Jeremy Fertic wrote:
> This reverts commit 00426e99789357dbff7e719a092ce36a3ce49d94.
>
> i2c_smbus_read_byte() returns 0 when a byte with the value 0 is read
> from
> the device. This is a valid read so revert the check for 0.
>
> Signed-off-by: Jeremy Fertic
>
On Thu, 2018-12-06 at 15:40 +0300, Dan Carpenter wrote:
> On Wed, Dec 05, 2018 at 02:59:53PM -0700, Jeremy Fertic wrote:
> > On Thu, Dec 06, 2018 at 01:25:55AM +0530, Shreeya Patel wrote:
> > > On Tue, 2018-12-04 at 18:49 -0700, Jeremy Fertic wrote:
> >
Add a dev_err() message "failed to request irq" for describing
what went wrong when an error contition is statisfied.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/addac
There is a function adt7316_irq_setup() where irq_type is being
set. It would be good to move devm_request_threaded_irq() function
and assignment of chip->config1 in adt7316_irq_setup() to unclutter
the code in probe function.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt731
about the error.
Shreeya Patel (3):
Staging: iio: adt7316: Use device tree data to assign irq_type
Staging: iio: adt7316: Move interrupt related code
Staging: iio: adt7316: Add a dev_err() message
drivers/staging/iio/addac/adt7316.c | 52 +
1 file changed, 38
is is implemented in a new function called adt7316_setup_irq.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316.c | 29 +
1 file changed, 25 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/iio/addac/adt7316.c
On Sat, 2018-12-08 at 11:17 +, Jonathan Cameron wrote:
> On Sat, 08 Dec 2018 00:07:21 +0530
> Shreeya Patel wrote:
>
> > On Thu, 2018-12-06 at 15:40 +0300, Dan Carpenter wrote:
> > > On Wed, Dec 05, 2018 at 02:59:53PM -0700, Jeremy Fertic wrote:
> > > >
On Sat, 2018-12-08 at 16:12 +, Jonathan Cameron wrote:
> On Sat, 8 Dec 2018 20:46:37 +0530
> Shreeya Patel wrote:
>
> > There is a function adt7316_irq_setup() where irq_type is being
> > set. It would be good to move devm_request_threaded_irq() function
> > and
e i.e.
irq_type = IRQF_TRIGGER_LOW
Move devm_request_threaded_irq() and assignment of chip->config1
into the adt7316_setup_irq() to unclutter the code in probe function.
Signed-off-by: Shreeya Patel
---
Changes in v4
- Merge patches *[1/3 v3], *[2/3 v3] and *[3/3 v3] to make it less
complex t
Both i2c and spi drivers have functions for reading and writing
to/from registers. Remove this redundant and common code by using
regmap API.
Also remove multi_read and multi_write functions from i2c
and spi driver as they are not being used anywhere.
Signed-off-by: Shreeya Patel
---
drivers
interrupt request is not needed to be present in the bus
structure. It is a good option to pass it as a parameter
in the probe function instead of having it in the bus structure.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 3 +--
drivers/staging/iio/addac/adt7316
This patchset consist of some initial patches for heading
towards the regmap implementation and also the final patch
which enables the driver to use regmap API thus removing
the redundant and common code.
Shreeya Patel (3):
Staging: iio: adt7316: Remove irq from bus structure
Staging: iio
Both i2c and spi drivers have functions for reading and writing
to/from registers. Remove this redundant and common code by using
regmap API.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 60 +++
drivers/staging/iio/addac/adt7316-spi.c | 74
Currently, adt7316 doesn't use multi read and multi write
functions hence remove the redundant code and make the
necessary changes in the code.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 40 -
drivers/staging/iio/addac/adt7316-spi.c
On Sat, 2019-01-19 at 19:04 +, Jonathan Cameron wrote:
> On Sun, 20 Jan 2019 00:09:29 +0530
> Shreeya Patel wrote:
>
> > This patchset consist of some initial patches for heading
> > towards the regmap implementation and also the final patch
> > which enables t
interrupt request is not needed to be present in the bus
structure. It is a good option to pass it as a parameter
in the probe function instead of having it in the bus structure.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 3 +--
drivers/staging/iio/addac/adt7316
directory.
Changes in v2
-Change the val_bits to 8 and add two more patches
having a different change before the final implemetation
of regmap.
Shreeya Patel (3):
Staging: iio: adt7316: Remove irq from bus structure
Staging: iio: adt7316: Remove multi read and write functions
Staging: iio
Currently, adt7316 doesn't use multi read and multi write
functions hence remove the redundant code and make the
necessary changes in the code.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 40 -
drivers/staging/iio/addac/adt7316-spi.c
Both i2c and spi drivers have functions for reading and writing
to/from registers. Remove this redundant and common code by using
regmap API.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 56 +++---
drivers/staging/iio/addac/adt7316-spi.c | 74
On Fri, 2019-01-25 at 18:22 -0700, Jeremy Fertic wrote:
> On Sun, Jan 20, 2019 at 09:06:30PM +0530, Shreeya Patel wrote:
> > This patchset consist of some initial patches for heading
> > towards the regmap implementation and also the final patch
> > which enables the driver t
On Sat, 2019-01-26 at 10:42 +0530, Shreeya Patel wrote:
> On Fri, 2019-01-25 at 18:22 -0700, Jeremy Fertic wrote:
> > On Sun, Jan 20, 2019 at 09:06:30PM +0530, Shreeya Patel wrote:
> > > This patchset consist of some initial patches for heading
> > > towards the regmap
interrupt request is not needed to be present in the bus
structure. It is a good option to pass it as a parameter
in the probe function instead of having it in the bus structure.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 3 +--
drivers/staging/iio/addac/adt7316
Currently, adt7316 doesn't use multi read and multi write
functions hence remove the redundant code and make the
necessary changes in the code.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 40 -
drivers/staging/iio/addac/adt7316-spi.c
Both i2c and spi drivers have functions for reading and writing
to/from registers. Remove this redundant and common code by using
regmap API.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/addac/adt7316-i2c.c | 56 +++---
drivers/staging/iio/addac/adt7316-spi.c | 74
ainst greg's testing branch.
Changes in v3
-Fetch the changes from remote and rebase to have it in
the current working directory.
Changes in v2
-Change the val_bits to 8 and add two more patches
having a different change before the final implemetation
of regmap.
Shreeya Patel (3):
St
The comments regarding memset are not needed in the
files which have been modified since the necessary changes
are already there in the files.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 ---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ---
drivers
On Fri, 2017-09-29 at 23:10 +0200, Julia Lawall wrote:
>
> On Sat, 30 Sep 2017, Shreeya Patel wrote:
>
> >
> > The comments regarding memset are not needed in the
> > files which have been modified since the necessary changes
> > are already there in the file
This patch removes unnecessary comments which are there
to explain why call to memset is in comments. Both of the
comments are not needed as they are not very useful.
Signed-off-by: Shreeya Patel
---
Changes in v2:
-Remove some more unnecessary comments and make the
commit message more
t, Sep 30, 2017 at 01:30:34PM +0530, Shreeya Patel wrote:
> >
> > This patch removes unnecessary comments which are there
> > to explain why call to memset is in comments. Both of the
> > comments are not needed as they are not very useful.
> You may like to read Docu
Remove unnecessary comments which are there
to explain why call to memset is in comments. Both of the
comments are not needed as they are not very useful.
Signed-off-by: Shreeya Patel
---
Changes in v2:
-Remove some more unnecessary comments and make the
commit message more appropriate
Remove unnecessary comments which are there
to explain why call to memset is in comments. Both of the
comments are not needed as they are not very useful.
Signed-off-by: Shreeya Patel
---
Changes in v2:
-Remove some more unnecessary comments and make the
commit message more appropriate
On Sun, 2017-10-01 at 09:42 +1100, Tobin C. Harding wrote:
> On Sat, Sep 30, 2017 at 07:41:11PM +0530, Shreeya Patel wrote:
> >
> > Remove unnecessary comments which are there
> > to explain why call to memset is in comments. Both of the
> > comments are not needed
Remove NULL pointer dereference as it results in undefined
behaviour, and will usually lead to a runtime error.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtlwifi/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging
On Tue, 2017-10-10 at 11:06 +1100, Tobin C. Harding wrote:
> On Tue, Oct 10, 2017 at 02:48:58AM +0530, Shreeya Patel wrote:
> >
> > Remove NULL pointer dereference as it results in undefined
> > behaviour, and will usually lead to a runtime error.
> The diff does not show
On Thu, 2017-10-12 at 13:16 +1100, Tobin C. Harding wrote:
> On Wed, Oct 11, 2017 at 06:02:47PM +0530, Shreeya Patel wrote:
> >
> > On Tue, 2017-10-10 at 11:06 +1100, Tobin C. Harding wrote:
> > >
> > > On Tue, Oct 10, 2017 at 02:4
Remove trailing whitespace checkpatch errors.
Signed-off-by: Shreeya Patel
---
drivers/staging/irda/drivers/esi-sir.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/irda/drivers/esi-sir.c
b/drivers/staging/irda/drivers/esi-sir.c
Resolve following checkpatch issue:
WARNING: Symbolic permissions 'S_IRUGO' are not preferred.
Consider using octal permissions '0444'.
Signed-off-by: Shreeya Patel
---
drivers/staging/speakup/speakup_bns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
On Fri, 2017-10-13 at 23:44 +0200, Julia Lawall wrote:
>
> On Sat, 14 Oct 2017, Shreeya Patel wrote:
>
> >
> > Resolve following checkpatch issue:
> > WARNING: Symbolic permissions 'S_IRUGO' are not preferred.
> > Consider using octal permissions &#
merge.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 53 +++-
1 file changed, 18 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c
b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index 9a4c248..93ac083 100644
This patchset removes some warnings generated by checkpatch
for cleanup of the rtl8723bs driver. Also some additional
cleanups are introduced in the *[1/4] and *[3/4] patches
to make the code according to the kernel coding style.
Shreeya Patel (4):
Staging: rtl8723bs: Replace true with x and
Replace true and false keywords with "x" and "!x"
respectively to follow the kernel coding style.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --g
Change names of some variables and functions to conform
to the kernel coding style.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 714 +++
1 file changed, 357 insertions(+), 357 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal
Change the conditional operator to assignment as it is
not a conditional statement.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c
b/drivers/staging/rtl8723bs
If "x" is compared to NULL, use "!x" instead of it, so
as to follow the kernel coding style.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8
On Sun, 2017-12-17 at 01:45 -0800, Joe Perches wrote:
> On Sun, 2017-12-17 at 15:07 +0530, Shreeya Patel wrote:
> >
> > Replace true and false keywords with "x" and "!x"
> > respectively to follow the kernel coding style.
> []
> >
> > dif
NULL in the case where ptr is NULL already.
Signed-off-by: Shreeya Patel
---
drivers/staging/irda/net/irnet/irnet_irda.c | 28 ++--
drivers/staging/irda/net/irnet/irnet_ppp.c | 10 --
2 files changed, 14 insertions(+), 24 deletions(-)
diff --git a/drivers/staging
On Mon, 2017-12-18 at 11:20 -0800, Stephen Hemminger wrote:
> On Tue, 19 Dec 2017 00:41:30 +0530
> Shreeya Patel wrote:
>
> >
> > Do not check for NOT NULL before calling kfree because if the
> > pointer is NULL, no action occurs.
> > Done using the follo
,flag);
if (to==NULL || ...) S
- memcpy(to, from, size);
Signed-off-by: Shreeya Patel
---
drivers/staging/lustre/lnet/lnet/api-ni.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c
b/drivers/staging/lustre/lnet/lnet/api-ni.c
Add space around & operator for improving the code
readability.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
b/drivers/staging/rtl8188eu/core/rtw_ml
On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
Hi Joe,
> On Sun, 2020-03-08 at 20:31 +0100, Julia Lawall wrote:
> > On Mon, 9 Mar 2020, Shreeya Patel wrote:
> >
> > > Add space around & operator for improving the code
> > > readability.
> > I g
Remove comparison to "true" from if statement to
maintain the kernel coding style.
Reported by checkpatch.pl
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/r
On Sun, 2020-03-08 at 13:19 -0700, Joe Perches wrote:
> On Mon, 2020-03-09 at 01:40 +0530, Shreeya Patel wrote:
> > On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
> > Hi Joe,
>
> Hello.
> []
> > > > > diff --git a/drivers/staging/rtl8188eu/core
On Sun, 2020-03-08 at 21:17 +0100, Julia Lawall wrote:
>
> On Mon, 9 Mar 2020, Shreeya Patel wrote:
>
> > On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
> >
> > Hi Joe,
> >
> > > On Sun, 2020-03-08 at 20:31 +0100, Julia Lawall wrote:
>
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 40 +++
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote:
> On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote:
> > Add space around operators for improving the code
> > readability.
>
> Hello again Shreeya.
>
> The subject isn't really quite appropriate as you
&
On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote:
> On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote:
> > Add space around operators for improving the code
> > readability.
>
> Hello again Shreeya.
>
I have some questions here...
> The subject isn't
On Mon, 2020-03-09 at 08:35 +0100, Julia Lawall wrote:
> On Mon, 9 Mar 2020, Shreeya Patel wrote:
>
> > On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote:
> > > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote:
> > > > Add space around operators for impro
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
Signed-off-by: Shreeya Patel
---
rtw_mlme_old.o - Previously produced object file before making any
changes to the source code.
rtw_mlme.o - Object file produced after compiling the changes done in source
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/staging/rtl8188eu/core/
shreeya@Shreeya-Patel:~git/kernels/staging$
git diff -w shows no difference
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers
Remove if and else conditions since both are leading to the
initialization of "valueDMATimeout" and "valueDMAPageCount" with
the same value.
Found using coccinelle script.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 +---
Remove unnecessary if and else conditions since both are leading to the
initialization of "phtpriv->ampdu_enable" with the same value.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
Hey Joe,
On March 11, 2020 10:56:29 PM GMT+05:30, Joe Perches wrote:
>On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote:
>> Remove if and else conditions since both are leading to the
>> initialization of "valueDMATimeout" and "valueDMAPageCount" w
On March 11, 2020 10:34:28 PM GMT+05:30, Stefano Brivio
wrote:
Hey Stefano,
>On Wed, 11 Mar 2020 18:47:42 +0530
>Shreeya Patel wrote:
>
>> Add space around operators for improving the code
>> readability.
>> Reported by checkpatch.pl
>>
>> git diff
On Fri, 2020-03-13 at 10:20 +0300, Dan Carpenter wrote:
> On Wed, Mar 11, 2020 at 07:08:11PM +0530, Shreeya Patel wrote:
> > diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > index e813382e78a6..643592b0bd38 100
Remove unnecessary if and else conditions since both are leading to the
initialization of "phtpriv->ampdu_enable" with the same value.
Also, remove the unnecessary else-if condition since it does nothing.
Signed-off-by: Shreeya Patel
---
Changes in v2
- Remove unnecessary commen
Remove if and else conditions since both are leading to the
initialization of "valueDMATimeout" and "valueDMAPageCount" with
the same value.
Found using coccinelle script.
Signed-off-by: Shreeya Patel
---
Changes in v2
- Remove unnecessary comments.
drivers/s
Remove if and else conditions since both are leading to the
initialization of "valueDMATimeout" and "valueDMAPageCount" with
the same value.
Found using coccinelle script.
Signed-off-by: Shreeya Patel
---
Changes in v2
- Remove unnecessary comments.
drivers/s
- memcpy(to, from, size);
Signed-off-by: Shreeya Patel
---
drivers/staging/wilc1000/cfg80211.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/cfg80211.c
b/drivers/staging/wilc1000/cfg80211.c
index 54e02807cebf..4bdcbc5fd2fd 100644
--- a/drivers
On Fri, 2020-03-13 at 14:21 -0700, Joe Perches wrote:
Hi Joe,
> On Fri, 2020-03-13 at 15:59 +0530, Shreeya Patel wrote:
> > Remove unnecessary if and else conditions since both are leading to
> > the
> > initialization of "phtpriv->ampdu_enable" with th
This patchset adds space around operators and removes
all the checkpatch warnings for the same from the files
present under drivers/staging/rtl8188eu/hal/ directory.
Shreeya Patel (11):
Staging: rtl8188eu: hal_com: Add space around operators
Staging: rtl8188eu: odm: Add space around operators
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers
On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote:
> On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote:
Hi Greg and Joe,
> > On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote:
> > > Add space around operators for improving the code
> > > readability.
>
1 - 100 of 173 matches
Mail list logo
